[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny added a comment. Hmm, apparently this could be achieved by making it a "CoreOption". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/ https://reviews.llvm.org/D133329 ___ cfe-commits mail

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny added a comment. I think you misunderstood me. The aforementioned tests fail if I put `--gcc-install-dir=` in the config file. There is no way to put it in the config file that wouldn't affect these tests right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

mgorny added a comment. In D106577#2965059 , @aaron.ballman wrote: > Thanks! I've passed them along to WG14 and will report back what I hear. Have you heard anything since? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny added inline comments. Comment at: clang/docs/UsersManual.rst:915 +in the directory where Clang resides. If Clang is started via an executable +without target prefix, Clang will use ``default.cfg`` instead. sepavloff wrote: > What about using default con

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny added a comment. In D109621#3799133 , @sepavloff wrote: > In D109621#3791511 , @mstorsjo > wrote: > >> On this topic, it would be great if we could pick up a per-target default >> config file too, if clan

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

mgorny added a comment. In D106577#3799276 , @aaron.ballman wrote: > Sorry, thanks for re-pinging this, it fell off my radar. Yes, I have heard > back from WG14 but there was not really a consensus position (which means > we'd need to write a paper if

[PATCH] D134191: [clang] Make config-related options CoreOptions

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay, hfinkel. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Make `--config`, `--no-default-config` and `--config-*-dir` CoreOptions to enable their availability to a

[PATCH] D134191: [clang] Make config-related options CoreOptions

mgorny added a comment. In D134191#3799841 , @MaskRay wrote: > They don't need to be `NoXarchOption` if I am not mistaken. I don't know about that. The comment on top says "The option is a "driver"-only option, and should not be forwarded to other tools

[PATCH] D134191: [clang] Make config-related options CoreOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaebf2c13ce2: [clang] Make config-related options CoreOptions (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Mono

[PATCH] D134208: [clang] [Driver] Do not transform explicit --config filename

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Disable transformations (e.g. attempting to replace target architecture) in the config filename that is passed exp

[PATCH] D134208: [clang] [Driver] Do not transform explicit --config filename

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7d2409bac7f: [clang] [Driver] Do not transform explicit --config filename (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Support specifying multiple configuration files via multiple `--config` options. When multiple files are specifie

[PATCH] D134271: [clang] [docs] Improve formatting & fix typo in config docs

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Fix teletype formatting in configuration file documentation to use double backticks rather than single backticks.

[PATCH] D134271: [clang] [docs] Improve formatting & fix typo in config docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3db2917e2706: [clang] [docs] Improve formatting & fix typo in config docs (authored by mgorny). Herald added a project: clang. Repository: rG LLVM

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. In D134270#3804855 , @sepavloff wrote: > What about the case, when executable file has a target prefix (so implicit > config file may be used) and the option `--config` is specified in command > line? Now this case becomes possib

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny updated this revision to Diff 461803. mgorny added a comment. Combining `--config` and default configuration files is now explicitly allowed. Adjust the code to load default configs before explicitly specified files. Update tests to cover combining `--config` with defaults. Update the do

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. For the record, I'm working on support for loading defaults from multiple files in a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134270/new/ https://reviews.llvm.org/D134270 ___ cfe-commits mailing l

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added subscribers: StephenFan, pengfei. Herald added a reviewer: sscalpone. Herald added a project: All. mgorny requested review of this revision. Update the rules used to load default configuration files to permit mo

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. @sepavloff, I'd appreciate if you could take a look at the logic before I start updating tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits mailing list c

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1061 return false; + if (ClangNameParts.TargetPrefix.empty()) +return false; sepavloff wrote: > Does it mean that executable without prefix won't load implicit config file? > For exa

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. To explain this better, let's take the following example call: x86_64-pc-linux-gnu-clang --driver-mode=g++ -target i386 This maps to: - effective triple: `i386` (from `-target`) - effective mode: `clang++` (from `--driver-mode`) - name prefix: `x86_64-pc-linux-gnu` - "

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a774c35e9f8: [clang] [Driver] Support multiple configuration files (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Githu

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134270/new/ https://reviews.llvm.org/D134270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny abandoned this revision. mgorny added a comment. Abandoning in favor of D134337 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109621/new/ https://reviews.llvm.org/D109621 ___ cfe-commits mailing list

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny updated this revision to Diff 461960. mgorny added a comment. Simplify getting driver mode — it turns out it's set for us already! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/include/clang/Driver/Driver.h clang/lib/

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Let's tackle the config changes independently and not block this on them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/ https://revi

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. @sepavloff, gentle ping. I'm waiting for your ACK/NAK on the algo in https://reviews.llvm.org/D134337#3805368. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. In D134337#3813779 , @sepavloff wrote: > First clang tries to find `x86_64-pc-linux-gnu-clang.cfg`. Just tool name > with added suffix `cfg`. No target override, no attempt to split tool name > into components. It provides possib

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. In D134337#3815339 , @sepavloff wrote: > In D134337#3805368 , @mgorny wrote: > >> For target, it will try: >> >> 1. `i386.cfg` (effective triple) >> 2. `i386-pc-linux-gnu.cfg` ("fixed" pref

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. In D134337#3817133 , @sepavloff wrote: > It make sense but the algorithm looks overcomplicated. The current > implementation is already too complex and documenting the new algorithm is a > challenge. > > What about making minimal

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny updated this revision to Diff 463201. mgorny edited the summary of this revision. mgorny added a comment. Ok, how about this variant? I think it's the simplest I can come up with that roughly matches the old behavior and adds what's necessary for the new. The algorithm is to use: 1. `-.c

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. Thanks. Since the algorithm's good, I'll work on updating the docs and tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny updated this revision to Diff 463274. mgorny added a comment. Update tests. Docs coming up next. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp clang/test/Dri

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny updated this revision to Diff 463288. mgorny added a comment. Added doc update. Would use some help with release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/UsersManual.rst clang/include/clang/Driver/Dri

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a reviewer: thesamesam. mgorny added a comment. Adding @thesamesam to reviewers since he's been testing it on Gentoo, and I'd like to get his ACK too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 __

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463413. mgorny retitled this revision from "[clang] [Driver] More flexible rules for loading default configs (WIP)" to "[clang] [Driver] More flexible rules for loading default configs". mgorny added a comment. Update release notes. I may have been a bit verb

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: clang/docs/ReleaseNotes.rst:243 + ``.cfg`` and ``.cfg`` if the former is not found. `Target` + is always the effective target (with respect to ``-target``, ``-m32``, etc.) + and `driver` first t

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463424. mgorny marked 2 inline comments as done. mgorny added a comment. Use `--target=` instead of `-target`. Use `touch` instead of `echo >`. Shorten FileCheck matches and guarantee that only expected configs appear. CHANGES SINCE LAST ACTION https://rev

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463433. mgorny marked 2 inline comments as done. mgorny added a comment. Use `llvm_unreachable()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManu

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: clang/docs/ReleaseNotes.rst:236-239 +- Clang now supports loading multiple configuration files. The files from + default configuration paths are loaded first, unless ``--no-default-config`` + opt

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463455. mgorny marked an inline comment as done. mgorny added a comment. Updated docs per @sepavloff 's suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst cl

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1089 + + bool ModeSuffixUnique = !ClangNameParts.ModeSuffix.empty() && + ClangNameParts.ModeSuffix != RealMode.str(); sepavlof

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463464. mgorny added a comment. Rename the bool to `TryModeSuffix`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/include/clang/Dr

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1098 + // Try loading separate config for the target (variants 3. and 4.) + CfgFileName = RealTriple.str() + ".cfg"; + if (searchForFile(CfgFilePath, CfgFileSearchDirs, CfgFileName, getVFS()) &&

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-linux-gnu-clang++.cfg first. //

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-linux-gnu-clang++.cfg first. //

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-linux-gnu-clang++.cfg first. //

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463531. mgorny marked 2 inline comments as done. mgorny added a comment. Swap driver and target config loading order. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: clang/test/Driver/config-file3.c:27 -//--- Invocation qqq-clang-g++ tries to find config file qqq-clang-g++.cfg first. +//--- Invocation x86_64-unknown-linux-gnu-clang-g++ tries x86_64-unknown-

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463548. mgorny edited the summary of this revision. mgorny added a comment. Herald added subscribers: pcwang-thead, s.egerton, simoncook. Implement the backwards compatible logic for using name prefix if 1) no target override options are used, and 2) name pref

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added a comment. @sepavloff, @arichardson, does this approach look OK? I've included the cheribsd name in tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits mailing list c

[PATCH] D134790: [Driver] Add --config= as canonical spelling of --config

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I don't know the fancy option magic you're using here, I haven't tested it but it seems to make sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463825. mgorny marked 2 inline comments as done. mgorny added a comment. Address @MaskRay 's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst clang/docs/Users

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added inline comments. Comment at: clang/include/clang/Driver/Driver.h:758 + /// Return the typical executable name for the specified driver \p Mode. + static const char *getExecutableForDriverMode(DriverMode Mode); }; MaskRay wrote: > This should be pr

[PATCH] D134871: [llvm] [lit] Move %clang_dxc substitution from clang/test

mgorny created this revision. mgorny added reviewers: python3kgae, beanz, MaskRay, zturner. Herald added subscribers: StephenFan, delcypher. Herald added a project: All. mgorny requested review of this revision. Herald added a project: LLVM. Move the `%clang_dxc` substitution from local definition

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

mgorny created this revision. mgorny added reviewers: python3kgae, beanz, jhuber6, davide, asb, MaskRay, plotfi. Herald added subscribers: StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1065-1080 + StringRef EffectiveDriverMode; + if (CLOptions) +EffectiveDriverMode = CLOptions->getLastArgValue(options::OPT_driver_mode); + if (EffectiveDriverMode

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463944. mgorny marked an inline comment as done. mgorny added a comment. Change confusing comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersMan

[PATCH] D134871: [llvm] [lit] Move %clang_dxc substitution from clang/test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74085ebfb68e: [llvm] [lit] Move %clang_dxc substitution from clang/test (authored by mgorny). Herald added a project: clang. Repository: rG LLVM G

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG063e17d8b04b: [clang] [Driver] More flexible rules for loading default configs (authored by mgorny). Herald added a project: clang. Repository: rG

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

This revision was automatically updated to reflect the committed changes. Closed by commit rG1609a5d7715c: [clang] [test] Use %clang_cc1 substitution consistently (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

mgorny added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) MaskRay wrote: > probinson wrote: > > But we _don't_ want to use `%clang_cc1` in Driver tests; if we

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny created this revision. mgorny added reviewers: MaskRay, sepavloff, zturner. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Add support for a CLANG_NO_DEFAULT_CONFIG envvar that works like the --no-default-config option when set

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny added a comment. I'm not sure if we should be documenting this in the user manual, or if it should be considered an internal-use envvar. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134905/new/ https://reviews.llvm.org/D134905 ___ cf

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1073 + if (const char *NoConfigEnv = ::getenv("CLANG_NO_DEFAULT_CONFIG")) { +if (*NoConfigEnv) + return false; MaskRay wrote: > Looking at LLDB_LAUNCH_FLAG_DISABLE_ASLR/LIBCLANG_DISAB

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: clang/test/Driver/config-file3.c:176 // -// SHORT-NAME: Configuration file: {{.*}}/testdmode/qqq.cfg -// SHORT-NAME: -Werror -// SHORT-NAME-NOT: -Wundefined-func-template +// FULL3-NOT: Configurat

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny added a comment. In D134905#3826111 , @MaskRay wrote: >> during testing > > This part of the subject is probably not needed. I think exposing the idea to > user can probably be useful, too. Sure but the larger part of the commit is actually about

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

mgorny added a comment. Is anyone working on a solution that would work for people using a zstd install method that's actually supported upstream? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG924996e0a011: [clang] [Driver] Disable default configs via envvar during testing (authored by mgorny). Herald added a project: clang. Repository:

[PATCH] D135018: [compiler-rt] [test] Fix sem_init_glibc.cpp test for glibc 2.36 on i386

mgorny created this revision. mgorny added reviewers: eugenis, vitalybuka, rovka. Herald added subscribers: Enna1, dberris. Herald added a project: All. mgorny requested review of this revision. Update sem_init_glibc.cpp to apply the "newer" GET_SEM_VALUE(v) logic to i386 if glibc is 2.36 or newer

[PATCH] D135018: [compiler-rt] [test] Fix sem_init_glibc.cpp test for glibc 2.36 on i386

mgorny added reviewers: MaskRay, thesamesam. mgorny added subscribers: thesamesam, MaskRay. mgorny added a comment. Herald added a subscriber: StephenFan. @MaskRay, @thesamesam, any chance you could reproduce/test this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135018/new/ https://r

[PATCH] D135018: [compiler-rt] [test] Fix sem_init_glibc.cpp test for glibc 2.36 on i386

mgorny abandoned this revision. mgorny added a comment. Abandoning in favor of D135023 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135018/new/ https://reviews.llvm.org/D135018 ___ cfe-commits mailing list

[PATCH] D135062: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

mgorny created this revision. mgorny added reviewers: sammccall, kadircet, hokein, ilya-biryukov, kbobyrev, MaskRay, thesamesam. Herald added subscribers: StephenFan, arphaman. Herald added a project: All. mgorny requested review of this revision. Herald added a project: clang-tools-extra. Add ll

[PATCH] D135159: [clang-tools-extra] [test] Use CLANG_NO_DEFAULT_CONFIG=1

mgorny created this revision. mgorny added reviewers: sammccall, MaskRay, sepavloff. Herald added subscribers: StephenFan, kadircet, arphaman. Herald added a project: All. mgorny requested review of this revision. Herald added a project: clang-tools-extra. Set CLANG_NO_DEFAULT_CONFIG=1 for clang-t

[PATCH] D135159: [clang-tools-extra] [test] Use CLANG_NO_DEFAULT_CONFIG=1

This revision was automatically updated to reflect the committed changes. Closed by commit rG52ce6776cf98: [clang-tools-extra] [test] Use CLANG_NO_DEFAULT_CONFIG=1 (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135159/new/ https

[PATCH] D135062: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

mgorny added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135062/new/ https://reviews.llvm.org/D135062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135062: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG77945a344c3d: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135062/new/ h

[PATCH] D135545: [clang] Mention -Werror changes revived for Clang 16

mgorny accepted this revision. mgorny added a comment. Thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135545/new/ https://reviews.llvm.org/D135545 ___ cfe-commits mailing list cfe-c

[PATCH] D135545: [clang] Mention -Werror changes revived for Clang 16

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bb86b674476: [clang] Mention -Werror changes revived for Clang 16 (authored by thesamesam, committed by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

mgorny created this revision. mgorny added reviewers: thieta, h-vetinari, tstellar, MaskRay, thesamesam. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. mgorny requested review of this revision. Instead of setting libclang.so's SOVERSION to CLANG_MAJOR_VERSION whe

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

mgorny added a comment. In D135701#3850251 , @MaskRay wrote: > I don't understand this well, though. Is `CLANG_VERSION_MAJOR` wrong or not > defined in some cases? It's about `LLVM_VERSION_SUFFIX`. Normally, `SOVERSION` for all libraries is `${LLVM_VER

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3ce1339264d: [clang] Do not override libclang.so's SOVERSION if… (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

mgorny added inline comments. Comment at: clang/test/Preprocessor/lang-std.cpp:1 -// UNSUPPORTED: default-std-cxx, ps4, ps5 -/// Test default standards when CLANG_DEFAULT_STD_CXX is unspecified. I suppose you want to remove the `lit.cfg.py` counterpart of this as

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1007 // Then load configuration files specified explicitly. - llvm::SmallString<128> CfgFilePath; + std::string CfgFilePath; if (CLOptions) { I don't really understand the purpose of th

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1007 // Then load configuration files specified explicitly. - llvm::SmallString<128> CfgFilePath; + std::string CfgFilePath; if (CLOptions) { mgorny wrote: > I don't really understand t

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks for doing this. For the record, Gentoo didn't need to use this for a long time now, so there's no backwards compatibility concern here. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: llvm/include/llvm/Support/CommandLine.h:2138 + /// directories specified by SearchDirs field. + bool findConfigFile(StringRef FileName, std::string &FilePath); + I'm sorry if I'm missing something obvious but is there a

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I haven't tested it but eyeball-review, it looks neat. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135439/new/ https://reviews.llvm.or

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. In D139723#4004536 , @doru1004 wrote: > Commit: 07ff3c5ccce68aed6c1a270b3f89ea14de7aa250 >

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

mgorny added a comment. Also, please link commits to diffs using `Differential Revision:` trailer in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139723/new/ https://reviews.llvm.org/D139723 __

[PATCH] D140155: [Clang][OpenMP] Allow host call to nohost function with host variant

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. In D140155#4004505 , @doru1004 wrote: > Commit 658ed9547cdd6657895339a6c390c31aa77a5698 >

[PATCH] D140155: [Clang][OpenMP] Allow host call to nohost function with host variant

mgorny closed this revision. mgorny added a comment. Thank you. I'm going to try if the same solution helps with D139723 too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140155/new/ https://reviews.llvm.org/D14

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

mgorny closed this revision. mgorny added a comment. I've pushed a fix in dab67c66932b9149842f7c8431e951f952125fc0 , based on @jhuber6's fix from the other diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

mgorny added reviewers: jbcoe, bkramer. mgorny added a comment. I'm wondering if we shouldn't just by setting `CLANG_NO_DEFAULT_CONFIG=1` like in clang's test suite rather than tying to predict how different config files will affect these tests. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:274-275 + "LLVM_CONFIG_PATH is deprecated, please use LLVM_CMAKE_DIR instead") +get_filename_component(LLVM_CMAKE_DIR "${LLVM_CONFIG_PATH}" DIRECTORY) +get_filename_component(LL

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny updated this revision to Diff 472376. mgorny added a comment. Add an explanatory comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/lib/xray/tests/CMakeLists.t

[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Hmm, I suppose it makes sense. At least at a first glance I don't see how it could yield different results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

This revision was automatically updated to reflect the committed changes. Closed by commit rG23c665371a98: [compiler-rt] Switch from llvm-config to find_package(LLVM) (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ ht

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. Thanks! Let's hope it works this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. > These workarounds are fine for me, but I wonder if it would be useful with a > more direct cmake option to tell it not look for these files at all. CMake has something like that built-in. I think it's `-DCMAKE_DISABLE_FIND_PACKAGE_LLVM=ON`. Repository: rG LLVM Gith

<    1   2   3   4   5   6   7   8   9   >