[chromium-dev] Re: Does JSONStringValueSerializer expect UTF8?

2009-03-25 Thread tony
Yes, it assumes the input is utf-8. From src/base/json_reader.h: // Known limitations/deviations from the RFC: // - Assumes input is encoded as UTF8. The spec says we should allow UTF-16 // (BE or LE) and UTF-32 (BE or LE) as well. On Tue, 24 Mar 2009, Book'em Dano wrote: > > Awesome. Than

[chromium-dev] src/media/

2009-03-25 Thread peng
Hi how to to use src/media/ ? It is very useful ! peng --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~

[chromium-dev] Re: src/media/

2009-03-25 Thread Andrew Scherkus
Hi peng! I'm one of the programmers working on that code. You can see how it's used by looking at the renderer process: /src/renderer/webmediaplayer_delegate_impl.cc /src/renderer/media/audio_renderer_impl.cc /src/renderer/media/data_source_impl.cc /src/renderer/media/video_renderer_impl.cc We're

[chromium-dev] Re: src/media/

2009-03-25 Thread peng
Hi Andrew Thanks for your info. Yes, it is very valuable if we know how to use /src/media OUTSIDE Chrome because it uses ffmpeg. Look forward to this! peng --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, chang

[chromium-dev] You might need to clobber your Linux client

2009-03-25 Thread Dan Kegel
Both my Linux clients were getting the build error scons: *** [Hammer/dbg/grit_derived_sources/grit/browser_resources.h] Implicit dependency `browser/resources/extensions.html' not found, needed by target `Hammer/dbg/grit_derived_sources/browser_resources.rc'. Deleting Hammer seemed to fix it.

[chromium-dev] Re: Including Droid font in Chrome?

2009-03-25 Thread Evan Martin
On Tue, Mar 24, 2009 at 9:49 PM, Alex Russell wrote: > A potential plus is that we could (finally?) count on having at least > one consistent font between platforms. I'm not sure that's an > un-adulterated Good Thing (TM), but I can imagine wanting a uniform > main body font that's not whatever j

[chromium-dev] Re: porting chrome_process_filter

2009-03-25 Thread Paweł Hajdan Jr .
Thanks for all your comments. Actually chrome_process_filter is only used by tests to enumerate chrome processes. So I plan to add a chrome_process_enumerator in chrome/test and remove chrome/common/chrome_process_filter. --~--~-~--~~~---~--~~ Chromium Developers ma

[chromium-dev] Re: You might need to clobber your Linux client

2009-03-25 Thread tony
If you see this error, the correct thing to do is run hammer with --implicit-deps-changed. By default scons caches dependencies to speed up builds. When some dependencies change, scons doesn't know about it. This doesn't impact the builders because they always build with --implicit-deps-changed

[chromium-dev] Re: Last Known Good Revision

2009-03-25 Thread Marc-Antoine Ruel
Just to be clear, it's really the last known good revision for the try server, so it's the thinest definition of "lkgr" you can ever find. It only checks for "unit_tests" to pass and nothing else, in debug on windows, linux and mac. http://build.chromium.org/buildbot/continuous/LATEST/REVISION is

[chromium-dev] Last Known Good Revision

2009-03-25 Thread Marc-Andre Decoste
Salut Chromium-Dev'ers, if you are not interested in knowing about the last revisions that successfully built, you can stop reading here (or you could actually go on if you are curious because this email isn't that long anyway :-). We just added a new builder status receiver to the build bot

[chromium-dev] Re: Last Known Good Revision

2009-03-25 Thread Patrick Johnson
Nice! Can we add an option to gclient to make it automatically sync to the last known good revision? Patrick On Wed, Mar 25, 2009 at 9:18 AM, Marc-Andre Decoste wrote: > Salut Chromium-Dev'ers, > if you are not interested in knowing about the last revisions that > successfully built, you can

[chromium-dev] Re: Including Droid font in Chrome?

2009-03-25 Thread Alex Russell
MSFT did a new set of fonts to take specific advantage of ClearType: http://www.microsoft.com/typography/ClearTypeFonts.mspx The "Core Fonts" are still available and installed by default on all windows versions that I can find information on, but they were designed for a simpler time when sub-pi

[chromium-dev] Re: Last Known Good Revision

2009-03-25 Thread Alex Russell
working on it. On Wed, Mar 25, 2009 at 10:00 AM, Patrick Johnson wrote: > Nice!  Can we add an option to gclient to make it automatically sync to the > last known good revision? > Patrick > > On Wed, Mar 25, 2009 at 9:18 AM, Marc-Andre Decoste > wrote: >> >> Salut Chromium-Dev'ers, >>   if you

[chromium-dev] Re: Last Known Good Revision

2009-03-25 Thread Berend-Jan Wever
That should not be to hard: LKGR = 'http://build.chromium.org/buildbot/continuous/LATEST/REVISION' revision_arg = '--revision=...@%s' % int(urllib.urlopen(LKGR).read()) Needs a bit of error handling, but it should be easy to put in gclient.py, optionally with a feature to allow you to specify the

[chromium-dev] Re: Including Droid font in Chrome?

2009-03-25 Thread Brett Wilson
On Wed, Mar 25, 2009 at 10:16 AM, Alex Russell wrote: > > MSFT did a new set of fonts to take specific advantage of ClearType: > > http://www.microsoft.com/typography/ClearTypeFonts.mspx > > The "Core Fonts" are still available and installed by default on all > windows versions that I can find in

[chromium-dev] Re: [chrome-team] Design-Doc: Automatic Spelling Correction

2009-03-25 Thread Nick Baum
Hi Peter, I'll let Sid chime in on the details of the implementation, but it's definitely been designed to allow for other algorithms. If there's a better way to integrate it into Hunspell itself, that might be worth looking into. -Nick On Tue, Mar 24, 2009 at 10:54 PM, Peter Kasting wrote: > On

[chromium-dev] Disabling "This type of file can harm your computer"

2009-03-25 Thread Robert Dailey
First of all, I'm using Chrome 2.0.171.0 I have been unable to find a way to disable the notification that comes up when downloading an EXE or MSI type file using Chromium. Is there a way of disabling this notification? I would like the files to begin downloading immediately. If there is no way

[chromium-dev] Re: Disabling "This type of file can harm your computer"

2009-03-25 Thread Adam Barth
It's important to have this discussion, but we should be having it in the bug tracker instead of on chromium-dev. Thanks, Adam On Wed, Mar 25, 2009 at 11:22 AM, Robert Dailey wrote: > > First of all, I'm using Chrome 2.0.171.0 > > I have been unable to find a way to disable the notification th

[chromium-dev] It's clobber time!

2009-03-25 Thread Eric Seidel
When the merge is done landing, you'll need to blast away DerivedSources (or just do a full clobber build). You'll also need to re-open your project file, as I changed the VS props file (to turn of ENABLE_VIDEO). -eric --~--~-~--~~~---~--~~ Chromium Developers mail

[chromium-dev] Re: [chrome-team] Design-Doc: Automatic Spelling Correction

2009-03-25 Thread Daniel A. White
Just a thought, why not for the Mac version of Chrome/Chromium, use the built in Mac OS X spell check services? Daniel A. White On Wed, Mar 25, 2009 at 1:45 PM, Nick Baum wrote: > Hi Peter, > I'll let Sid chime in on the details of the implementation, but it's > definitely been designed to all

[chromium-dev] Re: ScrollBar Implementation

2009-03-25 Thread Ben Goodger (Google)
There are different kinds of scrollbar supported by views... that native scrollbar and the bitmap scrollbar. bitmap scrollbar isn't used right now but likely will be again. ScrollBar is the base class of both NativeScrollbar and Bitmapscrollbar. Scrollview has a ScrollBar* so it doesn't have to c

[chromium-dev] Re: [chrome-team] Design-Doc: Automatic Spelling Correction

2009-03-25 Thread Mike Beltzner
On 25-Mar-09, at 3:34 PM, Daniel A. White wrote: > Just a thought, why not for the Mac version of Chrome/Chromium, use > the built in Mac OS X spell check services? For what it's worth, Mozilla has received fairly clear feedback that OSX users would prefer to have integration with their exis

[chromium-dev] Re: ScrollBar Implementation

2009-03-25 Thread Mohamed Mansour
Do you recommend me to refactor the Context Menu code from BitmapScrollBar into ScrollBar so that both will have context menu implementations? Currently, the context menu is the page context menu that has "reload, print, view page info, etc". Would that be the best approach fixing this "feature"

[chromium-dev] Re: ScrollBar Implementation

2009-03-25 Thread Ben Goodger (Google)
No. What's not working? -Ben On Wed, Mar 25, 2009 at 12:54 PM, Mohamed Mansour wrote: > Do you recommend me to refactor the Context Menu code from > BitmapScrollBar into ScrollBar so that both will have context menu > implementations? > > Currently, the context menu is the page context menu th

[chromium-dev] Re: ScrollBar Implementation

2009-03-25 Thread Mohamed Mansour
There is no context menu for the ScrollBar. -m0 On Wed, Mar 25, 2009 at 3:55 PM, Ben Goodger (Google) wrote: > No. > > What's not working? > > -Ben > > On Wed, Mar 25, 2009 at 12:54 PM, Mohamed Mansour > wrote: >> Do you recommend me to refactor the Context Menu code from >> BitmapScrollBar

[chromium-dev] Re: ScrollBar Implementation

2009-03-25 Thread Brett Wilson
As Peter said, the ScrollBar object is not responsible for drawing scroll bars on pages, which is what the bug is about. Brett On Wed, Mar 25, 2009 at 1:15 PM, Mohamed Mansour wrote: > > There is no context menu for the ScrollBar. > > -m0 > > > > On Wed, Mar 25, 2009 at 3:55 PM, Ben Goodger (Go

[chromium-dev] Re: Last Known Good Revision

2009-03-25 Thread Marc-Antoine Ruel
Yé! BJ is now fluent in Python! A month or two ago, that would have been written in JS... :) On Wed, Mar 25, 2009 at 1:18 PM, Berend-Jan Wever wrote: > That should not be to hard: > LKGR = 'http://build.chromium.org/buildbot/continuous/LATEST/REVISION' > revision_arg = '--revision=...@%s' % int

[chromium-dev] Recent refactoring of widget creation code

2009-03-25 Thread Avi Drissman
In re to http://codereview.chromium.org/48103/show: I like where you went, but this leaves me in a tough spot. I was implementing them in http://codereview.chromium.org/45040/show and now I'm a bit stuck. RWHV lives inside a view, and self-destructs when it's removed from the view. Its lifetime i

[chromium-dev] Re: Recent refactoring of widget creation code

2009-03-25 Thread Avi Drissman
Oh! CreateNewWidgetInternal is virtual! That's... useful. Avi On Wed, Mar 25, 2009 at 4:58 PM, Avi Drissman wrote: > In re to http://codereview.chromium.org/48103/show: > > I like where you went, but this leaves me in a tough spot. I was > implementing them in http://codereview.chromium.org/450

[chromium-dev] Re: Recent refactoring of widget creation code

2009-03-25 Thread Evan Stade
I agree the popup lives in a strange state of limbo before InitAsPopup() is called, but this structure seems to be a side effect of the messages the renderer sends us. It didn't turn out to be much of a problem for linux/win, but if it is for mac then let me know and I'll try to help figure someth

[chromium-dev] Re: Recent refactoring of widget creation code

2009-03-25 Thread Avi Drissman
That should work. If I just override those functions and retain/release the view through it, we should be fine. avi On Wed, Mar 25, 2009 at 5:09 PM, Evan Stade wrote: > > I agree the popup lives in a strange state of limbo before > InitAsPopup() is called, but this structure seems to be a side

[chromium-dev] Re: Including Droid font in Chrome?

2009-03-25 Thread Mike Reed
Indeed, its unhinted to keep it small. That said, we could (with some $$) have it hinted, either generically, or with cleartype in mind. On Wed, Mar 25, 2009 at 1:45 PM, Brett Wilson wrote: > > On Wed, Mar 25, 2009 at 10:16 AM, Alex Russell wrote: >> >> MSFT did a new set of fonts to take speci

[chromium-dev] recent changes to webkit test list expectations

2009-03-25 Thread Ojan Vafai
tests_ignored.txt and tests_fixable.txt no longer exist. They were merged into a single file: src/webkit/tools/layout_tests/test_expectations.txt. All the files that were previously ignored now have the WONTFIX metadata applied to them. WONTFIX means that we never intend to pass the test. WONTFIX W

[chromium-dev] Re: layout tests and bug triaging

2009-03-25 Thread David Levin
We could go with option 3 until someone is annoyed enough by the overhead to write a script. :) On Tue, Mar 24, 2009 at 4:19 PM, Ojan Vafai wrote: > OK. So, what I'm hearing is that every test should have a bug assigned to > it, no matter the priority. In that case, there's a couple other optio

[chromium-dev] What packages does Chromium depend on to run on Linux?

2009-03-25 Thread Wei Hu
After reading about people installing Chromium on Ubuntu, I gave it a try today on my Debian Unstable. I first tried the latest .deb package from http://build.chromium.org/buildbot/snapshots/chromium-rel-linux/?O=D. It installs fine, but I only get the "chrome", i.e. the tab strip and the menu. Wh

IMPORTANT: Re: [chromium-dev] Re: layout tests and bug triaging

2009-03-25 Thread Ojan Vafai
Just want to make sure everyone sees this. Please voice yourself now if you care about layout test fixing process and about managing test list process. I'll give another day. Unless I hear objections, I'll make run_webkit_tests do option 3. I'm not quite sure how we transition from the current wor

[chromium-dev] Re: What packages does Chromium depend on to run on Linux?

2009-03-25 Thread Evan Martin
http://code.google.com/p/chromium/wiki/LinuxBuildInstructionsPrerequisites is the canonical list. To get a useful product as quickly as possible, we've been targeting one particular release (Ubuntu Hardy). Once we have a working browser we of course intend to spend the time to track down glitche

[chromium-dev] Re: What packages does Chromium depend on to run on Linux?

2009-03-25 Thread Adam Langley
On Wed, Mar 25, 2009 at 3:56 PM, Wei Hu wrote: > the menu. Whenever I navigate to any URL, the title is updated, but > nothing shows in the browser body. This can also be caused by not having msttcorefonts installed. AGL --~--~-~--~~~---~--~~ Chromium Developer

[chromium-dev] Re: Including Droid font in Chrome?

2009-03-25 Thread cpu
On Mar 25, 2:52 pm, Mike Reed wrote: > Indeed, its unhinted to keep it small. That said, we could (with some > $$) have it hinted, either generically, or with cleartype in mind. Our font fallback is incomplete, Uniscribe is a no-go due to the sandbox. This seems something worth exploring. For

[chromium-dev] Re: What packages does Chromium depend on to run on Linux?

2009-03-25 Thread fta
On Mar 25, 11:56 pm, Wei Hu wrote: > I also > tried the Ubuntu package for Intrepid > fromhttps://launchpad.net/~chromium-daily/+archive/ppa, > but got the same result. If you used those builds older than 2 days and you didn't have mscorefonts installed, you got a blank page. I "fixed" the pack

[chromium-dev] Re: Chromium App Executables Disk Layout

2009-03-25 Thread cpu
On windows the exe/dll separation it was meant to simplify upgrade but in practice the exe changes frequently enough that we still need to support exe upgrading in place. We always wanted to have a do nothing exe that just loads the chrome dll but that never happened, reasons: 1) the sandbox 2) b

[chromium-dev] Re: What packages does Chromium depend on to run on Linux?

2009-03-25 Thread Adam Langley
On Wed, Mar 25, 2009 at 6:08 PM, fta wrote: > thing as a mandatory dep. This is clearly non-free. > So i guess someone will have to patch that, if not upstream, then > downstream, with all the consequences it implies. At some point I can imagine changing the default font and rebaselining pretty