[chromium-dev] Need help in using XMLSerializer to dump the root node of document

2009-06-04 Thread Daniel Dreiberg
Hi, In chromium, I am trying to use WebCore's XMLSerializer to dump the root node of document. I am able to pass all the necessary parameters to the XMLSerializer, but my question is XMLSerializer::serializeToString() return a Webkit's String, instead of chromium's String, and how can I write

[chromium-dev] Re: Question about chromium architecture

2009-06-04 Thread Meryl Silverburgh
On Wed, Jun 3, 2009 at 11:09 PM, Mike Belshe mbel...@google.com wrote: On Wed, Jun 3, 2009 at 10:40 PM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: On Tue, Jun 2, 2009 at 5:00 PM, Brett Wilson bre...@chromium.org wrote: On Tue, Jun 2, 2009 at 4:57 PM, Meryl Silverburgh

[chromium-dev] Re: Question about chromium architecture

2009-06-04 Thread Mike Belshe
On Thu, Jun 4, 2009 at 12:30 AM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: On Wed, Jun 3, 2009 at 11:09 PM, Mike Belshe mbel...@google.com wrote: On Wed, Jun 3, 2009 at 10:40 PM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: On Tue, Jun 2, 2009 at 5:00 PM, Brett

[chromium-dev] Re: Print Settings Mockup

2009-06-04 Thread Guille -bisho-
I really like the idea of a page for printing. It will feel pretty consistent with chrome UI. And I'll also love an easy option for removing all header and footers at once. Sometimes you print a document and then you want URL, page numbers, and so. But also many times you print plain tickets,

[chromium-dev] Question about chromium V8 engine compiling into native code

2009-06-04 Thread nathan
Hi, I understand chromium V8 engine compiling JS files into native code and then have native os executes the generated code. 1. Is there a lot of over head in writing the generated code to a file and have native os executes it? 2. Is there a cache in chromium so that if there is a common js file

[chromium-dev] Re: [linux] nested messageloop patch landed

2009-06-04 Thread Dean McNamee
I'm really curious of why that would be. I realize the old code was a bit buggy, but I wonder exactly where the startup improvement came in. I think it would be pretty important to understand... Any takers? On Thu, Jun 4, 2009 at 1:34 AM, Nicolas Sylvainnsylv...@chromium.org wrote: On Wed,

[chromium-dev] Re: Print Settings Mockup

2009-06-04 Thread Marshall Greenblatt
Hi Ben, On Wed, Jun 3, 2009 at 11:16 PM, Ben Goodger (Google) b...@chromium.orgwrote: I think we should do a page. This work is not otherwise on our immediate term plan so it may as well get done the right way. I think the page is more of a print preview than a print settings. Would it be

[chromium-dev] Re: Need help in using XMLSerializer to dump the root node of document

2009-06-04 Thread Marshall Greenblatt
Use any of the functions that accept a WebCore::String argument in webkit/glue/glue_util.h to retrieve a string type that you know how to work with. On Thu, Jun 4, 2009 at 3:11 AM, Daniel Dreiberg daniel.dreiber...@gmail.com wrote: Hi, In chromium, I am trying to use WebCore's XMLSerializer

[chromium-dev] Re: Print Settings Mockup

2009-06-04 Thread Mohamed Mansour
I don't think so, it would be using the same infrastructure of history / downloads / and new tab page. Someone can correct me if I am wrong. -- Mohamed Mansour On Thu, Jun 4, 2009 at 9:43 AM, Marshall Greenblatt magreenbl...@gmail.comwrote: Hi Ben, On Wed, Jun 3, 2009 at 11:16 PM, Ben

[chromium-dev] Re: Print Settings Mockup

2009-06-04 Thread Marc-Antoine Ruel
Most of the print preview will be implement in RenderView and friends which is in chrome/ ... (previously it was all in browser/ in fact) On Jun 4, 2009 10:04 AM, Mohamed Mansour m0.interact...@gmail.com wrote: I don't think so, it would be using the same infrastructure of history / downloads /

[chromium-dev] Re: Fwd: Chromium code coverage dashboard is up

2009-06-04 Thread Randall Spangler
The rules which Croc uses on linux are a combination of those in src/build/common.croc and src/build/linux/chrome_linux.croc. We can add exclusions to those rules as needed to fix cases like these. For example, the following rule will exclude .../wmi_util.* { 'regexp' :

[chromium-dev] Re: Need help in using XMLSerializer to dump the root node of document

2009-06-04 Thread Evan Martin
BTW, keep in mindthat webcore runs in the sandbox process and won't have access to the disk. Maybe this doesn't apply for your application, but typically in Chrome the pattern is: - Add a function to webkit/glue that converts a document to a string. - Add an IPC type to

[chromium-dev] Re: DLLs missing and DCHECKs in recent builds

2009-06-04 Thread Elliot Glaysher (Chromium)
I had to build under Windows for the first time in a month. I too can confirm this. -- Elliot On Wed, Jun 3, 2009 at 8:29 PM, Mohamed Mansour m...@chromium.org wrote: Yup, I can confirm. I had to manually build theme_dll or it hits crazy dchecks across the src. -- Mohamed Mansour On Wed,

[chromium-dev] Re: V8DOMMap

2009-06-04 Thread Mike Belshe
Wow - that might get messy. I wonder if use of v8 hidden properties might be useful here. You could potentially add a hidden object to the wrapper. But this may not work well. Mike On Wed, Jun 3, 2009 at 10:54 PM, Adam Barth aba...@google.com wrote: Thanks Mike. As I mentioned to Dimitri,

[chromium-dev] vs2008 - sync and sunk today

2009-06-04 Thread Mike Belshe
I've got a clean tree (I think), nuked things over and over again, rebuilt, restarted vs, and all the usual tricks, but the build is completely busted today. I'm getting incessant errors of this form: 2V8CharacterData.cpp 2C:\Program Files (x86)\Microsoft Visual Studio

[chromium-dev] Re: V8DOMMap

2009-06-04 Thread Aaron Boodman
You mean the idea in general won't work well, or this particular approach? I talked it over with Feng awhile ago, and he seemed to think the general idea was implementable. I think the code has changed since then though, with workers. - a On Thu, Jun 4, 2009 at 10:00 AM, Mike Belshe

[chromium-dev] Re: V8DOMMap

2009-06-04 Thread Mike Belshe
On Thu, Jun 4, 2009 at 10:33 AM, Aaron Boodman a...@chromium.org wrote: You mean the idea in general won't work well, or this particular approach? I talked it over with Feng awhile ago, and he seemed to think the general idea was implementable. I think the code has changed since then though,

[chromium-dev] Re: Are we now using Visual Studio 2008?

2009-06-04 Thread Mike Belshe
Can we change this so that you have to opt-in to vs2008? I have vs2008 on my system, but I never really wanted to use it for chrome. It's just that gyp automatically switched me to it. The vs2008 build seems to be subject to many more errors than the vs2005 system. I suspect this is due to low

[chromium-dev] Re: Are we now using Visual Studio 2008?

2009-06-04 Thread Bradley Nelson
Ok I'll change it to opt in.-BradN On Thu, Jun 4, 2009 at 10:51 AM, Mike Belshe mbel...@google.com wrote: Can we change this so that you have to opt-in to vs2008? I have vs2008 on my system, but I never really wanted to use it for chrome. It's just that gyp automatically switched me to it.

[chromium-dev] Re: Are we now using Visual Studio 2008?

2009-06-04 Thread Evan Martin
This is the same problem, more or less, as gcc versions = 4.3. We have a buildbot for it but it's usually red. :( It's hard to fix, when you've done a check-in that breaks some compiler that you don't have access to... On Thu, Jun 4, 2009 at 11:03 AM, Erik Kay erik...@chromium.org wrote: It

[chromium-dev] vs2008 and gyp

2009-06-04 Thread Bradley Nelson
Hi All, If you don't have Visual Studio 2008 installed you can stop reading. As many of you have no doubt noticed, gyp emits something approximating vs2008 sln/vcproj files for the portion of the build it has swallowed. Currently it decides to emit vs2008 format if vs2008 is installed. The

[chromium-dev] Re: V8DOMMap

2009-06-04 Thread Adam Barth
On Thu, Jun 4, 2009 at 10:36 AM, Mike Belshe mbel...@google.com wrote: On Thu, Jun 4, 2009 at 10:33 AM, Aaron Boodman a...@chromium.org wrote: You mean the idea in general won't work well, or this particular approach? I talked it over with Feng awhile ago, and he seemed to think the general