Re: [chromium-dev] Replicated State among tabs in Chromium

2010-01-08 Thread Ben Laurie
On Thu, Jan 7, 2010 at 10:18 PM, Fady Samuel fadysam...@gmail.com wrote: Which brings me back to the original topic of replicated state. Is there any reason not to have a single monolithic cache (or other similar state) across all processes other than synchronization issues or fault tolerance?

Re: [chromium-dev] Replicated State among tabs in Chromium

2010-01-07 Thread Ben Laurie
On Thu, Jan 7, 2010 at 8:43 PM, Fady Samuel fadysam...@gmail.com wrote: Charles, I've read your paper and ultimately I think my goal may be somewhere along the lines of making the DOM tree thread-safe by applying my research in iterators and lock-free data structures. A tricky question:

[chromium-dev] Re: Change to default build architecture

2009-10-20 Thread Ben Laurie
On Fri, Oct 16, 2009 at 1:28 AM, Michael Moss mm...@chromium.org wrote: http://codereview.chromium.org/271113 may require a clobber for Linux builds. I should belatedly observe that the Linux make build, at least, is supposed to detect command line changes and so should not need a clobber. If

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-09 Thread Ben Laurie
On Wed, Oct 7, 2009 at 8:09 PM, Evan Martin e...@chromium.org wrote: On Fri, Oct 2, 2009 at 2:40 PM, Adam Langley a...@chromium.org wrote: On Fri, Oct 2, 2009 at 2:37 PM, Ben Laurie b...@chromium.org wrote: Why will it certainly not work? From what (little) I understand, SOCK_SEQPACKET adds

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-09 Thread Ben Laurie
On Fri, Oct 9, 2009 at 4:33 PM, Evan Martin e...@chromium.org wrote: On Fri, Oct 9, 2009 at 7:42 AM, Ben Laurie b...@chromium.org wrote: If anyone gets the chance, I would happily pre-LGTM a change that stuffs some comments near this code explaining the reasoning for this. http

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-03 Thread Ben Laurie
On Fri, Oct 2, 2009 at 4:20 PM, Dan Kegel d...@kegel.com wrote: On Fri, Oct 2, 2009 at 4:02 PM, Jacob Mandelson ja...@mandelson.org wrote: Which reads like all or nothing to me, though I could imagine a (perverse?) implementation with each writer having a send buffer lower layer pulling data

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-03 Thread Ben Laurie
On Fri, Oct 2, 2009 at 2:34 PM, Adam Langley a...@chromium.org wrote: On Fri, Oct 2, 2009 at 2:30 PM, Adam Langley a...@chromium.org wrote: There was some concern that a renderer could use sendto on a SOCK_DGRAM to direct packets to other destinations. However, when created with socketpair,

[chromium-dev] Why SOCK_SEQPACKET?

2009-10-02 Thread Ben Laurie
zygote_host_linux.cc creates a socketpair using SOCK_SEQPACKET rather than the more usual SOCK_STREAM? Before I trawl through code, does anyone know why? This is a problem for the FreeBSD port: FreeBSD doesn't support SOCK_SEQPACKET for unix domain sockets...

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-02 Thread Ben Laurie
On Fri, Oct 2, 2009 at 2:30 PM, Adam Langley a...@chromium.org wrote: On Fri, Oct 2, 2009 at 2:26 PM, Ben Laurie b...@chromium.org wrote: zygote_host_linux.cc creates a socketpair using SOCK_SEQPACKET rather than the more usual SOCK_STREAM? Before I trawl through code, does anyone know why

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-02 Thread Ben Laurie
On Fri, Oct 2, 2009 at 2:40 PM, Adam Langley a...@chromium.org wrote: On Fri, Oct 2, 2009 at 2:37 PM, Ben Laurie b...@chromium.org wrote: Why will it certainly not work? From what (little) I understand, SOCK_SEQPACKET adds record boundaries to SOCK_STREAM ... presumably one could simulate

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-14 Thread Ben Laurie
On Thu, Sep 10, 2009 at 6:19 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: On Thu, Sep 10, 2009 at 10:16, Dan Kegel d...@kegel.com wrote: In this case, the code may have been submitted by a committer without  using the trybots (tsk, tsk).  We don't currently mention the trybots on

[chromium-dev] Where does -Werror get disabled for WebCore?

2009-09-13 Thread Ben Laurie
By default, cflags includes -Werror ... (see build/common.gypi). It seems something disables this for WebCore (which is built by webkit/webkit.gyp:webcore) but I can't figure out what - does anyone know? --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Where does -Werror get disabled for WebCore?

2009-09-13 Thread Ben Laurie
it seems like a battle worth fighting :-) BTW, did you know what -Wall -W (but not -W -Wall) turns on yet more warnings? On Sun, Sep 13, 2009 at 11:35 AM, Ben Laurie b...@chromium.org wrote: On Sun, Sep 13, 2009 at 7:13 PM, Darin Fisherda...@chromium.org wrote: I think no one has gone back

[chromium-dev] FreeBSD port, take 2

2009-08-27 Thread Ben Laurie
As brettw requested, I ported chrome/browser/renderer_host/ and base/. This is now done and can be reviewed here: http://codereview.chromium.org/172032 The description summarises the changes I made, what do people think? (I haven't forgot that I said I'd document defines - I'll do that once

[chromium-dev] Re: FreeBSD port, take 2

2009-08-27 Thread Ben Laurie
I forgot to mention - there's a single file that may not be complete, base/crypto/signature_verifier_nss.cc - this is because the FreeBSD port of NSS is too old and doesn't have a function it needs. I'll get to that at some point soon, but I don't anticipate it being a problem. On Thu, Aug 27,

[chromium-dev] Problem with try servers?

2009-08-27 Thread Ben Laurie
If I do a gcl try, I get prompted for a password for 'ben', which is my login name on my FreeBSD machine. Whatever I enter, the script then hangs - investigation shows that this is because it is prompting for a username, but gcl is swallowing the output. If I then enter b...@chromium.org, I get

[chromium-dev] Re: FreeBSD port, take 2

2009-08-27 Thread Ben Laurie
On Thu, Aug 27, 2009 at 3:56 PM, Evan Martine...@chromium.org wrote: On Thu, Aug 27, 2009 at 2:57 AM, Ben Laurieb...@google.com wrote: Added USE_GDK, set when either TOOLKIT_GTK or TOOLKIT_VIEWS is set but not OS_WIN. I believe VIEWS still uses GTK (for bits like the omnibox). So this

[chromium-dev] Re: FreeBSD port and ifdefs

2009-08-20 Thread Ben Laurie
On Thu, Aug 20, 2009 at 2:00 AM, Dean McNameede...@chromium.org wrote: I kinda feel like this is one of those things you can try hard to premeditate, but in the end you'll just have to deal with it being ugly for a while and hope it eventually converges to something better.  Sort of a

[chromium-dev] Re: FreeBSD port and ifdefs

2009-08-20 Thread Ben Laurie
On Thu, Aug 20, 2009 at 6:21 AM, Ben Goodger (Google)b...@chromium.org wrote: I don't know much about the technical details at play here, but a couple of high level notes: - I am sympathetic to concerns around codebase cleanliness. Many people (like Brett) have spent very many months

[chromium-dev] Re: FreeBSD port and ifdefs

2009-08-20 Thread Ben Laurie
On Wed, Aug 19, 2009 at 10:18 PM, Marc-Antoine Ruelmar...@google.com wrote: I don't mind as long it's documented on dev.chromium.org. Ben, ping me if you want to setup a freebsd slave on fyi. As long as you want to babysit it. :) Cool - I haven't got that far yet, but when it builds, I'll be

[chromium-dev] Re: FreeBSD port and ifdefs

2009-08-20 Thread Ben Laurie
On Thu, Aug 20, 2009 at 6:56 AM, Brett Wilsonbre...@chromium.org wrote: On Wed, Aug 19, 2009 at 9:49 PM, Brett Wilsonbre...@chromium.org wrote: On Wed, Aug 19, 2009 at 6:00 PM, Dean McNameede...@chromium.org wrote: I kinda feel like this is one of those things you can try hard to

[chromium-dev] Re: FreeBSD port and ifdefs

2009-08-20 Thread Ben Laurie
On Thu, Aug 20, 2009 at 2:26 PM, Evan Martine...@chromium.org wrote: On Thu, Aug 20, 2009 at 3:06 AM, Ben Laurieb...@chromium.org wrote: I'd be happy to do that. When I do, there's something that's already puzzling me, and that's OS_POSIX. I don't have a copy of the POSIX standard, at least

[chromium-dev] Re: FreeBSD port and ifdefs

2009-08-20 Thread Ben Laurie
On Thu, Aug 20, 2009 at 7:32 PM, Evan Martine...@chromium.org wrote: On Thu, Aug 20, 2009 at 11:15 AM, Ben Laurieb...@chromium.org wrote: On Thu, Aug 20, 2009 at 2:26 PM, Evan Martine...@chromium.org wrote: On Thu, Aug 20, 2009 at 3:06 AM, Ben Laurieb...@chromium.org wrote: I'd be happy to do

[chromium-dev] Re: jankfs

2009-08-19 Thread Ben Laurie
On Wed, Aug 19, 2009 at 6:20 AM, Joel Stanleyj...@jms.id.au wrote: When I first got Chromium going on the beagleboard it was slow.  I believe the the main slowdown is due to the limited RAM (128MB), but another factor was the slow disk I/O due to the root fs being held on a cheap SD card.

[chromium-dev] FreeBSD port and ifdefs

2009-08-19 Thread Ben Laurie
I've started working on a FreeBSD port. The first patch is here: http://codereview.chromium.org/172032. When looking at the patch, bear in mind a couple of things... 1. Added gyp lines for files like *_ar.pak are compensating for the fact that i18n targets are not currently being handled

[chromium-dev] Git and Mercurial?

2009-08-16 Thread Ben Laurie
I see some people like to use git to work on chromium. How about mercurial? Has anyone tried it? Is there some reason it doesn't work so well? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email

[chromium-dev] Re: Missing config.h?

2009-08-07 Thread Ben Laurie
, but uses WebCore. -Darin On Fri, Aug 7, 2009 at 5:48 AM, Ben Laurie b...@chromium.org wrote: I just got bitten by failing to #include config.h in a file. This caused that file to have a different version of KURL from the rest of the code (it did not use GOOGLEURL, whereas the rest did

[chromium-dev] Re: Missing config.h?

2009-08-07 Thread Ben Laurie
On Fri, Aug 7, 2009 at 8:11 PM, Jeremy Orlowjor...@chromium.org wrote: On Fri, Aug 7, 2009 at 12:01 PM, Darin Fisher da...@chromium.org wrote: On Fri, Aug 7, 2009 at 11:31 AM, Ben Laurie b...@chromium.org wrote: On Fri, Aug 7, 2009 at 6:17 PM, Darin Fisherda...@chromium.org wrote

[chromium-dev] Re: Missing config.h?

2009-08-07 Thread Ben Laurie
On Fri, Aug 7, 2009 at 10:33 PM, Jeremy Orlowjor...@chromium.org wrote: On Fri, Aug 7, 2009 at 2:15 PM, Ben Laurie b...@chromium.org wrote: On Fri, Aug 7, 2009 at 8:11 PM, Jeremy Orlowjor...@chromium.org wrote: On Fri, Aug 7, 2009 at 12:01 PM, Darin Fisher da...@chromium.org wrote

[chromium-dev] Re: Urgent, a very evil site i think which does evil things (no joke)

2009-08-05 Thread Ben Laurie
On Tue, Aug 4, 2009 at 11:29 PM, Ian Fettei...@chromium.org wrote: So far as I can tell, the page is not instantiating Java. it's instantiating acrobat / flash, and perhaps that instantiates java? At any rate, so far as I can tell there's little that can be done here. I presume you mean

[chromium-dev] Multiple outputs and errors: fail in make build

2009-08-04 Thread Ben Laurie
If you have a rule that produces multiple outputs, for example, the one for src/chrome/app/theme/theme_resources.grd, the make build currently works incorrectly if an error is encountered after the first output is produced - subsequent makes do not try to rebuild the outputs (e.g. try introducing

[chromium-dev] Re: Multiple outputs and errors: fail in make build

2009-08-04 Thread Ben Laurie
On Tue, Aug 4, 2009 at 4:52 PM, Evan Martinev...@chromium.org wrote: [retry with proper email address, please respond to this one if you got the other one] On Tue, Aug 4, 2009 at 8:11 AM, Ben Laurieb...@google.com wrote: If you have a rule that produces multiple outputs, for example, the

[chromium-dev] Re: Multiple outputs and errors: fail in make build

2009-08-04 Thread Ben Laurie
On Tue, Aug 4, 2009 at 5:11 PM, Evan Martine...@chromium.org wrote: On Tue, Aug 4, 2009 at 9:02 AM, Ben Laurieb...@google.com wrote: There's a big comment block about five lines below where you made that modification talking about how to express multiple outputs to make, along with a link to

[chromium-dev] Re: Mozilla design challenge

2009-07-31 Thread Ben Laurie
On Wed, Jul 22, 2009 at 6:08 PM, Brian Rakowskibr...@chromium.org wrote: The most promising things I found from the design challenge were the history view in Favitabs n' Drawers (see attached image). The cool thing about it is that it shows how long the tabs were open. I find other history

[chromium-dev] Re: Quota UI for LocalStorage (and others in the future)

2009-07-29 Thread Ben Laurie
On Wed, Jul 29, 2009 at 5:30 AM, Peter Kastingpkast...@chromium.org wrote: On Tue, Jul 28, 2009 at 9:23 PM, Mike Beltzner beltz...@mozilla.com wrote: All we're doing at this point is preventing malicious applications from eating up disk, really. Yep, I agree (although that may no longer be

[chromium-dev] Re: Quota UI for LocalStorage (and others in the future)

2009-07-29 Thread Ben Laurie
On Wed, Jul 29, 2009 at 5:51 AM, Jeremy Orlowjor...@google.com wrote: On Tue, Jul 28, 2009 at 9:30 PM, Peter Kasting pkast...@chromium.org wrote: On Tue, Jul 28, 2009 at 9:23 PM, Mike Beltzner beltz...@mozilla.com wrote: All we're doing at this point is preventing malicious applications

[chromium-dev] Re: Compiler warnings?

2009-07-23 Thread Ben Laurie
On Thu, Jul 23, 2009 at 4:30 PM, Wan-Teh Changw...@google.com wrote: Ben, I believe the GCC warning you want is -Wreturn-type, which is enabled if we specify -Wall: http://gcc.gnu.org/onlinedocs/gcc-4.3.3/gcc/Warning-Options.html#Warning-Options Are we not compiling with -Wall? Apparently

[chromium-dev] Re: Compiler warnings?

2009-07-23 Thread Ben Laurie
On Thu, Jul 23, 2009 at 4:44 PM, Darin Fisherda...@chromium.org wrote: On Thu, Jul 23, 2009 at 4:42 PM, Ben Laurie b...@google.com wrote: On Thu, Jul 23, 2009 at 4:30 PM, Wan-Teh Changw...@google.com wrote: Ben, I believe the GCC warning you want is -Wreturn-type, which is enabled

[chromium-dev] Re: Compiler warnings?

2009-07-23 Thread Ben Laurie
On Thu, Jul 23, 2009 at 4:54 PM, Evan Martine...@chromium.org wrote: On Thu, Jul 23, 2009 at 4:50 PM, Ben Laurieb...@google.com wrote: On Thu, Jul 23, 2009 at 4:44 PM, Darin Fisherda...@chromium.org wrote: On Thu, Jul 23, 2009 at 4:42 PM, Ben Laurie b...@google.com wrote: On Thu, Jul 23

[chromium-dev] Re: Compiler warnings?

2009-07-23 Thread Ben Laurie
On Thu, Jul 23, 2009 at 4:17 PM, Mike Mammarellam...@chromium.org wrote: gcc/g++ have __attribute__((warn_unused_result)) that you can specify on a per-function basis: http://www.ohse.de/uwe/articles/gcc-attributes.html#func-warn_unused_result Or do you mean warnings when a function is

[chromium-dev] Compiler warnings?

2009-07-23 Thread Ben Laurie
I just fixed a bug that wouldn't have happened at all if missing return values were flagged ... is there a way to turn on compiler warnings (building on Linux using make)? Is there some reason they're not on by default? --~--~-~--~~~---~--~~ Chromium Developers

[chromium-dev] Re: 2000 errors building WebCore bindings!

2009-07-06 Thread Ben Laurie
On Mon, Jul 6, 2009 at 3:29 PM, Evan Martine...@chromium.org wrote: http://code.google.com/p/chromium/issues/detail?id=15904 Something went wrong with quoting when some v8-related script was upstreamed.  Dimitri's working on it. On Mon, Jul 6, 2009 at 7:18 AM, Mike

[chromium-dev] Re: 2000 errors building WebCore bindings!

2009-07-06 Thread Ben Laurie
On Mon, Jul 6, 2009 at 3:43 PM, Dimitri Glazkovdglaz...@google.com wrote: Apply this locally, if you want to get rid of them: diff --git a/WebCore/bindings/scripts/IDLParser.pm b/WebCore/bindings/scripts/IDLParser.pm index c4cb041..0a6832f 100644 --- a/WebCore/bindings/scripts/IDLParser.pm

[chromium-dev] Frustrating problem with Linux Make build

2009-07-01 Thread Ben Laurie
Following http://code.google.com/p/chromium/wiki/LinuxMakeBuild, I get this error: chrome/browser/debugger/devtools_window.cc:23:38: error: grit/generated_resources.h: No such file or directory and, indeed, if I look: $ ls out/Debug/obj/gen/chrome/grit browser_resources.h renderer_resources.h

[chromium-dev] Re: Memory usage in chrome

2009-07-01 Thread Ben Laurie
On Wed, Jun 24, 2009 at 8:19 AM, Mike Belshembel...@google.com wrote: Anecdotally, a couple of people have said it works and a couple of people have said it makes no difference.  I do believe that people doing compiles could see a difference. To determine if it was real, we did an experiment

[chromium-dev] Re: Frustrating problem with Linux Make build

2009-07-01 Thread Ben Laurie
On Wed, Jul 1, 2009 at 8:22 AM, Ben Goodger (Google)b...@chromium.org wrote: Sounds like a dependency issue. Can you explicitly build the chrome_strings target and then try building the target you were trying to build again? $ make chrome_strings make: *** No rule to make target

[chromium-dev] Re: Frustrating problem with Linux Make build

2009-07-01 Thread Ben Laurie
On Wed, Jul 1, 2009 at 11:11 AM, Ben Laurieb...@google.com wrote: On Wed, Jul 1, 2009 at 8:22 AM, Ben Goodger (Google)b...@chromium.org wrote: Sounds like a dependency issue. Can you explicitly build the chrome_strings target and then try building the target you were trying to build again?

[chromium-dev] Re: Frustrating problem with Linux Make build

2009-07-01 Thread Ben Laurie
On Wed, Jul 1, 2009 at 1:24 PM, Dean McNameede...@chromium.org wrote: On Wed, Jul 1, 2009 at 2:21 PM, Dean McNameede...@chromium.org wrote: Patches are welcome.  It looks like maybe in chrome.gyp, the debugger target should also debug on chrome_strings ? Er, it should also _depend_ on.  

[chromium-dev] Re: Frustrating problem with Linux Make build

2009-07-01 Thread Ben Laurie
On Wed, Jul 1, 2009 at 1:21 PM, Dean McNameede...@chromium.org wrote: Patches are welcome.  It looks like maybe in chrome.gyp, the debugger target should also debug on chrome_strings ? Oh, hmmm. I didn't consider that. My personal preference is that dependencies should be calculated

[chromium-dev] Re: Frustrating problem with Linux Make build

2009-07-01 Thread Ben Laurie
On Wed, Jul 1, 2009 at 1:52 PM, Ben Laurieb...@google.com wrote: On Wed, Jul 1, 2009 at 1:21 PM, Dean McNameede...@chromium.org wrote: Patches are welcome.  It looks like maybe in chrome.gyp, the debugger target should also debug on chrome_strings ? Oh, hmmm. I didn't consider that. My

[chromium-dev] Re: Frustrating problem with Linux Make build

2009-07-01 Thread Ben Laurie
On Wed, Jul 1, 2009 at 1:21 PM, Dean McNameede...@chromium.org wrote: Patches are welcome.  It looks like maybe in chrome.gyp, the debugger target should also debug on chrome_strings ? Yeah. Here's the patch: http://codereview.chromium.org/150165 On Wed, Jul 1, 2009 at 12:50 PM, Ben

[chromium-dev] Re: Frustrating problem with Linux Make build

2009-07-01 Thread Ben Laurie
On Wed, Jul 1, 2009 at 3:22 PM, Evan Martine...@chromium.org wrote: On Tue, Jun 30, 2009 at 10:02 AM, Ben Laurieb...@google.com wrote: Following http://code.google.com/p/chromium/wiki/LinuxMakeBuild, I get this error: I really apologize.  I made this build as a quick hack and now people are

[chromium-dev] Re: Frustrating problem with Linux Make build

2009-07-01 Thread Ben Laurie
On Wed, Jul 1, 2009 at 3:33 PM, Evan Martine...@chromium.org wrote: On Wed, Jul 1, 2009 at 3:50 AM, Ben Laurieb...@google.com wrote: On Wed, Jul 1, 2009 at 11:11 AM, Ben Laurieb...@google.com wrote: On Wed, Jul 1, 2009 at 8:22 AM, Ben Goodger (Google)b...@chromium.org wrote: Sounds like a