[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-28 Thread John Grabowski
Macs appear to support MADV_DONTNEED (at least they are doc'ed as such). However, wtf/Platform.h seems to imply Apple uses mmap/munmap instead of madvise for their tcmalloc fork. The tcmalloc in third_party does not appear to have the mmap/munmap support seen in WTF's tcmalloc, so our TCMalloc_Sy

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-28 Thread Darin Fisher
On Wed, Oct 28, 2009 at 5:04 PM, Darin Fisher wrote: > On Wed, Oct 28, 2009 at 7:52 AM, Marc-Antoine Ruel wrote: > >> On Wed, Oct 28, 2009 at 1:30 AM, Darin Fisher wrote: >> > I'm pretty sure that enabling USE_SYSTEM_MALLOC will also lead to >> corruption >> > since WebKit is not hermetic (we al

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-28 Thread Darin Fisher
On Wed, Oct 28, 2009 at 7:52 AM, Marc-Antoine Ruel wrote: > On Wed, Oct 28, 2009 at 1:30 AM, Darin Fisher wrote: > > I'm pretty sure that enabling USE_SYSTEM_MALLOC will also lead to > corruption > > since WebKit is not hermetic (we allocate things externally that we then > > delete inside WebKit

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-28 Thread ι™ˆζ™Ίζ˜Œ
On Tue, Oct 27, 2009 at 9:10 PM, Mike Belshe wrote: > On Tue, Oct 27, 2009 at 3:24 PM, Jens Alfke wrote: >> >> Do we plan to switch the Mac build of Chromium to use tcmalloc instead of >> the system malloc? I thought this was the case, but I can't find any bug >> covering the task to do that. I'

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-28 Thread Mike Belshe
On Wed, Oct 28, 2009 at 10:54 AM, Jens Alfke wrote: > > On Oct 27, 2009, at 9:10 PM, Mike Belshe wrote: > > From a performance perspective, it may be critical to use tcmalloc to match > safari performance. It was literally a 50% speedup on most of the DOM perf > when running on WinXP. > > > Yeah

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-28 Thread Jens Alfke
On Oct 27, 2009, at 9:10 PM, Mike Belshe wrote: > From a performance perspective, it may be critical to use tcmalloc > to match safari performance. It was literally a 50% speedup on most > of the DOM perf when running on WinXP. Yeah, I've profiled some of the Dromaeo benchmarks, and the DOM

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-28 Thread Marc-Antoine Ruel
On Wed, Oct 28, 2009 at 1:30 AM, Darin Fisher wrote: > I'm pretty sure that enabling USE_SYSTEM_MALLOC will also lead to corruption > since WebKit is not hermetic (we allocate things externally that we then > delete inside WebKit). > -Darin Wouha! That really limit our capacity to link wekbit.dl

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-28 Thread Anton Muhin
On Wed, Oct 28, 2009 at 7:10 AM, Mike Belshe wrote: > On Tue, Oct 27, 2009 at 3:24 PM, Jens Alfke wrote: >> >> Do we plan to switch the Mac build of Chromium to use tcmalloc instead of >> the system malloc? I thought this was the case, but I can't find any bug >> covering the task to do that. I'

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-27 Thread Darin Fisher
On Tue, Oct 27, 2009 at 9:10 PM, Mike Belshe wrote: > On Tue, Oct 27, 2009 at 3:24 PM, Jens Alfke wrote: > >> Do we plan to switch the Mac build of Chromium to use tcmalloc instead of >> the system malloc? I thought this was the case, but I can't find any bug >> covering the task to do that. I'm

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-27 Thread Mike Belshe
On Tue, Oct 27, 2009 at 3:24 PM, Jens Alfke wrote: > Do we plan to switch the Mac build of Chromium to use tcmalloc instead of > the system malloc? I thought this was the case, but I can't find any bug > covering the task to do that. I'm on the memory task force, and this > decision could definit