[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-11-30 Thread krtulmay
And don't forget http://crbug.com/27594: Alt key doesn't focus Page Menu On Nov 29, 11:22 pm, PhistucK phist...@gmail.com wrote: Trying it out, I just noticed that when you press Tab while on the Go\Stop button, nothing is focused. Another Tab will make the focus go to the Page menu. My guess

Re: [chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-11-29 Thread PhistucK
Trying it out, I just noticed that when you press Tab while on the Go\Stop button, nothing is focused. Another Tab will make the focus go to the Page menu. My guess is that the problem is the hidden Bookmarks button. ☆PhistucK On Fri, Oct 9, 2009 at 03:21, Mohamed Mansour m...@chromium.org

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-10-12 Thread Jonas Klink (Google)
So, the background story here is as follows: in Windows, the typical toolbar will have one tabstop (accessible through tab or shift-tab) on the whole toolbar, and buttons will then be traversable using left and right arrow keys. For instance, this behavior can be seen in the Quick Launch toolbar,

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-10-09 Thread Peter Kasting
On Thu, Oct 8, 2009 at 6:32 PM, Finnur Thorarinsson fin...@chromium.orgwrote: Maybe it's just me, but I don't see the point in making a toolbar as a whole focusable. The keyboard shortcut should put focus on the first element in the toolbar and tab should cycle focus from there. ^^^ this PK

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-10-09 Thread Jay Campan
On Thu, Oct 8, 2009 at 6:32 PM, Finnur Thorarinsson fin...@chromium.orgwrote: Maybe it's just me, but I don't see the point in making a toolbar as a whole focusable. The keyboard shortcut should put focus on the first element in the toolbar and tab should cycle focus from there. The goal was

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-10-09 Thread Jay Campan
+1.  To a beginner, left and right arrow might be more intuitive and an opportunity for us to innovate.  But millions of people use screenreaders, have trouble using the mouse, or are just power users who love keyboard shortcuts, and we're just frustrating them by not letting them use

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-10-09 Thread Dominic Mazzoni
On Fri, Oct 9, 2009 at 11:15 AM, Jay Campan jcam...@chromium.org wrote: +1. To a beginner, left and right arrow might be more intuitive and an opportunity for us to innovate. But millions of people use screenreaders, have trouble using the mouse, or are just power users who love keyboard

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-10-08 Thread Mohamed Mansour
Hi everyone, I was experimenting on how to visualize when we focus different tabs, and (from a bug I was working on http://crbug.com/15228) I realized a few stuff. If we enable IsFocusable for all the toolbars we have in Chromium, we will have this good (or some people might be annoyed by it)

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-10-08 Thread Finnur Thorarinsson
Maybe it's just me, but I don't see the point in making a toolbar as a whole focusable. The keyboard shortcut should put focus on the first element in the toolbar and tab should cycle focus from there. and when we press ALT+T+TAB ... I hope you mean ALT+T and then TAB because ALT+T+TAB is a

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-30 Thread Scott Violet
Sounds good to me. -Scott On Tue, Sep 29, 2009 at 5:03 PM, Jonas Klink (Google) kl...@chromium.org wrote: So, to clarify, we would then use ALT+SHIFT+T (currently focusing the toolbar), to cycle keyboard focus through any open toolbars (toolbar-bookmark bar-infobar (restore tabs etc, if

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-29 Thread Jonas Klink (Google)
+ CC Scott and Evan, to maintain a good story cross-platform. Any suggestions for a keyboard model here? I'd really like to stay away from the long, complex keyboard combos, also because noone will ever discover that they are there... - Jonas On Mon, Sep 28, 2009 at 10:51 PM, Mohamed Mansour

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-29 Thread Peter Kasting
On Mon, Sep 28, 2009 at 10:51 PM, Mohamed Mansour m...@chromium.org wrote: CTRL+SHIFT+T --- Main Toolbar CTRL+SHIFT+B --- Main Bookmarks bar CTRL+SHIFT+E --- Extension bar I really don't like this. These are hard to discover and use. Besides, you can't use two of these three: ctrl-shift-t

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-29 Thread Evan Martin
I find our accessibility story a bit confusing since we don't allow most of the browser UI to be focused. That is, pressing tab in the URL bar doesn't do what tab normally does. I guess there's some other key that puts the browser into accessible mode? In that case, I would want to reuse that

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-29 Thread Scott Violet
On Tue, Sep 29, 2009 at 10:16 AM, Peter Kasting pkast...@google.com wrote: On Mon, Sep 28, 2009 at 10:51 PM, Mohamed Mansour m...@chromium.org wrote: CTRL+SHIFT+T  --- Main Toolbar CTRL+SHIFT+B --- Main Bookmarks bar CTRL+SHIFT+E --- Extension bar I really don't like this.  These are hard

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-29 Thread Ben Goodger (Google)
Indeed. We need to be very careful not to over-use keyboard shortcuts. We will regret it later if we do. -Ben On Tue, Sep 29, 2009 at 10:25 AM, Scott Violet s...@chromium.org wrote: On Tue, Sep 29, 2009 at 10:16 AM, Peter Kasting pkast...@google.com wrote: On Mon, Sep 28, 2009 at 10:51 PM,

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-29 Thread Nico Weber
FWIW, on OS X there's a system setting for Tab cycles through everything or just important things in sysprefs-accessibility (I think. Not at my mac right now). On Tue, Sep 29, 2009 at 10:25 AM, Scott Violet s...@chromium.org wrote: On Tue, Sep 29, 2009 at 10:16 AM, Peter Kasting

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-29 Thread Peter Kasting
On Tue, Sep 29, 2009 at 10:25 AM, Scott Violet s...@chromium.org wrote: On Tue, Sep 29, 2009 at 10:16 AM, Peter Kasting pkast...@google.com wrote: It seems like when these bars are open, their contents should be in the tab order. You should be able to tab through the contents of a page,

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-29 Thread Mohamed Mansour
What kind of accelerators do would you like to have? Maybe have a accelerator that traverses only toolbars, and once we are in that toolbar, we can tab through the widgets. -Mohamed On Tue, Sep 29, 2009 at 1:30 PM, Peter Kasting pkast...@google.com wrote: On Tue, Sep 29, 2009 at 10:25 AM,

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-29 Thread Scott Violet
I would just use the existing accelerator we have to focus the toolbar. -Scott On Tue, Sep 29, 2009 at 3:58 PM, Mohamed Mansour m...@chromium.org wrote: What kind of accelerators do would you like to have? Maybe have a accelerator that traverses only toolbars, and once we are in that

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-29 Thread Mohamed Mansour
What would differentiate which toolbar is currently focused? Would it be ideal to assume the first widget in that toolbar would be focused (hotkeyed), or we would draw some sort of ring around the whole toolbar? -Mohamed On Tue, Sep 29, 2009 at 8:03 PM, Jonas Klink (Google)

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-29 Thread Ben Goodger (Google)
Building on what we already have sounds good to me. -Ben On Tue, Sep 29, 2009 at 5:03 PM, Jonas Klink (Google) kl...@chromium.org wrote: So, to clarify, we would then use ALT+SHIFT+T (currently focusing the toolbar), to cycle keyboard focus through any open toolbars (toolbar-bookmark

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-29 Thread Jonas Klink (Google)
From an accessibility point-of-view, I'd prefer having the first widget in each toolbar focused when the toolbar itself gains focus (including hottracked and displaying any tooltip that is displayed on mouseover of this widget). On Tue, Sep 29, 2009 at 5:28 PM, Mohamed Mansour m...@chromium.org

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-28 Thread Mohamed Mansour
I agree with James, ALT keys should be only used for accessibility, if we want to be able to allow keyboard shortcuts to other toolbars, we need to reorganize our current ones. It would be nice to have the following combinations: CTRL+SHIFT+T --- Main Toolbar CTRL+SHIFT+B --- Main Bookmarks bar

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-26 Thread Jacob Mandelson
On Sat, Sep 26, 2009 at 11:40:07AM -0400, Mohamed Mansour wrote: Hi all, (need UI team feedback and other keyboard guru's) We need a more coherent story for accessing various toolbars. The current toolbars that exist right now are: - Toolbar - Bookmark bar - Extension bar -

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-09-26 Thread James Su
2009/9/26 Jacob Mandelson ja...@mandelson.org On Sat, Sep 26, 2009 at 11:40:07AM -0400, Mohamed Mansour wrote: Hi all, (need UI team feedback and other keyboard guru's) We need a more coherent story for accessing various toolbars. The current toolbars that exist right now are: -