[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-30 Thread Jeremy Orlow
The story is even simpler for localStorage. Everything is fairly self contained and the only way it cares about the main thread is in asserts to verify SQLite is not used on the main thread. My guess is that the story for what's considered the main thread will change for each API much like the spl

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-30 Thread Michael Nordman
On Thu, Apr 30, 2009 at 12:26 PM, Michael Nordman wrote: > On Thu, Apr 30, 2009 at 11:40 AM, Darin Fisher wrote: >> On Tue, Apr 28, 2009 at 6:22 PM, Aaron Boodman wrote: >>> >>> On Tue, Apr 28, 2009 at 6:18 PM, Michael Nordman >>> wrote: >>> > >>> > + chromium-dev >>> > >>> >> Can you please e

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-30 Thread Michael Nordman
On Thu, Apr 30, 2009 at 11:40 AM, Darin Fisher wrote: > On Tue, Apr 28, 2009 at 6:22 PM, Aaron Boodman wrote: >> >> On Tue, Apr 28, 2009 at 6:18 PM, Michael Nordman >> wrote: >> > >> > + chromium-dev >> > >> >> Can you please explain what you think has changed since such decisions >> >> were ma

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-30 Thread Darin Fisher
On Tue, Apr 28, 2009 at 6:22 PM, Aaron Boodman wrote: > > On Tue, Apr 28, 2009 at 6:18 PM, Michael Nordman > wrote: > > > > + chromium-dev > > > >> Can you please explain what you think has changed since such decisions > were made (or why it's time to revisit such decisions)? > > > > I don't thi

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-29 Thread Michael Nordman
Yup, I'm looking to work thru things in a similar fashion with anders (original appcache author). On Wed, Apr 29, 2009 at 11:53 AM, David Levin wrote: > I think how to split/refactor depends on the feature, understanding the > current code, and working with the appropriate webkit dev. > For work

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-29 Thread David Levin
I think how to split/refactor depends on the feature, understanding the current code, and working with the appropriate webkit dev. For workers, we thought about how/where it made sense to split the impl for chrome and talked with a...@webkit about it. There was some iteration as we figured out thi

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-29 Thread Michael Nordman
+chromium-dev Designing things in this front/back fashion and re-using the code entirely in chrome removes at least one high-coefficient of friction surface rubbing between the chromium and webkit teams. We will likely pay a higher price up front, but it should pay dividends down the road. Add an

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-29 Thread Peter Kasting
On Wed, Apr 29, 2009 at 9:44 AM, Dimitri Glazkov wrote: > I think it's a great idea and the only drawback I can see is the WTF > dependency and the security implications, which shouldn't be anything > we couldn't overcome. Yes, the biggest worry I'd have here has little to do with whether it's o

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-29 Thread Dimitri Glazkov
I think it's a great idea and the only drawback I can see is the WTF dependency and the security implications, which shouldn't be anything we couldn't overcome. The biggest challenges IMHO would be: 1) clearly identifying what backend and frontend mean and where the separation occurs. I worry (p

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-29 Thread Peter Kasting
On Wed, Apr 29, 2009 at 7:43 AM, David Levin wrote: > Ideally, there would be one implementation in webkit for html features > which would allow multiple things: > 1. Better compatibility across webkit impls. This makes it easier for web > devs. > 2. Bugs fixes in one implementation help for bot

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-29 Thread Jeremy Orlow
On Wed, Apr 29, 2009 at 7:43 AM, David Levin wrote: > > > On Wed, Apr 29, 2009 at 7:02 AM, Peter Kasting wrote: > >> On Tue, Apr 28, 2009 at 6:38 PM, Jeremy Orlow wrote: >> >>> Darin was there on that lunch and was actually the one who first >>> suggested running parts of WebCore in the browser t

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-29 Thread David Levin
On Wed, Apr 29, 2009 at 7:02 AM, Peter Kasting wrote: > On Tue, Apr 28, 2009 at 6:38 PM, Jeremy Orlow wrote: > >> Darin was there on that lunch and was actually the one who first suggested >> running parts of WebCore in the browser to me during a 1:1. :-) >> > > Indeed, we're already planning to

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-29 Thread Peter Kasting
On Tue, Apr 28, 2009 at 6:38 PM, Jeremy Orlow wrote: > Darin was there on that lunch and was actually the one who first suggested > running parts of WebCore in the browser to me during a 1:1. :-) > Indeed, we're already planning to do it in other ways -- using a text field as a directly-instant

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-28 Thread Jeremy Orlow
On Tue, Apr 28, 2009 at 6:26 PM, Evan Martin wrote: > On Tue, Apr 28, 2009 at 5:59 PM, Aaron Boodman wrote: > > Is the idea that someday the browser and renderer processes > > might be separate binaries? > > Though this shouldn't drive your decision, about 50% of our code > weight (at least by o

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-28 Thread Aaron Boodman
On Tue, Apr 28, 2009 at 6:31 PM, Michael Nordman wrote: I have always felt like running the WebCore "backend" in the browser was elegant >>> >>> Yea, but we need a webcore backend to run :) >> >> Well last time I looked at this there was already a Database backend :) > > Right... inter

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-28 Thread Michael Nordman
On Tue, Apr 28, 2009 at 6:22 PM, Aaron Boodman wrote: > On Tue, Apr 28, 2009 at 6:18 PM, Michael Nordman > wrote: >> >> + chromium-dev >> >>> Can you please explain what you think has changed since such decisions were >>> made (or why it's time to revisit such decisions)? >> >> I don't think t

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-28 Thread Evan Martin
On Tue, Apr 28, 2009 at 5:59 PM, Aaron Boodman wrote: > Is the idea that someday the browser and renderer processes > might be separate binaries? Though this shouldn't drive your decision, about 50% of our code weight (at least by one metric) is WebKit. You could imagine that the browser proces

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-28 Thread Aaron Boodman
On Tue, Apr 28, 2009 at 6:18 PM, Michael Nordman wrote: > > + chromium-dev > >> Can you please explain what you think has changed since such decisions were >> made (or why it's time to revisit such decisions)? > > I don't think there was code in webcore suitable for this purpose > before... html

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-28 Thread Michael Nordman
+ chromium-dev > Can you please explain what you think has changed since such decisions were > made (or why it's time to revisit such decisions)? I don't think there was code in webcore suitable for this purpose before... html parsing, javascript,sql interpretting... all dangerous from a securi

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-28 Thread Jeremy Orlow
Well, the question comes down to this: Can we trust running small amounts of WebCore in the browser process. Historically, the answer to running WebCore in the browser has been a resounding no. Can you please explain what you think has changed since such decisions were made (or why it's time to re

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-28 Thread Aaron Boodman
I have always felt like running the WebCore "backend" in the browser process with an IPC channel between it and the frontend was a really elegant design for this problem. And I never really understood why we weren't allowed to depend on WebCore (even indirectly) in the browser process. Is the idea

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-28 Thread Michael Nordman
On Tue, Apr 28, 2009 at 5:38 PM, Jeremy Orlow wrote: > On Tue, Apr 28, 2009 at 5:27 PM, Michael Nordman > wrote: >> >> > In some sense we do have separate process in which to run sandboxed >> > 'backend' code relevant to multiple renders if the need arises... the >> > worker process. > > The way

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some "browser helper" process

2009-04-28 Thread Jeremy Orlow
On Tue, Apr 28, 2009 at 5:27 PM, Michael Nordman wrote: > > In some sense we do have separate process in which to run sandboxed > > 'backend' code relevant to multiple renders if the need arises... the > > worker process. > The way you stated this is a bit odd, but on the surface I guess this cou