[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Jeremy Orlow
On Wed, Aug 12, 2009 at 2:36 PM, Thomas Van Lenten wrote: > > On Wed, Aug 12, 2009 at 5:32 PM, Bradley Nelson wrote: > >> I would argue this does fall in the domain of something gyp should be able >> to do. Scons for instance detects when command lines have changed. If I >> recall correctly, xcode

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Thomas Van Lenten
On Wed, Aug 12, 2009 at 5:32 PM, Bradley Nelson wrote: > I would argue this does fall in the domain of something gyp should be able > to do. Scons for instance detects when command lines have changed. If I > recall correctly, xcode does as well. This wouldn't involve gyp touching the > output dire

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Bradley Nelson
I would argue this does fall in the domain of something gyp should be able to do. Scons for instance detects when command lines have changed. If I recall correctly, xcode does as well. This wouldn't involve gyp touching the output directory at all, it would be more like how you can list a makefile

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Jeremy Orlow
I don't understand your response. On Wed, Aug 12, 2009 at 2:22 PM, Thomas Van Lenten wrote: > > > On Wed, Aug 12, 2009 at 5:03 PM, Bradley Nelson wrote: > >> That one is know (we have a gyp issue filed from a while back).The >> problem is that visual studio doesn't detect command line changes (we

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Thomas Van Lenten
On Wed, Aug 12, 2009 at 5:03 PM, Bradley Nelson wrote: > That one is know (we have a gyp issue filed from a while back).The problem > is that visual studio doesn't detect command line changes (well actually it > does as long as you do them in the IDE and don't leave the sln). > We believe we can '

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Bradley Nelson
That one is know (we have a gyp issue filed from a while back).The problem is that visual studio doesn't detect command line changes (well actually it does as long as you do them in the IDE and don't leave the sln). We believe we can 'fix' this limitation by having gyp emit a file containing comman

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Mark Mentovai
I don't think so. It looks like VS doesn't rebuild files when the compiler invocation to build them would change. Michael added a new macro definition on the command line. If that's the case, this would be a VS problem (I'd call it a bug), and I'm not sure how easy it would be to work around in

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Jeremy Orlow
Brad, looks like we might have another dependency bug in GYP? J On Wed, Aug 12, 2009 at 1:57 PM, Michael Nordman wrote: > I just submitted the change that ENABLE's that flag a moment ago... we're > clobbering things now > > > On Wed, Aug 12, 2009 at 1:55 PM, Jeremy Orlow wrote: > >> Clobber nee

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Michael Nordman
I just submitted the change that ENABLE's that flag a moment ago... we're clobbering things now On Wed, Aug 12, 2009 at 1:55 PM, Jeremy Orlow wrote: > Clobber needed? > I know Michael just enabled this within the last 24 hours. > > > On Wed, Aug 12, 2009 at 1:49 PM, Paweł Hajdan Jr. > wrote: >

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Jeremy Orlow
Clobber needed? I know Michael just enabled this within the last 24 hours. On Wed, Aug 12, 2009 at 1:49 PM, Paweł Hajdan Jr. wrote: > Just got this on the Windows tryserver: > C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc : > error C2220: warning treated as error - no 'ob