Re: [cp-patches] [PATCH] Fix raw type references in AnnotationInvocationHandler

2011-10-12 Thread Ian Rogers
On 12 October 2011 03:52, Mark Wielaard m...@klomp.org wrote: On Wed, 2011-10-12 at 10:29 +0300, Pekka Enberg wrote: On Wed, Oct 12, 2011 at 1:28 AM, Dr Andrew John Hughes ahug...@redhat.com wrote: If we're going to change that, it should happen after the next release and with plenty of

Re: netif.h present but unusable on Mac

2009-11-25 Thread Ian Rogers
Hi Richard, Jikes RVM is using an older version of Classpath than what is current. MRP [1] (derived from Jikes RVM) uses the latest GNU Classpath. You may want to try this as an alternative, although currently you'll need to download MRP using git. Regards, Ian [1] http://mrp.codehaus.org/

Re: [cp-patches] FYI: Add VM updates in 0.98

2009-02-09 Thread Ian Rogers
Hi, I've attached a revision for the reflection classes that is applied to Jikes RVM and has been updated for 0.98. This patch removes the messy backlink mechanism in reflection and better supports eliminating reflection overhead in Jikes RVM. Due to the problems it would cause to VMs thought is

Problems with Jikes RVM and Ubuntu 8.10

2008-11-06 Thread Ian Rogers
the same problem? Thanks, Ian Rogers -- http://www.cs.man.ac.uk/~irogers/

Jikes RVM 3.0.1 released

2008-10-17 Thread Ian Rogers
Jikes RVM version 3.0.1 has been released and is available for download at _http://downloads.sourceforge.net/jikesrvm/jikesrvm-3.0.1.tar.bz2_ http://downloads.sourceforge.net/jikesrvm/jikesrvm-3.0.1.tar.bz2 The detailed release notes for major changes since 3.0.0 can be found below or in JIRA

Re: [cp-patches] FYI: ThreadLocal optimisation

2008-09-12 Thread Ian Rogers
Andrew Haley wrote: Andrew John Hughes wrote: Daniel's copyright assignment is finally through, so I'm committing this patch which optimises the use of ThreadLocals by replacing the use of the generic java.util.WeakHashMap with a ThreadLocal-specific implementation. It's slightly

[cp-patches] RFC: Try to reduce char[] copying in jlr.Proxy

2008-08-29 Thread Ian Rogers
Hi, the attached patch is trying to continue Andrew's good work and reduce the amount of redundant array copying, in this case in jlr.Proxy. There is a TODO in that we have no back door to turn a char[] in to a String without copying. Thanks, Ian Index: java/lang/reflect/Proxy.java

[cp-patches] State of Jikes RVM patches waiting to go into Classpath

2008-08-18 Thread Ian Rogers
? Thanks, Ian Rogers

[cp-patches] RFC: AIX build fix - paths too long in check_jni.sh

2008-08-18 Thread Ian Rogers
Dave Grove fixed an AIX build issue for the Jikes RVM with the attached patch. Jikes RVM tracker here: http://jira.codehaus.org/browse/RVM-526 Regards, Ian Rogers Index: scripts/check_jni_methods.sh.in === RCS file: /sources

Re: [cp-patches] [rvm-core] State of Jikes RVM patches waiting to go into Classpath

2008-08-18 Thread Ian Rogers
Andrew John Hughes wrote: On 18/08/2008, Ian Rogers [EMAIL PROTECTED] wrote: Thanks Andrew, Andrew John Hughes wrote: On 18/08/2008, Ian Rogers [EMAIL PROTECTED] wrote: Hi, currently there are 3 patches waiting to go into GNU Classpath from Jikes RVM: Note

[cp-patches] RFC: Avoid back references in java.lang.reflect VMXXX classes

2008-08-18 Thread Ian Rogers
This patch is part of Jikes RVM JIRA issue 443: http://jira.codehaus.org/browse/RVM-443 committed here: http://jikesrvm.svn.sourceforge.net/viewvc/jikesrvm?view=revrevision=14905 The patch avoids back references in java.lang.reflect.VM* classes and instead passes the parent object as a

Jikes RVM 3.0.0 released

2008-08-07 Thread Ian Rogers
We're very happy to announce the release of Jikes RVM version 3.0.0. The road towards 3.0 began just about two years ago and a large number of people, both on the core team and from our user community at large, have contributed to making it a success. Thank You! The release is available for

Re: Savannah has Mercurial!

2008-06-06 Thread Ian Rogers
Andrew John Hughes wrote: I just noticed this announcement when submitting the news announcement for 0.97.2. What do people think to the idea of switching? Maybe post 0.98? Hi, just to give a different perspective. For Jikes RVM there's been no choice to use Mercurial as SourceForge

Re: [cp-patches] RFC: changes to java.lang.Integer, Long...

2008-06-03 Thread Ian Rogers
Andrew Haley wrote: Ian Rogers wrote: please give your comments on the attached patch. It tries to reduce the size of char[] for strings used to hold numbers. It changes Float/Double equals to use bit based comparisons rather than division. It increases the use of valueOf methods. It adds

[cp-patches] RFC: Change to ArrayList.ensureCapacity

2008-05-27 Thread Ian Rogers
This patch changes the array list size increase to ~50% rather than doubling in line with what OpenJDK does. OpenJDK still doubles the size of vectors, as that's documented behavior. Feedback appreciated, Ian -- http://www.cs.man.ac.uk/~irogers/ ---

Re: Classpath 0.98

2008-05-11 Thread Ian Rogers
Andrew John Hughes wrote: Dear all, I think it's about time we started to consider another (major) release. My personal wishlist of things to finish for this release is: * java.util.regex 1.6 support * java.util.Scanner import (dependent on the above) * import of javax.activation Another

SPEC jvm 2008 successes?

2008-05-08 Thread Ian Rogers
Hi, I was wondering what success people have had running SPEC jvm 2008 [1]. My experiences are here [2] and I'd like to get further. If anyone succeeds I'd be interested to know. Thanks, Ian [1] http://www.spec.org/jvm2008/ [2] http://jira.codehaus.org/browse/RVM-480 -- Third International

Re: [cp-patches] RFC: Move exception handling out of common case: java.util.Vector/ArrayList

2008-04-26 Thread Ian Rogers
patch applied. Ian -- Third International Workshop on Implementation, Compilation, Optimization of Object-Oriented Languages, Programs and Systems (ICOOOLPS 2008) July 7, Paphos (Cyprus) http://icoolps.loria.fr http://icooolps.loria.fr/

[commit-cp] classpath ChangeLog java/util/ArrayList.java ja...

2008-04-26 Thread Ian Rogers
CVSROOT:/sources/classpath Module name:classpath Changes by: Ian Rogers irogers08/04/26 16:46:47 Modified files: . : ChangeLog java/util : ArrayList.java Vector.java Log message: 2008-04-26 Ian Rogers [EMAIL PROTECTED

[cp-patches] RFC: Move exception handling out of common case: java.util.Vector/ArrayList

2008-04-25 Thread Ian Rogers
Hi, the attached patch moves exception handling code out of the common case for elementAt of both java.util.Vector and java.util.elementAt, this helps JIT compilation inline the common non-exception throwing case (and avoid expense incurred by considering StringBuilders, etc.). Other than

Re: [cp-patches] RFC: Move exception handling out of common case: java.util.Vector/ArrayList

2008-04-25 Thread Ian Rogers
Andrew John Hughes wrote: Looks okay, overlooking the obvious formatting issues. Is there an overhead to the method call or would most VMs inline this? So, most code shouldn't access an element beyond the length of the Vector or ArrayList - so the exception handling code will never

[cp-patches] Re: RFC: changes to java.nio buffers

2008-04-18 Thread Ian Rogers
Committed. 2008-04-18 Ian Rogers [EMAIL PROTECTED] * java/nio/Buffer.java (cap): make field private and final. (address): make field final. (Buffer): add address argument to package protected constructor thereby

[commit-cp] classpath ChangeLog java/lang/Byte.java java/la...

2008-04-18 Thread Ian Rogers
CVSROOT:/sources/classpath Module name:classpath Changes by: Ian Rogers irogers08/04/18 21:00:12 Modified files: . : ChangeLog java/lang : Byte.java Character.java Double.java Float.java Integer.java Long.java

[commit-cp] classpath ChangeLog java/nio/Buffer.java java/n...

2008-04-18 Thread Ian Rogers
CVSROOT:/sources/classpath Module name:classpath Changes by: Ian Rogers irogers08/04/18 23:23:34 Modified files: . : ChangeLog java/nio : Buffer.java ByteBuffer.java ByteBufferImpl.java CharBuffer.java

[cp-patches] RFC: changes to java.lang.Integer, Long...

2008-04-14 Thread Ian Rogers
-r1.9572 ChangeLog --- ChangeLog 9 Apr 2008 20:23:11 - 1.9572 +++ ChangeLog 14 Apr 2008 13:54:25 - @@ -1,3 +1,50 @@ +2008-04-14 Ian Rogers [EMAIL PROTECTED] + + * java/lang/Byte.java (static): initialize byteCache. + (valueOf(String,int)): use valueOf(byte) rather than

Re: [cp-patches] RFC: changes to java.lang.Integer, Long...

2008-04-14 Thread Ian Rogers
David Daney wrote: Ian Rogers wrote: Hi, please give your comments on the attached patch. It tries to reduce the size of char[] for strings used to hold numbers. It changes Float/Double equals to use bit based comparisons rather than division. It increases the use of valueOf methods

Re: [cp-patches] RFC: File bug Fix and small VM interface change

2008-04-09 Thread Ian Rogers
Hi Mario, this looks like a good patch so +1 from me. Just to note that we've been discussing the VMFile interface in a Jikes RVM tracker [1] and that on IRC MJW pointed out that GCJ's implementation appeared to vary from that of Classpath [2] [3] [4]. Regards, Ian [1]

[cp-patches] RFC: changes to java.nio buffers

2008-04-08 Thread Ian Rogers
Hi, the attached patch makes more fields in java.nio final, restructuring constructors to enable this. This simplifies the code sufficiently that it aids the Jikes RVM's escape analysis so that it can remove memory allocations associated with buffers in certain key areas. When some fields

Re: Inconvertible types error in EnumSet.java

2008-03-17 Thread Ian Rogers
bytecode when compiling Classpath - this is fixed in the first milestone after ECJ 3.3, but most Linux distributions ship with the broken ECJ). The broken javac problem is also present in other 1.5 JDKs (e.g. BEA, IBM), and is actually a different bug with the initial 1.5 releases. Regards, Ian

Re: brandweg hacking session on friday

2008-02-21 Thread Ian Rogers
Dalibor Topic wrote: I'll be in Brussels from 12h on. So I'd either suggest meeting at Hotel Barry at 12:30, or that we meet at Brussels Centraal train station, (my train from Luxembourg arrives 11:47), grab some food, and move over to Hotel Barry to hack on BrandWeg afterwards, until 5pm,

Re: brandweg hacking session on friday

2008-02-19 Thread Ian Rogers
Dalibor Topic wrote: Andrew John Hughes wrote: Thanks for organising this. I should arrive in Brussels around 4pm on the Friday, so will probably be available around an hour from then I guess (given time to find the hotel and check in, etc.). My preference would be for somewhere with food and

Re: [cp-patches] RFC: Double.doubleToLongBits simplified

2008-02-08 Thread Ian Rogers
Dalibor Topic wrote: Hi all, I've implemented doubleToLongBits without requring a VMDouble method of the same name. It would let us remove one method from the VM interface for the next version, and the corresoponding native code. OK to commit? (I'd do the equivalent patch for Float, too).

Re: [cp-patches] RFC: use helper method to clone char array in java.lang.String

2008-02-07 Thread Ian Rogers
Tom Tromey wrote: Ian == Ian Rogers [EMAIL PROTECTED] writes: Ian Please let me know if you think this patch is suitable for Ian inclusion. It looks fine. I do have one nit, which is that we put spaces around operators... this problem is pervasive in the patch, but here's one

Re: [cp-patches] RFC: tweaks to java.util.zip.ZipEntry

2008-02-07 Thread Ian Rogers
Mark Wielaard wrote: On Tue, 2008-02-05 at 06:07 -0700, Tom Tromey wrote: Ian == Ian Rogers [EMAIL PROTECTED] writes: Ian the attached patch stops the lazy initialization of a Calendar object Ian in ZipEntry and instead uses a static final one. I thought this could lead

[cp-patches] FYI: changes of StringBuffer to StringBuilder, new Number(x) to Number.valueOf(x), add final to a few private fields and avoid creating Integer objects for the sake of comparison

2008-02-06 Thread Ian Rogers
Apologies this was committed yesterday and I should have posted the patch here earlier. Ian CVSROOT:/sources/classpath Module name:classpath Changes by: Ian Rogers irogers 08/02/05 14:59:06 Modified files: gnu/java/lang/reflect: TypeSignature.java java/io

[commit-cp] classpath ChangeLog

2008-02-06 Thread Ian Rogers
CVSROOT:/sources/classpath Module name:classpath Changes by: Ian Rogers irogers08/02/06 19:00:46 Modified files: . : ChangeLog Log message: Changelog missed from last commit CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog

Re: [cp-patches] RFC: use helper method to clone char array in java.lang.String

2008-02-05 Thread Ian Rogers
Robert Lougher wrote: Hi, On 2/4/08, Ian Rogers [EMAIL PROTECTED] wrote: Hi, xalan performs 1.4 million char array clones per iteration of the normal size DaCapo benchmark. All of the character array clones are coming from java.lang.String. The attached patch changes the use of char

[cp-patches] RFC: tweaks to java.util.zip.ZipEntry

2008-02-05 Thread Ian Rogers
Hi, the attached patch stops the lazy initialization of a Calendar object in ZipEntry and instead uses a static final one. It also modifies the clone method to instead of using Object.clone to use the ZipEntry's own copy constructor. This patch has implications to bootstrapping and subtly

Re: [cp-patches] RFC: use helper method to clone char array in java.lang.String

2008-02-05 Thread Ian Rogers
Hello all, here's a revised patch that removes the use of clone in preference to just array copying the live portion of the String. Here are the DaCapo xalan figures: run 1: 97972ms run 2: 97837ms run 3: 95290ms which represents anything from a 0.04% slow down to a 2.8% speed up. There

[cp-patches] RFC: use helper method to clone char array in java.lang.String

2008-02-04 Thread Ian Rogers
Hi, xalan performs 1.4 million char array clones per iteration of the normal size DaCapo benchmark. All of the character array clones are coming from java.lang.String. The attached patch changes the use of char[].clone (which maps to java.lang.Object.clone) to a helper method that allocates

Re: [cp-patches] FYI: more CopyOnWriteArrayList fixlets

2007-11-26 Thread Ian Rogers
Mario Torre wrote: I'm committing this one, that fixes a couple of woops! I did in the last patch, as well as some other methods that were already broken (read: not my fault :) Now it should pass all the public domain tck166 tests, except for subList. Thanks, Mario This is great! The

[commit-cp] classpath AUTHORS

2007-11-24 Thread Ian Rogers
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Ian Rogers irogers07/11/23 14:38:58 Modified files: . : AUTHORS Log message: add myself CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/AUTHORS?cvsroot=classpathr1=1.41r2

[commit-cp] classpath/java/lang Long.java

2007-11-24 Thread Ian Rogers
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Ian Rogers irogers07/11/23 14:50:53 Modified files: java/lang : Long.java Log message: Remove unnecessary synchronized from Long.valueOf(long) CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs

[commit-cp] classpath/java io/FileOutputStream.java io/Prin...

2007-11-24 Thread Ian Rogers
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Ian Rogers irogers07/11/23 14:58:14 Modified files: java/io: FileOutputStream.java PrintStream.java java/util : Locale.java Log message: Make private fields that can be final

[commit-cp] classpath/java/lang String.java

2007-11-24 Thread Ian Rogers
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Ian Rogers irogers07/11/23 15:04:25 Modified files: java/lang : String.java Log message: Separate Turkish case conversion into their own routines. Switch from using String.equals

[commit-cp] classpath/gnu/java/nio/charset ByteCharset.java...

2007-11-24 Thread Ian Rogers
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Ian Rogers irogers07/11/23 15:12:17 Modified files: gnu/java/nio/charset: ByteCharset.java Cp424.java Cp437.java Cp737.java Cp775.java Cp850.java

Re: [cp-patches] Streamline String.toUpper/LowerCase

2007-11-23 Thread Ian Rogers
Committed. Ian Rogers wrote: Hi, the attached patch separates out the special case of making a string upper and lower case for the Turkish Locale. As Locale's language should be interned, the tr.equals test is replaced with tr ==. Thanks, Ian

Re: [cp-patches] Fix for GTk peers with Classpath 0.96.1

2007-11-23 Thread Ian Rogers
Committed. Ian Rogers wrote: Hi, attached is a patch required to make JNI GTk peers work on 32bit architectures. Regards, Ian

Re: [cp-patches] Patch to gnu.java.nio.charset

2007-11-23 Thread Ian Rogers
Committed. Ian Rogers wrote: Hi, the attached patch adds efficient support for array encoding/decoding character sets to all ByteCharsets, US_ASCII and ISO_8859_1. It does this by using 2 package private helper classes. The patch also makes fields and classes that can be final, final

Re: [cp-patches] Make fields that aren't final, final

2007-11-23 Thread Ian Rogers
committed. Ian Rogers wrote: Hi, the attached patch makes a few fields that could be final, final. Thanks, Ian

[cp-patches] FYI: java.lang.Long remove unnecessary synchronized

2007-11-23 Thread Ian Rogers
Hi, Committed. Regards, Ian Index: Long.java === RCS file: /cvsroot/classpath/classpath/java/lang/Long.java,v retrieving revision 1.24 diff -u -r1.24 Long.java --- Long.java 10 Dec 2006 20:25:44 - 1.24 +++ Long.java 23

Re: New GNU Classpath developer Ian Rogers

2007-11-23 Thread Ian Rogers
Mark Wielaard wrote: Hi all, I am happy to announce that Ian is now one of our active hackers with commit access. Ian has been pushing useful patches for a long time now and is one of the JikesRVM hackers. Ian, even though you have been contributing to GNU Classpath in the past you name is

[commit-cp] classpath/gnu/java/nio/charset ByteEncodeLoopHe...

2007-11-23 Thread Ian Rogers
CVSROOT:/sources/classpath Module name:classpath Changes by: Ian Rogers irogers07/11/23 16:11:17 Added files: gnu/java/nio/charset: ByteEncodeLoopHelper.java ByteDecodeLoopHelper.java Log message: Helper classes for array

[commit-cp] classpath ChangeLog

2007-11-23 Thread Ian Rogers
CVSROOT:/sources/classpath Module name:classpath Changes by: Ian Rogers irogers07/11/23 17:06:57 Modified files: . : ChangeLog Log message: 2007-11-23 Ian Rogers [EMAIL PROTECTED] * java/io/FileOutputStream.java

[cp-patches] Greater use of StringBuilder rather than StringBuffer

2007-10-20 Thread Ian Rogers
Hi, the attached patch increases the use of StringBuilder in Classpath rather than StringBuffer. Thanks, Ian Index: gnu/java/lang/reflect/TypeSignature.java === RCS file:

[cp-patches] Greater use of Number.valueOf rather than new Number

2007-10-20 Thread Ian Rogers
Hi, the attached patch increases the use of Number.valueOf rather than new Number. Thanks, Ian Index: java/beans/PropertyChangeSupport.java === RCS file: /sources/classpath/classpath/java/beans/PropertyChangeSupport.java,v

[cp-patches] Make fields that aren't final, final

2007-10-20 Thread Ian Rogers
Hi, the attached patch makes a few fields that could be final, final. Thanks, Ian Index: java/io/FileOutputStream.java === RCS file: /sources/classpath/classpath/java/io/FileOutputStream.java,v retrieving revision 1.38 diff -u

[cp-patches] Streamline String.toUpper/LowerCase

2007-10-20 Thread Ian Rogers
Hi, the attached patch separates out the special case of making a string upper and lower case for the Turkish Locale. As Locale's language should be interned, the tr.equals test is replaced with tr ==. Thanks, Ian Index: java/lang/String.java

[cp-patches] Patch to java.io.OutputStreamWriter

2007-10-19 Thread Ian Rogers
Hi, the attached patch makes fields of OutputStreamWriter that can be final, final. Thanks, Ian --- java/io/OutputStreamWriter.java 2007-10-12 13:01:47.0 +0100 +++ java/io/OutputStreamWriter.java 2007-10-19 15:46:37.0 +0100 @@ -91,17 +91,17 @@ /** * The charset

[cp-patches] Fix for GTk peers with Classpath 0.96.1

2007-10-17 Thread Ian Rogers
Hi, attached is a patch required to make JNI GTk peers work on 32bit architectures. Regards, Ian --- native/jni/gtk-peer/gtkpeer.c 2007-05-08 01:00:54.0 +0100 +++ native/jni/gtk-peer/gtkpeer.c 2007-10-17 10:49:25.0 +0100 @@ -102,11 +102,13 @@ #else #if

[cp-patches] Fix for GTk peers and portable native sync

2007-09-27 Thread Ian Rogers
Hi, this patch removes a call to atexit from GtkToolkit. The comment didn't give sufficient detail as to why the atexit call was necessary and the failure I witnessed in the Jikes RVM was as follows: 1) VM runs some AWT code that causes the atexit routine in GtkToolkit to be registered 2)

Re: [Jikesrvm-core] [cp-patches] Changes to ThreadLocal

2007-08-23 Thread Ian Rogers
Hi, here is a revision of Daniel's patch, from Daniel, that revises a bug with InheritableThreadLocals not calling childValue. This bug was found through the JSR 166 TCK, which now passes its thread local tests. Thanks, Ian Daniel Frampton wrote: In order to tease out where the performance

Re: [cp-patches] Changes to ThreadLocal

2007-08-22 Thread Ian Rogers
Jeroen Frijters wrote: No, any VM that implements the spec is vulnerable. Here's an example of a possible attack: class Attacker { static ArrayListThreadLocal resurrected; ArrayListThreadLocal list = new ArrayListThreadLocal(); Attacker() { for (int i = 0; i 1000; i++) {

Re: [cp-patches] Changes to ThreadLocal

2007-08-21 Thread Ian Rogers
Jeroen Frijters wrote: Ian Rogers wrote: the attached patch modifies ThreadLocal to use an array of Objects hung off Thread rather than a weak hash map hung off Thread. On DaCapo's Jython benchmark this can improve the performance of the Jikes RVM by more than 10%. It also improves other

Re: [cp-patches] Changes to ThreadLocal

2007-08-21 Thread Ian Rogers
Andrew Haley wrote: Ian Rogers writes: Jeroen Frijters wrote: Ian Rogers wrote: the attached patch modifies ThreadLocal to use an array of Objects hung off Thread rather than a weak hash map hung off Thread. On DaCapo's Jython benchmark this can improve the performance

Re: [cp-patches] Changes to ThreadLocal

2007-08-21 Thread Ian Rogers
Jeroen Frijters wrote: Ian Rogers wrote: here is the revised patch. + int arraySize = group.activeCount(); + Thread[] threadList = new Thread[arraySize]; + int filled = group.enumerate(threadList); + while (filled == arraySize) + { +arraySize *= 2

Re: [cp-patches] Changes to ThreadLocal

2007-08-21 Thread Ian Rogers
Threads. The value of the @@ -56,12 +56,22 @@ * @author Eric Blake ([EMAIL PROTECTED]) * @author Tom Tromey ([EMAIL PROTECTED]) * @author Andrew John Hughes ([EMAIL PROTECTED]) + * @author Ian Rogers ([EMAIL PROTECTED]) * @see ThreadLocal * @since 1.2 * @status updated to 1.4

Re: [cp-patches] Changes to ThreadLocal

2007-08-21 Thread Ian Rogers
Ian Rogers wrote: Jeroen Frijters wrote: This is not true. Once an object becomes finalizer reachable the finalizer can run, but that doesn't mean all references are gone. Any object with a finalizer can still have references to objects that have already been finalized. In its finalizer

[cp-patches] Changes to ThreadLocal

2007-08-20 Thread Ian Rogers
PROTECTED]) * @author Tom Tromey ([EMAIL PROTECTED]) * @author Andrew John Hughes ([EMAIL PROTECTED]) + * @author Ian Rogers ([EMAIL PROTECTED]) * @see ThreadLocal * @since 1.2 * @status updated to 1.4 @@ -93,29 +92,28 @@ * @param childThread the newly created thread, to inherit from

Re: [cp-patches] Float/Double compare

2007-07-03 Thread Ian Rogers
Here's a revised version of the patch following suggestions from Andrew Haley. Ian --- java/lang/Float.java2006-12-10 15:25:44.0 -0500 +++ java/lang/Float.java2007-07-02 12:17:29.0 -0400 @@ -596,16 +596,25 @@ */ public static int compare(float x, float y)

Re: Float/Double compare

2007-07-02 Thread Ian Rogers
Andrew Haley wrote: We know that any calculation involving NaN returns false, right? So, simple cases can be done first without the (possibly expensive) move out of the FPU: if (x y) return -1; if (x y) return 1; then you can do the doubleToLongBits:

Re: Float/Double compare

2007-07-01 Thread Ian Rogers
Hi Mark, Mark Wielaard wrote: Hi Ian, On Sat, 2007-06-30 at 15:25 -0400, Ian Rogers wrote: public static int compare(float x, float y) { int ix = floatAsIntBits(x); int iy = floatAsIntBits(y); if (ix == iy) return 0; if (isNaN(x)) return 1; if (isNaN(y)) return -1; int

[cp-patches] Float/Double compare

2007-06-30 Thread Ian Rogers
Attached is a patch that improves the performance of an Float/Double compare by exploiting information carried in their bit integer/long versions sign bit. It removes one comparison from the normal path, as well as making other compares with ints/longs. When sorting an array of floats this can

Re: [cp-patches] Float/Double compare

2007-06-30 Thread Ian Rogers
Andrew Pinski wrote: On 6/30/07, Ian Rogers [EMAIL PROTECTED] wrote: Attached is a patch that improves the performance of an Float/Double compare by exploiting information carried in their bit integer/long versions sign bit. It removes one comparison from the normal path, as well as making

Float/Double compare

2007-06-30 Thread Ian Rogers
Hi everyone, I was tracking a bug and came across the code in Float.compare which is very similar to Double.compare. It just so happened that the bug was being caused by sorting arrays containing lots of floating point 0s. This occurs quite frequently in the Jikes RVM when we have an array of

Re: Float/Double compare

2007-06-30 Thread Ian Rogers
Ian Rogers wrote: public static int compare(float x, float y) { if (isNaN(x)) return isNaN(y) ? 0 : 1; if (isNaN(y)) return -1; // recall that 0.0 == -0.0, so we convert to infinities and try again if (x == 0 y == 0) return (int) (1 / x - 1 / y); if (x

Re: Float/Double compare

2007-06-30 Thread Ian Rogers
In terms of performance I just tried sorting an array of floats with the new code (floatAsIntBits should have been floatToIntBits, sorry). The test was to initialize an array of floats backwards and then sort it to be ascending. Running a large enough array and enough iterations to get a ~4

Migration to generics opens up exciting optimization opportunities from annotations

2006-11-30 Thread Ian Rogers
. The Jikes RVM uses a package called org.vmmagic.pragma for some other compiler tricks. Interested in your responses, thanks, Ian Rogers -- http://www.cs.man.ac.uk/~irogers

Re: Trouble building x86 32-bit classpath on an x86-64 machine

2006-10-31 Thread Ian Rogers
with the environment variables CFLAGS and CXXFLAGS. I have been trying to capture information on building the Jikes RVM in the wiki: http://jikesrvm.sourceforge.net/wiki/index.php/Building I would welcome help and contributions. Thanks, Ian Rogers

[cp-patches] Problem in native/jni/classpath/jcl.c

2006-09-27 Thread Ian Rogers
There's a bug in the Classpath CVS head that's crashing the Jikes RVM (thanks to Mark for helping me to find it). It's in jcl.c where we delete a global ref which is actually only a local ref. The following fixes it. Thanks, Ian Rogers Index: native/jni/classpath/jcl.c

Re: [cp-patches] Revise threading description in vmintegration.texinfo

2006-08-19 Thread Ian Rogers
Hi, I'm resending this updated patch with a hope that someone will commit it now that I've got all the FSF paper work through. Thanks, Ian Rogers Ian Rogers wrote: Hi, this patch revises the discussion of threading in the VM integration guide, as well as fixing a link to the Jikes RVM

Re: Q: userland threads and system calls

2006-08-19 Thread Ian Rogers
guide describing this too. Regards, Ian Rogers Casey Marshall wrote: This is a general question for those using Classpath with VMs that support UNIXy C implementations of native methods, but who use userland (green) threads as opposed to native threads. My understanding is that the core

[cp-patches] Revise threading description in vmintegration.texinfo

2006-04-19 Thread Ian Rogers
on this subject, although maybe my description of the problems is a little verbose. Regards, Ian Rogers -- http://www.cs.man.ac.uk/~irogers Index: vmintegration.texinfo === RCS file: /sources/classpath/classpath/doc/vmintegration.texinfo,v

[cp-patches] Patch: Reduce number of compilation warnings

2006-04-13 Thread Ian Rogers
see in rmic where the $ signs were creeping in :-( The patch is just a suggestion, but it cleans up watching a build for me, which could potentially help spot new bugs in the future. Regards, Ian Rogers -- http://www.cs.man.ac.uk/~irogers Index: external/sax/org/xml/sax/helpers

Re: [cp-patches] Patch: Reduce number of compilation warnings

2006-04-13 Thread Ian Rogers
Thanks Tom, I thought I'd fix all the warnings and wait for people to complain. I agree with what you say and I've attached a fixed patch for just MD4 and MD5, any idea on how to stop the $ symbols being generated by rmic? They are on private fields so altering the names shouldn't matter.

Re: [cp-patches] Patch: Reduce number of compilation warnings

2006-04-13 Thread Ian Rogers
Hi Audrius, Wouldn't it be better to regenerate the sources rather than manually remove the $ signs? I don't know how the RMI compiler generated the sources. I'm happy to modify the files by hand otherwise. Thanks! Ian Audrius Meskauskas wrote: any idea on how to stop the $ symbols being

Re: Green threads - some experience

2006-03-31 Thread Ian Rogers
Archie Cobbs wrote: IMHO using POSIX threads is the only right answer for a multi-platform JVM. You have no other choice except to leave it up to the specific platform to then implement POSIX threads efficiently. For example, on Linux where each POSIX thread is a cloned process, it's Linux's

Green threads - some experience

2006-03-29 Thread Ian Rogers
before embarking on threaded native code. Regards, Ian Rogers --- http://www.cs.man.ac.uk/~irogers/

Re: Green threads - some experience

2006-03-29 Thread Ian Rogers
Hi Nic, I think the long term view is to switch to POSIX threads. Having used the Jikes RVM for an OS like project, relying on native threads wouldn't have been desirable. In theory green thread context switches should be possible in a few instructions whereas a full context switch takes a

Re: [cp-patches] RFC: gnu.java.math.MPN optimizations

2006-03-23 Thread Ian Rogers
. Interest welcomed. Many thanks, Ian Rogers -- http://www.cs.man.ac.uk/~irogers/

[cp-patches] RFC: gnu.java.math.MPN optimizations

2006-03-22 Thread Ian Rogers
an unsigned integer compare on the two registers. In any case the revised code has fewer long/int operations, I believe. I've also not tested the code, so I'm really just putting it here to generate discussion. Thanks, Ian Rogers -- http://www.cs.man.ac.uk/~irogers --- MPN.java 2005-07-02 21:32

Re: JNI calls that don't return

2006-03-08 Thread Ian Rogers
into java.lang.Thread.yield intermittently or avoids using purely native functions (as shown in the changes of my first e-mail on this thread). Thanks, Ian Rogers David Daney wrote: Ian Rogers wrote: The JNI provides mappings to monitor entry and exit. From google I found this document

Re: JNI calls that don't return

2006-03-08 Thread Ian Rogers
Andrew Haley wrote: Currently, to the best of my knowledge, classpath's gtk peer code isn't working with any JVM with M-to-N threading. No, that's not true, is it? Surely it works correctly if blocking system calls are correctly hooked by the thread library. Andrew. According to:

Re: JNI calls that don't return

2006-03-08 Thread Ian Rogers
Andrew Haley wrote: Maybe you know something I don't. Is there any wordage in the JNI spec that forbids blocking calls, or suggests that this might be problematic? Is there any wordage in the JNI spec that allows the Jikes RVM to behave in the way that it does with repect to blocking calls?

Re: JNI calls that don't return

2006-03-07 Thread Ian Rogers
change. What are others opinions? As part of this would it be possible to have versions of JNI routines that don't return that at least call Java yield in the case of being on a M-to-N threaded JVM? Thanks, Ian Rogers

Re: JNI calls that don't return

2006-03-07 Thread Ian Rogers
other JVMs that implemented M-to-N threading. Thanks, Ian Rogers Andrew Haley wrote: Ian Rogers writes: Thanks for the replies. I have worked further on this and the particular issue isn't with GC barriers but with M-to-N threading. It's possible that I'm completely missing the point here

Re: JNI calls that don't return

2006-03-07 Thread Ian Rogers
up my point-of-view. Thanks, Ian Rogers

JNI calls that don't return

2006-03-03 Thread Ian Rogers
loop could be moved into the JNI code. Is having all JNI code return an option for classpath? Thanks, Ian Rogers

java.util.zip

2001-09-03 Thread Ian Rogers
files will be added to java.util.zip? The web site says things are nearly complete. TIA, Ian Rogers ___ Classpath mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/classpath

Re: Why catch (NullPointerException e)?

2000-08-19 Thread Ian Rogers
this. It also doesn't require analysis looking for double comparisons. I know this makes a lot of assumptions on the workings of a JIT and on the target JVM for Classpath. I wanted offer this solution to see what others opinions are. Cheers, -- Ian Rogers -- Dept. Of Computer Science -- The University

  1   2   >