Re: [cp-patches] DSSKeyPairGenerator JCE Adapter

2006-02-06 Thread Raif S. Naffah
hello Mark, On Monday 06 February 2006 09:53, Mark Wielaard wrote: Hi Raif, On Sun, 2006-02-05 at 09:12 +1100, Raif S. Naffah wrote: if (!(key instanceof DSSPublicKey)) throw new InvalidParameterException(key); Officially there is a space after each operator, so also

[cp-patches] Eclipse GNU style

2006-02-06 Thread Raif S. Naffah
hello there, this is a patch for the srcipts/eclipse-gnu.xml style specs that does the following: * force a line split on extends and implements clauses. * force a whitespace after unary operators. * does not force a new-line after a @param tag. * force a new-line at the end of a .java file.

[cp-patches] Use of OID strings

2006-02-06 Thread Raif S. Naffah
hello there, this is a patch that fixes a wrong OID string used in GnuDSAPublicKey and replaces OID strings use in both the DSA and RSA public and private keys (under the gnu.java.secuity.provider hierarchy by their Registry equivalent. ChangeLog entry is: 2006-02-06 Raif S. Naffah [EMAIL

Re: [cp-patches] Use of OID strings

2006-02-06 Thread Raif S. Naffah
On Monday 06 February 2006 20:40, Raif S. Naffah wrote: ... this is a patch that fixes a wrong OID string... the previous patch did not include the RSA changes. the attached patch is the correct one. cheers; rsn Index: EncodedKeyFactory.java

[cp-patches] FYI: Compatibility fixes for javax.print.attribute.standard

2006-02-06 Thread Wolfgang Baer
Hi, I am checking in some compatibility fixes pointed out by reverse japi. 2006-02-06 Wolfgang Baer [EMAIL PROTECTED] * javax/print/attribute/standard/Compression.java, * javax/print/attribute/standard/Finishings.java, *

Re: [cp-patches] FYI: SwingPropertyChangeSupport fixlet

2006-02-06 Thread Roman Kennke
Hi there again, Am Freitag, den 03.02.2006, 14:36 +0100 schrieb Roman Kennke: Hi Mark, Am Freitag, den 03.02.2006, 12:19 +0100 schrieb Mark Wielaard: Hi, This should get rid of the last regression that builder is complaining about (technically it isn't a regression, the test got

[cp-patches] FYI: ObjectInputStream fix

2006-02-06 Thread Jeroen Frijters
Hi, Committed. Regards, Jeroen 2006-02-06 Jeroen Frijters [EMAIL PROTECTED] Fixes PR 26121 * java/io/ObjectInputStream.java (readNextBlock()): Handle TC_RESET. ObjectInputStream.java.patch Description: ObjectInputStream.java.patch

[cp-patches] FYI: InetAddress deserialization fix

2006-02-06 Thread Jeroen Frijters
Hi, Committed. Regards, Jeroen 2006-02-06 Jeroen Frijters [EMAIL PROTECTED] Fixes PR 25313 * java/net/InetAddress.java (readResolve): Implemented. InetAddress.java.patch Description: InetAddress.java.patch

[cp-patches] FYI: SwingPropertyChangeSupport

2006-02-06 Thread Roman Kennke
Hi there, It seems that Sun has removed everything except the constructor from javax.swing.event.SwingPropertyChangeSupport. See http://java.sun.com/j2se/1.5.0/docs/guide/swing/1.5/index.html#swingMisc for details. 2006-02-06 Roman Kennke [EMAIL PROTECTED] *

Re: [cp-patches] FYI: SwingPropertyChangeSupport fixlet

2006-02-06 Thread Mark Wielaard
Hi Roman, On Mon, 2006-02-06 at 12:09 +0100, Roman Kennke wrote: I guess the java.beans.PropertyChangeSupport is now made more efficient (and not thread safe) so that the SwingPropertyChangeSupport is not needed anymore. Should we follow this? Sure. It will clean up some of our code

Re: [cp-patches] FYI: SwingPropertyChangeSupport fixlet

2006-02-06 Thread Roman Kennke
Hi Mark again, But maybe it can be made a little more efficient by not using the old Vector and Hashtable classes all the time which seem to double the synchronization in that class, but use an List and Map for that and only synchronize on those when really needed. Thinking about it, I am

[cp-patches] FYI: New java.awt.Component methods

2006-02-06 Thread Roman Kennke
I added a couple of JDK1.5 methods to java.awt.Component that are related to my last 2 property related Swing patches. This adds the firePropertyChange overloads that have been in javax.swing.JComponent before JDK1.5. 2006-02-06 Roman Kennke [EMAIL PROTECTED] * java/awt/Component.java

Re: [cp-patches] FYI: SwingPropertyChangeSupport fixlet

2006-02-06 Thread Roman Kennke
Hi Mark, Am Montag, den 06.02.2006, 14:21 +0100 schrieb Mark Wielaard: Hi Roman, On Mon, 2006-02-06 at 12:09 +0100, Roman Kennke wrote: I guess the java.beans.PropertyChangeSupport is now made more efficient (and not thread safe) so that the SwingPropertyChangeSupport is not needed

[cp-patches] FYI: gnu.regexp: fixed bugs in stingy match of RETokenRepeated

2006-02-06 Thread Ito Kazumitsu
From: Ito Kazumitsu [EMAIL PROTECTED] Date: Mon, 30 Jan 2006 00:18:47 +0900 (JST) ChangeLog 2006-01-29 Ito Kazumitsu [EMAIL PROTECTED] Fixes bug #24876 * gnu/regexp/gnu/regexp/RE.java(REG_TRY_ENTIRE_MATCH): New execution flag. (getMatchImpl): if

Re: [cp-patches] Patch: DefaultStyledDocument.ElementBuffer final fix

2006-02-06 Thread Lillian Angel
Great work indeed! The BeanShell Swing console now starts up again and I am actually able to type into it. It looks a bit ugly and is slow like hell, but that seems to be a view problem. Now we should go on with fixing the styled text views and push HTML when that works. Maybe we can get

[cp-patches] Re: Patch: DefaultStyledDocument.ElementBuffer final fix

2006-02-06 Thread Lillian Angel
They are seen as just failures and not as regressions by builder. (Builder takes a snapshot of the PASS/FAILs at a certain date and only reports real regressions for those tests that used to PASS but now FAIL. The ElementBuffer.ElementStructure are seem as new failures (since they are new

[cp-patches] FYI: Container fix

2006-02-06 Thread Roman Kennke
I remove one more duplication of the PropertyChangeSupport thingy in java.awt.Container. From the specs it is not immediately clear to me why addPropertyChangeListener is overridden in java.awt.Container. So I let it call super for now. 2006-02-06 Roman Kennke [EMAIL PROTECTED] *

[cp-patches] FYI: javax.swing.text fixes

2006-02-06 Thread Roman Kennke
The attached patch makes the BeanShell JConsole work quite well (ok, slow and ugly, but anyway ;-) ). Thanks to Lillian and Anthony for making this possible with their work on DefaultStyledDocument. 2006-02-06 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/GlyphView.java:

Re: [cp-patches] Eclipse GNU style

2006-02-06 Thread Tom Tromey
Raif == Raif S Naffah [EMAIL PROTECTED] writes: Raif this is a patch for the srcipts/eclipse-gnu.xml style specs that does Raif the following: FWIW, with Eclipse 3.1 I don't think we need this file any more. We have the style checked in .settings instead. Tom

Re: [cp-patches] Eclipse GNU style

2006-02-06 Thread Raif S. Naffah
On Tuesday 07 February 2006 03:54, Tom Tromey wrote: Raif == Raif S Naffah [EMAIL PROTECTED] writes: Raif this is a patch for the srcipts/eclipse-gnu.xml style specs that does Raif the following: FWIW, with Eclipse 3.1 I don't think we need this file any more. We have the style checked in

[cp-patches] FYI. was: Use of OID strings

2006-02-06 Thread Raif S. Naffah
On Monday 06 February 2006 20:44, Raif S. Naffah wrote: On Monday 06 February 2006 20:40, Raif S. Naffah wrote: ... this is a patch that fixes a wrong OID string... the previous patch did not include the RSA changes. the attached patch is the correct one. committed. cheers; rsn

[cp-patches] FYI. was: Eclipse GNU style

2006-02-06 Thread Raif S. Naffah
On Tuesday 07 February 2006 05:38, Raif S. Naffah wrote: On Tuesday 07 February 2006 03:54, Tom Tromey wrote: Raif == Raif S Naffah [EMAIL PROTECTED] writes: Raif this is a patch for the srcipts/eclipse-gnu.xml style specs that does Raif the following: FWIW, with Eclipse 3.1 I don't

Re: [cp-patches] Eclipse GNU style

2006-02-06 Thread Tom Tromey
Raif == Raif S Naffah [EMAIL PROTECTED] writes: Raif ok to commit? Sure, thanks. Tom

Re: [cp-patches] Patch: add missing switch break?

2006-02-06 Thread Tom Tromey
Anthony == Anthony Green [EMAIL PROTECTED] writes: Anthony 2005-09-13 Anthony Green [EMAIL PROTECTED] Anthony* gnu/xml/aelfred2/XmlParser.java: Add missing break;. This patch got dropped... I'm checking it in now. Tom

[cp-patches] RFC: Introduction of VMMath

2006-02-06 Thread Andrew John Hughes
I'd welcome any comments on the attached patch, which separates the Math native methods into a separate class, VMMath, so that they can optionally be replaced by the VM. This fixes PR22198. I also have code for most of the new Math methods here as well. However, I've had some problems in using

Re: [cp-patches] FYI: SwingPropertyChangeSupport fixlet

2006-02-06 Thread Mark Wielaard
Hi Roman, On Mon, 2006-02-06 at 14:54 +0100, Roman Kennke wrote: But maybe it can be made a little more efficient by not using the old Vector and Hashtable classes all the time which seem to double the synchronization in that class, but use an List and Map for that and only synchronize on

[cp-patches] Patch: FYI: copyright update

2006-02-06 Thread Tom Tromey
I'm checking this in. For GCC, the rule for '--version' output is that it should mention the most recent year only. I assume this applies to GNU Classpath as well. This patch makes this change. Tom 2006-02-06 Tom Tromey [EMAIL PROTECTED] *

Re: [cp-patches] RFC: Introduction of VMMath

2006-02-06 Thread Robert Schuster
Hi. Nice work. I think the JNode guys will appreciate this. :) +package java.lang; + +import gnu.classpath.Configuration; + +class VMMath +{ + + static + { +if (Configuration.INIT_LOAD_LIBRARY) + System.loadLibrary(javanet); + } Should this really be javanet? cya Robert