[cp-patches] [calendar] remove explicitDSTOffset from Calendar

2007-04-13 Thread Gary Benson
: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.9239.2.1 diff -u -r1.9239.2.1 ChangeLog --- ChangeLog 12 Apr 2007 15:29:51 - 1.9239.2.1 +++ ChangeLog 13 Apr 2007 07:40:38 - @@ -1,3 +1,10 @@ +2007-04-13 Gary Benson [EMAIL PROTECTED] + + * java/util/Calendar.java

[cp-patches] [calendar] GregorianCalendar.setDefaultFields() tweak

2007-04-13 Thread Gary Benson
: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.9239.2.3 diff -u -r1.9239.2.3 ChangeLog --- ChangeLog 13 Apr 2007 08:12:36 - 1.9239.2.3 +++ ChangeLog 13 Apr 2007 09:17:23 - @@ -1,3 +1,9 @@ +2007-04-13 Gary Benson [EMAIL PROTECTED] + + * java/util

[cp-patches] [calendar] fix Calendar.setTimeZone()

2007-04-13 Thread Gary Benson
+++ ChangeLog 13 Apr 2007 10:48:15 - @@ -1,3 +1,9 @@ +2007-04-13 Gary Benson [EMAIL PROTECTED] + + * java/util/Calendar.java + (setTimeZone): Don't recalculate anything, just invalidate + the fields. + 2007-04-13 Gary Benson [EMAIL PROTECTED] * java/util

[cp-patches] [calendar] Reorder Calendar.complete()

2007-04-13 Thread Gary Benson
1.9239.2.5 diff -u -r1.9239.2.5 ChangeLog --- ChangeLog 13 Apr 2007 10:48:41 - 1.9239.2.5 +++ ChangeLog 13 Apr 2007 11:46:29 - @@ -1,3 +1,10 @@ +2007-04-13 Gary Benson [EMAIL PROTECTED] + + * java/util/Calendar.java + (complete): Reorder, and set isTimeSet

[cp-patches] [calendar] fix Calendar.clear()

2007-04-13 Thread Gary Benson
--- ChangeLog 13 Apr 2007 11:47:12 - 1.9239.2.6 +++ ChangeLog 13 Apr 2007 13:01:16 - @@ -1,3 +1,8 @@ +2007-04-13 Gary Benson [EMAIL PROTECTED] + + * java/util/Calendar.java + (clear): Do not call complete. + 2007-04-13 Gary Benson [EMAIL PROTECTED] * java/util

[cp-patches] [calendar] Another GregorianCalendar.setDefaultFields() tweak

2007-04-13 Thread Gary Benson
-r1.9239.2.7 ChangeLog --- ChangeLog 13 Apr 2007 13:01:50 - 1.9239.2.7 +++ ChangeLog 13 Apr 2007 13:05:06 - @@ -1,3 +1,9 @@ +2007-04-13 Gary Benson [EMAIL PROTECTED] + + * java/util/GregorianCalendar.java + (defaults): Moved from within setDefaultFields

[cp-patches] [calendar] Make computeTime() sometimes update fields

2007-04-13 Thread Gary Benson
Hi again, This commit makes GregorianCalendar.computeTime() sometimes update the fields. The more weird logic I put in to make us match Sun the less happy I am, but I'm hoping that something's suddenly going to click and it's all going to become clear. Til then... well, that's why I'm working

[cp-patches] [calendar] reorder GregorianCalendar.computeTime()

2007-04-12 Thread Gary Benson
=== RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.9239 diff -u -r1.9239 ChangeLog --- ChangeLog 12 Apr 2007 15:09:31 - 1.9239 +++ ChangeLog 12 Apr 2007 15:27:00 - @@ -1,3 +1,8 @@ +2007-04-12 Gary Benson [EMAIL

[cp-patches] FYI: GregorianCalendar week of month fix

2007-04-05 Thread Gary Benson
@@ +2007-04-05 Gary Benson [EMAIL PROTECTED] + + * java/util/GregorianCalendar.java + (computeFields): Fix WEEK_OF_MONTH calculation. + 2007-04-05 Christian Thalinger [EMAIL PROTECTED] PR classpath/22800: Index: java/util/GregorianCalendar.java

[cp-patches] FYI: GregorianCalendar tweak

2007-04-04 Thread Gary Benson
/classpath/ChangeLog,v retrieving revision 1.9208 diff -u -r1.9208 ChangeLog --- ChangeLog 4 Apr 2007 11:38:46 - 1.9208 +++ ChangeLog 4 Apr 2007 15:31:36 - @@ -1,3 +1,8 @@ +2007-04-04 Gary Benson [EMAIL PROTECTED] + + * java/util/GregorianCalendar.java

[cp-patches] FYI: Another javax.xml bugfix (PR 30983)

2007-03-08 Thread Gary Benson
-03-08 Gary Benson [EMAIL PROTECTED] + + PR classpath/30983: + * gnu/xml/dom/ls/DomLSParser.java (getInputSource): + Do not use the entity resolver to resolve the top-level document. + 2007-03-07 Tom Tromey [EMAIL PROTECTED] PR classpath/31057: Index: gnu/xml/dom/ls

Re: [cp-patches] FYI: Another javax.xml bugfix (PR 30983)

2007-03-08 Thread Gary Benson
Chris Burdess wrote: Gary Benson wrote: This commit fixes a bug where the entity resolver (if set) would be used to open the top-level document when parsing an XML file. The spec states that the parser will use the entity resolver before opening any external entity _except_ the top-level

[cp-patches] FYI: javax.xml bugfix

2007-03-07 Thread Gary Benson
revision 1.9144 diff -u -r1.9144 ChangeLog --- ChangeLog 6 Mar 2007 23:24:19 - 1.9144 +++ ChangeLog 7 Mar 2007 13:29:30 - @@ -1,3 +1,8 @@ +2007-03-07 Gary Benson [EMAIL PROTECTED] + + * resource/META-INF/services/org.w3c.dom.DOMImplementationSourceList: + New file

[cp-patches] FYI: Ensure ObjectName.properties is initialized

2007-02-19 Thread Gary Benson
Hi all, This commit ensures that javax.management.ObjectName.properties is always initialized. Without it there are at least two possible ways to create an ObjectName with a null properties field. Cheers, Gary

[cp-patches] Re: FYI: Ensure ObjectName.properties is initialized

2007-02-19 Thread Gary Benson
Gary Benson wrote: This commit ensures that javax.management.ObjectName.properties is always initialized. Without it there are at least two possible ways to create an ObjectName with a null properties field. This commit. Cheers, Gary Index: ChangeLog

[cp-patches] FYI: Another javax.management fix

2007-02-15 Thread Gary Benson
=== RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.9110 diff -u -r1.9110 ChangeLog --- ChangeLog 15 Feb 2007 10:38:30 - 1.9110 +++ ChangeLog 15 Feb 2007 14:06:41 - @@ -1,3 +1,10 @@ +2007-02-15 Gary Benson [EMAIL PROTECTED] + + * gnu

[cp-patches] FYI: javax.management fix

2007-02-13 Thread Gary Benson
Gary Benson wrote: Tomcat is failing with Classpath's javax.management because it assumes the result of javax.management.ObjectName.toString() is a valid string representation of the item. Ours isn't, but I guess Sun's and MX4J's must or they'd be failing too. The javadoc does not specify

[cp-patches] RFC: Proposed javax.management fix

2007-02-12 Thread Gary Benson
=== RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.9104 diff -u -r1.9104 ChangeLog --- ChangeLog 12 Feb 2007 00:56:29 - 1.9104 +++ ChangeLog 12 Feb 2007 14:14:37 - @@ -1,3 +1,8 @@ +2007-02-12 Gary Benson [EMAIL PROTECTED] + + * javax

Re: [cp-patches] RFC: Proposed javax.management fix

2007-02-12 Thread Gary Benson
Tom Tromey wrote: Gary == Gary Benson [EMAIL PROTECTED] writes: Gary This patch makes our toString() return the canonical Gary representation. Can anyone (ie Andrew) see any problems Gary with this? I think this method should have a comment explaining why it should not be changed

[cp-patches] FYI: javax.management.ObjectName.quote() fix

2007-02-09 Thread Gary Benson
=== RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.9095 diff -u -r1.9095 ChangeLog --- ChangeLog 9 Feb 2007 16:24:06 - 1.9095 +++ ChangeLog 9 Feb 2007 17:23:15 - @@ -1,3 +1,8 @@ +2007-02-09 Gary Benson [EMAIL PROTECTED] + + * javax

[cp-patches] FYI: Thread javadoc tweaks

2006-11-30 Thread Gary Benson
-u -r1.8884 ChangeLog --- ChangeLog 29 Nov 2006 20:48:29 - 1.8884 +++ ChangeLog 30 Nov 2006 09:29:54 - @@ -1,3 +1,7 @@ +2006-11-30 Gary Benson [EMAIL PROTECTED] + + * java/lang/Thread.java: Javadoc fixes. + 2006-11-29 Tania Bento [EMAIL PROTECTED] * tools/gnu

Re: [cp-patches] FYI: SocketPermission tweak

2006-10-31 Thread Gary Benson
Anthony Green wrote: On Thu, 2006-08-31 at 12:58 -0600, Tom Tromey wrote: Gary == Gary Benson [EMAIL PROTECTED] writes: Gary This commit makes java.net.SocketPermission()'s constructor Gary use localhost when called with an empty hostport argument Gary as mandated by the spec. Do

[cp-patches] FYI: ServerSocket security fixes

2006-10-09 Thread Gary Benson
: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.8656 diff -u -r1.8656 ChangeLog --- ChangeLog 9 Oct 2006 13:51:43 - 1.8656 +++ ChangeLog 9 Oct 2006 14:03:51 - @@ -1,3 +1,10 @@ +2006-10-09 Gary Benson [EMAIL PROTECTED] + + * java/net/ServerSocket.java

[cp-patches] FYI: Socket security fix

2006-10-05 Thread Gary Benson
15:35:35 - 1.8645 +++ ChangeLog 5 Oct 2006 14:49:22 - @@ -1,3 +1,8 @@ +2006-10-05 Gary Benson [EMAIL PROTECTED] + + * java/net/Socket.java + (Socket): Perform security check on address not hostname. + 2006-10-04 Roman Kennke [EMAIL PROTECTED] * javax/swing

[cp-patches] FYI: InetAddress tweaks

2006-10-04 Thread Gary Benson
/classpath/classpath/ChangeLog,v retrieving revision 1.8642 diff -u -r1.8642 ChangeLog --- ChangeLog 3 Oct 2006 19:47:58 - 1.8642 +++ ChangeLog 4 Oct 2006 10:20:40 - @@ -1,3 +1,8 @@ +2006-10-04 Gary Benson [EMAIL PROTECTED] + + * java/net/InetAddress.java: Updated javadoc

[cp-patches] FYI: SocketPermission tweak

2006-09-22 Thread Gary Benson
retrieving revision 1.8594 diff -u -r1.8594 ChangeLog --- ChangeLog 22 Sep 2006 12:27:10 - 1.8594 +++ ChangeLog 22 Sep 2006 13:23:56 - @@ -1,3 +1,9 @@ +2006-09-22 Gary Benson [EMAIL PROTECTED] + + * java/net/SocketPermission.java + (processHostport): Cope with IPv6

[cp-patches] FYI: InetAddress DNS caching

2006-09-19 Thread Gary Benson
Committed. Gary Benson wrote: Hi all, The documentation for java.net.InetAddress states that it maintains a DNS cache in order to guard against DNS spoofing attacks. This patch adds this, but I wanted to float it for comments before checking it in as this has been an issue before

[cp-patches] RFC: InetAddress DNS caching

2006-09-14 Thread Gary Benson
: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.8543 diff -u -r1.8543 ChangeLog --- ChangeLog 14 Sep 2006 10:35:48 - 1.8543 +++ ChangeLog 14 Sep 2006 10:42:51 - @@ -1,3 +1,9 @@ +2006-09-14 Gary Benson [EMAIL PROTECTED] + + * java/net/ResolverCache.java: New class

[cp-patches] FYI: SocketPermission host checking rewrite

2006-09-14 Thread Gary Benson
=== RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.8543 diff -u -r1.8543 ChangeLog --- ChangeLog 14 Sep 2006 10:35:48 - 1.8543 +++ ChangeLog 14 Sep 2006 13:37:30 - @@ -1,3 +1,17 @@ +2006-09-14 Gary Benson

[cp-patches] FYI: NetworkInterface security fix

2006-09-12 Thread Gary Benson
12 Sep 2006 14:30:52 - 1.8532 +++ ChangeLog 12 Sep 2006 14:55:05 - @@ -1,3 +1,8 @@ +2006-09-12 Gary Benson [EMAIL PROTECTED] + + * java/net/NetworkInterface.java (getInetAddresses): + Fix port used in security check. + 2006-09-12 David Gilbert [EMAIL PROTECTED

[cp-patches] FYI: InetAddress family handling (take 2)

2006-09-11 Thread Gary Benson
=== RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.8521 diff -u -r1.8521 ChangeLog --- ChangeLog 10 Sep 2006 21:16:39 - 1.8521 +++ ChangeLog 11 Sep 2006 10:31:14 - @@ -1,3 +1,12 @@ +2006-09-11 Gary Benson [EMAIL PROTECTED] + + * java/net

[cp-patches] FYI: InetAddress family handling (take 3)

2006-09-11 Thread Gary Benson
=== RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.8523 diff -u -r1.8523 ChangeLog --- ChangeLog 11 Sep 2006 10:45:02 - 1.8523 +++ ChangeLog 11 Sep 2006 11:43:47 - @@ -1,3 +1,12 @@ +2006-09-11 Gary Benson [EMAIL PROTECTED

[cp-patches] FYI: InetAddress merge

2006-09-08 Thread Gary Benson
-r1.8513 ChangeLog --- ChangeLog 7 Sep 2006 11:42:13 - 1.8513 +++ ChangeLog 8 Sep 2006 08:23:15 - @@ -1,3 +1,31 @@ +2006-09-08 Gary Benson [EMAIL PROTECTED] + + * java/net/InetAddress.java + (inaddr_any): Removed. + (ANY_IF, LOCALHOST): Create using getByAddress

[cp-patches] FYI: InetAddress reorganisation

2006-09-08 Thread Gary Benson
-09-08 Gary Benson [EMAIL PROTECTED] + + * java/net/Inet4Address.java (isMulticastAddress, + isLoopbackAddress, isAnyLocalAddress, isLinkLocalAddress, + isSiteLocalAddress, isMCGlobal, isMCNodeLocal, isMCLinkLocal, + isMCSiteLocal, isMCOrgLocal, getHostAddress): Moved

[cp-patches] FYI: InetAddress.getHostName() reorganisation

2006-09-08 Thread Gary Benson
1.8515 +++ ChangeLog 8 Sep 2006 12:54:58 - @@ -1,3 +1,10 @@ +2006-09-08 Gary Benson [EMAIL PROTECTED] + + * java/net/InetAddress.java + (getHostName): Move lookup into getCanonicalHostName. + (getCanonicalHostName): Move lookup from getHostName, + Perform security

[cp-patches] FYI: InetAddress family handling

2006-09-08 Thread Gary Benson
/ChangeLog,v retrieving revision 1.8516 diff -u -r1.8516 ChangeLog --- ChangeLog 8 Sep 2006 12:58:13 - 1.8516 +++ ChangeLog 8 Sep 2006 14:31:25 - @@ -1,3 +1,17 @@ +2006-09-08 Gary Benson [EMAIL PROTECTED] + + * java/net/InetAddress.java + (family): Updated javadoc and made

Re: [cp-patches] FYI: SocketPermission tweak

2006-09-01 Thread Gary Benson
Tom Tromey wrote: Gary == Gary Benson [EMAIL PROTECTED] writes: This commit makes java.net.SocketPermission()'s constructor use localhost when called with an empty hostport argument as mandated by the spec. Do we want this in GCC 4.2? Or FC6? This particular one probably doesn't

[cp-patches] FYI: SocketPermission tweak

2006-08-31 Thread Gary Benson
/ChangeLog,v retrieving revision 1.8476 diff -u -r1.8476 ChangeLog --- ChangeLog 31 Aug 2006 10:50:56 - 1.8476 +++ ChangeLog 31 Aug 2006 12:25:06 - @@ -1,3 +1,11 @@ +2006-08-31 Gary Benson [EMAIL PROTECTED] + + * java/net/SocketPermission.java + (maybeBracketIPv6Address

[cp-patches] FYI: SocketPermission fix

2006-08-29 Thread Gary Benson
diff -u -r1.8469 ChangeLog --- ChangeLog 28 Aug 2006 21:41:57 - 1.8469 +++ ChangeLog 29 Aug 2006 08:23:49 - @@ -1,3 +1,12 @@ +2006-08-29 Gary Benson [EMAIL PROTECTED] + + * java/net/SocketPermission.java + (maybeBracketIPv6Address): New method. + (init): Pass

[cp-patches] FYI: NetworkInterface.getInetAddresses() fix

2006-08-24 Thread Gary Benson
=== RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.8447 diff -u -r1.8447 ChangeLog --- ChangeLog 24 Aug 2006 06:40:04 - 1.8447 +++ ChangeLog 24 Aug 2006 10:57:43 - @@ -1,3 +1,8 @@ +2006-08-24 Gary Benson [EMAIL PROTECTED] + + * java/net

[cp-patches] FYI: AccessControlContext speedup

2006-08-10 Thread Gary Benson
- @@ -1,3 +1,8 @@ +2006-08-10 Gary Benson [EMAIL PROTECTED] + + * java/security/AccessControlContext.java (init): + Avoid a duplicated AccessController.getContext() call. + 2006-08-09 Mark Wielaard [EMAIL PROTECTED] * NEWS: Add updates for 0.92 release. Index: java

[cp-patches] FYI: Fix FilePermission on root directory

2006-06-29 Thread Gary Benson
+1,7 @@ +2006-06-29 Gary Benson [EMAIL PROTECTED] + + * java/io/FilePermission.java (implies): Work when path is /. + 2006-06-28 Andrew John Hughes [EMAIL PROTECTED] * java/lang/Thread.java: Index: java/io/FilePermission.java

[cp-patches] FYI: Merge File.listRoots security checks from libgcj

2006-06-29 Thread Gary Benson
29 Jun 2006 09:02:49 - 1.7966 +++ ChangeLog 29 Jun 2006 09:59:31 - @@ -1,3 +1,7 @@ +2006-06-29 Gary Benson [EMAIL PROTECTED] + + * java/io/File.java (listRoots): Merge security checks from libgcj. + 2006-06-29 Gary Benson [EMAIL PROTECTED] * java/io

[cp-patches] FYI: Add Graphics2D security checks

2006-06-21 Thread Gary Benson
-r1.7888 ChangeLog --- ChangeLog 20 Jun 2006 21:46:37 - 1.7888 +++ ChangeLog 21 Jun 2006 08:05:19 - @@ -1,3 +1,9 @@ +2006-06-21 Gary Benson [EMAIL PROTECTED] + + * gnu/java/awt/peer/gtk/CairoGraphics2D.java: Add security check. + * gnu/java/awt/peer/qt/QtGraphics.java

[cp-patches] FYI: Add printing security checks

2006-06-20 Thread Gary Benson
: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.7880 diff -u -r1.7880 ChangeLog --- ChangeLog 20 Jun 2006 11:24:41 - 1.7880 +++ ChangeLog 20 Jun 2006 11:35:39 - @@ -1,3 +1,9 @@ +2006-06-20 Gary Benson [EMAIL PROTECTED] + + * java/awt/Toolkit.java: Add security

[cp-patches] RFC: Add security checks to Graphics2D peers

2006-06-19 Thread Gary Benson
- @@ -1,3 +1,9 @@ +2006-06-19 Gary Benson [EMAIL PROTECTED] + + * gnu/java/awt/peer/gtk/CairoGraphics2D.java: Add security check. + * gnu/java/awt/peer/qt/QtGraphics.java: Likewise. + * gnu/java/awt/java2d/AbstractGraphics2D.java: Likewise. + 2006-06-19 Raif S. Naffah [EMAIL

[cp-patches] FYI: rewrite File.toCanonicalPath()

2006-06-07 Thread Gary Benson
=== RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.7697 diff -u -r1.7697 ChangeLog --- ChangeLog 7 Jun 2006 14:46:49 - 1.7697 +++ ChangeLog 7 Jun 2006 15:08:26 - @@ -1,3 +1,15 @@ +2006-06-07 Gary Benson [EMAIL PROTECTED

[cp-patches] FYI: Remove unnecessary ThreadGroup access checks

2006-05-10 Thread Gary Benson
=== RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.7348 diff -u -r1.7348 ChangeLog --- ChangeLog 10 May 2006 10:15:44 - 1.7348 +++ ChangeLog 10 May 2006 13:54:03 - @@ -1,3 +1,11 @@ +2006-05-10 Gary Benson [EMAIL PROTECTED] + + * java/lang

[cp-patches] FYI: Add missing security check to Thread constructor

2006-05-09 Thread Gary Benson
@@ -1,3 +1,8 @@ +2006-05-09 Gary Benson [EMAIL PROTECTED] + + * java/lang/Thread.java (Thread): Always perform threadgroup + access checks on thread creation. + 2006-05-09 Chris Burdess [EMAIL PROTECTED] * gnu/xml/dom/DomNode.java: Permit comments and PIs in doctype nodes

[cp-patches] FYI: Updated java.lang.Thread throwpoint tests

2006-05-04 Thread Gary Benson
revision 1.1604 diff -u -r1.1604 ChangeLog --- ChangeLog 3 May 2006 00:13:37 - 1.1604 +++ ChangeLog 4 May 2006 14:37:33 - @@ -1,3 +1,9 @@ +2006-05-04 Gary Benson [EMAIL PROTECTED] + + * gnu/testlet/java/lang/Thread/security.java: Added some missing + constructor tests

[cp-patches] Re: FYI: Updated java.lang.Thread throwpoint tests

2006-05-04 Thread Gary Benson
Balls, wrong list! Gary Benson wrote: Hi all, My previous commit fixes a number of problems with the Thread throwpoint tests. Firstly, they failed big-time on proprietary runtimes: seems that Classpath's default SecurityManager's checkAccess() methods perform permission checks in more

Re: [cp-patches] RFC: Path canonicalizer

2006-04-07 Thread Gary Benson
Tom Tromey wrote: Gary == Gary Benson [EMAIL PROTECTED] writes: Gary It's possible, I suppose, but it seems over-complex when libgcj Gary manages to sidestep the PATH_MAX thing just fine with: Gary #ifndef MAXPATHLEN Gary#define MAXPATHLEN 4096 Gary #endif Yeah, I suppose so

Re: [cp-patches] RFC: Path canonicalizer

2006-04-06 Thread Gary Benson
Tom Tromey wrote: Mark == Mark Wielaard [EMAIL PROTECTED] writes: Mark It does look good to me. But in theory the usage of PATH_MAX Mark PATH_MAX might be a problem. Yeah, this famously is not defined in Hurd. Do we really need a limit here? Can't we just resize the buffer

Re: [cp-patches] RFC: Path canonicalizer

2006-04-06 Thread Gary Benson
Mark Wielaard wrote: ...I assume this is normally called on absolute paths that are already in canonical form. Not necessarily. For example, the way JPackage makes Tomcat FHS compliant (with symlinks all over the place) means that just about every FilePermission check will involve following

Re: [cp-patches] RFC: Path canonicalizer

2006-04-04 Thread Gary Benson
Mark Wielaard wrote: On Wed, 2006-03-29 at 09:54 +0100, Gary Benson wrote: This patch makes Classpath do the right thing on GNU/Posix systems. Cool. But where is the ChangeLog entry!? Erm, future work? :) It does look good to me. But in theory the usage of PATH_MAX might be a problem

Re: [cp-patches] RFC: Path canonicalizer

2006-04-04 Thread Gary Benson
Mark Wielaard wrote: Do note that with that define you will end up using 3 * 4K for each toCanonicalForm() operation. Will that be a problem do you think? Cheers, Gary

[cp-patches] RFC: Path canonicalizer

2006-03-29 Thread Gary Benson
Hi all, Here's my attempt at a JNI GNU/Posix path canonicalizer. If you missed my previous mail, this is required in order for FilePermission checks to work (PR classpath/24895). Classpath's canonicalizer doesn't handle symbolic links, whereas GCJ's does, just not very well. This patch makes

[cp-patches] FYI: Canonicalize paths during FilePermission checks

2006-03-29 Thread Gary Benson
Mar 2006 14:52:34 - 1.6941 +++ ChangeLog 29 Mar 2006 15:32:50 - @@ -1,3 +1,8 @@ +2006-03-29 Gary Benson [EMAIL PROTECTED] + + Partial fix for PR classpath/24895 + * java/io/FilePermission.java (implies): Canonicalize paths. + 2006-03-29 Robert Schuster [EMAIL PROTECTED

[cp-patches] FYI: FilePermission symlink handling test

2006-03-22 Thread Gary Benson
=== RCS file: /cvs/mauve/mauve/ChangeLog,v retrieving revision 1.1562 diff -u -r1.1562 ChangeLog --- ChangeLog 21 Mar 2006 19:59:15 - 1.1562 +++ ChangeLog 22 Mar 2006 10:41:39 - @@ -1,3 +1,7 @@ +2006-03-22 Gary Benson [EMAIL PROTECTED] + + * gnu/testlet/java/io/FilePermission

[cp-patches] Re: FYI: FilePermission symlink handling test

2006-03-22 Thread Gary Benson
Oops, that was for mauve-patches! Sorry for the noise. Gary Benson wrote: Hi all, My last commit adds a test to check FilePermission's handling of symbolic links. Both proprietary JVMs I tried passed this test, but Classpath does not. Now to figure out how to fix this... Cheers, Gary

Re: [cp-patches] RFC: system clipboard integration

2006-03-22 Thread Gary Benson
Robert Schuster wrote: The code contains security related stuff which I am unfamiliar with. Can somebody review that part? Gary? It looks fine. Cheers, Gary

Re: [cp-patches] RFC: Checking file resource validity by walking path components

2006-03-09 Thread Gary Benson
Olivier Jolly wrote: the current implementation which retrieves a File resource allows to retrieve Files which are located above the root dir (imagine ClassLoader.getResource(../../../etc/passwd)) while it shouldn't (hence the current regression in

[cp-patches] FYI: Added missing access check in Thread.stop

2006-02-16 Thread Gary Benson
08:45:28 - 1.6414 +++ ChangeLog 16 Feb 2006 09:52:34 - @@ -1,3 +1,7 @@ +2006-02-16 Gary Benson [EMAIL PROTECTED] + + * java/lang/Thread.java (stop): Add a missing access check. + 2006-02-16 Robert Schuster [EMAIL PROTECTED] * javax/swing/text/JTextComponent.java

[cp-patches] FYI: Implemented java.net.SocketPermission serialization

2006-01-24 Thread Gary Benson
Gary Benson [EMAIL PROTECTED] + + * java/net/SocketPermission.java: Implemented serialization. + 2006-01-24 David Gilbert [EMAIL PROTECTED] * javax/swing/text/StringContent.java Index: java/net/SocketPermission.java

[cp-patches] RFC: Rewritten java.net.SocketPermission

2006-01-19 Thread Gary Benson
* - * @author Aaron M. Renn ([EMAIL PROTECTED]) + * @author Written by Aaron M. Renn ([EMAIL PROTECTED]) + * @author Extensively modified by Gary Benson ([EMAIL PROTECTED]) */ public final class SocketPermission extends Permission implements Serializable { @@ -114,16 +116,37 @@ // FIXME: Needs

[cp-patches] FYI: Security manager preload tweak

2006-01-17 Thread Gary Benson
revision 1.6092 diff -u -r1.6092 ChangeLog --- ChangeLog 16 Jan 2006 20:43:20 - 1.6092 +++ ChangeLog 17 Jan 2006 10:25:21 - @@ -1,3 +1,8 @@ +2006-01-17 Gary Benson [EMAIL PROTECTED] + + * java/lang/System.java (setSecurityManager): Catch + ClassNotFoundException

[cp-patches] FYI: Load policies before setting security manager

2006-01-16 Thread Gary Benson
file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.6069 diff -u -r1.6069 ChangeLog --- ChangeLog 16 Jan 2006 09:24:19 - 1.6069 +++ ChangeLog 16 Jan 2006 09:53:13 - @@ -1,3 +1,8 @@ +2006-01-16 Gary Benson [EMAIL PROTECTED] + + * java/lang/System.java

[cp-patches] FYI: Fix SocketPermission action checks

2006-01-16 Thread Gary Benson
=== RCS file: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.6073 diff -u -r1.6073 ChangeLog --- ChangeLog 16 Jan 2006 10:15:47 - 1.6073 +++ ChangeLog 16 Jan 2006 10:27:42 - @@ -1,3 +1,7 @@ +2006-01-16 Gary Benson [EMAIL PROTECTED] + + * java/net

Re: [cp-patches] Patch: remove bogus ServerSocket security check

2006-01-03 Thread Gary Benson
Mark Wielaard wrote: On Mon, 2005-12-26 at 19:05 -0800, Anthony Green wrote: This patch removes a bogus security check from ServerSocket.accept(), and replaces it with a request to implement a proper check. Once applied I will file a bug report for our records. Gary, do we have Mauve

Re: [cp-patches] FYI: Allow Security.setProperty(foo, null)

2005-12-13 Thread Gary Benson
Tom Tromey wrote: Gary == Gary Benson [EMAIL PROTECTED] writes: Gary At the moment Security.setProperty() will not allow the Gary setting of null property values. Since Security.getProperty() Gary returns null for unset properties this means that the Gary following will fail: When you

[cp-patches] FYI: Allow Security.setProperty(foo, null)

2005-12-12 Thread Gary Benson
- 1.5793 +++ ChangeLog 12 Dec 2005 15:28:48 - @@ -1,3 +1,8 @@ +2005-12-12 Gary Benson [EMAIL PROTECTED] + + * java/security/Security.java (setProperty): Spelling correction. + * java/security/Security.java (setProperty): Allow null values. + 2005-12-12 Roman Kennke

Re: [cp-patches] FYI: Opening RandomAccessFilesrequiresexcessivepermission

2005-12-09 Thread Gary Benson
] On Behalf Of Gary Benson Sent: Thursday, December 08, 2005 17:25 To: classpath-patches@gnu.org Subject: Re: [cp-patches] FYI: Opening RandomAccessFilesrequiresexcessivepermission Hi Jeroen, Oh, in that case I'll use your patch, assuming nobody objects. The mauve test ought

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-08 Thread Gary Benson
David Daney wrote: Gary Benson wrote: David Daney wrote: Gary Benson wrote: ...I'll commit my original patch for now. I hate to sound like I have a burr under the saddle, but does anybody see any merit whatsoever in changing the exception text as I suggested in my previous

Re: [cp-patches] FYI: Opening RandomAccessFiles requiresexcessivepermission

2005-12-08 Thread Gary Benson
Of Gary Benson Sent: Thursday, December 08, 2005 13:02 To: classpath-patches@gnu.org Subject: Re: [cp-patches] FYI: Opening RandomAccessFiles requiresexcessivepermission Hi Jeroen, Hey, interesting. You'd have to override more methods than that though, I think. Maybe the best

Re: [cp-patches] Patch: Add security check to Class.getClasses()

2005-12-07 Thread Gary Benson
Tom Tromey wrote: Gary == Gary Benson [EMAIL PROTECTED] writes: Gary Class.getClasses() was not performing the member access checks Gary like it ought. The attached patch fixes. I'm working on Gary mauve tests for all of Class's security calls so there will be Gary a check for this issue

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-07 Thread Gary Benson
Tom Tromey wrote: Twisti == Christian Thalinger [EMAIL PROTECTED] writes: Twisti Yeah, i didn't take it personally :-) Of course i see your Twisti point, but what i'm trying to say is, if we ever want to Twisti catch up (or even be better) than sun or other proprietary Twisti JVMs, we should

[cp-patches] FYI: Opening RandomAccessFiles requires excessive permission

2005-12-07 Thread Gary Benson
: /cvsroot/classpath/classpath/ChangeLog,v retrieving revision 1.5775 diff -u -r1.5775 ChangeLog --- ChangeLog 7 Dec 2005 15:12:19 - 1.5775 +++ ChangeLog 7 Dec 2005 15:24:26 - @@ -1,3 +1,9 @@ +2005-12-07 Gary Benson [EMAIL PROTECTED] + + * java/io/RandomAccessFile.java

[cp-patches] Patch: Allow Security.setProperty(foo, null)

2005-12-07 Thread Gary Benson
- 1.5776 +++ ChangeLog 7 Dec 2005 15:44:29 - @@ -1,5 +1,10 @@ 2005-12-07 Gary Benson [EMAIL PROTECTED] + * java/security/Security.java (setProperty): Spelling correction. + * java/security/Security.java (setProperty): Allow null values. + +2005-12-07 Gary Benson

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-07 Thread Gary Benson
David Daney wrote: Gary Benson wrote: ...I'll commit my original patch for now. I hate to sound like I have a burr under the saddle, but does anybody see any merit whatsoever in changing the exception text as I suggested in my previous response to the patch? What did you suggest? I saw

Re: [cp-patches] FYI: Getting the system clipboard in javax/swing/TransferHandler

2005-11-29 Thread Gary Benson
Mark Wielaard wrote: On Sat, 2005-11-19 at 23:40 +0100, Meskauskas Audrius wrote: The idea probably is that if we cannot get access to the system clipboard, we may still want to cut/copy/paste inside the same application (for instance, to move the text fragment in the text area being

Re: [cp-patches] Patch: SecurityManager.checkAccess broken

2005-11-18 Thread Gary Benson
Mark Wielaard wrote: BTW If you are going to more work like this and want developer access please sent register a user name on savannah and sent me an email to add that user to the group. Cool, ok, my savanna username is gbenson. Cheers, Gary ___

[cp-patches] FYI: Adding myself to AUTHORS

2005-11-18 Thread Gary Benson
Mark Wielaard wrote: Please post a patch and ChangeLog entry to classpath-patches to add yourself to the AUTHORS file. You can consider that patch pre-approved of course. Here I go! 2005-11-17 Gary Benson [EMAIL PROTECTED] * AUTHORS: Added myself. Cheers, Gary Index: AUTHORS

Re: [cp-patches] Patch: java.io.FilePermission.implies checks reversed

2005-11-17 Thread Gary Benson
Mark Wielaard wrote: On Wed, 2005-11-16 at 15:10 +, Gary Benson wrote: 2005-11-16 Gary Benson [EMAIL PROTECTED] * java/io/FilePermission.java (implies): Correct the sense in which action checks are applied. And you created mauve tests for this. Very nice! Patch

[cp-patches] Patch: infinite loop in security manager

2005-11-16 Thread Gary Benson
Michael Koch wrote: On Wed, Nov 16, 2005 at 11:56:37AM +, Gary Benson wrote: I found a bug where the thing that throws SecurityExceptions can itself cause a SecurityException to be thrown causing an infinite loop. When java.security.AccessControlContext.checkPermission decides

[cp-patches] Patch: java.io.FilePermission.implies checks reversed

2005-11-16 Thread Gary Benson
retrieving revision 1.5612 diff -u -r1.5612 ChangeLog --- ChangeLog 15 Nov 2005 23:07:23 - 1.5612 +++ ChangeLog 16 Nov 2005 15:09:25 - @@ -1,3 +1,8 @@ +2005-11-16 Gary Benson [EMAIL PROTECTED] + + * java/io/FilePermission.java (implies): Correct the sense + in which