Re: [cp-patches] HTMLWriter

2006-11-11 Thread fchoong
Ok, Thanks! > Hi David, > >> I tried it just now, and your fix works with the new patch, as the >> implied >> tag is now recognized as a HTML.Tag.IMPLIED Tag! So the implied tags for >> CP and the RI behave the same now! > > Very good. I checked in your patch (attached again). > > 2006-11-10 Davi

Re: [cp-patches] HTMLWriter

2006-11-10 Thread Roman Kennke
Hi David, > I tried it just now, and your fix works with the new patch, as the implied > tag is now recognized as a HTML.Tag.IMPLIED Tag! So the implied tags for > CP and the RI behave the same now! Very good. I checked in your patch (attached again). 2006-11-10 David Fu <[EMAIL PROTECTED]>

Re: [cp-patches] HTMLWriter

2006-11-10 Thread fchoong
Hi Roman, I tried it just now, and your fix works with the new patch, as the implied tag is now recognized as a HTML.Tag.IMPLIED Tag! So the implied tags for CP and the RI behave the same now! David Fu. > Hi David, > > Am Freitag, den

Re: [cp-patches] HTMLWriter

2006-11-10 Thread Roman Kennke
Hi David, Am Freitag, den 10.11.2006, 17:16 +0900 schrieb [EMAIL PROTECTED]: > Hi Roman, > Can you commit this patch after you fix p-implied? This patch removes all > the CP specific sections. Thanks! Sure. Can you tell me what is different in Classpath ATM? I think I still don't understand compl

Re: [cp-patches] HTMLWriter

2006-11-10 Thread fchoong
Hi Roman, Can you commit this patch after you fix p-implied? This patch removes all the CP specific sections. Thanks! David Fu. > Hi David, > >> Thanks for checking the file in! The IMPLIED tag in the RI is >> implemented >> as a Tag w

Re: [cp-patches] HTMLWriter

2006-10-31 Thread Roman Kennke
Hi David, > Thanks for checking the file in! The IMPLIED tag in the RI is implemented > as a Tag with a NameAttribute of HTML.Tag.IMPLIED. GNU CP > implements it as a Tag with a NameAttribute of HTML.Tag.P, with a tag > attribute of _implied_="true". We should fix that. It sounds easy enough.

Re: [cp-patches] HTMLWriter

2006-10-31 Thread fchoong
Hi Roman, Thanks for checking the file in! The IMPLIED tag in the RI is implemented as a Tag with a NameAttribute of HTML.Tag.IMPLIED. GNU CP implements it as a Tag with a NameAttribute of HTML.Tag.P, with a tag attribute of _implied_="true". The other difference is that since the RI is using HTM

Re: [cp-patches] HTMLWriter

2006-10-31 Thread Roman Kennke
Hi all, > On Mon, 2006-10-30 at 17:39 +0100, Roman Kennke wrote: > > > I have fixed the formatting, added comments and also finished up the > > > incomplete parts. Hope this passes the muster :) > > > > Looks good to me. I have included it in my local tree and finished it up > > for committing (S

Re: [cp-patches] HTMLWriter

2006-10-31 Thread Mark Wielaard
Hi Roman, On Mon, 2006-10-30 at 17:39 +0100, Roman Kennke wrote: > > I have fixed the formatting, added comments and also finished up the > > incomplete parts. Hope this passes the muster :) > > Looks good to me. I have included it in my local tree and finished it up > for committing (Some more f

Re: [cp-patches] HTMLWriter

2006-10-30 Thread Roman Kennke
Hi David, > I have fixed the formatting, added comments and also finished up the > incomplete parts. Hope this passes the muster :) Looks good to me. I have included it in my local tree and finished it up for committing (Some more formatting etc). I'd like to talk back to Mark before anyhow. You

Re: [cp-patches] HTMLWriter

2006-10-30 Thread fchoong
Hi Roman, all, I have fixed the formatting, added comments and also finished up the incomplete parts. Hope this passes the muster :) David Fu./* HTMLWriter.java -- Copyright (C) 2006 Free Software Foundation, Inc. This file is part o

Re: [cp-patches] HTMLWriter

2006-10-27 Thread fchoong
Hi Roman, Tom, The paperwork is already done(handled by Mark), so I should be ok. I will try to finish the formating and commenting this weekend. Mark's probably having a great time in Colorado right now :) David Fu. > Hi David, > >> I

Re: [cp-patches] HTMLWriter

2006-10-26 Thread Roman Kennke
Hi David, > I have tested it with Blackdown JDK 1.4.2, and JamVM 1.4.2 + GNU Classpath > 0.92. The output formatting(indent and newlines) is tricky, but I tried to > keep as close to the RI as possible. CP 0.92 does not have all the tags > yet, but looks to be ok. I have not tried Mauve/testlets b

Re: [cp-patches] HTMLWriter

2006-10-25 Thread fchoong
Hi Roman, Audrius, I have tested it with Blackdown JDK 1.4.2, and JamVM 1.4.2 + GNU Classpath 0.92. The output formatting(indent and newlines) is tricky, but I tried to keep as close to the RI as possible. CP 0.92 does not have all the tags yet, but looks to be ok. I have not tried Mauve/testlets b

Re: [cp-patches] HTMLWriter

2006-10-24 Thread Audrius Meskauskas
Ho, David! Congratulations, we were waiting for this class for a long time! The most important is now to have a little bit of tests for the new class. It may be that your tests only pass with Sun's jre and not with ours - does not matter anyway, just convert into testlets (a piece of cake to

Re: [cp-patches] HTMLWriter

2006-10-24 Thread Roman Kennke
Hi Fu, > Hi Mark, > Just finished javax.swing.text.html.HTMLWriter, can you commit it for me? > Thanks! ;) The code looks good. Maybe you could fix the following points, then it would be even better: - Add (extensive ;-) ) comments to the class and to each method/field etc. This makes the code mo

[cp-patches] HTMLWriter

2006-10-24 Thread fchoong
Hi Mark, Just finished javax.swing.text.html.HTMLWriter, can you commit it for me? Thanks! ;) David Fu./* HTMLWriter.java -- Copyright (C) 2006 Free Software Foundation, Inc. This file is part of GNU Classpath. GNU Classpath is