Re: RFR: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

2022-11-09 Thread Tejesh R
On Wed, 9 Nov 2022 10:37:24 GMT, Prasanta Sadhukhan wrote: > Test intermittently fails in VM citing "Tree is not editing". Seems to be > problem with mouse clicks not getting registered properly.. > Similar test test/jdk/javax/swing/JTable/6263446/bug6263446.java is not > affected, so made the

Re: RFR: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

2022-11-09 Thread Prasanta Sadhukhan
On Thu, 10 Nov 2022 06:01:39 GMT, Sergey Bylokhov wrote: >> Test intermittently fails in VM citing "Tree is not editing". Seems to be >> problem with mouse clicks not getting registered properly.. >> Similar test test/jdk/javax/swing/JTable/6263446/bug6263446.java is not >> affected, so made th

RFR: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

2022-11-09 Thread Tejesh R
Observation found when _JFileChooser_ is instantiated in _WindowsLookAndFeel_ which invokes _getSystemIcon()_ from WindowsFileChooserUI class. Could not find the exact root cause so predicting it to be an issue with icons not loaded where _resolutionVariants_ map is empty in _public Image getRe

Re: RFR: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

2022-11-09 Thread Tejesh R
On Thu, 10 Nov 2022 06:00:27 GMT, Tejesh R wrote: > Observation found when _JFileChooser_ is instantiated in _WindowsLookAndFeel_ > which invokes _getSystemIcon()_ from WindowsFileChooserUI class. Could not > find the exact root cause so predicting it to be an issue with icons not > loaded whe

Re: RFR: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

2022-11-09 Thread Tejesh R
On Thu, 10 Nov 2022 06:00:27 GMT, Tejesh R wrote: > Observation found when _JFileChooser_ is instantiated in _WindowsLookAndFeel_ > which invokes _getSystemIcon()_ from WindowsFileChooserUI class. Could not > find the exact root cause so predicting it to be an issue with icons not > loaded whe

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v2]

2022-11-09 Thread Manukumar V S
On Thu, 10 Nov 2022 04:29:36 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Integrated: 8295430: Use cmsDoTransformLineStride instead of cmsDoTransform in the loop

2022-11-09 Thread Sergey Bylokhov
On Wed, 19 Oct 2022 02:59:37 GMT, Sergey Bylokhov wrote: > This is the request to improve the change made by the > [8005530: [lcms] Improve performance of ColorConverOp for default > destinations](http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fd8810d50c99) > > Right now the LCMSTransform mantain

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v2]

2022-11-09 Thread Sergey Bylokhov
On Thu, 10 Nov 2022 04:29:36 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Integrated: 8295812: Skip the "half float" support in LittleCMS during the build

2022-11-09 Thread Sergey Bylokhov
On Sun, 23 Oct 2022 20:10:35 GMT, Sergey Bylokhov wrote: > The Java2d do not use "half" float in the image layouts, so we can disable it > in the LittleCMS library during the build. It is possible to do using > [this](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/libl

Re: RFR: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

2022-11-09 Thread Sergey Bylokhov
On Wed, 9 Nov 2022 10:37:24 GMT, Prasanta Sadhukhan wrote: > Test intermittently fails in VM citing "Tree is not editing". Seems to be > problem with mouse clicks not getting registered properly.. > Similar test test/jdk/javax/swing/JTable/6263446/bug6263446.java is not > affected, so made the

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v2]

2022-11-09 Thread Manukumar V S
On Thu, 10 Nov 2022 04:29:36 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Re: RFR: 6788481: CellEditorListener.editingCanceled is never called

2022-11-09 Thread Sergey Bylokhov
On Thu, 3 Nov 2022 07:05:10 GMT, Prasanta Sadhukhan wrote: > When editing of a table cell is canceled, the function editingCanceled of the > registered listener CellEditorListener is not called as actionPerformed on > ESC key press was not notifying the "cancel" listeners. > Fix is to handle "

Integrated: 8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel

2022-11-09 Thread Prasanta Sadhukhan
On Fri, 4 Nov 2022 06:27:19 GMT, Prasanta Sadhukhan wrote: > Test sometimes fail for Motif L&F only which might require some code change > in Motif code but since Motif is already deprecated and obsolete, it seems > prudent to skip Motif L&F in the test. > Several iterations of the modified te

Re: RFR: 8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel

2022-11-09 Thread Jayathirth D V
On Fri, 4 Nov 2022 06:27:19 GMT, Prasanta Sadhukhan wrote: > Test sometimes fail for Motif L&F only which might require some code change > in Motif code but since Motif is already deprecated and obsolete, it seems > prudent to skip Motif L&F in the test. > Several iterations of the modified te

Re: RFR: 8296275: Write a test to verify setAccelerator method of JMenuItem. [v3]

2022-11-09 Thread Naveen Narayanan
> This testcase will > 1) Verify setAccelerator method of JMenuitem. > 2) Check that the selection of a menu item in the menu bar will generate > action by a key combination of META+M. > > Testing: > Tested using Mach5(20 times per platform) in Mac OS, Linux and Windows and > got all pass. Nave

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v2]

2022-11-09 Thread ravi gupta
> This testcase Verify the content changes of a TextArea for the following > assertions. > > a. TextListener get invoked when the content of a TextArea gets changed. > b. TextListener not get invoked during text selection or when Special keys > such as Function Keys are pressed. > > > Testing:

RFR: JDK-8296547: Add @spec tags to API

2022-11-09 Thread Jonathan Gibbons
Please review a "somewhat automated" change to insert `@spec` tags into doc comments, as appropriate, to leverage the recent new javadoc feature to generate a new page listing the references to all external specifications listed in the `@spec` tags. "Somewhat automated" means that I wrote and u

Re: RFR: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

2022-11-09 Thread Prasanta Sadhukhan
On Wed, 9 Nov 2022 15:03:08 GMT, lawrence.andrews wrote: >> Test intermittently fails in VM citing "Tree is not editing". Seems to be >> problem with mouse clicks not getting registered properly.. >> Similar test test/jdk/javax/swing/JTable/6263446/bug6263446.java is not >> affected, so made th

Re: RFR: JDK-8296661 : Fix typo

2022-11-09 Thread Andy Goryachev
On Fri, 4 Nov 2022 01:56:05 GMT, ScientificWare wrote: > I suspect a typo in the documentation comments. Marked as reviewed by angorya (no project role). - PR: https://git.openjdk.org/jdk/pull/10975

RFR: JDK-8296661 : Fix typo

2022-11-09 Thread ScientificWare
I suspect a typo in the documentation comments. - Commit messages: - Fix typos in CSSParser.java Changes: https://git.openjdk.org/jdk/pull/10975/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10975&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296661 Stats: 1 lin

Re: RFR: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

2022-11-09 Thread lawrence . andrews
On Wed, 9 Nov 2022 10:37:24 GMT, Prasanta Sadhukhan wrote: > Test intermittently fails in VM citing "Tree is not editing". Seems to be > problem with mouse clicks not getting registered properly.. > Similar test test/jdk/javax/swing/JTable/6263446/bug6263446.java is not > affected, so made the

Re: RFR: 8295779: Xcode 14.0 fails to build jdk on m1 macos

2022-11-09 Thread Kevin Rushforth
On Wed, 9 Nov 2022 11:57:51 GMT, yosbits wrote: > It is marked as a duplicate of the issue I reported and this issue.but it is > a different issue. but I am very doubtful as to why such a decision was made. > > https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8296654 Yes, [JDK-8296654]

Re: RFR: 8295779: Xcode 14.0 fails to build jdk on m1 macos

2022-11-09 Thread yosbits
On Wed, 19 Oct 2022 15:33:31 GMT, Archie L. Cobbs wrote: > Building on MacOS 12.6 M1 with Xcode 14.0 fails due to C compiler unused > parameter warnings: > > Creating support/modules_libs/java.desktop/libosx.dylib from 1 file(s) It is marked as a duplicate of the issue I reported and this issu

Re: RFR: 8296496: Overzealous check in sizecalc.h prevents large memory allocation [v3]

2022-11-09 Thread Alexey Ivanov
On Tue, 8 Nov 2022 23:43:23 GMT, Alexander Zuev wrote: >> Removed the additional multiplication overflow detection. >> Instead cast all the parameters to type_t just the way they are treated in >> the existing size check macro. >> This way there is no possibility to accidentally provide paramet

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v2]

2022-11-09 Thread Artem Semenov
On Wed, 9 Nov 2022 00:51:10 GMT, Alexander Zuev wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> We don't do @author tags in openjdk >> Not 2022 ? > > src/java.desktop/share/classes/javax/swing/JList.java line 52

RFR: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

2022-11-09 Thread Prasanta Sadhukhan
Test intermittently fails in VM citing "Tree is not editing". Seems to be problem with mouse clicks not getting registered properly.. Similar test test/jdk/javax/swing/JTable/6263446/bug6263446.java is not affected, so made the test similar to it by using same safeguard using Robot.waitForIdle()

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v3]

2022-11-09 Thread Artem Semenov
> A11Y implementation on macOS has to directly call the > 'JList.setSelectedIndex' method in order to request selection on an item (see > 'CAccessibility.requestSelection'). The reason is that a11y API lacks > appropriate method.There's only > 'javax.accessibility.AccessibleSelection#addAccessi

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2022-11-09 Thread Artem Semenov
> A11Y implementation on macOS has to directly call the > 'JList.setSelectedIndex' method in order to request selection on an item (see > 'CAccessibility.requestSelection'). The reason is that a11y API lacks > appropriate method.There's only > 'javax.accessibility.AccessibleSelection#addAccessi

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v2]

2022-11-09 Thread Artem Semenov
On Wed, 9 Nov 2022 04:29:57 GMT, Phil Race wrote: >> I am still waiting for the following questions (from July) to be answered >> here (not somewhere else) >> >>> You did not acknowledge this is not a backportable fix >> >> By which I mean, if this needs to be solved in say JDK 11 too, what wi

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent.

2022-11-09 Thread Srinivas Mandalika
On Wed, 9 Nov 2022 04:29:35 GMT, ravi gupta wrote: > This testcase Verify the content changes of a TextArea for the following > assertions. > > a. TextListener get invoked when the content of a TextArea gets changed. > b. TextListener not get invoked during text selection or when Special keys

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent.

2022-11-09 Thread Srinivas Mandalika
On Wed, 9 Nov 2022 04:29:35 GMT, ravi gupta wrote: > This testcase Verify the content changes of a TextArea for the following > assertions. > > a. TextListener get invoked when the content of a TextArea gets changed. > b. TextListener not get invoked during text selection or when Special keys

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent.

2022-11-09 Thread Manukumar V S
On Wed, 9 Nov 2022 04:29:35 GMT, ravi gupta wrote: > This testcase Verify the content changes of a TextArea for the following > assertions. > > a. TextListener get invoked when the content of a TextArea gets changed. > b. TextListener not get invoked during text selection or when Special keys