Re: RFR: 8297481: Create a regression test for JDK-4424517

2022-11-24 Thread Sergey Bylokhov
On Wed, 23 Nov 2022 08:57:23 GMT, Srinivas Mandalika wrote: > 8297481: Create a regression test for JDK-4424517 Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11313

Re: RFR: 8296905: Replace the native LCMS#getProfileID() method with the accessor [v3]

2022-11-24 Thread Sergey Bylokhov
On Fri, 25 Nov 2022 02:21:09 GMT, SWinxy wrote: >> Sergey Bylokhov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits

Re: RFR: 8296905: Replace the native LCMS#getProfileID() method with the accessor [v3]

2022-11-24 Thread SWinxy
On Fri, 25 Nov 2022 01:34:26 GMT, Sergey Bylokhov wrote: >> The native method used to access the private method in the `ICC_Profile` >> class is replaced by the accessor. > > Sergey Bylokhov has updated the pull request with a new target base due to a > merge or a rebase. The incremental

Re: RFR: 8296905: Replace the native LCMS#getProfileID() method with the accessor [v3]

2022-11-24 Thread Sergey Bylokhov
> The native method used to access the private method in the `ICC_Profile` > class is replaced by the accessor. Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

RFR: 8296660: Swing HTML table with omitted closing tags misparsed

2022-11-24 Thread Prasanta Sadhukhan
This is in continuation with https://github.com/openjdk/jdk/commit/7133fc93e168f3671d048b2ae654f84ec289b98d fix done for [JDK-7172359](https://bugs.openjdk.org/browse/JDK-7172359) issue where fix was done to rectify invalid tag causing StackOverflowError but it caused alignment issue if the

Re: RFR: 8078471: The BACKSPACE key doesn't work with the special options"-client -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel" [v2]

2022-11-24 Thread Abhishek Kumar
On Thu, 24 Nov 2022 13:29:12 GMT, Prasanta Sadhukhan wrote: > This mapping ""BACK_SPACE", "Go Up"," I guess has nothing to do with > squarebutton property..Probably you are confusing it with your other fix? Yeah, I am sorry. I will check in Nimbus then how it's happening. > You probably can

Re: RFR: 8078471: The BACKSPACE key doesn't work with the special options"-client -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel" [v2]

2022-11-24 Thread Prasanta Sadhukhan
On Thu, 24 Nov 2022 08:57:45 GMT, Abhishek Kumar wrote: >> The Backspace key doesn't lead to parent directory of current directory for >> JFileChooser in GTK LAF. >> Added the lazy input value in `GTKLookandFeel` and fix is working fine. >> >> Implemented a manual test to check BackSpace

Re: RFR: 8078471: The BACKSPACE key doesn't work with the special options"-client -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel" [v2]

2022-11-24 Thread Abhishek Kumar
On Thu, 24 Nov 2022 13:00:52 GMT, Prasanta Sadhukhan wrote: > I wonder how it works in Nimbus as this mapping is not there in > Synth/NimbusLookAndFeel and still it works and both GTK/Nimbus extends Synth. > Can you please check? There is a mapping for squarebutton in skin.laf ``. Setting

Re: RFR: 8078471: The BACKSPACE key doesn't work with the special options"-client -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel" [v2]

2022-11-24 Thread Prasanta Sadhukhan
On Thu, 24 Nov 2022 08:57:45 GMT, Abhishek Kumar wrote: >> The Backspace key doesn't lead to parent directory of current directory for >> JFileChooser in GTK LAF. >> Added the lazy input value in `GTKLookandFeel` and fix is working fine. >> >> Implemented a manual test to check BackSpace

Re: RFR: 8078471: The BACKSPACE key doesn't work with the special options"-client -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel" [v2]

2022-11-24 Thread Abhishek Kumar
On Thu, 24 Nov 2022 08:57:45 GMT, Abhishek Kumar wrote: >> The Backspace key doesn't lead to parent directory of current directory for >> JFileChooser in GTK LAF. >> Added the lazy input value in `GTKLookandFeel` and fix is working fine. >> >> Implemented a manual test to check BackSpace

Re: RFR: 8296546: Add @spec tags to API [v3]

2022-11-24 Thread Alan Bateman
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote: >> Please review a "somewhat automated" change to insert `@spec` tags into doc >> comments, as appropriate, to leverage the recent new javadoc feature to >> generate a new page listing the references to all external specifications >>

Re: RFR: 8297095: Write a test to determine the quit request of the application

2022-11-24 Thread Naveen Narayanan
On Wed, 23 Nov 2022 18:29:50 GMT, Harshitha Onkar wrote: >> This testcase will >> 1) Verify the handleQuitRequestWith() method of QuitHandler interface. >> 2) Check that the response is passed to the handler by means of quit >> notification generated by a key combination of META+Q (Mac) or >>

Re: RFR: JDK-8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NULL check

2022-11-24 Thread Patrick Chen
On Wed, 23 Nov 2022 08:18:32 GMT, Matthias Baesken wrote: > Seems there is a remaining GetPrimitiveArrayCritical in imageioJPEG that > misses a result - NULL check, this should be added. some tests are failing - PR: https://git.openjdk.org/jdk/pull/11312

Re: RFR: 8078471: The BACKSPACE key doesn't work with the special options"-client -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel" [v2]

2022-11-24 Thread Abhishek Kumar
On Thu, 24 Nov 2022 08:57:45 GMT, Abhishek Kumar wrote: >> The Backspace key doesn't lead to parent directory of current directory for >> JFileChooser in GTK LAF. >> Added the lazy input value in `GTKLookandFeel` and fix is working fine. >> >> Implemented a manual test to check BackSpace

Re: RFR: 6972078: Can not select single directory with GTKLookAndFeel [v6]

2022-11-24 Thread Patrick Chen
On Tue, 8 Nov 2022 07:06:27 GMT, Abhishek Kumar wrote: >> While using a JFileChooser with the file selection mode >> FILES_AND_DIRECTORIES and multiSelection enabled, it is impossible to select >> a single directory in GTK LAF. >> >> The condition check has been modified when multiselection

Re: RFR: 8078471: The BACKSPACE key doesn't work with the special options"-client -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel" [v2]

2022-11-24 Thread Abhishek Kumar
> The Backspace key doesn't lead to parent directory of current directory for > JFileChooser in GTK LAF. > Added the lazy input value in `GTKLookandFeel` and fix is working fine. > > Implemented a manual test to check BackSpace behavior for all installed LAF > in Linux platform. > The test

Re: RFR: JDK-8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NULL check

2022-11-24 Thread Matthias Baesken
On Wed, 23 Nov 2022 08:18:32 GMT, Matthias Baesken wrote: > Seems there is a remaining GetPrimitiveArrayCritical in imageioJPEG that > misses a result - NULL check, this should be added. Thanks for the review ! - PR: https://git.openjdk.org/jdk/pull/11312

Integrated: JDK-8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NULL check

2022-11-24 Thread Matthias Baesken
On Wed, 23 Nov 2022 08:18:32 GMT, Matthias Baesken wrote: > Seems there is a remaining GetPrimitiveArrayCritical in imageioJPEG that > misses a result - NULL check, this should be added. This pull request has now been integrated. Changeset: 2f8a5c2e Author:Matthias Baesken URL: