On Mon, 16 Jan 2023 05:31:18 GMT, Prasanta Sadhukhan
wrote:
> `list` and `c` points to same object
> _javax.swing.JList[,0,0,0x0,invalid,alignmentX=0.0,alignmentY=0.0,border=javax.swing.plaf.synth.SynthBorder@fc8b518,flags=3355472
>
> 8,maximumSize=,minimumSize=,preferredSize=,fixedCellHeight=
On Tue, 17 Jan 2023 05:37:38 GMT, Tejesh R wrote:
>> FileChooser Open/Approve button size is shown incorrectly when no Approve
>> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
>> Approve Button text is returned during Dialog Type Property change. Since
>> `null` is r
On Tue, 17 Jan 2023 04:29:31 GMT, David Holmes wrote:
> Hotspot changes are good.
Thanks @dholmes-ora .
-
PR: https://git.openjdk.org/jdk/pull/12005
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is returned as Button string the Button size is incorrectly
On Tue, 17 Jan 2023 05:07:42 GMT, Tejesh R wrote:
>> FileChooser Open/Approve button size is shown incorrectly when no Approve
>> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
>> Approve Button text is returned during Dialog Type Property change. Since
>> `null` is r
On Mon, 16 Jan 2023 20:07:07 GMT, SWinxy wrote:
> Please review this small change to cache a component's popup menu in BLAF.
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java
line 35:
> 33:
> 34: import javax.sound.sampled.*;
> 35: import javax.swing.*;
Fix looks ok
On Mon, 16 Jan 2023 18:11:14 GMT, Sergey Bylokhov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated JTREG summary
>
> test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 71:
>
>> 69:
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is returned as Button string the Button size is incorrectly
On Mon, 16 Jan 2023 11:17:10 GMT, Tejesh R wrote:
> In Aqua look and feel, `getDefaultButton()` of `JFileChooser` returns null.
> The fix overrides the method from `FileChooserUI` to return the
> `ApproveButton` of `FileChooser` which is similar to other L&F.
> The test is run for multiple ite
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>2) src/hotspot/share/runtime/notificationThre
Please review this itty-bitty typo fix.
-
Commit messages:
- 8283203: Fix typo in SystemTray.getTrayIconSize javadoc
Changes: https://git.openjdk.org/jdk/pull/12020/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12020&range=00
Issue: https://bugs.openjdk.org/browse/JDK-82
> This PR adds a new lint warning category `this-escape`.
>
> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
> allow the JDK to continue to compile with `-Xlint:all`.
>
> A 'this' escape warning is generated for a constructor `A()` in a class `A`
> when the compiler
On Mon, 16 Jan 2023 15:09:27 GMT, Matthias Baesken wrote:
> The test javax/swing/text/html/parser/Parser/8078268/bug8078268.java has a
> latch timeout that is currently fix but should better be configurable to
> better deal with slow test infrastructures.
Marked as reviewed by serb (Reviewer).
On Mon, 16 Jan 2023 15:09:27 GMT, Matthias Baesken wrote:
> The test javax/swing/text/html/parser/Parser/8078268/bug8078268.java has a
> latch timeout that is currently fix but should better be configurable to
> better deal with slow test infrastructures.
test/jdk/javax/swing/text/html/parser/
On Fri, 13 Jan 2023 20:53:31 GMT, Rajat Mahajan wrote:
> I tested by removing dpi-awareness settings from the manifest file, and then
> running my app with -Dsun.java2d.dpiaware=false. This showed java.exe as
> "Unaware" in task-manager, and with it set to true I saw "Per-Monitor (v2)"
> dpi a
On Mon, 16 Jan 2023 19:43:06 GMT, Sergey Bylokhov wrote:
> I remember that match 5 uses timeout=4, so I wonder if timeout will be
> changed to 40 seconds will it be possible to verify old bug or not.
The test still fails:
./jdk-9-b123/bin/java -Dtest.timeout.factor=5 bug8078268
Exception in th
Please review this small change to cache a component's popup menu in BLAF.
-
Commit messages:
- 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get
a popup menu
Changes: https://git.openjdk.org/jdk/pull/12017/files
Webrev: https://webrevs.openjdk.org/?repo
On Mon, 16 Jan 2023 15:09:27 GMT, Matthias Baesken wrote:
> The test javax/swing/text/html/parser/Parser/8078268/bug8078268.java has a
> latch timeout that is currently fix but should better be configurable to
> better deal with slow test infrastructures.
I remember that match 5 uses timeout=4
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to ge
On Mon, 16 Jan 2023 15:09:27 GMT, Matthias Baesken wrote:
> The test javax/swing/text/html/parser/Parser/8078268/bug8078268.java has a
> latch timeout that is currently fix but should better be configurable to
> better deal with slow test infrastructures.
Looks fine.
I'd appreciate if you upd
On Fri, 2 Dec 2022 17:06:23 GMT, Magnus Ihse Bursie wrote:
> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an
> attempt to remove all trailing whitespace from properties files, and enable a
> jcheck verification that they did not come back, similar to other source
>
On Mon, 16 Jan 2023 17:22:36 GMT, Roger Riggs wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains two commits:
>>
>> - Merge branch 'master' into properties-eol-clean-safe
>> - 8298047: Remove all non-si
On Mon, 16 Jan 2023 14:57:33 GMT, Tejesh R wrote:
>> FileChooser Open/Approve button size is shown incorrectly when no Approve
>> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
>> Approve Button text is returned during Dialog Type Property change. Since
>> `null` is r
On Mon, 16 Jan 2023 13:49:23 GMT, Tejesh R wrote:
>> In Aqua look and feel, `getDefaultButton()` of `JFileChooser` returns null.
>> The fix overrides the method from `FileChooserUI` to return the
>> `ApproveButton` of `FileChooser` which is similar to other L&F.
>> The test is run for multiple
On Mon, 16 Jan 2023 16:50:06 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an
>> attempt to remove all trailing whitespace from properties files, and enable
>> a jcheck verification that they did not come back, similar to other sourc
On Mon, 16 Jan 2023 16:29:31 GMT, Archie L. Cobbs wrote:
> It looks like you might be counting the "here via invocation" lines as
> separate warnings. These are really part of the previous `possible 'this'
> escape` line, e.g.:
yes, I really did the simplest possible thing (e.g. just counting
On Fri, 2 Dec 2022 17:06:23 GMT, Magnus Ihse Bursie wrote:
> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an
> attempt to remove all trailing whitespace from properties files, and enable a
> jcheck verification that they did not come back, similar to other source
>
> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an
> attempt to remove all trailing whitespace from properties files, and enable a
> jcheck verification that they did not come back, similar to other source
> code. It turned out that this was not so simple, however, si
On Mon, 16 Jan 2023 12:51:49 GMT, Maurizio Cimadamore
wrote:
>> The number of times around any single loop is bounded by the number of new
>> references that can possibly be created during the analysis of that loop.
>>
>> That number is at most 2 * (1 + 1 + 1 + 1 + N) where N is the number of
On Mon, 16 Jan 2023 14:57:33 GMT, Tejesh R wrote:
>> FileChooser Open/Approve button size is shown incorrectly when no Approve
>> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
>> Approve Button text is returned during Dialog Type Property change. Since
>> `null` is r
On Mon, 16 Jan 2023 11:53:40 GMT, Maurizio Cimadamore
wrote:
>> Archie L. Cobbs has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix bug where field initializer warnings could be incorrectly suppressed.
>> - Consolidate all the unit t
The test javax/swing/text/html/parser/Parser/8078268/bug8078268.java has a
latch timeout that is currently fix but should better be configurable to better
deal with slow test infrastructures.
-
Commit messages:
- JDK-8300205
Changes: https://git.openjdk.org/jdk/pull/12011/files
W
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is returned as Button string the Button size is incorrectly
On Mon, 16 Jan 2023 14:20:30 GMT, Tejesh R wrote:
>> FileChooser Open/Approve button size is shown incorrectly when no Approve
>> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
>> Approve Button text is returned during Dialog Type Property change. Since
>> `null` is r
This is somewhat a continuation of #11104 where the issue was discussed and
where I found [the root
cause](https://github.com/openjdk/jdk/pull/11104#issuecomment-1382435784).
**Root Cause**
The icon extraction code compares the returned handle to zero:
https://github.com/openjdk/jdk/blob/8cb25
On Mon, 16 Jan 2023 13:49:23 GMT, Tejesh R wrote:
>> In Aqua look and feel, `getDefaultButton()` of `JFileChooser` returns null.
>> The fix overrides the method from `FileChooserUI` to return the
>> `ApproveButton` of `FileChooser` which is similar to other L&F.
>> The test is run for multiple
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is returned as Button string the Button size is incorrectly
On Mon, 16 Jan 2023 13:38:32 GMT, Tejesh R wrote:
> > It's exactly the point: **include Aqua L&F in #11901**. The Aqua L&F is
> > excluded only because `getDefaultButton` returns null, isn't it? This fix
> > makes it return non-null, therefore Aqua L&F can be included in testing.
> >
> > This f
On Mon, 16 Jan 2023 13:33:04 GMT, Alexey Ivanov wrote:
> > > This case is entirely covered by the test in #11901 for
> > > [JDK-8299522](https://bugs.openjdk.org/browse/JDK-8299522), which also
> > > ensures the button text isn't empty.
> > > Adding 8300084 to the `@bug` tag in that test is eno
On Mon, 16 Jan 2023 13:04:27 GMT, Tejesh R wrote:
>> In Aqua look and feel, `getDefaultButton()` of `JFileChooser` returns null.
>> The fix overrides the method from `FileChooserUI` to return the
>> `ApproveButton` of `FileChooser` which is similar to other L&F.
>> The test is run for multiple
> In Aqua look and feel, `getDefaultButton()` of `JFileChooser` returns null.
> The fix overrides the method from `FileChooserUI` to return the
> `ApproveButton` of `FileChooser` which is similar to other L&F.
> The test is run for multiple iterations in CI machine.
Tejesh R has updated the pul
On Mon, 16 Jan 2023 13:04:27 GMT, Tejesh R wrote:
>> In Aqua look and feel, `getDefaultButton()` of `JFileChooser` returns null.
>> The fix overrides the method from `FileChooserUI` to return the
>> `ApproveButton` of `FileChooser` which is similar to other L&F.
>> The test is run for multiple
On Mon, 16 Jan 2023 12:18:18 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JFileChooser/AquaDefaultButtonTest.java line 48:
>>
>>> 46: if (defaultApproveButton == null) {
>>> 47: throw new RuntimeException("getDefaultButton()
>>> method returns null for A
> In Aqua look and feel, `getDefaultButton()` of `JFileChooser` returns null.
> The fix overrides the method from `FileChooserUI` to return the
> `ApproveButton` of `FileChooser` which is similar to other L&F.
> The test is run for multiple iterations in CI machine.
Tejesh R has updated the pul
On Mon, 16 Jan 2023 11:40:00 GMT, Alexey Ivanov wrote:
>
> Looks good to me.
>
> I doubt a separate test for this issue is worth it. This case is entirely
> covered by the test in #11901 for
> [JDK-8299522](https://bugs.openjdk.org/browse/JDK-8299522), which also
> ensures the button text
On Fri, 13 Jan 2023 21:28:51 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java
>> line 1088:
>>
>>> 1086: private void visitLooped(T tree, Consumer
>>> visitor) {
>>> 1087: visitScoped(tree, false, t -> {
>>> 1088:
On Tue, 11 Oct 2022 14:17:42 GMT, Manukumar V S wrote:
> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS
> machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as
> adding some stability improvements fixes the issue. It intermittently fails
> in CI
On Mon, 16 Jan 2023 11:33:39 GMT, Alexey Ivanov wrote:
>> In Aqua look and feel, `getDefaultButton()` of `JFileChooser` returns null.
>> The fix overrides the method from `FileChooserUI` to return the
>> `ApproveButton` of `FileChooser` which is similar to other L&F.
>> The test is run for mul
On Fri, 13 Jan 2023 22:48:59 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Mon, 16 Jan 2023 11:17:10 GMT, Tejesh R wrote:
> In Aqua look and feel, `getDefaultButton()` of `JFileChooser` returns null.
> The fix overrides the method from `FileChooserUI` to return the
> `ApproveButton` of `FileChooser` which is similar to other L&F.
> The test is run for multiple ite
In Aqua look and feel, `getDefaultButton()` of `JFileChooser` returns null. The
fix overrides the method from `FileChooserUI` to return the `ApproveButton` of
`FileChooser` which is similar to other L&F.
The test is run for multiple iterations in CI machine.
-
Commit messages:
- f
On Wed, 14 Dec 2022 04:59:56 GMT, Prasanta Sadhukhan
wrote:
> Label.foreground UIProperty is not honored by Nimbus L&F. It needs to be
> Label[Enabled].textForeground which is the corresponding Synth property
> Added support for setting JLabel foreground color for Nimbus L&F
This pull request
On Sat, 14 Jan 2023 07:23:18 GMT, Sergey Bylokhov wrote:
> Currently, we always validate image layouts passed from java to native,
> except for some types of rasters. One of the reasons why the rasters are
> skipped is that they are not public and have their own validation during
> constructio
On Mon, 16 Jan 2023 08:56:13 GMT, Jie Fu wrote:
> Mainly caused by files under `src/java.base/share/native/libzip/zlib/`. I'm
> not sure if there is already a bug report to the upstream.
Maybe this one:
https://github.com/madler/zlib/issues/633
-
PR: https://git.openjdk.org/jdk/pu
On Mon, 16 Jan 2023 08:51:34 GMT, Jie Fu wrote:
> For the libzip issues, are these in the native methods or when compiling the
> zlib code, just wondering if there are bug reports for upstream there too.
Mainly caused by files under `src/java.base/share/native/libzip/zlib/`.
I'm not sure if the
On Mon, 16 Jan 2023 08:21:47 GMT, Alan Bateman wrote:
> Is there a list of the issues building libjli? I don't see the in the PR or
> the JBS issue. For the libzip issues, are these in the native methods or when
> compiling the zlib code, just wondering if there are bug reports for upstream
>
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> It occurred while building LIBJLI, LIBZIP and LIBSPLASHSCREEN.
Is there a list of the issues building libjli? I don't see the in the PR or the
JBS issue. For the libzip issues, are these in the native methods or when
compiling the zlib code, ju
Currently, we always validate image layouts passed from java to native, except
for some types of rasters. One of the reasons why the rasters are skipped is
that they are not public and have their own validation during construction. But
it is unclear how it works in the multithreaded case. All th
58 matches
Mail list logo
