Issue is observed that after changing the Look & Feel from Metal to Nimbus and
back to Metal, the Nimbus font continues to be used by a JFileChooser.
This is because Synth `installDefaults `methods set the font, but its inverse
methods `uninstallDefaults `do not remove them.
Fix is made to
On Wed, 25 Jan 2023 06:41:19 GMT, Prasanta Sadhukhan
wrote:
> Test intermittently failed in CI macos system owing to robot screencapture
> failing to compare the images.
> Seems like from artifacts, that composite image created by robot contains
> mouse cursor, which when compared are not
Test intermittently failed in CI macos system owing to robot screencapture
failing to compare the images.
Seems like from artifacts, that composite image created by robot contains mouse
cursor, which when compared are not giving exact pixel color. This has occurred
in the past also for some
On Fri, 9 Dec 2022 08:06:43 GMT, Prasanta Sadhukhan
wrote:
> In Swingset2 JInternalFrame demo, focusing on any internalframes and pressing
> Ctrl+F7 and then any of up/down/left/arrow key to move the internal frames
> results in NPE in NimbusL
> It is because `JComponent.processKeyBinding()
On Mon, 12 Dec 2022 13:06:09 GMT, Alexey Ivanov wrote:
>> Looks good to me.
>>
>> In the description above: “…invoked one per property…”, it shoud be “once”.
>>
>> I think there's room for improvement. However, this is an internal-only
>> class.
>
>> I think there's room for improvement.
On Tue, 24 Jan 2023 20:14:20 GMT, Alisen Chung wrote:
>> Removed check for MapVirtualKeyEx return value causing some keys to become
>> undefined
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> readded check for dead key
On Wed, 28 Dec 2022 00:10:53 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8296661 : Typo Found In
>> CSSParser.java](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661)
>>
>> This is tracked in JBS as
>> - [JDK-8296661 : Typo Found In
>>
On Thu, 13 Oct 2022 01:48:45 GMT, Toshio Nakamura wrote:
> When JEditorPane shown HTML form with multi-selection, the reset operation
> broke its data.
>
> The sample testcase were attached in JBS. The recreate steps are below:
> 1. The sample shows a multi-selection form with 5 items.
> 2.
On Wed, 25 Jan 2023 00:13:02 GMT, Sergey Bylokhov wrote:
> I do not think that this method should/must be used by custom L only, it is
> a way to provide custom styles for an existing L including Nimbus like
> discussed here:
>
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last
On Tue, 24 Jan 2023 23:29:58 GMT, Phil Race wrote:
> SynthLookAndFeel.load(URL) is problematic because applications need to trust
> the URL.
> As documented in the bug report there are alternative mechanisms and JDK
> itself has not used this for the two Synth based L : Nimbus and GTK.
> So
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last
On Tue, 24 Jan 2023 23:16:02 GMT, Alexey Semenyuk wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change localization codes. Add CNY back
>
>
On Tue, 24 Jan 2023 22:55:43 GMT, Alexey Semenyuk wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change German help of jar command
>
>
On Tue, 24 Jan 2023 23:02:58 GMT, Justin Lu wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change localization codes. Add CNY back
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_ja.properties
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Revert culture attribute
-
Changes:
-
SynthLookAndFeel.load(URL) is problematic because applications need to trust
the URL.
As documented in the bug report there are alternative mechanisms and JDK itself
has not used this for the two Synth based L : Nimbus and GTK.
So deprecating - for removal - and adding warnings now in the docs
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Remove trailing whitespace
-
Changes:
-
On Tue, 11 Oct 2022 00:25:04 GMT, Damon Nguyen wrote:
>>> > Can we move the test file to one directory back as we are doing it in
>>> > swing test fix. Means moving the test to Multscreen folder, instead of
>>> > MultiScreenLocationTest.?
>>>
>>> I second this. The test can sit inside the
> Fixed test bug where mouse location was being calculated before robot
> mouseMove operation was complete
Alisen Chung has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last
On Tue, 24 Jan 2023 20:12:44 GMT, Andrey Turbanov wrote:
> Oof... Approach for synchronization in `BeanContextServicesSupport` is
> confusing for me and inconsistent. Do you know why read access to `children`
> is not syncrhonized in `java.beans.beancontext.BeanContextSupport#add` ?
>
>
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last
On Tue, 24 Jan 2023 22:49:20 GMT, Naoto Sato wrote:
>> This change was made because it was compared to the original
>> messages.properties. In that file, the respective line is given as
>> `MANAGE_HOTSPOT_MBEANS_IN_COLON_=Manage Hotspot MBeans in:` with no trailing
>> space. That's why in
On Tue, 24 Jan 2023 22:40:55 GMT, Justin Lu wrote:
>> OK, I can make the manual edit for this
>
> This change was made because it was compared to the original
> messages.properties. In that file, the respective line is given as
> `MANAGE_HOTSPOT_MBEANS_IN_COLON_=Manage Hotspot MBeans in:` with
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last
On Tue, 24 Jan 2023 19:39:38 GMT, Attila Szegedi wrote:
>> src/java.desktop/share/classes/java/awt/image/Raster.java line 372:
>>
>>> 370: for (int i = 0; i < bands; i++) {
>>> 371: bankIndices[i] = i;
>>> 372: bandOffsets[i] = 0;
>>
>> I suggest to comment this
On Tue, 29 Nov 2022 10:36:32 GMT, Alexander Scherbatiy
wrote:
>> A printed content is truncated on macOS if the content paper size width
>> larger than height with portrait orientation or width is less than height
>> with landscape orientation.
>>
>> To reproduce the issue run the
>>
On Tue, 24 Jan 2023 22:20:22 GMT, Damon Nguyen wrote:
>> src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties
>> line 174:
>>
>>> 172:
>>> MBEANS_TAB_UNSUBSCRIBE_NOTIFICATIONS_BUTTON=\u53D6\u6D88\u8BA2\u9605()
>>> 173:
>>>
On Tue, 24 Jan 2023 22:12:26 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last
On Tue, 24 Jan 2023 22:14:36 GMT, Naoto Sato wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change localization codes. Add CNY back
>
>
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Change localization codes. Add CNY back
-
On Tue, 24 Jan 2023 22:12:02 GMT, Naoto Sato wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change German help of jar command
>
>
On Tue, 24 Jan 2023 22:05:55 GMT, Naoto Sato wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change German help of jar command
>
>
On Tue, 24 Jan 2023 22:12:26 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Change German help of jar command
-
On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen wrote:
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
jdk.console and jdk.management.agent changes look good.
-
Marked as reviewed by cjplummer
On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen wrote:
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
@magicus @LanceAndersen @jonathan-gibbons @pavelrappo @dougxc @lahodaj
Could you review the changes from this
On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen wrote:
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
@prrace @wangweij @naotoj @JoeWang-Java @plummercj @alexeysemenyukoracle
Could you review the changes from this
Open l10n drop. Files have been updated with translated versions. Whitespace
tool has been ran on files.
All tests passed
-
Commit messages:
- Remove currency symbol entries
- Remove whitespace using tool
- Remove double quotes generated by translation tool
- Revert
On Tue, 24 Jan 2023 03:15:50 GMT, Sergey Bylokhov wrote:
> Two methods in the BeanContextSupport class use two locks in a different
> order, which can cause a deadlock.
>
> Here is the first order: (1) first acquire BeanContext.globalHierarchyLock
> and then children:
>
> enter public
> Removed check for MapVirtualKeyEx return value causing some keys to become
> undefined
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
readded check for dead key leading bit, added separate check for group
separator
On Tue, 24 Jan 2023 16:25:46 GMT, Sergey Bylokhov wrote:
>> No need to fill elements of array with default values if it was just
>> created. Java guarantees that all elements of numeric array have default
>> values after allocations - 0.
>
>
On Tue, 24 Jan 2023 16:25:46 GMT, Sergey Bylokhov wrote:
>> No need to fill elements of array with default values if it was just
>> created. Java guarantees that all elements of numeric array have default
>> values after allocations - 0.
>
>
On Tue, 24 Jan 2023 16:22:43 GMT, Sergey Bylokhov wrote:
>> No need to fill elements of array with default values if it was just
>> created. Java guarantees that all elements of numeric array have default
>> values after allocations - 0.
>
>
On Wed, 9 Nov 2022 09:42:00 GMT, Artem Semenov wrote:
>> A11Y implementation on macOS has to directly call the
>> 'JList.setSelectedIndex' method in order to request selection on an item
>> (see 'CAccessibility.requestSelection'). The reason is that a11y API lacks
>> appropriate
On Mon, 23 Jan 2023 17:20:41 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with default values if it was just created.
> Java guarantees that all elements of numeric array have default values after
> allocations - 0.
On Mon, 23 Jan 2023 17:20:41 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with default values if it was just created.
> Java guarantees that all elements of numeric array have default values after
> allocations - 0.
Marked as reviewed by attila (Reviewer).
-
Two methods in the BeanContextSupport class use two locks in a different order,
which can cause a deadlock.
Here is the first order: (1) first acquire BeanContext.globalHierarchyLock and
then children:
enter public method remove(Object) at line 484
call remove(Object, boolean) at line
50 matches
Mail list logo
