On Fri, 27 Jan 2023 13:26:28 GMT, Andrey Turbanov wrote:
> There is only add/iterator calls on this list. No removes from the head or
> something like this. Not sure why LinkedList was used, but ArrayList should
> be preferred as more efficient and widely used (more chances for JIT)
> collecti
On Fri, 27 Jan 2023 13:26:28 GMT, Andrey Turbanov wrote:
> There is only add/iterator calls on this list. No removes from the head or
> something like this. Not sure why LinkedList was used, but ArrayList should
> be preferred as more efficient and widely used (more chances for JIT)
> collecti
On Fri, 10 Feb 2023 16:58:02 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 70:
>>
>>> 68: System.out.println("current font " + curFont);
>>> 69: if ((curFont != null && !curFont.equals(origFont))
>>>
On Fri, 10 Feb 2023 16:08:56 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add both null check
>
> test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 70:
>
>> 68:
> SwingWorker done() method [spec
> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452)
> says "Executed on the Event Dispatch Thread after the doInBackground method
> is finished"
> but there's no mechanism in place to honor that claim.
On Fri, 10 Feb 2023 15:26:33 GMT, Prasanta Sadhukhan
wrote:
> I have tried alignment to the extent possible..
Not to the extent possible if it's different from the commonly used style.
> I am not sure if it's required to be so finicky about it :-)
It's probably not. However, the code which us
On Fri, 10 Feb 2023 16:00:56 GMT, Prasanta Sadhukhan
wrote:
>> Issue is observed that after changing the Look & Feel from Metal to Nimbus
>> and back to Metal, the Nimbus font continues to be used by a JFileChooser.
>> This is because Synth `installDefaults `methods set the font, but its
>> i
> Issue is observed that after changing the Look & Feel from Metal to Nimbus
> and back to Metal, the Nimbus font continues to be used by a JFileChooser.
> This is because Synth `installDefaults `methods set the font, but its
> inverse methods `uninstallDefaults `do not remove them.
> Fix is mad
On Fri, 10 Feb 2023 15:02:22 GMT, Prasanta Sadhukhan
wrote:
>> SwingWorker done() method [spec
>> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452)
>> says "Executed on the Event Dispatch Thread after the doInBackground method
>> is
> SwingWorker done() method [spec
> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452)
> says "Executed on the Event Dispatch Thread after the doInBackground method
> is finished"
> but there's no mechanism in place to honor that claim.
On Fri, 10 Feb 2023 11:44:35 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 69:
>>
>>> 67: Font curFont = fc.getFont();
>>> 68: System.out.println("current font " + curFont);
>>> 69:
On Fri, 10 Feb 2023 14:49:00 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java line 29:
>>
>>> 27: * before the 'doInBackground' is finished
>>> 28: * @run main TestDoneBeforeDoInBackground
>>> 29: */
>>
>> May I ask you to move t
On Fri, 10 Feb 2023 15:02:22 GMT, Prasanta Sadhukhan
wrote:
>> SwingWorker done() method [spec
>> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452)
>> says "Executed on the Event Dispatch Thread after the doInBackground method
>> is
> SwingWorker done() method [spec
> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452)
> says "Executed on the Event Dispatch Thread after the doInBackground method
> is finished"
> but there's no mechanism in place to honor that claim.
On Fri, 10 Feb 2023 14:31:59 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix and test updated
>> - Fix and test updated
>
> test/jdk/javax/swing/SwingWorker/TestDoneBeforeDoInBackgro
> SwingWorker done() method [spec
> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452)
> says "Executed on the Event Dispatch Thread after the doInBackground method
> is finished"
> but there's no mechanism in place to honor that claim.
On Fri, 10 Feb 2023 11:46:22 GMT, Prasanta Sadhukhan
wrote:
>> SwingWorker done() method [spec
>> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452)
>> says "Executed on the Event Dispatch Thread after the doInBackground method
>> is
On Fri, 10 Feb 2023 11:46:22 GMT, Prasanta Sadhukhan
wrote:
>> SwingWorker done() method [spec
>> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452)
>> says "Executed on the Event Dispatch Thread after the doInBackground method
>> is
On Fri, 10 Feb 2023 11:46:22 GMT, Prasanta Sadhukhan
wrote:
>> SwingWorker done() method [spec
>> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452)
>> says "Executed on the Event Dispatch Thread after the doInBackground method
>> is
On Thu, 9 Feb 2023 20:45:58 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update test
>
> test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 69:
>
>> 67:
> SwingWorker done() method [spec
> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452)
> says "Executed on the Event Dispatch Thread after the doInBackground method
> is finished"
> but there's no mechanism in place to honor that claim.
21 matches
Mail list logo
