Withdrawn: 4365952: Cannot disable JFileChooser

2023-03-17 Thread duke
On Wed, 7 Dec 2022 05:48:57 GMT, Tejesh R wrote: > Disable functionality not working for JFileChooser. `public void > setEnabled(boolean enabled)` functionality is overridden in JFileChooser > class which enable/disable each sub-component of FileChooser. > The added functionality is tested in

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v5]

2023-03-17 Thread Justin Lu
> This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the > .properties files as UTF-8 during the conversion

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v4]

2023-03-17 Thread Weijun Wang
On Fri, 17 Mar 2023 21:49:33 GMT, Weijun Wang wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adjust CF test to read in with UTF-8 to fix failing test > >

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v4]

2023-03-17 Thread Weijun Wang
On Fri, 17 Mar 2023 20:28:13 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support reading in

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v4]

2023-03-17 Thread Naoto Sato
On Fri, 17 Mar 2023 20:31:27 GMT, Andy Goryachev wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adjust CF test to read in with UTF-8 to fix failing test > >

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v4]

2023-03-17 Thread Andy Goryachev
On Fri, 17 Mar 2023 20:28:13 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support reading in

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v4]

2023-03-17 Thread Justin Lu
> This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the > .properties files as UTF-8 during the conversion

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v2]

2023-03-17 Thread Artem Semenov
On Fri, 17 Mar 2023 08:51:50 GMT, Andrey Turbanov wrote: >> Artem Semenov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update >> - I suppose that adding @Native to AccessibleAnnouncer constants would >> simplify the code > >

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v2]

2023-03-17 Thread Artem Semenov
> This enhancement covers basic API and shared code that should be implemented > for the Accessibility Announcement feature. Artem Semenov has updated the pull request incrementally with two additional commits since the last revision: - update - I suppose that adding @Native to

Re: RFR: 8302558: Editable JComboBox 's popup blocks user from seeing characters in Acq look and feel [v6]

2023-03-17 Thread Damon Nguyen
> The issue is in Aqua L when an editable JComboBox with a border is used. In > this case, when the comboBox is clicked for the drop-down menu to show, the > drop-down menu appears at the wrong coordinates (blocking the text of the > comboBox and making it unreadable). > > This seems to have

Re: RFR: 8302558: Editable JComboBox 's popup blocks user from seeing characters in Acq look and feel [v5]

2023-03-17 Thread Damon Nguyen
On Fri, 17 Mar 2023 04:24:42 GMT, Prasanta Sadhukhan wrote: >> @azvegint In reference to the combobox's button, the email I got back from >> Apple says "in Aqua, there is no concept of a non editable Combo Box... what >> you are depicting as a JComboBox is actually a popup/pulldown". However,

RFR: JDK-8304334: java/awt/color/ICC_ColorSpace/ToFromCIEXYZRoundTrip.java times out on slow platforms

2023-03-17 Thread Matthias Baesken
The ToFromCIEXYZRoundTrip test times out on slow platforms , especially when (fast)debug binaries are used. This was observed on Alpine Linux and AIX in our automated tests. Setting an increased timeout for the test helps to reduce test errors because of timeouts. - Commit

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature

2023-03-17 Thread Andrey Turbanov
On Mon, 13 Mar 2023 16:46:10 GMT, Artem Semenov wrote: > This enhancement covers basic API and shared code that should be implemented > for the Accessibility Announcement feature. test/jdk/java/awt/a11y/AccessibleAnnouncerTest.java line 127: > 125: } > 126: > 127: public static void

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v2]

2023-03-17 Thread 柳鲲鹏
On Thu, 16 Mar 2023 08:33:35 GMT, 柳鲲鹏 wrote: >> JDK-8264728 : When use chinese IME, the candidate box isn't moved with caret >> of JTextArea >> Type: Bug >> Component: client-libs >> Sub-Component: java.awt:i18n >> Affected Version: 8,9,15,16 >> Priority: P3 >> Status: Open >> Resolution:

Re: RFR: 8257455: javax/swing/Security/6378709/TimerHack.java and javax/swing/JFileChooser/4163841/AcceptAllFileFilterTest.java fails in CI

2023-03-17 Thread Tejesh R
On Wed, 15 Mar 2023 21:36:31 GMT, Sergey Bylokhov wrote: >> The issue is intermittent and was not able to reproduce it. Though through >> code analysis and bug reported logs, the issue seems to be in COM thread of >> `FilesLoader` class in `BasicDirectoryModel` file. Looks like there are >>