Re: RFR: 8316218: Open some swing tests 5

2023-09-25 Thread Logan Abernathy
On Thu, 21 Sep 2023 21:36:52 GMT, Alisen Chung wrote: > Opening some swing tests: > 16 javax/swing/plaf/metal/MetalBorders/4290656/bug4290656.java > 17 javax/swing/plaf/metal/MetalInternalFrameTitlePane/4221007/bug4221007.java > 18 > javax/swing/plaf/metal/isJavaLAFLockedCorrectly/isJavaLAFLocke

Re: RFR: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java

2023-09-25 Thread Logan Abernathy
On Fri, 22 Sep 2023 06:20:42 GMT, Christoph Langer wrote: > Exclude java/awt/font/Rotate/RotatedTextTest.java until > [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The > error shows in several linux installations. Marked as reviewed by m4ximumpi...@github.com (no known O

Integrated: 8313220: Remove Windows specific workaround in LCMS.c for _snprintf

2023-09-25 Thread Sergey Bylokhov
On Wed, 23 Aug 2023 00:42:47 GMT, Sergey Bylokhov wrote: > This patch addresses two issues: > * For Windows: The snprintf is available with Visual Studio 2015 and above, > so we do not need to use the windows speciific "_snprintf". We also do not > need to set a zero at the end of the string s

Re: RFR: 8316146: Open some swing tests 4 [v3]

2023-09-25 Thread Alisen Chung
> Opening closed tests: > 12 javax/swing/ToolTipManager/5078214/bug5078214.java > 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java > 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java > 15 javax/swing/plaf/metal/4306431/bug4306431.java Alisen Chung has updated the pull

Re: RFR: 8316146: Open some swing tests 4 [v2]

2023-09-25 Thread Alisen Chung
On Mon, 25 Sep 2023 11:57:18 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - updated tests based on feedback >> - updated tests > > test/jdk/javax/swing/BasicMenuUI/bug4244616.java line 67: >

Integrated: 8312191: ColorConvertOp.filter for the default destination is too slow

2023-09-25 Thread Sergey Bylokhov
On Mon, 17 Jul 2023 20:59:05 GMT, Sergey Bylokhov wrote: > I have found that MTPerLineTransformValidation - one of our slowest stress > test spends most of the time not in the code related to the colors > conversion(as it was intended) but in the initialization of the native > cmm-transforms.

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-25 Thread Alexander Zvegintsev
On Mon, 25 Sep 2023 16:43:57 GMT, Alexey Ivanov wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > test/jdk/javax/swing/JFrame/DefaultCloseOperation.java line 1: > >> 1: /* > > I wonder i

Re: RFR: 8316211: Open source several manual applet tests [v4]

2023-09-25 Thread Alexander Zvegintsev
> Open sourcing several manual applet tests > > > test/jdk/java/awt/Frame/DefaultSizeTest.java > test/jdk/java/awt/LightweightComponent/LightweightCliprect.java > test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java > test/jdk/javax/swing/JFrame/DefaultCloseOperation.java Alexander Zvegintsev h

Re: RFR: 8316389: Open source few AWT applet tests [v7]

2023-09-25 Thread Alexey Ivanov
On Mon, 25 Sep 2023 18:31:04 GMT, Alexander Zvegintsev wrote: >> Open sourcing few tests: >> >> java/awt/Frame/FrameRepackTest.java >> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java >> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java >> java/awt/Frame/WindowMoveTest.java > > Alexand

Re: RFR: 8316412: javax/print tests fail without printer set up

2023-09-25 Thread Phil Race
On Tue, 19 Sep 2023 14:45:47 GMT, Michal Sobierski wrote: > For NullClipARGB we are throwing SkippedException only if instance of caught > exception is PrinterException. All other exceptions are considered unrelated > to printer configuration. > > For CountPrintServices we want to throw Skippe

Integrated: 8315871: Opensource five more Swing regression tests

2023-09-25 Thread Alexander Zuev
On Wed, 13 Sep 2023 08:48:25 GMT, Alexander Zuev wrote: > Clean up and move to open source five tests. > javax/swing/AncestorNotifier/4817630/bug4817630.java > javax/swing/BoxLayout/4191948/bug4191948.java > javax/swing/ComponentInputMap/4248723/bug4248723.java > javax/swing/DefaultBoundedRangeMo

Re: RFR: 8316389: Open source few AWT applet tests [v7]

2023-09-25 Thread Alexander Zvegintsev
> Open sourcing few tests: > > java/awt/Frame/FrameRepackTest.java > java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java > java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java > java/awt/Frame/WindowMoveTest.java Alexander Zvegintsev has updated the pull request incrementally with one additio

Re: RFR: 8315871: Opensource five more Swing regression tests [v3]

2023-09-25 Thread Phil Race
On Mon, 25 Sep 2023 18:02:45 GMT, Alexander Zuev wrote: >> Clean up and move to open source five tests. >> javax/swing/AncestorNotifier/4817630/bug4817630.java >> javax/swing/BoxLayout/4191948/bug4191948.java >> javax/swing/ComponentInputMap/4248723/bug4248723.java >> javax/swing/DefaultBoundedRa

Integrated: 8313403: Remove unused 'mask' field from JFormattedTextField

2023-09-25 Thread Alexey Ivanov
On Mon, 31 Jul 2023 10:26:44 GMT, Alexey Ivanov wrote: > The private field `mask` is never used in `JFormattedTextField`. > > I couldn't find any usages of the field, including JNI. Therefore, it is safe > to remove. This pull request has now been integrated. Changeset: b65f4f72 Author:Al

Re: RFR: 8316371: Open some swing tests 6 [v2]

2023-09-25 Thread Damon Nguyen
On Mon, 25 Sep 2023 15:48:11 GMT, Alisen Chung wrote: >> Opening some closed tests: >> 20 javax/swing/plaf/windows/4736093/bug4736093.java >> 21 javax/swing/table/DefaultTableCellRenderer/4240870/bug4240870.java >> 22 javax/swing/table/JTableHeader/4243927/bug4243927.java >> 23 javax/swing/text/A

Re: RFR: 8316389: Open source few AWT applet tests [v6]

2023-09-25 Thread Phil Race
On Mon, 25 Sep 2023 17:33:35 GMT, Alexey Ivanov wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > test/jdk/java/awt/Frame/WindowMoveTest.java line 57: > >> 55: frame.dispa

Re: RFR: 8315871: Opensource five more Swing regression tests [v2]

2023-09-25 Thread Alexander Zuev
On Thu, 14 Sep 2023 21:45:31 GMT, Damon Nguyen wrote: >> Alexander Zuev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update test/jdk/javax/swing/AncestorNotifier/4817630/bug4817630.java >> >>Co-authored-by: Andrey Turbanov

Re: RFR: 8315871: Opensource five more Swing regression tests [v2]

2023-09-25 Thread Alexander Zuev
On Thu, 14 Sep 2023 15:27:48 GMT, Alexander Zuev wrote: >> Clean up and move to open source five tests. >> javax/swing/AncestorNotifier/4817630/bug4817630.java >> javax/swing/BoxLayout/4191948/bug4191948.java >> javax/swing/ComponentInputMap/4248723/bug4248723.java >> javax/swing/DefaultBoundedRa

Re: RFR: 8315871: Opensource five more Swing regression tests [v3]

2023-09-25 Thread Alexander Zuev
> Clean up and move to open source five tests. > javax/swing/AncestorNotifier/4817630/bug4817630.java > javax/swing/BoxLayout/4191948/bug4191948.java > javax/swing/ComponentInputMap/4248723/bug4248723.java > javax/swing/DefaultBoundedRangeModel/4297953/bug4297953.java > javax/swing/DefaultButtonMod

Re: RFR: 8316371: Open some swing tests 6 [v2]

2023-09-25 Thread Phil Race
On Mon, 25 Sep 2023 15:48:11 GMT, Alisen Chung wrote: >> Opening some closed tests: >> 20 javax/swing/plaf/windows/4736093/bug4736093.java >> 21 javax/swing/table/DefaultTableCellRenderer/4240870/bug4240870.java >> 22 javax/swing/table/JTableHeader/4243927/bug4243927.java >> 23 javax/swing/text/A

Re: RFR: 8316389: Open source few AWT applet tests [v4]

2023-09-25 Thread Alexey Ivanov
On Mon, 25 Sep 2023 16:46:26 GMT, Alexander Zvegintsev wrote: >> test/jdk/java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java line 62: >> >>> 60: .build(); >>> 61: >>> 62: SwingUtilities.invokeAndWait(() -> { >> >> Suggestion: >> >> EventQueue.invokeAndWait(

Re: RFR: 8316389: Open source few AWT applet tests [v6]

2023-09-25 Thread Alexey Ivanov
On Mon, 25 Sep 2023 17:21:13 GMT, Alexander Zvegintsev wrote: >> Open sourcing few tests: >> >> java/awt/Frame/FrameRepackTest.java >> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java >> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java >> java/awt/Frame/WindowMoveTest.java > > Alexand

Re: RFR: 8316218: Open some swing tests 5

2023-09-25 Thread Damon Nguyen
On Thu, 21 Sep 2023 21:36:52 GMT, Alisen Chung wrote: > Opening some swing tests: > 16 javax/swing/plaf/metal/MetalBorders/4290656/bug4290656.java > 17 javax/swing/plaf/metal/MetalInternalFrameTitlePane/4221007/bug4221007.java > 18 > javax/swing/plaf/metal/isJavaLAFLockedCorrectly/isJavaLAFLocke

Re: RFR: 8316389: Open source few AWT applet tests [v4]

2023-09-25 Thread Alexey Ivanov
On Mon, 25 Sep 2023 16:48:51 GMT, Alexander Zvegintsev wrote: >> test/jdk/java/awt/Frame/FrameRepackTest.java line 134: >> >>> 132: north.setLayout(new BorderLayout(2, 2)); >>> 133: north.add("North", new Label(" This panel is always >>> displayed")); >>> 134: north.add

Re: RFR: 8316389: Open source few AWT applet tests [v5]

2023-09-25 Thread Alexander Zvegintsev
On Mon, 25 Sep 2023 15:35:03 GMT, Alexey Ivanov wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> space removed > > test/jdk/java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java line 94: > >> 92: c.

Re: RFR: 8316389: Open source few AWT applet tests [v4]

2023-09-25 Thread Alexander Zvegintsev
On Mon, 25 Sep 2023 15:12:27 GMT, Alexey Ivanov wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> space added > > test/jdk/java/awt/Frame/FrameRepackTest.java line 134: > >> 132: north.setLayout(new

Re: RFR: 8316389: Open source few AWT applet tests [v6]

2023-09-25 Thread Alexander Zvegintsev
> Open sourcing few tests: > > java/awt/Frame/FrameRepackTest.java > java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java > java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java > java/awt/Frame/WindowMoveTest.java Alexander Zvegintsev has updated the pull request incrementally with one additio

Re: RFR: 8312191: ColorConvertOp.filter for the default destination is too slow [v2]

2023-09-25 Thread Sergey Bylokhov
> I have found that MTPerLineTransformValidation - one of our slowest stress > test spends most of the time not in the code related to the colors > conversion(as it was intended) but in the initialization of the native > cmm-transforms. > > > ColorConvertOp sharedOp = new ColorConvertOp(srcCS,

Re: RFR: 8313403: Remove unused 'mask' field from JFormattedTextField

2023-09-25 Thread Alexey Ivanov
On Wed, 20 Sep 2023 20:05:01 GMT, Phil Race wrote: > Swing isn't serializable across releases, so I see no need for a CSR. Thank you. That's what I thought. - PR Comment: https://git.openjdk.org/jdk/pull/15088#issuecomment-1734125157

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-25 Thread Alexey Ivanov
On Fri, 22 Sep 2023 15:43:18 GMT, Alexander Zvegintsev wrote: >> Open sourcing several manual applet tests >> >> >> test/jdk/java/awt/Frame/DefaultSizeTest.java >> test/jdk/java/awt/LightweightComponent/LightweightCliprect.java >> test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java >> test/j

Re: RFR: 8316371: Open some swing tests 6 [v2]

2023-09-25 Thread Alisen Chung
> Opening some closed tests: > 20 javax/swing/plaf/windows/4736093/bug4736093.java > 21 javax/swing/table/DefaultTableCellRenderer/4240870/bug4240870.java > 22 javax/swing/table/JTableHeader/4243927/bug4243927.java > 23 javax/swing/text/AbstractDocument/4549069/bug4549069.java > 24 javax/swing/text

Re: RFR: 8316389: Open source few AWT applet tests [v5]

2023-09-25 Thread Alexey Ivanov
On Mon, 25 Sep 2023 15:27:15 GMT, Alexander Zvegintsev wrote: >> Open sourcing few tests: >> >> java/awt/Frame/FrameRepackTest.java >> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java >> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java >> java/awt/Frame/WindowMoveTest.java > > Alexand

Re: RFR: 8316389: Open source few AWT applet tests [v4]

2023-09-25 Thread Alexey Ivanov
On Wed, 20 Sep 2023 16:55:30 GMT, Alexander Zvegintsev wrote: >> Open sourcing few tests: >> >> java/awt/Frame/FrameRepackTest.java >> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java >> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java >> java/awt/Frame/WindowMoveTest.java > > Alexand

Re: RFR: 8316389: Open source few AWT applet tests [v5]

2023-09-25 Thread Alexander Zvegintsev
> Open sourcing few tests: > > java/awt/Frame/FrameRepackTest.java > java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java > java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java > java/awt/Frame/WindowMoveTest.java Alexander Zvegintsev has updated the pull request incrementally with one additio

Re: RFR: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java

2023-09-25 Thread Alexey Ivanov
On Mon, 25 Sep 2023 13:29:09 GMT, Christoph Langer wrote: >> test/jdk/ProblemList.txt line 472: >> >>> 470: >>> 471: java/awt/font/Rotate/RotatedTextTest.java 8219641 linux-all >>> 472: >> >> Looks good to me, except for its placement: shouldn't it be placed close to >> other font tests? Sho

Re: RFR: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java

2023-09-25 Thread Christoph Langer
On Mon, 25 Sep 2023 10:35:21 GMT, Alexey Ivanov wrote: >> Exclude java/awt/font/Rotate/RotatedTextTest.java until >> [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The >> error shows in several linux installations. > > test/jdk/ProblemList.txt line 472: > >> 470: >> 471:

Re: RFR: 8316146: Open some swing tests 4 [v2]

2023-09-25 Thread Alexey Ivanov
On Sun, 24 Sep 2023 06:12:17 GMT, Alisen Chung wrote: >> Opening closed tests: >> 12 javax/swing/ToolTipManager/5078214/bug5078214.java >> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java >> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java >> 15 javax/swing/plaf/meta

Re: RFR: 8315804: Open source several Swing JTabbedPane JTextArea JTextField tests [v5]

2023-09-25 Thread Alexey Ivanov
On Mon, 18 Sep 2023 19:08:48 GMT, Damon Nguyen wrote: >> test/jdk/javax/swing/JTabbedPane/bug4703690.java line 54: >> >>> 52: static volatile boolean focusButtonTwo = false; >>> 53: static volatile boolean switchToTabTwo = false; >>> 54: static volatile boolean focusButtonOne = false

Re: RFR: 8316146: Open some swing tests 4 [v2]

2023-09-25 Thread Alexey Ivanov
On Sun, 24 Sep 2023 06:12:17 GMT, Alisen Chung wrote: >> Opening closed tests: >> 12 javax/swing/ToolTipManager/5078214/bug5078214.java >> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java >> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java >> 15 javax/swing/plaf/meta

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v3]

2023-09-25 Thread Alexey Ivanov
On Mon, 25 Sep 2023 06:53:49 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/JTableHeader/SerializeJTableHeader.java line 55: >> >>> 53: for (UIManager.LookAndFeelInfo laf : >>> UIManager.getInstalledLookAndFeels()) { >>> 54: System.out.println("Testing L&F: " + laf)

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v4]

2023-09-25 Thread Alexey Ivanov
On Mon, 25 Sep 2023 07:00:38 GMT, Prasanta Sadhukhan wrote: >> After the first time a JTableHeader is serialized, it no longer will >> uninstall its UI upon subsequent serializations. >> This happens for classes that use the BasicTableHeaderUI class. Any LAF that >> extends the BasicTableHeade

Re: RFR: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java

2023-09-25 Thread Alexey Ivanov
On Fri, 22 Sep 2023 06:20:42 GMT, Christoph Langer wrote: > Exclude java/awt/font/Rotate/RotatedTextTest.java until > [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The > error shows in several linux installations. test/jdk/ProblemList.txt line 472: > 470: > 471: java/a

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v3]

2023-09-25 Thread Prasanta Sadhukhan
On Fri, 22 Sep 2023 11:53:30 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> try-with-resource use > > test/jdk/javax/swing/JTableHeader/SerializeJTableHeader.java line 55: > >> 53:

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v4]

2023-09-25 Thread Prasanta Sadhukhan
> After the first time a JTableHeader is serialized, it no longer will > uninstall its UI upon subsequent serializations. > This happens for classes that use the BasicTableHeaderUI class. Any LAF that > extends the BasicTableHeaderUI like SynthTableHeaderUI and > WindowsTableHeaderUI will get an