Integrated: 8316146: Open some swing tests 4

2023-10-04 Thread Alisen Chung
On Thu, 21 Sep 2023 22:00:27 GMT, Alisen Chung wrote: > Opening closed tests: > 12 javax/swing/ToolTipManager/5078214/bug5078214.java > 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java > 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java > 15 javax/swing/plaf/metal/430

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v4]

2023-10-04 Thread Damon Nguyen
On Wed, 4 Oct 2023 11:34:13 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unnecessary delay. Modify delay amount. Add break. > > test/jdk/java/awt/dnd/RejectDragDropActionTest.java line

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v5]

2023-10-04 Thread Damon Nguyen
> This test intermittently fails by timeout. Increasing the timeout alone > doesn't solve the failure as it still fails in about 400 runs. Adding another > delay and reducing the delay amount to 1000ms. Now, the test passes after 2 > sets of 500 repeats on all OS's without a timeout. Damon Nguy

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v3]

2023-10-04 Thread Damon Nguyen
On Wed, 4 Oct 2023 11:38:01 GMT, Alexey Ivanov wrote: >> Sure can do. Is this to replace the initial `waitForIdle` after robot's >> creation? So, remove the `waitForIdle` and add `latch.await()` before >> robot's creation? > > I'm not sure it's the right idea. If a paint occurred, it means the

Re: RFR: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly

2023-10-04 Thread Harshitha Onkar
On Thu, 28 Sep 2023 11:18:16 GMT, Ravi Gupta wrote: > Write a test to check textArea triggers MouseEntered/MouseExited events > properly > > MouseEntered should be triggered only when the mouse enters the component and > MouseExited should be triggered when the mouse goes out of the component.

Re: RFR: 8316146: Open some swing tests 4 [v10]

2023-10-04 Thread Harshitha Onkar
On Tue, 3 Oct 2023 21:57:42 GMT, Alisen Chung wrote: >> Opening closed tests: >> 12 javax/swing/ToolTipManager/5078214/bug5078214.java >> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java >> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java >> 15 javax/swing/plaf/metal

Re: RFR: 8315986: javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location [v4]

2023-10-04 Thread Prasanta Sadhukhan
On Wed, 4 Oct 2023 11:01:09 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> jcheck > > test/jdk/javax/swing/JMenuItem/4654927/bug4654927.java line 1: > >> 1: /* > > I looked at the test c

Re: RFR: 8314498: [macos] Transferring File objects to Finder fails [v2]

2023-10-04 Thread Alexey Ushakov
On Sat, 30 Sep 2023 02:54:56 GMT, Sergey Bylokhov wrote: >> Arik Hadas has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new com

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v3]

2023-10-04 Thread Alexey Ivanov
On Tue, 3 Oct 2023 22:36:15 GMT, Damon Nguyen wrote: >> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 91: >> >>> 89: robot.setAutoWaitForIdle(true); >>> 90: robot.waitForIdle(); >>> 91: robot.delay(DELAY_TIME); >> >> To reduce the initial delay, yo

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v3]

2023-10-04 Thread Alexey Ivanov
On Tue, 3 Oct 2023 22:49:17 GMT, Damon Nguyen wrote: >> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 88: >> >>> 86: >>> 87: try { >>> 88: Robot robot = new Robot(); >> >> To reduce the initial delay, you may override `Frame.paint` and `countDown` >> a latch aft

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v4]

2023-10-04 Thread Alexey Ivanov
On Tue, 3 Oct 2023 22:41:37 GMT, Damon Nguyen wrote: >> This test intermittently fails by timeout. Increasing the timeout alone >> doesn't solve the failure as it still fails in about 400 runs. Adding >> another delay and reducing the delay amount to 1000ms. Now, the test passes >> after 2 set

Re: RFR: 8316146: Open some swing tests 4 [v10]

2023-10-04 Thread Alexey Ivanov
On Tue, 3 Oct 2023 21:57:42 GMT, Alisen Chung wrote: >> Opening closed tests: >> 12 javax/swing/ToolTipManager/5078214/bug5078214.java >> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java >> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java >> 15 javax/swing/plaf/metal

Re: RFR: 8315986: javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location [v4]

2023-10-04 Thread Alexey Ivanov
On Wed, 4 Oct 2023 09:30:55 GMT, Prasanta Sadhukhan wrote: >> Test was run without waiting for UI to be made visible leading to >> IllegalComponentStateException. >> Used robot.delay consistent with other headful tests to made the test wait >> after UI is created and shown. >> >> Test passed

Re: RFR: 8315986: javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location [v2]

2023-10-04 Thread Alexey Ivanov
On Wed, 4 Oct 2023 08:32:31 GMT, Prasanta Sadhukhan wrote: >> Can you please tell which system it is not working? >> I guess harshita and vitaly tested on macos14 and it worked for them and I >> tested on other mac13,windows10 locally where it also worked, as well as in >> mach5 systems, whos

Re: RFR: 8315986: javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location [v4]

2023-10-04 Thread Prasanta Sadhukhan
> Test was run without waiting for UI to be made visible leading to > IllegalComponentStateException. > Used robot.delay consistent with other headful tests to made the test wait > after UI is created and shown. > > Test passed in several iterations in all platforms. Link in JBS Prasanta Sadhuk

Re: RFR: 8315986: javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location [v3]

2023-10-04 Thread Prasanta Sadhukhan
> Test was run without waiting for UI to be made visible leading to > IllegalComponentStateException. > Used robot.delay consistent with other headful tests to made the test wait > after UI is created and shown. > > Test passed in several iterations in all platforms. Link in JBS Prasanta Sadhuk

Re: RFR: 8315986: javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location [v2]

2023-10-04 Thread Prasanta Sadhukhan
On Wed, 4 Oct 2023 02:52:19 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/JMenuItem/4654927/bug4654927.java line 83: >> >>> 81: robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK); >>> 82: robot.waitForIdle(); >>> 83: robot.delay(250); >> >> These don'