Re: RFR: JDK-6690019: JOptionPane obscured behind an always on top JFrame hangs UI [v3]

2023-10-09 Thread Tejesh R
On Tue, 10 Oct 2023 03:50:11 GMT, Prasanta Sadhukhan wrote: >> A JOptionPane message dialog owned by a JFrame which is not always on top >> can be obscured behind an `"always on top" JFrame`. Since the option pane is >> modal, one can't move the "always on top frame" to reveal it, so the >>

Re: RFR: JDK-6690019: JOptionPane obscured behind an always on top JFrame hangs UI

2023-10-09 Thread Prasanta Sadhukhan
On Mon, 9 Oct 2023 16:46:36 GMT, Alisen Chung wrote: > Would it be better to check if the JFrame is "always on top" before making > the JOptionPane also always on top? No..That's the issue this PR is trying to solve... If a frame is not "always on top" and is hidden by a frame which is "always

Re: RFR: JDK-6690019: JOptionPane obscured behind an always on top JFrame hangs UI [v3]

2023-10-09 Thread Prasanta Sadhukhan
> A JOptionPane message dialog owned by a JFrame which is not always on top can > be obscured behind an `"always on top" JFrame`. Since the option pane is > modal, one can't move the "always on top frame" to reveal it, so the > application effectively hangs as we cannot dismiss the option pane

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v7]

2023-10-09 Thread Julian Waters
> We should set the -permissive- flag for the Microsoft Visual C compiler, as > was requested by the now backed out > [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes > the Visual C compiler much less accepting of ill formed code, which will > improve code quality on

Re: RFR: JDK-6690019: JOptionPane obscured behind an always on top JFrame hangs UI [v2]

2023-10-09 Thread Prasanta Sadhukhan
> A JOptionPane message dialog owned by a JFrame which is not always on top can > be obscured behind an `"always on top" JFrame`. Since the option pane is > modal, one can't move the "always on top frame" to reveal it, so the > application effectively hangs as we cannot dismiss the option pane

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v6]

2023-10-09 Thread Julian Waters
On Thu, 28 Sep 2023 03:12:03 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-09 Thread Prasanta Sadhukhan
On Mon, 9 Oct 2023 17:31:46 GMT, Andy Goryachev wrote: > in the mean time, do you know why the checks are consistently failing for > this PR? No, this failure is in hotspot and it's ok to ignore thisnothing to do with the change in this PR ❌ [linux-x64 / test (hs/tier1

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v38]

2023-10-09 Thread ScientificWare
On Mon, 9 Oct 2023 23:24:35 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add named

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v38]

2023-10-09 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named colors from CSS Color Module Level >

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v37]

2023-10-09 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named colors from CSS Color Module Level >

Re: Fwd: Metal renderer threading issues [macOS]

2023-10-09 Thread Philip Race
I can't find any Apple docs saying anything like "invoke this only on the Appkit thread", perhaps because you don't have to, but nor do I see any caution about using a consistent thread. The JDK code to start a thread is - (void) startDisplayLink {     if

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v14]

2023-10-09 Thread Alexey Ivanov
On Mon, 9 Oct 2023 03:20:17 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Observations : >> 1. Without com initialize if we access Mixer for recording, library loaded >> invalid GUID and clipped description in windows(ID not found in registry). >> With com initialization

Re: RFR: 8317706: Exclude java/awt/Graphics2D/DrawString/RotTransText.java on linux

2023-10-09 Thread Alexey Ivanov
On Sun, 8 Oct 2023 22:15:59 GMT, Christoph Langer wrote: > This test is failing on several Linux configurations (SLES 15), so it should > be excluded. Looks good to me. - Marked as reviewed by aivanov (Reviewer). PR Review:

Re: RFR: 8317696: Fix compilation with clang-16 [v3]

2023-10-09 Thread Daniel Jeliński
On Mon, 9 Oct 2023 15:01:41 GMT, Jan Kratochvil wrote: >> `--with-toolchain-type=clang` fails the compilation for me with >> `clang-16.0.6-3.fc38.x86_64` >> >> While the warnings can be disabled I find better to just fix them. The GTK >> prototypes in JDK reported by clang are either missing

Re: RFR: 8317696: Fix compilation with clang-16 [v3]

2023-10-09 Thread Alexey Ivanov
On Mon, 9 Oct 2023 15:01:41 GMT, Jan Kratochvil wrote: >> `--with-toolchain-type=clang` fails the compilation for me with >> `clang-16.0.6-3.fc38.x86_64` >> >> While the warnings can be disabled I find better to just fix them. The GTK >> prototypes in JDK reported by clang are either missing

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-09 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: JDK-6690019: JOptionPane obscured behind an always on top JFrame hangs UI

2023-10-09 Thread Alisen Chung
On Thu, 5 Oct 2023 16:43:17 GMT, Prasanta Sadhukhan wrote: > A JOptionPane message dialog owned by a JFrame which is not always on top can > be obscured behind an `"always on top" JFrame`. Since the option pane is > modal, one can't move the "always on top frame" to reveal it, so the >

Re: RFR: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly [v3]

2023-10-09 Thread Alexey Ivanov
On Mon, 9 Oct 2023 05:07:13 GMT, Ravi Gupta wrote: >> Write a test to check textArea triggers MouseEntered/MouseExited events >> properly >> >> MouseEntered should be triggered only when the mouse enters the component >> and MouseExited should be triggered when the mouse goes out of the

Re: RFR: 8317696: Fix compilation with clang-16 [v3]

2023-10-09 Thread Jan Kratochvil
On Mon, 9 Oct 2023 14:38:27 GMT, Daniel Jeliński wrote: >> Jan Kratochvil has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove declaration changes which are not required >>- suggested by djelinski > >

Re: RFR: 8317696: Fix compilation with clang-16 [v3]

2023-10-09 Thread Jan Kratochvil
> `--with-toolchain-type=clang` fails the compilation for me with > `clang-16.0.6-3.fc38.x86_64` > > While the warnings can be disabled I find better to just fix them. The GTK > prototypes in JDK reported by clang are either missing or wrong. > > >

Re: RFR: 8317696: Fix compilation with clang-16 [v2]

2023-10-09 Thread Jan Kratochvil
> `--with-toolchain-type=clang` fails the compilation for me with > `clang-16.0.6-3.fc38.x86_64` > > While the warnings can be disabled I find better to just fix them. The GTK > prototypes in JDK reported by clang are either missing or wrong. > > >

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v36]

2023-10-09 Thread ScientificWare
On Thu, 17 Aug 2023 23:13:51 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add named

Re: RFR: 8317696: Fix compilation with clang-16

2023-10-09 Thread Daniel Jeliński
On Sat, 7 Oct 2023 16:24:29 GMT, Jan Kratochvil wrote: > `--with-toolchain-type=clang` fails the compilation for me with > `clang-16.0.6-3.fc38.x86_64` > > While the warnings can be disabled I find better to just fix them. The GTK > prototypes in JDK reported by clang are either missing or

Withdrawn: JDK-8294090 : Aligns the CSS and function behaviours

2023-10-09 Thread ScientificWare
On Sun, 13 Aug 2023 18:17:57 GMT, ScientificWare wrote: > This is referenced in Java Bug Database as > - [JDK-8294090 : Aligns the CSS `` and `` function > behaviours](https://bugs.java.com/bugdatabase/view_bug?bug_id=8294090) > > This is tracked in JBS as > - [JDK-8294090 : Aligns the CSS ``

Re: RFR: JDK-8294090 : Aligns the CSS and function behaviours [v3]

2023-10-09 Thread ScientificWare
On Sun, 20 Aug 2023 23:07:01 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8294090 : Aligns the CSS `` and `` function >> behaviours](https://bugs.java.com/bugdatabase/view_bug?bug_id=8294090) >> >> This is tracked in JBS as >> - [JDK-8294090 : Aligns the

Re: RFR: JDK-6690019: JOptionPane obscured behind an always on top JFrame hangs UI

2023-10-09 Thread Prasanta Sadhukhan
On Mon, 9 Oct 2023 06:25:08 GMT, Tejesh R wrote: > The fix is working fine with the test mentioned in JBS. Any reason for not > adding a test for the fix? I couldn't get ways to do automated test for this and manual test using PassFailJFrame doesn't support multiple test windows which this

RFR: 8317706: Exclude java/awt/Graphics2D/DrawString/RotTransText.java on linux

2023-10-09 Thread Christoph Langer
This test is failing on several Linux configurations (SLES 15), so it should be excluded. - Commit messages: - JDK-8317706 Changes: https://git.openjdk.org/jdk/pull/16096/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16096=00 Issue:

Re: RFR: JDK-6690019: JOptionPane obscured behind an always on top JFrame hangs UI

2023-10-09 Thread Tejesh R
On Thu, 5 Oct 2023 16:43:17 GMT, Prasanta Sadhukhan wrote: > A JOptionPane message dialog owned by a JFrame which is not always on top can > be obscured behind an `"always on top" JFrame`. Since the option pane is > modal, one can't move the "always on top frame" to reveal it, so the >

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-09 Thread Prasanta Sadhukhan
On Fri, 6 Oct 2023 17:34:54 GMT, Andy Goryachev wrote: > With the latest change, it behaves as expected on the primary retina screen. > > However, something is wrong if I put it on the secondary monitor right after > the launch: I am still getting inconsistent behavior, incorrect button >