On Wed, 11 Oct 2023 06:13:48 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/JScrollBar.java line 765:
>>
>>> 763: if (isMinimumSizeSet()) {
>>> 764: return super.getMinimumSize();
>>> 765: }
>>
>> This looks like it has potential to cau
On Tue, 10 Oct 2023 22:19:51 GMT, Phil Race wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - copyright year
>> - Fix maximumSize, test
>
> src/java.desktop/share/classes/javax/swing/JScrollBar.java line 765
> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>
> "Sets the minimum size of this component to a constant value. Subsequent
> calls to getMinimumSize will always return this value..."
>
> However, JScrollBar overrides getMinimumSize() and breaks this contract - it
> always
> Invoking `setEnabled(false)` on an instance of `JFileChooser` the
> sub-components are unaffected since the sub-components didn't set/unset
> enabled explicitly. The fix address the issue and sets the Enabled flag to
> each sub-components. Along with setting the property to each sub components
Hello,
I have fixed the typo in the comment for the method
JPopupMenu.setInvoker(Component invoker)
before: Sets the invoker of this popup menu -- the component in which the popup
menu menu is to be displayed.
after: Sets the invoker of this popup menu -- the component in which the popup
menu
On Tue, 10 Oct 2023 20:00:10 GMT, Phil Race wrote:
>> Invoking `setEnabled(false)` on an instance of `JFileChooser` the
>> sub-components are unaffected since the sub-components didn't set/unset
>> enabled explicitly. The fix address the issue and sets the Enabled flag to
>> each sub-component
On Wed, 11 Oct 2023 04:09:37 GMT, ANUPAM DEV wrote:
> Hello,
>
> I have fixed the typo in the comment for the method
> JPopupMenu.setInvoker(Component invoker)
>
> before: Sets the invoker of this popup menu -- the component in which the
> popup menu menu is to be displayed.
> after: Sets the
On Wed, 11 Oct 2023 04:09:37 GMT, ANUPAM DEV wrote:
> Hello,
>
> I have fixed the typo in the comment for the method
> JPopupMenu.setInvoker(Component invoker)
>
> before: Sets the invoker of this popup menu -- the component in which the
> popup menu menu is to be displayed.
> after: Sets the
Hello,
I have fixed the typo in the comment for the method
JPopupMenu.setInvoker(Component invoker)
before: Sets the invoker of this popup menu -- the component in which the popup
menu menu is to be displayed.
after: Sets the invoker of this popup menu -- the component in which the popup
menu
On Tue, 10 Oct 2023 12:03:23 GMT, Jayathirth D V wrote:
> In MTLSurfaceData_initOps() we return if "(gc == NULL)" but we don't free
> already allocated "mtlsdo" using (MTLSDOps *)malloc(sizeof(MTLSDOps)) which
> is of 40 bytes.
>
> We need to free(mtlsdo) before we return from MTLSurfaceData_i
On Tue, 10 Oct 2023 06:45:45 GMT, Prasanta Sadhukhan
wrote:
>>> in the mean time, do you know why the checks are consistently failing for
>>> this PR?
>>
>> No, this failure is in hotspot and it's ok to ignore thisnothing to do
>> with the change in this PR
>> ❌ [linux-x64 / test (hs/tier
On Tue, 10 Oct 2023 19:29:16 GMT, Phil Race wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restore current frame to maximise=false when another frame is maximised
>
> src/java.desktop/windows/classes/com/sun
> Issue is if one internal frame is open and maximized and another internal
> frame is created which is initialized with setMaximum(true) then after
> opening the second internal frame both internal frames are non-maximized
> It can also be seen with SwingSet2 JInternalFrameDemo in WIndowsLookAnd
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote:
> For stroked shapes (no Renderer use), the min-join-error check is disabled.
> Added new jtreg test to verify join using pixel counts
Tests all passed.
-
Marked as reviewed by prr (Reviewer).
PR Review: https://git.openjdk.o
On Mon, 9 Oct 2023 20:14:40 GMT, lawrence.andrews wrote:
> ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java &
> MouseModifiersUnitTest_Standard.java for windows
>
> @prrace
This pull request has now been integrated.
Changeset: f40ea510
Author:lawrence.andrews <873
On Tue, 10 Oct 2023 22:32:54 GMT, Phil Race wrote:
>> Julian Waters has updated the pull request incrementally with five
>> additional commits since the last revision:
>>
>> - Revert sspi.cpp
>> - Revert NativeCreds.c
>> - Revert allocation.cpp
>> - Revert symbolengine.cpp
>> - Revert os_w
On Tue, 10 Oct 2023 03:44:27 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less acceptin
On Thu, 24 Aug 2023 07:46:07 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However, JScrollBa
On Fri, 6 Oct 2023 03:24:36 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have added screen shot capturing facility to the test case and that will
> help for debugging in case of failure. Please review and let me know your
> suggestions or comments if any.
>
> Regards,
> Renjith.
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Fri, 29 Sep 2023 19:35:33 GMT, Arik Hadas wrote:
> Credit goes to JetBrain that fixed it in JetBrainsRuntime (commit 24819d9).
Yes as Sergey noted that's a problem.
Please just withdraw this PR. JetBrains have said they'll pick up doing the
fix. The JBS bug ID can be re-used but not the PR.
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote:
> For stroked shapes (no Renderer use), the min-join-error check is disabled.
> Added new jtreg test to verify join using pixel counts
Let me submit a test task to verify.
-
PR Comment: https://git.openjdk.org/jdk/pull/16002#i
On Tue, 10 Oct 2023 03:50:11 GMT, Prasanta Sadhukhan
wrote:
>> A JOptionPane message dialog owned by a JFrame which is not always on top
>> can be obscured behind an `"always on top" JFrame`. Since the option pane is
>> modal, one can't move the "always on top frame" to reveal it, so the
>> a
On Fri, 6 Oct 2023 03:24:36 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have added screen shot capturing facility to the test case and that will
> help for debugging in case of failure. Please review and let me know your
> suggestions or comments if any.
>
> Regards,
> Renjith.
On Mon, 9 Oct 2023 18:29:26 GMT, Alexey Ivanov wrote:
>> Jan Kratochvil has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove declaration changes which are not required
>>- suggested by djelinski
>
> src/java.desktop/unix/native/com
On Tue, 10 Oct 2023 15:11:24 GMT, Andy Goryachev wrote:
>>> would it make more sense to use a switch statement instead of a static map?
>>
>> I believe this was discussed somewhere… Looks like map provides better
>> performance compared to `switch` statement. Fetching an element from a map
>>
On Tue, 10 Oct 2023 06:45:45 GMT, Prasanta Sadhukhan
wrote:
>>> in the mean time, do you know why the checks are consistently failing for
>>> this PR?
>>
>> No, this failure is in hotspot and it's ok to ignore thisnothing to do
>> with the change in this PR
>> ❌ [linux-x64 / test (hs/tier
On Fri, 6 Oct 2023 05:10:18 GMT, Tejesh R wrote:
> Invoking `setEnabled(false)` on an instance of `JFileChooser` the
> sub-components are unaffected since the sub-components didn't set/unset
> enabled explicitly. The fix address the issue and sets the Enabled flag to
> each sub-components. Alo
On Mon, 9 Oct 2023 05:17:58 GMT, Prasanta Sadhukhan
wrote:
> Issue is if one internal frame is open and maximized and another internal
> frame is created which is initialized with setMaximum(true) then after
> opening the second internal frame both internal frames are non-maximized
> It can al
On Tue, 10 Oct 2023 12:03:23 GMT, Jayathirth D V wrote:
> In MTLSurfaceData_initOps() we return if "(gc == NULL)" but we don't free
> already allocated "mtlsdo" using (MTLSDOps *)malloc(sizeof(MTLSDOps)) which
> is of 40 bytes.
>
> We need to free(mtlsdo) before we return from MTLSurfaceData_i
On Tue, 10 Oct 2023 18:17:06 GMT, lawrence.andrews wrote:
>> ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java &
>> MouseModifiersUnitTest_Standard.java for windows
>>
>> @prrace
>
> lawrence.andrews has updated the pull request incrementally with one
> additional commi
> ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java &
> MouseModifiersUnitTest_Standard.java for windows
>
> @prrace
lawrence.andrews has updated the pull request incrementally with one additional
commit since the last revision:
Update ProblemList.txt
Fixed the b
On Mon, 9 Oct 2023 20:14:40 GMT, lawrence.andrews wrote:
> ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java &
> MouseModifiersUnitTest_Standard.java for windows
>
> @prrace
test/jdk/ProblemList.txt line 460:
> 458:
> java/awt/KeyboardFocusmanager/ConsumeNextMnemonicK
ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java &
MouseModifiersUnitTest_Standard.java for windows
@prrace
-
Commit messages:
- 8317751 : ProblemList ConsumeForModalDialogTest.java,
MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for win
On Tue, 3 Oct 2023 10:30:50 GMT, Alexander Zvegintsev
wrote:
> The current implementation of screen capture with ScreenCast has some
> shortcomings in handling ui scale.
>
> This changeset includes:
>
> * sun.java2d.uiScale value is now taken into account
> * screen data streams from ScreenCa
On Tue, 10 Oct 2023 15:04:51 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 1439:
>>
>>> 1437:
>>> 1438: private static Map initColorNames() {
>>> 1439: return Map.ofEntries(
>>
>> would it make more sense to use a switch statement i
On Tue, 10 Oct 2023 14:44:04 GMT, Andy Goryachev wrote:
> would it make more sense to use a switch statement instead of a static map?
I believe this was discussed somewhere… Looks like map provides better
performance compared to `switch` statement. Fetching an element from a map
gives a consta
On Mon, 9 Oct 2023 23:24:35 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level
>> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>>
>> This is tracked in JBS as
>> - [JDK-8292276 : Add named c
On Mon, 9 Oct 2023 23:24:35 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level
>> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>>
>> This is tracked in JBS as
>> - [JDK-8292276 : Add named c
I’m using an M2 mac also.
> On Oct 10, 2023, at 3:32 AM, Alexey Ushakov
> wrote:
>
> We actually changed this logic in JetBrains Runtime and invoke the CVD api
> only from one thread but still I see multiple display link threads on M2
> machines in some rare cases. So it maybe OS related issu
In MTLSurfaceData_initOps() we return if "(gc == NULL)" but we don't free
already allocated "mtlsdo" using (MTLSDOps *)malloc(sizeof(MTLSDOps)) which is
of 40 bytes.
We need to free(mtlsdo) before we return from MTLSurfaceData_initOps() for any
reasons. Moved (mtlsdo == NULL) check right after
On Tue, 10 Oct 2023 11:32:41 GMT, Ravi Gupta wrote:
>> Write a test to check textArea triggers MouseEntered/MouseExited events
>> properly
>>
>> MouseEntered should be triggered only when the mouse enters the component
>> and MouseExited should be triggered when the mouse goes out of the compo
> Write a test to check textArea triggers MouseEntered/MouseExited events
> properly
>
> MouseEntered should be triggered only when the mouse enters the component and
> MouseExited should be triggered when the mouse goes out of the component.
>
> In TextArea, when we moved the mouse inside the
On Tue, 10 Oct 2023 06:52:43 GMT, Tejesh R wrote:
> We call `enableEvents` in `JFileChooser.setup` so I guess we can call
> `disableEvents ` logically..
`disableEvents ` not helpful in blocking the mouse events.
-
PR Comment: https://git.openjdk.org/jdk/pull/16068#issuecomment-175
Hi,
We actually changed this logic in JetBrains Runtime and invoke the CVD api only
from one thread but still I see multiple display link threads on M2 machines in
some rare cases. So it maybe OS related issue.
Best Regards,
Alexey
> On Oct 9, 2023, at 9:27 PM, Philip Race wrote:
>
> I can't
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote:
> For stroked shapes (no Renderer use), the min-join-error check is disabled.
> Added new jtreg test to verify join using pixel counts
@prrace could you review this simple fix for jdk22, thatcan be backported to 21
next ?
-
P
On Sun, 8 Oct 2023 22:15:59 GMT, Christoph Langer wrote:
> This test is failing on several Linux configurations (SLES 15), so it should
> be excluded.
This pull request has now been integrated.
Changeset: fcff222f
Author:Christoph Langer
URL:
https://git.openjdk.org/jdk/commit/fcff
47 matches
Mail list logo
