Re: RFR: 8318364: Add an FFM-based implementation of harfbuzz OpenType layout [v3]

2023-10-20 Thread Phil Race
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout Phil Race has updated the pull request incrementally with one additional commit since the last revision: Use new arrayElementVarHandle method - Changes: - all: https://git.openjdk.org/jdk/pull/15476/files

Re: RFR: 8318364: Add an FFM-based implementation of harfbuzz OpenType layout [v2]

2023-10-20 Thread Phil Race
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout Phil Race has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: - Merge remote-tracking branch 'upstream/master' into harfbuzz_panama Merge - remove tai

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v39]

2023-10-20 Thread Phil Race
On Fri, 20 Oct 2023 22:12:29 GMT, Phil Race wrote: >> ScientificWare has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 59 commits: >> >> - Merge master >> - CSS.java : >>- Update source code declaration in documentation commen

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v39]

2023-10-20 Thread Phil Race
On Fri, 13 Oct 2023 07:50:17 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add named

Re: RFR: 8169475 : WheelModifier.java fails by timeout

2023-10-20 Thread Phil Race
On Fri, 20 Oct 2023 11:42:03 GMT, Alexey Ivanov wrote: >> test/jdk/java/awt/event/MouseWheelEvent/WheelModifier/WheelModifier.java >> line 173: >> >>> 171: test.run(); >>> 172: } finally { >>> 173: SwingUtilities.invokeAndWait(test.f::dispose); >> >> It would be

Re: RFR: JDK-8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-20 Thread Damon Nguyen
On Tue, 10 Oct 2023 21:24:47 GMT, Phil Race wrote: >> For stroked shapes (no Renderer use), the min-join-error check is disabled. >> Added new jtreg test to verify join using pixel counts > > Let me submit a test task to verify. > As only @prrace approved, is it enough for me to integrate this P

Re: RFR: JDK-8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-20 Thread Damon Nguyen
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote: > For stroked shapes (no Renderer use), the min-join-error check is disabled. > Added new jtreg test to verify join using pixel counts Changes look reasonable and the test looks good. Ran it myself and it passes with the changes. test/jdk

Integrated: JDK-8316030: Update Libpng to 1.6.40

2023-10-20 Thread Harshitha Onkar
On Tue, 17 Oct 2023 17:27:45 GMT, Harshitha Onkar wrote: > Libpng updated from 1.6.39 to 1.6.40 > > Build and CI Testing passes on all platforms. This pull request has now been integrated. Changeset: 158293d2 Author:Harshitha Onkar URL: https://git.openjdk.org/jdk/commit/158293d251

Re: RFR: JDK-8316030: Update Libpng to 1.6.40

2023-10-20 Thread Harshitha Onkar
On Thu, 19 Oct 2023 16:11:41 GMT, Damon Nguyen wrote: >> Libpng updated from 1.6.39 to 1.6.40 >> >> Build and CI Testing passes on all platforms. > > src/java.desktop/share/native/libsplashscreen/libpng/pngget.c line 60: > >> 58: if (flag == PNG_INFO_tRNS && png_ptr->num_trans == 0) >> 59

Re: RFR: 8169475 : WheelModifier.java fails by timeout

2023-10-20 Thread Alexey Ivanov
On Fri, 20 Oct 2023 10:13:40 GMT, Dmitry Markov wrote: > It would be good to ensure that f is not NULL before dispose. I know we're doing it all the time… But is it really relevant? This has been bothering me for a while now… Let's clear things up. If the frame is `null`, something has gone aw

Re: RFR: 8169475 : WheelModifier.java fails by timeout

2023-10-20 Thread Alexey Ivanov
On Fri, 20 Oct 2023 06:59:17 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > I have added additional CountDownLatch for making sure button is visible > before proceeding,(observe this was one of the key reason for failure) so > this helps to improve test case stability. Modified _a

Integrated: 8318448: Link PopupMenu/PopupMenuLocation.java failure to JDK-8259913

2023-10-20 Thread Alexey Ivanov
On Wed, 18 Oct 2023 13:21:17 GMT, Alexey Ivanov wrote: > Update ProblemList entry for java/awt/PopupMenu/PopupMenuLocation.java to > [JDK-8259913](https://bugs.openjdk.org/browse/JDK-8259913) which is a > specific bug for AWT menus in High DPI environment. This pull request has now been integr

Integrated: 8318101: Additional test cases for CSSAttributeEqualityBug

2023-10-20 Thread Alexey Ivanov
On Fri, 13 Oct 2023 20:21:04 GMT, Alexey Ivanov wrote: > Adds additional test cases to > `javax/swing/text/html/CSS/CSSAttributeEqualityBug.java`. > > Currently, CSS parser in Java allows space between the number and the unit or > percent. This is what the additional test cases verify. > > Th

Re: RFR: 8169475 : WheelModifier.java fails by timeout

2023-10-20 Thread Dmitry Markov
On Fri, 20 Oct 2023 06:59:17 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > I have added additional CountDownLatch for making sure button is visible > before proceeding,(observe this was one of the key reason for failure) so > this helps to improve test case stability. Modified _a

Re: RFR: JDK-8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-20 Thread Laurent Bourgès
On Tue, 10 Oct 2023 21:24:47 GMT, Phil Race wrote: >> For stroked shapes (no Renderer use), the min-join-error check is disabled. >> Added new jtreg test to verify join using pixel counts > > Let me submit a test task to verify. As only @prrace approved, is it enough for me to integrate this PR

Re: RFR: 4365952: Cannot disable JFileChooser [v6]

2023-10-20 Thread Tejesh R
> Invoking `setEnabled(false)` on an instance of `JFileChooser` the > sub-components are unaffected since the sub-components didn't set/unset > enabled explicitly. The fix address the issue and sets the Enabled flag to > each sub-components. Along with setting the property to each sub components

Re: RFR: 8315097: Rename createJavaProcessBuilder [v5]

2023-10-20 Thread Leo Korinth
On Thu, 19 Oct 2023 15:16:13 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 4365952: Cannot disable JFileChooser [v4]

2023-10-20 Thread Abhishek Kumar
On Fri, 20 Oct 2023 06:48:11 GMT, Tejesh R wrote: >> test/jdk/javax/swing/JFileChooser/FileChooserDisableTest.java line 94: >> >>> 92: String currentDirectory = >>> jfc.getCurrentDirectory().toString(); >>> 93: if (!currentDirectory.equals(defaultDirectory)) { >>

RFR: 8169475 : WheelModifier.java fails by timeout

2023-10-20 Thread Renjith Kannath Pariyangad
Hi Reviewers, I have added additional CountDownLatch for making sure button is visible before proceeding,(observe this was one of the key reason for failure) so this helps to improve test case stability. Modified _await()_ function by adding 1sec timeout with exception, this will help to reduce