> The root cause of the bug is because mousePress() method is invoked before
> mouseMove() event is completely processed causing the drag & drop behavior
> not being able to be recognized properly. This in turn makes the method
> dragSourceListener.isDropFinished() returns false and fail the
> The root cause of the bug is because mousePress() method is invoked before
> mouseMove() event is completely processed causing the drag & drop behavior
> not being able to be recognized properly. This in turn makes the method
> dragSourceListener.isDropFinished() returns false and fail the
On Sun, 5 Nov 2023 07:11:27 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less
> Table contents does not follow right-left Orientation when Max width of
> columns are set. This is due to not considering the offset in `x position`
> while painting table grid and table cell. The fix handles the offset and
> adjust the x position for each paint, similar to how header is
On Fri, 3 Nov 2023 21:06:07 GMT, Damon Nguyen wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Synth update
>
> test/jdk/javax/swing/JTable/JTableRightAlignmentTest.java line 64:
>
>> 62:
>> 63: public static
On Mon, 6 Nov 2023 06:22:33 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However,
On Fri, 27 Oct 2023 11:01:55 GMT, Daniel Jeliński wrote:
>> src/java.desktop/share/classes/java/awt/Button.java line 128:
>>
>>> 126: static {
>>> 127: /* ensure that the necessary native libraries are loaded */
>>> 128: Toolkit.loadLibraries();
>>
>> I think it is safer to
On Mon, 6 Nov 2023 23:58:11 GMT, Sergey Bylokhov wrote:
> > So we have somewhere around a fixed 125ms startup cost for the FFM case -
> > as measured on my Mac,
> > but only 35-40ms of that is attributable to the specific needs of layout.
>
> That looks unfortunate. I guess if we will start to
On Mon, 6 Nov 2023 23:28:30 GMT, Phil Race wrote:
>So we have somewhere around a fixed 125ms startup cost for the FFM case - as
>measured on my Mac,
but only 35-40ms of that is attributable to the specific needs of layout.
That looks unfortunate. I guess if we will start to use ffm in other
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
> This
On Mon, 6 Nov 2023 18:52:05 GMT, Sergey Bylokhov wrote:
> Since we plan to import it into jdk22, do you have some performance data to
> share? any positive or negative effects of this migration?
There's three phases - (1) startup, (2) warmup and (3) warmed up performance.
JNI has minimal
On Mon, 6 Nov 2023 21:10:55 GMT, Phil Race wrote:
>> Alec Su has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Code cleanup
>
> test/jdk/javax/sound/midi/Devices/OutputBuffer.java line 33:
>
>> 31: * is sent again with the next
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
> This
On Sun, 29 Oct 2023 14:29:45 GMT, Alec Su wrote:
>> JVM attempts to reuse the buffer for sending MIDI out data when the buffer
>> size is enough. It use `dwBytesRecorded` in `MIDIHDR` structure to indicate
>> the actual size of the data. However, `midiOutLongMsg()` ignores
>>
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
> This
On Sun, 29 Oct 2023 14:29:45 GMT, Alec Su wrote:
>> JVM attempts to reuse the buffer for sending MIDI out data when the buffer
>> size is enough. It use `dwBytesRecorded` in `MIDIHDR` structure to indicate
>> the actual size of the data. However, `midiOutLongMsg()` ignores
>>
On Fri, 27 Oct 2023 23:29:19 GMT, lawrence.andrews wrote:
> 1) Fixed the @library regtesthelpers file path
> 2) Added @build PassFailJFrame
> 3) Added a empty line at the end of the file that was missing.
This pull request has now been integrated.
Changeset: e4803e0c
Author:
On Fri, 27 Oct 2023 23:29:19 GMT, lawrence.andrews wrote:
> 1) Fixed the @library regtesthelpers file path
> 2) Added @build PassFailJFrame
> 3) Added a empty line at the end of the file that was missing.
Marked as reviewed by aivanov (Reviewer).
-
PR Review:
On Mon, 6 Nov 2023 04:06:57 GMT, Julian Waters wrote:
> By the way, how outdated is the comment that awt.dll should not rely on
> msvcp.dll? As far as I can tell we now always distribute msvcp.dll in the
> JDK, and it would help a lot if I could use the C++ Standard Library for this
Do we ?
I have experienced a problem related to Container.remove(index).
As this code has been around for a long time, I’m wondering (1) why it does
what it does and (2) whether
there is some AWT/Swing design rule that I should be following (but I don’t
know of one that would have helped).
The
On Mon, 6 Nov 2023 07:17:27 GMT, Abhishek Kumar wrote:
>> This is definitely an improvement compared to the complete lack of magnified
>> text on hover, but it still doesn't handle custom renderers.
>>
>> I've been digging into how this works in Metal but I couldn't figure it out
>>
On Mon, 6 Nov 2023 06:22:33 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However,
On Fri, 27 Oct 2023 23:29:19 GMT, lawrence.andrews wrote:
> 1) Fixed the @library regtesthelpers file path
> 2) Added @build PassFailJFrame
> 3) Added a empty line at the end of the file that was missing.
Marked as reviewed by serb (Reviewer).
-
PR Review:
On Wed, 25 Oct 2023 23:42:08 GMT, Phil Race wrote:
>> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> indentation
Since we plan to import it into jdk22, do
On Thu, 2 Nov 2023 13:55:41 GMT, Alec Su wrote:
> The bug on Windows doesn't generate any error messages. During the testcase
> run, every "Open MIDI port" message should be followed by an "All
> SysexMessage sent" message. Alternatively, you can check `%ERRORLEVEL%` to
> determine if there's
On Mon, 6 Nov 2023 13:09:08 GMT, Daniel Jeliński wrote:
>> @djelinski Just curious; what would the effect be to both include this
>> change and setting the NO_* defines?
>>
>> If all the references to these defines are made in the excluded files then
>> the only reason for doing that would be
On Fri, 6 Oct 2023 05:10:18 GMT, Tejesh R wrote:
> Invoking `setEnabled(false)` on an instance of `JFileChooser` the
> sub-components are unaffected since the sub-components didn't set/unset
> enabled explicitly. The fix address the issue and sets the Enabled flag to
> each sub-components.
On Mon, 6 Nov 2023 12:26:58 GMT, Magnus Ihse Bursie wrote:
>> FWIW, I compiled the code without this PR, but with `HARFBUZZ_CFLAGS +=
>> -DHB_NO_SUBSET_LAYOUT -DHB_NO_SUBSET_CFF` instead, and checked `make
>> LOG=profile` output. Results:
>> - without this change, compiling `hb-subset.cc` took
On Fri, 3 Nov 2023 06:06:29 GMT, Daniel Jeliński wrote:
>> You can find the file here:
>> https://github.com/openjdk/jdk/blob/f262f06c97b9ea94cd6119b3a8beb16bf804d083/src/java.desktop/share/native/libharfbuzz/graph/gsubgpos-context.cc
>>
>> Hb-subset files are not guarded by ifdefs;
On Fri, 20 Oct 2023 09:15:11 GMT, Tejesh R wrote:
>> Invoking `setEnabled(false)` on an instance of `JFileChooser` the
>> sub-components are unaffected since the sub-components didn't set/unset
>> enabled explicitly. The fix address the issue and sets the Enabled flag to
>> each
30 matches
Mail list logo
