RFR: 8210807: Printing a JTable with a JScrollPane prints table without rows populated

2023-11-07 Thread Tejesh R
`BackingStore` uses its own Graphics to Paint the Image. This is fine when we want to paint it on a Window/Frame, but fails to print. Since `WPathGraphics` is used for Printing, backing store fails to print it and backing store uses newly created `SunGraphics2D` always. The proposed fix is to

Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v6]

2023-11-07 Thread Prasanta Sadhukhan
On Mon, 6 Nov 2023 06:22:33 GMT, Prasanta Sadhukhan wrote: >> javadoc contract for JComponent.setMinimumSize(Dimension) states: >> >> "Sets the minimum size of this component to a constant value. Subsequent >> calls to getMinimumSize will always return this value..." >> >> However,

Re: RFR: 8319315: Sending a SysexMessage starting with 0xF7 leads to JVM crash [v3]

2023-11-07 Thread Alec Su
> The bug on Windows doesn't generate any error messages. During the testcase > run, every "Open MIDI port" message should be followed by an "All > SysexMessage sent" message. Alternatively, you can check `%ERRORLEVEL%` to > determine if there's an error when JVM exits. > > On Linux, there are

Re: Container.remove issue

2023-11-07 Thread Alan Snyder
> On Nov 7, 2023, at 2:57 PM, Philip Race wrote: > > I don't have a definite answer to your question, and for sure AWT docs may be > a bit lacking, > but there's also a lot of them so an answer may be buried somewhere. > > Not sure if you are saying you are in fact running "arbitrary code"

Re: RFR: 8319315: Sending a SysexMessage starting with 0xF7 leads to JVM crash [v2]

2023-11-07 Thread Phil Race
On Tue, 7 Nov 2023 16:20:56 GMT, Alec Su wrote: >> The bug on Windows doesn't generate any error messages. During the testcase >> run, every "Open MIDI port" message should be followed by an "All >> SysexMessage sent" message. Alternatively, you can check `%ERRORLEVEL%` to >> determine if

Re: Container.remove issue

2023-11-07 Thread Philip Race
I don't have a definite answer to your question, and for sure AWT docs may be a bit lacking, but there's also a lot of them so an answer may be buried somewhere. Not sure if you are saying you are in fact running "arbitrary code" in removeNotify() but I don't think that would be a good idea.

Re: RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v5]

2023-11-07 Thread Phil Race
On Tue, 7 Nov 2023 09:10:02 GMT, songpv-imt wrote: >> The root cause of the bug is because mousePress() method is invoked before >> mouseMove() event is completely processed causing the drag & drop behavior >> not being able to be recognized properly. This in turn makes the method >>

RFR: 8319665: [macOS] Obsolete imports of in java.desktop

2023-11-07 Thread Phil Race
Remove unused imports - Commit messages: - 8319665 Changes: https://git.openjdk.org/jdk/pull/16548/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16548=00 Issue: https://bugs.openjdk.org/browse/JDK-8319665 Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod Patch:

Re: RFR: 8319598: SMFParser misinterprets interrupted running status

2023-11-07 Thread Jan Trukenmüller
Am 07.11.23 um 20:37 schrieb Jan Trukenmüller: The MIDI file parser misinterprets events without status byte when they appear directly after a Meta of SysEx event. For my bugfix I had to decide between two possible solutions: - Strict solution: Throw an InvalidMidiDataException - Tolerant

RFR: 8319598: SMFParser misinterprets interrupted running status

2023-11-07 Thread Jan Trukenmüller
The MIDI file parser misinterprets events without status byte when they appear directly after a Meta of SysEx event. For my bugfix I had to decide between two possible solutions: - Strict solution: Throw an InvalidMidiDataException - Tolerant solution: Use the status of the last channel event as

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v3]

2023-11-07 Thread Alexey Ivanov
On Thu, 2 Nov 2023 14:01:20 GMT, xpbob wrote: >> Build failure with GCC8.3.1 >> >> === Output from failing command(s) repeated here === >> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: >> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: >>

Re: RFR: 8074211: javax.sound.midi: Error with send System Exclusive messages of different length [v3]

2023-11-07 Thread Alec Su
On Mon, 6 Nov 2023 21:43:24 GMT, Sergey Bylokhov wrote: >> test/jdk/javax/sound/midi/Devices/OutputBuffer.java line 33: >> >>> 31: * is sent again with the next sysex message >>> 32: * @comment This test does not fail when the bug occurs. It requires >>> manual >>> 33: *

Re: RFR: 8074211: javax.sound.midi: Error with send System Exclusive messages of different length [v3]

2023-11-07 Thread Alec Su
On Mon, 6 Nov 2023 20:53:53 GMT, Sergey Bylokhov wrote: >> Alec Su has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Code cleanup > > test/jdk/javax/sound/midi/Devices/OutputBuffer.java line 34: > >> 32: * @comment This test does not

Re: RFR: 8074211: javax.sound.midi: Error with send System Exclusive messages of different length [v4]

2023-11-07 Thread Alec Su
> JVM attempts to reuse the buffer for sending MIDI out data when the buffer > size is enough. It use `dwBytesRecorded` in `MIDIHDR` structure to indicate > the actual size of the data. However, `midiOutLongMsg()` ignores > `dwBytesRecorded`, although it did not mentioned in the documentation.

Re: RFR: 8319315: Sending a SysexMessage starting with 0xF7 leads to JVM crash

2023-11-07 Thread Alec Su
On Mon, 6 Nov 2023 18:45:41 GMT, Sergey Bylokhov wrote: >> The bug on Windows doesn't generate any error messages. During the testcase >> run, every "Open MIDI port" message should be followed by an "All >> SysexMessage sent" message. Alternatively, you can check `%ERRORLEVEL%` to >>

Re: RFR: 8319315: Sending a SysexMessage starting with 0xF7 leads to JVM crash [v2]

2023-11-07 Thread Alec Su
> The bug on Windows doesn't generate any error messages. During the testcase > run, every "Open MIDI port" message should be followed by an "All > SysexMessage sent" message. Alternatively, you can check `%ERRORLEVEL%` to > determine if there's an error when JVM exits. > > On Linux, there are

Re: RFR: 6928542: Chinese characters in RTF are not decoded [v7]

2023-11-07 Thread Ichiroh Takiguchi
On Thu, 26 Oct 2023 12:44:28 GMT, Prasanta Sadhukhan wrote: >> Ichiroh Takiguchi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 6928542: Chinese characters in RTF are not decoded > > For me the added regression test still fails with

Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v6]

2023-11-07 Thread Alexey Ivanov
On Tue, 7 Nov 2023 03:29:15 GMT, Prasanta Sadhukhan wrote: > Can you please attach your testcode in JBS? I tried with the testcases > JScrollBarMinLayout.java and JScrollBarMaxLauout.java resizing the frame and > I dont see any difference in layout behaviour of the scrollbars with and >

Re: RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v5]

2023-11-07 Thread songpv-imt
> The root cause of the bug is because mousePress() method is invoked before > mouseMove() event is completely processed causing the drag & drop behavior > not being able to be recognized properly. This in turn makes the method > dragSourceListener.isDropFinished() returns false and fail the

Re: RFR: 8319197: Exclude hb-subset and hb-style from compilation

2023-11-07 Thread Daniel Jeliński
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote: > hb-subset and hb-style APIs are not used and not exported by libfontmanger. > We can cut the compilation time by not compiling the unused files. > > The added exclusions reduce the build time by ~1 minute (~8%) on my machine. > This

Integrated: 8319197: Exclude hb-subset and hb-style from compilation

2023-11-07 Thread Daniel Jeliński
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote: > hb-subset and hb-style APIs are not used and not exported by libfontmanger. > We can cut the compilation time by not compiling the unused files. > > The added exclusions reduce the build time by ~1 minute (~8%) on my machine. > This