CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
field isn't declared as volatile. Without the volatile modifier, double-checked
locking implementation is broken.
-
Commit messages:
- 8319925: CSS.BackgroundImage incorrectly uses double-checked locking
On Thu, 30 Nov 2023 17:44:46 GMT, Alexey Ivanov wrote:
>> You don't call `parent.getWidth()` here, you always call `this.getWidth()`.
>>
>> I don't know why `JTableHeader` has special handling for it… Yet in the case
>> of `JTableHeader` it may be reasonable: the header follows the table width
On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote:
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
This pull request has now been integrated.
Ch
On Thu, 23 Nov 2023 13:00:06 GMT, Anton Bobrov wrote:
> This patch addresses the issues described in the
> https://bugs.openjdk.org/browse/JDK-8320655 by fixing the proper locking and
> signalling around libpipewire thread loop condition variables and also fixing
> libpipewire error detection
On Thu, 30 Nov 2023 18:23:28 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Thu, 30 Nov 2023 18:14:21 GMT, Phil Race wrote:
>> That's the reason why I prefer you keep the `@run` tag in `SetOrient.java`:
>> to document that it's *an applet test* — with the html file being the test
>> starter.
>
> Ok, although when I see something like that it looks more like a bug to
On Thu, 30 Nov 2023 18:23:28 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Thu, 30 Nov 2023 19:50:00 GMT, Sergey Bylokhov wrote:
> probably we can link this from our wiki page where we describe the usage of
> keywords?:
> https://wiki.openjdk.org/display/ClientLibs/Automated+client+GUI+testing+system+set+up+requirements
Good idea, once this is pushed, I'll add th
On Fri, 17 Nov 2023 20:21:32 GMT, Alexey Ivanov wrote:
> Update `FileChooserSymLinkTest.java` to simplify its implementation by
> replacing `List` with `JFrame` of its `createTestUI` which now uses
> `PassFailJFrame.Builder testUI(PassFailJFrame.WindowCreator)` instead of
> `PassFailJFrame.Bui
On Fri, 17 Nov 2023 20:01:55 GMT, Alexey Ivanov wrote:
> Enhance `PassFailJFrame` for single-window test UI which is the most common
> case so that there's no need to return `List.of`.
>
> With this change, the lambda or method reference passed to `Builder.testUI`
> will return Window instead
On Thu, 30 Nov 2023 18:23:28 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Thu, 30 Nov 2023 18:54:42 GMT, Phil Race wrote:
> It will test that it builds, but nothing more.
Right, thanks. Still useful it's not breaking a build :) Besides, the settings
carry forward for future PRs.
-
PR Comment: https://git.openjdk.org/jdk/pull/16794#issuecomment-183441
On Thu, 30 Nov 2023 03:34:08 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> There was a typo for color conversion instead of dstColorSpace function
> srcColorSpace was used. Please review and let me know your suggestions if
> any.
>
> Renjith.
Can this patch be covered by the new
On Thu, 23 Nov 2023 13:21:10 GMT, Severin Gehwolf wrote:
> @antbob Please trigger a test run of GHA. You should be able to do that in
> https://github.com/antbob/jdk/actions/workflows/main.yml (manual trigger).
> Thanks!
That is pointless for this change. There are ZERO tests that GHA runs tha
On Wed, 29 Nov 2023 19:48:27 GMT, Damon Nguyen wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java
>> line 464:
>>
>>> 462: *
>>> 463: * The default button margin value is (2, 14, 2, 14), which may
>>> 464: * greatly differ from other LookAndFee
> The initial issue was a padding issue for JButton when HTML content was set
> as the button's text.
> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and
> [JDK-8302173](https://bugs.openjdk.org/browse/JDK-8302173) are
On Thu, 30 Nov 2023 17:08:21 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320608
>
> test/jdk/java/awt/print/PrinterJob/EmptyFill.java line 72:
>
>> 70:return;
>> 71:}
>> 72
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
Phil Race has updated the pull request incrementally with one additional commit
since the last rev
On Thu, 30 Nov 2023 15:59:29 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320608
>
> test/jdk/java/awt/print/PageFormat/SmallPaperPrinting.java line 73:
>
>> 71: job.print();
>> 72:
On Thu, 30 Nov 2023 15:41:28 GMT, Alexey Ivanov wrote:
>> "Should not" is strong. Why ? There's no requirement do to this even though
>> you can.
>> https://openjdk.org/jtreg/faq.html#can-i-use-the-author-run-etc.-tags-in-other-files
>
> That's the reason why I prefer you keep the `@run` tag in
On Thu, 30 Nov 2023 17:20:40 GMT, Tejesh R wrote:
>> Table contents does not follow right-left Orientation when Max width of
>> columns are set. This is due to not considering the offset in `x position`
>> while painting table grid and table cell. The fix handles the offset and
>> adjust the x
On Thu, 30 Nov 2023 17:44:11 GMT, Alexey Ivanov wrote:
>> I actually reused it from `JTableHeader` class and yeah it will be
>> `parent.getWidth ` always as of now, but I thought it might be for future
>> purpose, but not sure... Should we retain or just use `parent.getWidth`
>> directly?
>
>
On Thu, 30 Nov 2023 17:03:00 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/JTable.java line 9809:
>>
>>> 9807: }
>>> 9808: return super.getWidth();
>>> 9809: }
>>
>> Can you elaborate on why it's needed? Presumably both versions return the
>> same width
On Mon, 27 Nov 2023 20:20:38 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Mon, 27 Nov 2023 18:48:52 GMT, Phil Race wrote:
>> I see `SetOrient.java` has its sibling `SetOrient.html` where you added
>> `@key printer`.
>>
>> Since both files contain all the tags except for `@test` in the .java file,
>> you should not remove the `@run` tag from the .java file and add
On Mon, 27 Nov 2023 20:20:38 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Mon, 27 Nov 2023 18:53:24 GMT, Phil Race wrote:
> I can .. but I am not aware of even a convention to do that ordering.
It's not written anywhere as far as I know. There's [an ongoing
discussion](https://github.com/openjdk/jdk/pull/16674#discussion_r1402082665)
about it in #16674.
https://
> Table contents does not follow right-left Orientation when Max width of
> columns are set. This is due to not considering the offset in `x position`
> while painting table grid and table cell. The fix handles the offset and
> adjust the x position for each paint, similar to how header is paint
On Thu, 30 Nov 2023 12:37:37 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 9809:
>
>> 9807: }
>> 9808: re
> The initial issue was a padding issue for JButton when HTML content was set
> as the button's text.
> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and
> [JDK-8302173](https://bugs.openjdk.org/browse/JDK-8302173) are
On Tue, 14 Nov 2023 21:22:37 GMT, Alisen Chung wrote:
> Updated previous fix (8262945) to work on extendedKeyCodes. Updated
> AcceleratorTest to use PassFailJFrame instead of Applet
This pull request has now been integrated.
Changeset: a3eb6640
Author:Alisen Chung
URL:
https://git.
On Thu, 30 Nov 2023 10:52:18 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 3013:
>
>> 3011: }
>> 3012:
On Thu, 30 Nov 2023 10:03:47 GMT, Tejesh R wrote:
>> Table contents does not follow right-left Orientation when Max width of
>> columns are set. This is due to not considering the offset in `x position`
>> while painting table grid and table cell. The fix handles the offset and
>> adjust the x
> Table contents does not follow right-left Orientation when Max width of
> columns are set. This is due to not considering the offset in `x position`
> while painting table grid and table cell. The fix handles the offset and
> adjust the x position for each paint, similar to how header is paint
On Thu, 30 Nov 2023 08:08:33 GMT, Tejesh R wrote:
>> Table contents does not follow right-left Orientation when Max width of
>> columns are set. This is due to not considering the offset in `x position`
>> while painting table grid and table cell. The fix handles the offset and
>> adjust the x
> Table contents does not follow right-left Orientation when Max width of
> columns are set. This is due to not considering the offset in `x position`
> while painting table grid and table cell. The fix handles the offset and
> adjust the x position for each paint, similar to how header is paint
36 matches
Mail list logo
