On Wed, 31 Jan 2024 07:23:13 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>>
> The assertions reported in the bug were observed spuriously and here and
> there broke tests in some Windows configurations.
> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
> [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or
>
On Tue, 30 Jan 2024 04:35:02 GMT, Prasanta Sadhukhan
wrote:
>> vtstydev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix header and imports section in AlphaPrintingOffsets
>
>
On Tue, 30 Jan 2024 04:44:31 GMT, Prasanta Sadhukhan
wrote:
> > Only on Windows platform under certain conditions real device prints
> > shifted image on paper.
>
> Also, if it affects only windows platform, will it not be more advisable to
> do in WPrinterJob class instead of
On Tue, 30 Jan 2024 14:03:39 GMT, Alexey Ivanov wrote:
> Now that I re-read the problem statement and the exception handling JNI, the
> fix doesn't look correct to me.
>
> What does the warning say?
>
> > WARNING in native method: JNI call made without checking exceptions when
> > required
On Tue, 30 Jan 2024 14:13:07 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>>
On Tue, 30 Jan 2024 13:44:22 GMT, Alexey Ivanov wrote:
>> In fact, any method can throw an exception…
>>
>> Is there a guide which clearly states where `ExceptionCheck` is required?
>> The function returns a boolean indicating whether there's a pending
>> exception. Shall we back out if
On Tue, 30 Jan 2024 14:02:41 GMT, Matthias Baesken wrote:
>>> Yes there is a nice define in the AIX header
>>
>> *sigh* On linux, they go to some lengths to avoid this, using a __REDEFINE
>> mechanism. Oh well.
>>
>> Anyway, I think this particular can be resolved by not including the
>>
On Mon, 29 Jan 2024 20:45:18 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>>
> This picks up fixing the issue of
> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
> been integrated with #17224 but @prrace had concerns and so it was backed out.
>
> I have now spent quite some thoughts into the problem and end up with the
> [initial
>
On Tue, 30 Jan 2024 04:32:50 GMT, Prasanta Sadhukhan
wrote:
>> vtstydev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix header and imports section in AlphaPrintingOffsets
>
>
> When using a TreeCellRenterer which creates new components in
> getTreeCellRendererComponent() in a JTree that is not visible, changes to the
> nodes cause a memory leak.
> When a node is changed, the Method getNodeDimensions() is called to calculate
> the new dimensions for the node. In this
On Tue, 30 Jan 2024 10:38:03 GMT, Alexey Ivanov wrote:
>> I was not sure of the nuances of PhantomReference and ReferenceQueue, so
>> have used WeakReference logic in the test which I think is more simpler..
>
> It's simpler with `PhantomReference`. This type of reference does not allow
>
On Mon, 11 Dec 2023 11:25:34 GMT, Tejesh R wrote:
> The issue is w.r.t to way that Synth prints the table. In Synth, the printing
> of Table happens column wise by painting blocks of columns which is due to
> the fact that Graphics used which is `ProxyGrpahics2D` (which get selected in
>
> When using a TreeCellRenterer which creates new components in
> getTreeCellRendererComponent() in a JTree that is not visible, changes to the
> nodes cause a memory leak.
> When a node is changed, the Method getNodeDimensions() is called to calculate
> the new dimensions for the node. In this
On Tue, 30 Jan 2024 16:30:43 GMT, Alexey Ivanov wrote:
> I forgot to add a direct link to the test:
>
On Wed, 31 Jan 2024 01:08:13 GMT, Harshitha Onkar wrote:
>> ShapeNotSetSometimes.java fails on macOS 11 on a random iteration of
>> `colorCheck()` as shown below. The `colorCheck()` is repeated for about 50
>> times in the test. It is observed to pass on previous attempts and fail on a
>>
On Tue, 30 Jan 2024 11:41:44 GMT, Tejesh R wrote:
>> The issue is w.r.t to way that Synth prints the table. In Synth, the
>> printing of Table happens column wise by painting blocks of columns which is
>> due to the fact that Graphics used which is `ProxyGrpahics2D` (which get
>> selected in
On Wed, 31 Jan 2024 01:08:13 GMT, Harshitha Onkar wrote:
>> ShapeNotSetSometimes.java fails on macOS 11 on a random iteration of
>> `colorCheck()` as shown below. The `colorCheck()` is repeated for about 50
>> times in the test. It is observed to pass on previous attempts and fail on a
>>
> ShapeNotSetSometimes.java fails on macOS 11 on a random iteration of
> `colorCheck()` as shown below. The `colorCheck()` is repeated for about 50
> times in the test. It is observed to pass on previous attempts and fail on a
> random attempt such as Attempt# 29 shown here.
>
> Here the point
On Tue, 30 Jan 2024 21:49:12 GMT, Rajat Mahajan wrote:
> Modified the test to use PassFailJFrame and open sourced it.
> The test shows two windows, one for instructions and the other to perform
> testing on.
> Tested locally and it works fine.
Marked as reviewed by honkar (Committer).
Modified the test to use PassFailJFrame and moved it from closed to open.
The test shows two windows, one for instructions and the other to perform
testing on.
Tested locally and it works fine.
-
Commit messages:
- 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
On Tue, 30 Jan 2024 13:47:05 GMT, Tejesh R wrote:
>> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091)
>> also created concurrent exception intermittently (monthly once/quarterly
>> once) on CI system. The issue was not able to be reproduced yet, hence
>> proposing an
On Tue, 30 Jan 2024 15:35:54 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use removeAll and testcase modified
>
>
On Mon, 29 Jan 2024 06:18:50 GMT, Prasanta Sadhukhan
wrote:
>> When using a TreeCellRenterer which creates new components in
>> getTreeCellRendererComponent() in a JTree that is not visible, changes to
>> the nodes cause a memory leak.
>> When a node is changed, the Method getNodeDimensions()
On Thu, 25 Jan 2024 09:56:08 GMT, Alexey Ivanov wrote:
> > > …I'm for replacing `Vector` with `ArrayList` for the `newFileCache` and
> > > `newFiles` variables. These are local variables, they're not accessed
> > > concurrently. Yet they're accessed from two threads: the current one and
> > >
On Tue, 30 Jan 2024 13:47:05 GMT, Tejesh R wrote:
>> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091)
>> also created concurrent exception intermittently (monthly once/quarterly
>> once) on CI system. The issue was not able to be reproduced yet, hence
>> proposing an
On Mon, 29 Jan 2024 07:13:49 GMT, Christoph Langer wrote:
>> This picks up fixing the issue of
>> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
>> been integrated with #17224 but @prrace had concerns and so it was backed
>> out.
>>
>> I have now spent quite some
On Mon, 29 Jan 2024 07:13:49 GMT, Christoph Langer wrote:
>> This picks up fixing the issue of
>> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
>> been integrated with #17224 but @prrace had concerns and so it was backed
>> out.
>>
>> I have now spent quite some
On Mon, 29 Jan 2024 19:50:51 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains three additional commits
>>
On Tue, 30 Jan 2024 13:15:14 GMT, Alexey Ivanov wrote:
> Is there a guide which clearly states where `ExceptionCheck` is required?
I should've looked it up. [Java Native Interface
Specification](https://docs.oracle.com/en/java/javase/21/docs/specs/jni/index.html),
section on [handling Java
> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) also
> created concurrent exception intermittently (monthly once/quarterly once) on
> CI system. The issue was not able to be reproduced yet, hence proposing an
> alternative fix which uses iterators to compare the List.
On Mon, 29 Jan 2024 21:29:53 GMT, Phil Race wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>>
> The issue is w.r.t to way that Synth prints the table. In Synth, the printing
> of Table happens column wise by painting blocks of columns which is due to
> the fact that Graphics used which is `ProxyGrpahics2D` (which get selected in
> `RasterPrinterJob `class, otherwise it would be
On Mon, 29 Jan 2024 06:16:04 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/plaf/basic/BasicTreeUI/TreeCellRendererLeakTest.java
>> line 62:
>>
>>> 60: }
>>> 61:
>>> 62: public void finalize( ) {
>>
>> The `finalize` method is deprecated. Can't we use `Reference` API
On Tue, 30 Jan 2024 10:08:51 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JTable/PrintManualTest_FitWidthMultiple.java line 29:
>>
>>> 27: * @summary Verify if printed content is within border and all columns
>>> are
>>> 28: * printed for PrintMode.FIT_WIDTH
>>> 29: * @run
On Tue, 30 Jan 2024 09:58:33 GMT, Prasanta Sadhukhan
wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Test file updated
>
> test/jdk/javax/swing/JTable/PrintManualTest_FitWidthMultiple.java line 29:
>
>> 27: *
On Tue, 30 Jan 2024 09:35:55 GMT, Tejesh R wrote:
>> The issue is w.r.t to way that Synth prints the table. In Synth, the
>> printing of Table happens column wise by painting blocks of columns which is
>> due to the fact that Graphics used which is `ProxyGrpahics2D` (which get
>> selected in
On Tue, 30 Jan 2024 07:02:36 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
> The issue is w.r.t to way that Synth prints the table. In Synth, the printing
> of Table happens column wise by painting blocks of columns which is due to
> the fact that Graphics used which is `ProxyGrpahics2D` (which get selected in
> `RasterPrinterJob `class, otherwise it would be
On Tue, 30 Jan 2024 07:28:43 GMT, Tejesh R wrote:
>> The issue is w.r.t to way that Synth prints the table. In Synth, the
>> printing of Table happens column wise by painting blocks of columns which is
>> due to the fact that Graphics used which is `ProxyGrpahics2D` (which get
>> selected in
> The issue is w.r.t to way that Synth prints the table. In Synth, the printing
> of Table happens column wise by painting blocks of columns which is due to
> the fact that Graphics used which is `ProxyGrpahics2D` (which get selected in
> `RasterPrinterJob `class, otherwise it would be
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has
On Tue, 30 Jan 2024 00:14:05 GMT, Harshitha Onkar wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Suggestions integrated
>
> test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line
44 matches
Mail list logo
