Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Prasanta Sadhukhan
On Thu, 15 Feb 2024 01:11:51 GMT, Alexander Zvegintsev wrote: > There is an issue displaying the xembed icons in the appIndicators area which > are not displayed correctly with certain Gnome Shell versions. > It was already fixed > [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/comm

Re: RFR: 8187759: Background not refreshed when painting over a transparent JFrame [v2]

2024-02-14 Thread Tejesh R
On Thu, 15 Feb 2024 03:35:17 GMT, Sergey Bylokhov wrote: >> Somehow the automated test is not working flawless in windows and mac. In >> windows the image is getting stuck at center of white frame when its made >> automatic and in mac CI machines are failing even though the white screen is >>

Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Jayathirth D V
On Thu, 15 Feb 2024 03:29:39 GMT, Phil Race wrote: >>> Latest comment from Phil related to not disabling SystemTray for Gnome>=45 >>> needs to be taken care. >> >> With the current version string format, this should not happen unless the >> executable is somewhere else, environment variables a

Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Jayathirth D V
On Thu, 15 Feb 2024 01:11:51 GMT, Alexander Zvegintsev wrote: > There is an issue displaying the xembed icons in the appIndicators area which > are not displayed correctly with certain Gnome Shell versions. > It was already fixed > [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/comm

Re: RFR: 8187759: Background not refreshed when painting over a transparent JFrame [v2]

2024-02-14 Thread Sergey Bylokhov
On Tue, 6 Feb 2024 08:09:20 GMT, Tejesh R wrote: >> Since the fix was done for linux alone, I have restricted the test to it. >> Anyhow it works on windows and mac. > > Somehow the automated test is not working flawless in windows and mac. In > windows the image is getting stuck at center of wh

Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Phil Race
On Thu, 15 Feb 2024 03:26:54 GMT, Alexander Zvegintsev wrote: >> A fair question. My understanding of how Gnome vs Gnome Shell vs GTK version >> naming interact here is definitely not as clear as I'd like but I understand >> anything that is Gnome 3.X or 40+ (and < 44.1) is affected, leaving o

Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Alexander Zvegintsev
On Thu, 15 Feb 2024 03:13:05 GMT, Phil Race wrote: >> Latest comment from Phil related to not disabling SystemTray for Gnome>=45 >> needs to be taken care. >> Also do we need to worry about this issue being regression from some Gnome >> version like 3.38.0 and we need to disable SystemTray only

Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Phil Race
On Thu, 15 Feb 2024 02:58:45 GMT, Jayathirth D V wrote: >> And in fact we need to be VERY careful that we don't turn the existing code >> reporting "available == false" into "true" due to us simply detecting Gnome >> >= 45 .. that would be unfortunate. > > Latest comment from Phil related to no

Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Jayathirth D V
On Thu, 15 Feb 2024 02:20:51 GMT, Phil Race wrote: >> If we do that we could be up to 99.5% of cases aren't affected. > > And in fact we need to be VERY careful that we don't turn the existing code > reporting "available == false" into "true" due to us simply detecting Gnome > >= 45 .. that wou

Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Phil Race
On Thu, 15 Feb 2024 02:10:59 GMT, Phil Race wrote: >>> (arm-waving alert) 99% of apps don't do it at all, >> >> That may not be so arm-wavy actually considering this has been a problem for >> a while and we haven't exactly been inundated with complaints, especially >> since on RH & (I think) F

Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Alexander Zvegintsev
On Thu, 15 Feb 2024 01:59:48 GMT, Phil Race wrote: >> src/java.desktop/unix/classes/sun/awt/UNIXToolkit.java line 286: >> >>> 284: try { >>> 285: Process process = >>> 286: new ProcessBuilder("/usr/bin/gnome-shell", "--version") >> >> How it will affect perfo

Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Phil Race
On Thu, 15 Feb 2024 02:10:23 GMT, Phil Race wrote: >> According to my tests, the call to `getGnomeShellMajorVersion()` took about >> 25-35 ms on average, but it is a one-time task. > >> (arm-waving alert) 99% of apps don't do it at all, > > That may not be so arm-wavy actually considering this

Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Phil Race
On Thu, 15 Feb 2024 02:10:22 GMT, Alexander Zvegintsev wrote: >> Well, clearly the exec will take some non-zero time, but this part of >> initialising the SystemTray only happens once and (arm-waving alert) 99% of >> apps don't do it at all, so I don't see it as a major problem and it needs >

Re: RFR: 8323170 - j2dbench is using outdated javac source/target to be able to build by itself

2024-02-14 Thread Sergey Bylokhov
On Sat, 3 Feb 2024 12:31:16 GMT, Jiří Vaněk wrote: > added workarounds so freshly built jdk can set its necessary source/taret > without touching ant/makefile. In addition it can set itself as > compiler/runner without putting itself on path. Marked as reviewed by serb (Reviewer). ---

Re: RFR: 8323170 - j2dbench is using outdated javac source/target to be able to build by itself

2024-02-14 Thread Sergey Bylokhov
On Sat, 13 Jan 2024 20:17:06 GMT, Jiří Vaněk wrote: >Also, I'm not saying to bump source/target to something drastic like 20 or so, >I originally prosed 8 - which is the oldest live openjdk anyway. However >(unless something unexpected comes form >https://bugs.openjdk.org/browse/JDK-8323169) w

Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Phil Race
On Thu, 15 Feb 2024 01:41:49 GMT, Sergey Bylokhov wrote: >> There is an issue displaying the xembed icons in the appIndicators area >> which are not displayed correctly with certain Gnome Shell versions. >> It was already fixed >> [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/commit

Re: RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Sergey Bylokhov
On Thu, 15 Feb 2024 01:11:51 GMT, Alexander Zvegintsev wrote: > There is an issue displaying the xembed icons in the appIndicators area which > are not displayed correctly with certain Gnome Shell versions. > It was already fixed > [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/comm

RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray

2024-02-14 Thread Alexander Zvegintsev
There is an issue displaying the xembed icons in the appIndicators area which are not displayed correctly with certain Gnome Shell versions. It was already fixed [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/commit/20a81d786697f40880e81d867453b1bad9524ec1). However this is still a bl

Re: RFR: 8294148: Support JSplitPane for instructions and test UI

2024-02-14 Thread Harshitha Onkar
On Wed, 14 Feb 2024 13:22:48 GMT, Alexey Ivanov wrote: > This enhancement adds three methods to `PassFailJFrame.Builder`: > > 1. **`splitUIRight`** to display test UI to the right of the instructions; > 2. **`splitUIBottom`** to display test UI to the bottom of the instructions; > 3. `splitUI`:

Re: RFR: 8294148: Support JSplitPane for instructions and test UI

2024-02-14 Thread Harshitha Onkar
On Wed, 14 Feb 2024 19:11:42 GMT, Alexey Ivanov wrote: >> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1229: >> >>> 1227: * @throws IllegalArgumentException if {panelCreator} is >>> {@code null} >>> 1228: */ >>> 1229: public Builder splitUI(PanelCreator pa

Re: RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

2024-02-14 Thread Harshitha Onkar
On Wed, 14 Feb 2024 14:06:15 GMT, Alexey Ivanov wrote: >> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a >> single *Print* button as its test UI. To simplify the UI, I used the new >> `splitUI` method from #17845. >> >> In addition to it, I refactored the test: >>

Re: RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

2024-02-14 Thread Harshitha Onkar
On Wed, 14 Feb 2024 14:06:15 GMT, Alexey Ivanov wrote: >> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a >> single *Print* button as its test UI. To simplify the UI, I used the new >> `splitUI` method from #17845. >> >> In addition to it, I refactored the test: >>

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v14]

2024-02-14 Thread Phil Race
On Wed, 14 Feb 2024 09:52:12 GMT, vtstydev wrote: >> More correct way to take in consideration nonzero PHYSICALOFFSETX, >> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows >> platform under certain conditions real device prints shifted image on paper. > > vtstydev has

Re: RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane [v3]

2024-02-14 Thread Alexey Ivanov
On Wed, 14 Feb 2024 19:47:30 GMT, Alexander Zuev wrote: >> test/jdk/javax/swing/JTabbedPane/TabbedPaneNPECheck.java line 56: >> >>> 54: SwingUtilities.invokeAndWait(me::test); >>> 55: } finally { >>> 56: if (mainFrame != null) { >> >> should be disposed on EDT. >

Re: RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane [v4]

2024-02-14 Thread Alexey Ivanov
On Wed, 14 Feb 2024 19:50:34 GMT, Alexander Zuev wrote: >> Add null check for the Aqua LnF situation when tab is hidden die to the tabs >> overflow. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Moved frame disposal to

Re: RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane [v3]

2024-02-14 Thread Alexander Zuev
On Wed, 14 Feb 2024 06:58:15 GMT, Abhishek Kumar wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixing some coding style related issues > > test/jdk/javax/swing/JTabbedPane/TabbedPaneNPECheck.java line 56: > >>

Re: RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane [v4]

2024-02-14 Thread Alexander Zuev
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs > overflow. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Moved frame disposal to the EDT - Changes: - all: https://git.openjdk.org/jd

Re: RFR: 8294148: Support JSplitPane for instructions and test UI

2024-02-14 Thread Alexey Ivanov
On Wed, 14 Feb 2024 18:47:55 GMT, Harshitha Onkar wrote: >> This enhancement adds three methods to `PassFailJFrame.Builder`: >> >> 1. **`splitUIRight`** to display test UI to the right of the instructions; >> 2. **`splitUIBottom`** to display test UI to the bottom of the instructions; >> 3. `spl

Re: RFR: 8294148: Support JSplitPane for instructions and test UI

2024-02-14 Thread Harshitha Onkar
On Wed, 14 Feb 2024 13:22:48 GMT, Alexey Ivanov wrote: > This enhancement adds three methods to `PassFailJFrame.Builder`: > > 1. **`splitUIRight`** to display test UI to the right of the instructions; > 2. **`splitUIBottom`** to display test UI to the bottom of the instructions; > 3. `splitUI`:

Re: RFR: 8325858: Replace Unsafe usage in XEmbeddingContainer with FFM API [v3]

2024-02-14 Thread Per Minborg
> This PR proposes to remove the use of `Unsafe` in the class > `XEmbeddingContainer ` and replace it with the supported FFM API. > > I tried to make this PR as small as possible while opening up for migration > of other classes later on (such as `XEmbedServer` which can be modified > similarly

Re: RFR: 8325858: Replace Unsafe usage in XEmbeddingContainer with FFM API [v2]

2024-02-14 Thread Per Minborg
> This PR proposes to remove the use of `Unsafe` in the class > `XEmbeddingContainer ` and replace it with the supported FFM API. > > I tried to make this PR as small as possible while opening up for migration > of other classes later on (such as `XEmbedServer` which can be modified > similarly

Re: RFR: 8294148: Support JSplitPane for instructions and test UI

2024-02-14 Thread Alexey Ivanov
On Wed, 14 Feb 2024 13:22:48 GMT, Alexey Ivanov wrote: > This enhancement adds three methods to `PassFailJFrame.Builder`: > > 1. **`splitUIRight`** to display test UI to the right of the instructions; > 2. **`splitUIBottom`** to display test UI to the bottom of the instructions; > 3. `splitUI`:

Re: RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

2024-02-14 Thread Alexey Ivanov
On Wed, 14 Feb 2024 14:06:15 GMT, Alexey Ivanov wrote: >> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a >> single *Print* button as its test UI. To simplify the UI, I used the new >> `splitUI` method from #17845. >> >> In addition to it, I refactored the test: >>

Re: RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

2024-02-14 Thread Alexey Ivanov
> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a > single *Print* button as its test UI. To simplify the UI, I used the new > `splitUI` method from #17845. > > In addition to it, I refactored the test: > > - Extracted the rendered text into a constant to ensure the s

RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java

2024-02-14 Thread Alexey Ivanov
The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a single *Print* button as its test UI. To simplify the UI, I used the new `splitUI` method from #17845. In addition to it, I refactored the test: - Extracted the rendered text into a constant to ensure the same text is p

RFR: 8325858: Replace Unsafe usage in XEmbeddingContainer with FFM API

2024-02-14 Thread Per Minborg
This PR proposes to remove the use of `Unsafe` in the class `XEmbeddingContainer ` and replace it with the supported FFM API. I tried to make this PR as small as possible while opening up for migration of other classes later on (such as `XEmbedServer` which can be modified similarly under a sep

RFR: 8294148: Support JSplitPane for instructions and test UI

2024-02-14 Thread Alexey Ivanov
This enhancement adds three methods to `PassFailJFrame.Builder`: 1. **`splitUIRight`** to display test UI to the right of the instructions; 2. **`splitUIBottom`** to display test UI to the bottom of the instructions; 3. `splitUI`: a convenience method for a default split orientation, currently de

Re: RFR: 8233177: Remove testcase for JDK-8001470 as fix has been reverted [v3]

2024-02-14 Thread Alexey Ivanov
On Tue, 13 Feb 2024 07:50:15 GMT, Prasanta Sadhukhan wrote: >> Existing regression test is failing because textfield height is not as per >> test's expectation..Seems like the indic character being tried to render is >> not being loaded (probably because of missing glyphs) leading to 0 >> pre

Re: RFR: 8233177: Remove testcase for JDK-8001470 as fix has been reverted

2024-02-14 Thread Alexey Ivanov
On Wed, 14 Feb 2024 09:08:59 GMT, Prasanta Sadhukhan wrote: > > For me, it fails on Windows because no suitable font is found; > > It is not because of fonts availability...It's because of the order of `pack > `and `setVisible `being called which is causing some issue with > `i18nFieldView `l

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12) [v5]

2024-02-14 Thread Alexey Ushakov
On Fri, 9 Feb 2024 21:29:28 GMT, Laurent Bourgès wrote: >> - new executor modes (buffer & volatile) >> - support parallel rendering on several frames and / or screens >> - added robot calibration + optionally use rounded duration to min frame >> latency (120Hz) >> - give more statistics in verbo

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v14]

2024-02-14 Thread Alexey Ivanov
On Wed, 14 Feb 2024 09:52:12 GMT, vtstydev wrote: >> More correct way to take in consideration nonzero PHYSICALOFFSETX, >> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows >> platform under certain conditions real device prints shifted image on paper. > > vtstydev has

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v9]

2024-02-14 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith Renjith Kannath Pariyangad has upda

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v14]

2024-02-14 Thread vtstydev
> More correct way to take in consideration nonzero PHYSICALOFFSETX, > PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows > platform under certain conditions real device prints shifted image on paper. vtstydev has updated the pull request incrementally with one additional

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v8]

2024-02-14 Thread Andrey Turbanov
On Wed, 14 Feb 2024 09:06:19 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know

Re: RFR: 8233177: Remove testcase for JDK-8001470 as fix has been reverted

2024-02-14 Thread Prasanta Sadhukhan
On Tue, 13 Feb 2024 15:35:13 GMT, Alexey Ivanov wrote: > For me, it fails on Windows because no suitable font is found; It is not because of fonts availability...It's because of the order of `pack `and `setVisible `being called which is causing some issue with `i18nFieldView `layouting. If th

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v8]

2024-02-14 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith Renjith Kannath Pariyangad has upda

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v7]

2024-02-14 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith Renjith Kannath Pariyangad has upda