Re: RFR: 8325097: [macos14] DisposeInActionEventTest.html failed with message: "Event posted on wrong app contex" [v8]

2024-02-27 Thread Harshitha Onkar
On Tue, 27 Feb 2024 21:05:47 GMT, Alisen Chung wrote: >> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java >> line 77: >> >>> 75: .testUI(DisposeInActionEventTest::showFrameAndIcon) >>> 76: .build() >>> 77: .awaitAn

Re: RFR: 8325097: [macos14] DisposeInActionEventTest.html failed with message: "Event posted on wrong app contex" [v8]

2024-02-27 Thread Harshitha Onkar
On Tue, 27 Feb 2024 11:04:05 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove system property set > > test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java > li

Re: RFR: 8325097: [macos14] DisposeInActionEventTest.html failed with message: "Event posted on wrong app contex" [v9]

2024-02-27 Thread Alisen Chung
> Root cause of the test failure was fixed with > https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the > other fix also included a test update. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: update test from fe

Re: RFR: 8325097: [macos14] DisposeInActionEventTest.html failed with message: "Event posted on wrong app contex" [v8]

2024-02-27 Thread Alisen Chung
On Tue, 27 Feb 2024 11:05:20 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove system property set > > test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java > li

Re: RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v3]

2024-02-27 Thread Harshitha Onkar
On Fri, 23 Feb 2024 12:09:14 GMT, Alexey Ivanov wrote: >> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a >> single *Print* button as its test UI. To simplify the UI, I used the new >> `splitUI` method from #17845. >> >> In addition to it, I refactored the test: >>

Re: RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

2024-02-27 Thread Harshitha Onkar
On Thu, 15 Feb 2024 19:29:52 GMT, Harshitha Onkar wrote: >>> I have a printer configured but I'm running into `PrinterException: Access >>> is denied.` The option of saving to pdf doesn't work too. >> >> Do other printer tests work? It seems more like a system configuration issue >> rather tha

Withdrawn: 8319598: SMFParser misinterprets interrupted running status

2024-02-27 Thread duke
On Tue, 7 Nov 2023 19:18:28 GMT, Jan Trukenmüller wrote: > The MIDI file parser misinterprets events without status byte when they > appear directly after a Meta of SysEx event. > > For my bugfix I had to decide between two possible solutions: > - Strict solution: Throw an InvalidMidiDataExcept

Re: how to get find out the keyboard shortcut for the paste action?

2024-02-27 Thread Jeremy Wood
Sorry this went so long without a reply. > Is there a way to ask Java would the right keyboard shortcut should be? Yes. Try: int modifier = Toolkit.getDefaultToolkit().getMenuShortcutKeyMaskEx() A sample usage is below. import javax.swing.*; import javax.swing.border.EmptyBorder; import jav

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v4]

2024-02-27 Thread Julian Waters
On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie wrote: >> The idea of setting up general "toolchains" in the native build was good, >> but it turned out that we really only need a single toolchain, with a single >> twist: if it should use CC or CPP to link. This is better described by a >

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v4]

2024-02-27 Thread Magnus Ihse Bursie
On Tue, 27 Feb 2024 11:44:31 GMT, Daniel Jeliński wrote: > FWIW, when I added -lstdc++ before both -static-libstdc++ and replaced LDCXX > with LD, the code compiled and linked just fine. Both GCC and G++ call the same linker, and the parameter differences are well documented. It's only a matter

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v4]

2024-02-27 Thread Daniel Jeliński
On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie wrote: >> The idea of setting up general "toolchains" in the native build was good, >> but it turned out that we really only need a single toolchain, with a single >> twist: if it should use CC or CPP to link. This is better described by a >

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v3]

2024-02-27 Thread Julian Waters
On Tue, 27 Feb 2024 11:09:26 GMT, Magnus Ihse Bursie wrote: > > can we get rid of LDCXX? > > Yeah, that is something I plan to look into. Linking C++ object files with > gcc will fail; and it might be that linking pure C with g++ might be > problematic. If this is the case, I hope we can at le

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v4]

2024-02-27 Thread Magnus Ihse Bursie
> The idea of setting up general "toolchains" in the native build was good, but > it turned out that we really only need a single toolchain, with a single > twist: if it should use CC or CPP to link. This is better described by a > specific argument to SetupNativeCompilation, LANG := C++ or LANG

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v3]

2024-02-27 Thread Magnus Ihse Bursie
On Tue, 27 Feb 2024 08:14:56 GMT, Julian Waters wrote: > can we get rid of LDCXX? Yeah, that is something I plan to look into. Linking C++ object files with gcc will fail; and it might be that linking pure C with g++ might be problematic. If this is the case, I hope we can at least determine

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v3]

2024-02-27 Thread Magnus Ihse Bursie
On Tue, 27 Feb 2024 08:29:44 GMT, Julian Waters wrote: > All those new parameters to SetupNativeCompilation, were they always there > and the comments about them were just missing from the documentation about > the function? Yep. The toolchain definition was a way to "package" multiple argumen

Integrated: 8326583: Remove over-generalized DefineNativeToolchain solution

2024-02-27 Thread Magnus Ihse Bursie
On Fri, 23 Feb 2024 16:23:43 GMT, Magnus Ihse Bursie wrote: > The idea of setting up general "toolchains" in the native build was good, but > it turned out that we really only need a single toolchain, with a single > twist: if it should use CC or CPP to link. This is better described by a > sp

Re: RFR: 8325097: [macos14] DisposeInActionEventTest.html failed with message: "Event posted on wrong app contex" [v8]

2024-02-27 Thread Alexey Ivanov
On Mon, 26 Feb 2024 20:32:54 GMT, Alisen Chung wrote: >> Root cause of the test failure was fixed with >> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the >> other fix also included a test update. > > Alisen Chung has updated the pull request incrementally with one addi

Re: RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

2024-02-27 Thread Alexey Ivanov
On Thu, 15 Feb 2024 19:29:52 GMT, Harshitha Onkar wrote: >>> I have a printer configured but I'm running into `PrinterException: Access >>> is denied.` The option of saving to pdf doesn't work too. >> >> Do other printer tests work? It seems more like a system configuration issue >> rather tha

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v3]

2024-02-27 Thread Julian Waters
On Mon, 26 Feb 2024 20:21:55 GMT, Magnus Ihse Bursie wrote: >> The idea of setting up general "toolchains" in the native build was good, >> but it turned out that we really only need a single toolchain, with a single >> twist: if it should use CC or CPP to link. This is better described by a >

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v3]

2024-02-27 Thread Julian Waters
On Tue, 27 Feb 2024 08:07:38 GMT, Daniel Jeliński wrote: > can we get rid of LDCXX? On my system LDCXX is mapped to `g++` and LD is > `gcc`; I searched for the differences, and the only thing I could find is > that `g++` implicitly adds `-lstdc++ -shared-libgcc`; I suppose we could > explicitl

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v3]

2024-02-27 Thread Daniel Jeliński
On Mon, 26 Feb 2024 20:21:55 GMT, Magnus Ihse Bursie wrote: >> The idea of setting up general "toolchains" in the native build was good, >> but it turned out that we really only need a single toolchain, with a single >> twist: if it should use CC or CPP to link. This is better described by a >