Cleaned up five more tests.
Continuation of https://github.com/openjdk/jdk/pull/18184
Unfortunately one of the commits rendered the whole PR invalid so i closed it
and restarting it here.
All comments from the previous review are addressed.
-
Commit messages:
- 8316388: Opensource
On Mon, 11 Mar 2024 09:41:47 GMT, Alexander Zuev wrote:
> Clean up five more tests.
>
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
> test/jdk/javax/swing/JEditorP
Conversion of manual applet test to main based using PassFailJFrame manual
framework
-
Commit messages:
- 8327755: Convert javax/swing/JScrollBar/8039464/Test8039464.java applet to
main
Changes: https://git.openjdk.org/jdk/pull/18258/files
Webrev: https://webrevs.openjdk.org/?re
Conversion of manual applet test to main based using PassFailJFrame manual
framework
-
Commit messages:
- Fix
- 8327754: Convert javax/swing/JPopupMenu/7160604/bug7160604.java applet to
main
Changes: https://git.openjdk.org/jdk/pull/18257/files
Webrev: https://webrevs.openjdk.o
Convert javax/swing/text/GlyphView/4984669/bug4984669.java manual applet test
to main based using PassFailJFrame.
-
Commit messages:
- Conversion from Applet to Main
Changes: https://git.openjdk.org/jdk/pull/18256/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18256&range
On Wed, 13 Mar 2024 05:18:23 GMT, Prasanta Sadhukhan
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove redundant
On Wed, 13 Mar 2024 05:21:32 GMT, Prasanta Sadhukhan
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove redundant
On Wed, 13 Mar 2024 05:27:43 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Test file moved outside o
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Review comment fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18233/fi
On Tue, 12 Mar 2024 20:09:35 GMT, Alexander Zvegintsev
wrote:
>> This was recently converted from a manual Applet to a PassFailJFrame main
>> program
>> But I see a few things that could be tweaked
>> - Clarify instructions
>> - Set path to PassFailJFrame
>> - reduce timeout to default
>>
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Test file moved outside of folder
-
Changes:
- all: https://git.openjdk.org/jd
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Remove redundant dir
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Review comment update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18215
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Remove redundant dir
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18
On Tue, 12 Mar 2024 18:49:03 GMT, Phil Race wrote:
> This was recently converted from a manual Applet to a PassFailJFrame main
> program
> But I see a few things that could be tweaked
> - Clarify instructions
> - Set path to PassFailJFrame
> - reduce timeout to default
> - eliminate redunda
On Tue, 12 Mar 2024 00:39:26 GMT, Alisen Chung wrote:
>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - fix pfjframe builder styling and jtreg manual tag
> - revert
On Tue, 12 Mar 2024 20:47:47 GMT, Phil Race wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review updates
>
> test/jdk/javax/swing/border/Test4247606.java line 74:
>
>> 72:
>> 73: Box main = Box.createVertic
> Convert javax/swing/border/Test4247606.java applet test to main based test
> using PassFailJFrame.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Review updates
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18213/
> Convert javax/swing/border/Test6910490.java applet test to main based test
> using PassFailJFrame.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Review updates
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18229/
> Convert javax/swing/border/Test6910490.java applet test to main based test
> using PassFailJFrame.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Review updates
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18229/
On Wed, 13 Mar 2024 00:49:15 GMT, Alexander Zuev wrote:
>> I'm also a bit surprised I don't see all the rest of the original html &
>> java files anywhere now, not as deleted, not as changed.
>
> There's something wrong with the latest commit. Looking at it now.
Ok, either github or skara got m
On Tue, 12 Mar 2024 13:50:42 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove commented line
Ma
On Tue, 12 Mar 2024 12:49:06 GMT, Abhishek Kumar wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Changes requested by honkar (Reviewer).
test/jdk/javax/swing/JToggleButton/4128979/bug4128979.java line 81:
> 79:
> 80: public static JFrame cr
On Tue, 12 Mar 2024 11:15:38 GMT, Tejesh R wrote:
> Convert javax/swing/border/Test6910490.java applet test to main based test
> using PassFailJFrame.
Marked as reviewed by honkar (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18229#pullrequestreview-1933002465
On Wed, 13 Mar 2024 01:11:10 GMT, Damon Nguyen wrote:
>> Convert javax/swing/border/Test6910490.java applet test to main based test
>> using PassFailJFrame.
>
> test/jdk/javax/swing/border/Test6910490.java line 63:
>
>> 61: public JFrame init() {
>> 62: Insets insets = new Insets(10
On Tue, 12 Mar 2024 11:15:38 GMT, Tejesh R wrote:
> Convert javax/swing/border/Test6910490.java applet test to main based test
> using PassFailJFrame.
Changes look straightforward and good to me.
Changes requested by dnguyen (Committer).
test/jdk/javax/swing/border/Test6910490.java line 63:
On Wed, 13 Mar 2024 00:53:36 GMT, Alexander Zvegintsev
wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> minor formatting
Marked as rev
> The test is converted to main.
> Tested on Linux, Macos and Windows.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
minor formatting
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18250/files
- new: ht
On Wed, 13 Mar 2024 00:30:56 GMT, Harshitha Onkar wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor formatting
>
> test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 76:
>
>> 74: tex
On Tue, 12 Mar 2024 23:04:17 GMT, Phil Race wrote:
>> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html line 1:
>>
>>> 1:
>>
>> Looks like you forgot to remove this file ?
>
> I'm also a bit surprised I don't see all the rest of the original html & java
> files anywhere now, not as d
On Tue, 12 Mar 2024 19:37:55 GMT, Alexander Zvegintsev
wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1338:
>
>> 1336: if (panelCreator != null) {
>> 1337: if (splitUI && (
On Tue, 12 Mar 2024 19:28:45 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 76:
> 74: textArea
> 75: .append("Original Frame.getBounds() = %s\n
> Convert java/awt/im/JTextFieldTest.java applet test to main using
> PassFailJFrame.
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Fix suggested redudant changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1
On Tue, 12 Mar 2024 22:57:45 GMT, Phil Race wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor changes based on the review.
>> Tests moved to the components folders.
>
> test/jdk/javax/swing/JEditorPane/4694
On Tue, 12 Mar 2024 22:33:51 GMT, Alexander Zuev wrote:
>> Clean up five more tests.
>>
>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
>> test/jdk/javax/swing/JE
java/awt/List/SetFontTest/SetFontTest.html is a manual applet-based test.
It can be converted to a main program test using PassFailJFrame
-
Commit messages:
- 8328021
- 8328021
- 8328021
Changes: https://git.openjdk.org/jdk/pull/18255/files
Webrev: https://webrevs.openjdk.org/?r
> Clean up five more tests.
>
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
> test/jdk/javax/swing/JEditor
On Tue, 12 Mar 2024 20:04:52 GMT, Phil Race wrote:
>> No harm but a dependency on a library which isn't used.
>
> I am very much against including libraries that aren't needed.
> If this test isn't using any JRobot functionality, please remove it.
Ok, removed.
-
PR Review Comment:
On Tue, 12 Mar 2024 20:11:02 GMT, Phil Race wrote:
>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java line 83:
>>
>>> 81: robo.setAutoDelay(100);
>>> 82: robo.delay(1000);
>>> 83: robo.mouseMove(100,100);
>>
>> Suggestion:
>>
>> robo.mou
On Tue, 12 Mar 2024 16:48:28 GMT, Alexey Ivanov wrote:
>> The test is converted to use `PassFailJFrame`.
>>
>> I confirmed the updated test reproduce the original problem described in
>> [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text
>> displayed as missing glyphs
On Tue, 12 Mar 2024 18:50:58 GMT, Damon Nguyen wrote:
> Convert java/awt/im/JTextFieldTest.java applet test to main using
> PassFailJFrame.
test/jdk/java/awt/im/JTextFieldTest.java line 59:
> 57: .columns(40)
> 58: .position(PassFailJFrame.Position.TOP_LEFT_CORNER)
> 59
On Tue, 12 Mar 2024 18:50:58 GMT, Damon Nguyen wrote:
> Convert java/awt/im/JTextFieldTest.java applet test to main using
> PassFailJFrame.
test/jdk/java/awt/im/JTextFieldTest.java line 73:
> 71: frame.getContentPane().add(tf2);
> 72: frame.setDefaultCloseOperation(WindowConsta
On Tue, 12 Mar 2024 20:08:00 GMT, Phil Race wrote:
>> This is the only point with which I *disagree*.
>
> Right, I see no reason to catch anything unless it is known to sometimes
> happen and not be a problem.
Ok, removing the try/catch clause, this will cause this exception to cause test
to f
On Tue, 12 Mar 2024 20:33:29 GMT, Harshitha Onkar wrote:
>> The following InputMethod test, bug8148984.java is converted to main using
>> PassFailJFrame.
>>
>> - test instructions updated to make to more clear
>> - test renamed to PinyinIMCommaTest
>> - moved one directory above - /java/awt/im/
> The following InputMethod test, bug8148984.java is converted to main using
> PassFailJFrame.
>
> - test instructions updated to make to more clear
> - test renamed to PinyinIMCommaTest
> - moved one directory above - /java/awt/im/
> - html file deleted.
>
> Two tests are updated as part of thi
On Tue, 5 Mar 2024 15:51:56 GMT, Alexey Ivanov wrote:
>> A trivial change in a comment: consequent → _consecutive_ positions.
>>
>> This was found in [a code
>> review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for
>> [JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285
On Thu, 7 Mar 2024 20:07:19 GMT, Alisen Chung wrote:
>> Introduce delays in test to stabilize. Test passes 50x after fix.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update copyright, fix jtreg formatting, update frame
On Mon, 4 Mar 2024 15:52:45 GMT, Alexey Ivanov wrote:
> I'm adding a regression test for
> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a
> regression test for
> [JDK-8240690](https://bugs.openjdk.org/br
On Tue, 12 Mar 2024 11:30:00 GMT, Alexey Ivanov wrote:
>> It is not in the center, because in the latest commit I added
>> `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)`, as Alexey suggested.
>
> I have 1920×1200 with 150%. This is why it doesn't fit. The second frame
> overlapped instruc
On Tue, 12 Mar 2024 10:22:35 GMT, Alexander Zvegintsev
wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> review comments
test/jdk/java/
On Tue, 12 Mar 2024 06:43:36 GMT, Abhishek Kumar wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
We no longer need the extra folder level.
-
PR Comment: https://git.openjdk.org/jdk/pull/18215#issuecomment-1992552561
On Tue, 12 Mar 2024 10:01:25 GMT, Tejesh R wrote:
>> Convert javax/swing/border/Test4247606.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review updates
test/jdk/
On Tue, 12 Mar 2024 13:50:42 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove commented line
Ma
> The following InputMethod test, bug8148984.java is converted to main using
> PassFailJFrame.
>
> - test instructions updated to make to more clear
> - test renamed to PinyinIMCommaTest
> - moved one directory above - /java/awt/im/
> - html file deleted.
Harshitha Onkar has updated the pull req
On Tue, 12 Mar 2024 00:39:26 GMT, Alisen Chung wrote:
>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - fix pfjframe builder styling and jtreg manual tag
> - revert
On Mon, 11 Mar 2024 21:18:40 GMT, Alexey Ivanov wrote:
> The `Builder` class in `PassFailJFrame` is public and has a public
> constructor. At the same time, a better design would be to hide all the
> Builder constructors and rely on the `builder()` method which returns an
> instance of the `Bu
On Mon, 11 Mar 2024 11:53:14 GMT, Andrey Turbanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Bumped copyright year of the affected tests
>> Minor changes based on the review comments
>
> test/jdk/javax/swi
On Tue, 12 Mar 2024 18:49:03 GMT, Phil Race wrote:
> This was recently converted from a manual Applet to a PassFailJFrame main
> program
> But I see a few things that could be tweaked
> - Clarify instructions
> - Set path to PassFailJFrame
> - reduce timeout to default
> - eliminate redunda
On Tue, 12 Mar 2024 12:06:59 GMT, Alexey Ivanov wrote:
>> I prefer to keep things simpler and not to create an additional possible
>> point of failure. The supporting html file is self-explanatory and, if
>> needed, can be changed outside of fixing the test itself.
>
> It will make the test sel
On Tue, 12 Mar 2024 12:18:25 GMT, Alexey Ivanov wrote:
>> I believe it's unexpected because we don't expect `PropertyVetoException`,
>> in which case failure seems a better option.
>>
>> If anything changes so that `PropertyVetoException` would be thrown all the
>> time, the test would appear
On Tue, 12 Mar 2024 11:07:38 GMT, Alexander Zuev wrote:
>> Clean up five more tests.
>>
>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
>> test/jdk/javax/swing/JE
The following InputMethod test, bug8148984.java is converted to main using
PassFailJFrame.
- test intruction updated to make to more clear
- test renamed to PinyinIMCommaTest
- moved one directory above - /java/awt/im/
- html file deleted.
-
Commit messages:
- applet to main change
On Tue, 12 Mar 2024 19:28:45 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1338:
> 1336: if (panelCreator != null) {
> 1337: if (splitUI && (testWindo
The test is converted to main.
Tested on Linux, Macos and Windows.
-
Commit messages:
- 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java
applet test to main
- 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java
applet test to ma
On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov wrote:
>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
>> synchronized.
>>
>> Without synchronization, a thread checks if `filesLoader` is not null and
>> creates a new `FilesLoader` thread. If the thread is pre-empted betw
On Tue, 5 Mar 2024 17:40:01 GMT, Alexey Ivanov wrote:
>> The implementation of `Win32ShellFolder2.compareTo` is inconsistent: there
>> are cases where
>> `a < b & b < c but a == c`
>> which *violates its general contract*.
>>
>> In particular, it happens for the personal folder (*Documents*
On Tue, 12 Mar 2024 17:28:57 GMT, Alexander Scherbatiy
wrote:
> > But I am really surprised to see a PR rather than a discussion first as it
> > is making a lot of policy decisions
> > and implies we need to support something I am not sure we want to support.
>
> There was an email with the is
Convert java/awt/im/JTextFieldTest.java applet test to main using
PassFailJFrame.
-
Commit messages:
- Initial test changes
Changes: https://git.openjdk.org/jdk/pull/18247/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18247&range=00
Issue: https://bugs.openjdk.org/brow
This was recently converted from a manual Applet to a PassFailJFrame main
program
But I see a few things that could be tweaked
- Clarify instructions
- Set path to PassFailJFrame
- reduce timeout to default
- eliminate redundant folder
-
Commit messages:
- 8328004
- 8328004
C
On Mon, 11 Mar 2024 23:02:53 GMT, Phil Race wrote:
> Converts the manual applet test in the files ..
> SpanishDiacriticsTest/SpanishDiacriticsTest.html
> SpanishDiacriticsTest/SpanishDiacriticsTest.java
> .. to a main program using PassFailJFrame
>
> Added requires windows since it seems very w
On Tue, 12 Mar 2024 18:20:14 GMT, Harshitha Onkar wrote:
> The following InputMethod test, bug8154816.java is converted to main using
> PassFailJFrame.
>
> - test renamed to PinyinIMCapsTest
> - moved one directory above - /java/awt/im/
> - html file deleted.
I tried to automate this test usin
On Tue, 12 Mar 2024 12:34:57 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
This pull request has now been integrated.
Changeset: 7283c8b0
Author:Alexander Zvegintsev
URL:
https://git.openjdk.org/jdk/commit/7283c8b075aa289dbb
On Mon, 11 Mar 2024 17:53:48 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
This pull request has now been integrated.
Changeset: 30249c4c
Author:Alexander Zvegintsev
URL:
https://git.openjdk.org/jdk/commit/30249c4cca51dccd24
The following InputMethod test, bug8154816.java is converted to main using
PassFailJFrame.
- test renamed to PinyinIMCapsTest
- moved one directory above - /java/awt/im/
- html file deleted.
-
Commit messages:
- added requires tag
- removed extra newline
- test file added
- appl
> Converts the manual applet test in the files ..
> SpanishDiacriticsTest/SpanishDiacriticsTest.html
> SpanishDiacriticsTest/SpanishDiacriticsTest.java
> .. to a main program using PassFailJFrame
>
> Added requires windows since it seems very windows-specific.
>
> I got rid of the redundant extr
On Tue, 12 Mar 2024 18:21:58 GMT, Phil Race wrote:
>> Converts the manual applet test in the files ..
>> SpanishDiacriticsTest/SpanishDiacriticsTest.html
>> SpanishDiacriticsTest/SpanishDiacriticsTest.java
>> .. to a main program using PassFailJFrame
>>
>> Added requires windows since it seems
On Tue, 12 Mar 2024 17:36:46 GMT, Phil Race wrote:
>> Converts the manual applet test in the files ..
>> SpanishDiacriticsTest/SpanishDiacriticsTest.html
>> SpanishDiacriticsTest/SpanishDiacriticsTest.java
>> .. to a main program using PassFailJFrame
>>
>> Added requires windows since it seems
On Tue, 12 Mar 2024 17:24:22 GMT, Phil Race wrote:
>> What if we spell the conditions explicitly:
>>
>> The text field should display ''o (i.e. two apostrophes and o without an
>> acute), press Pass.
>> If you see ó (i.e. o with an acute), press Fail.
>
> I will reword it but the text is the sa
On Tue, 12 Mar 2024 12:50:16 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8327856
>> - 8327856
>
> test/jdk/java/awt/InputMethods/SpanishDiacriticsTest.java line 89:
>
>> 87: frame.se
> Converts the manual applet test in the files ..
> SpanishDiacriticsTest/SpanishDiacriticsTest.html
> SpanishDiacriticsTest/SpanishDiacriticsTest.java
> .. to a main program using PassFailJFrame
>
> Added requires windows since it seems very windows-specific.
>
> I got rid of the redundant extr
On Tue, 12 Mar 2024 16:41:12 GMT, Phil Race wrote:
> But I am really surprised to see a PR rather than a discussion first as it is
> making a lot of policy decisions
and implies we need to support something I am not sure we want to support.
There was an email with the issue discussion on the cl
On Tue, 12 Mar 2024 17:12:08 GMT, Alexey Ivanov wrote:
>> I misread it. If the text is `''o` instead of `ó`…
>
> What if we spell the conditions explicitly:
>
> The text field should display ''o (i.e. two apostrophes and o without an
> acute), press Pass.
> If you see ó (i.e. o with an acute),
On Tue, 12 Mar 2024 17:08:18 GMT, Alexey Ivanov wrote:
>> It isn't a single char. It is as written - the sequence of 3 characters -
>> "single quote" "single quote", "latin lower case o"
>
> I misread it. If the text is `''o` instead of `ó`…
What if we spell the conditions explicitly:
The te
On Tue, 12 Mar 2024 17:05:04 GMT, Phil Race wrote:
>> test/jdk/java/awt/InputMethods/SpanishDiacriticsTest.java line 60:
>>
>>> 58: expected behaviour for this test.
>>> 59:
>>> 60:If the text field displays ''o, (i.e. o should be without an
>>> acute)
>>
>> Suggestion:
>>
On Tue, 12 Mar 2024 12:47:46 GMT, Alexey Ivanov wrote:
>> Converts the manual applet test in the files ..
>> SpanishDiacriticsTest/SpanishDiacriticsTest.html
>> SpanishDiacriticsTest/SpanishDiacriticsTest.java
>> .. to a main program using PassFailJFrame
>>
>> Added requires windows since it se
On Tue, 12 Mar 2024 12:34:57 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
Marked as reviewed by prr (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18231#pullrequestreview-1931679316
On Mon, 11 Mar 2024 21:18:40 GMT, Alexey Ivanov wrote:
> The `Builder` class in `PassFailJFrame` is public and has a public
> constructor. At the same time, a better design would be to hide all the
> Builder constructors and rely on the `builder()` method which returns an
> instance of the `Bu
On Tue, 12 Mar 2024 08:33:41 GMT, Alexey Ivanov wrote:
> This is to simplify `TrayIconScalingTest.java`.
>
> 1. Rename `createAndShowGUI` to `createAndShowTrayIcon` which is more
> specific.
> 2. Move creating tray icon to the top.
> 3. Streamline PassFailJFrame with the chained calls, includin
On Tue, 12 Mar 2024 16:48:28 GMT, Alexey Ivanov wrote:
>> The test is converted to use `PassFailJFrame`.
>>
>> I confirmed the updated test reproduce the original problem described in
>> [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text
>> displayed as missing glyphs
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy
wrote:
> The fix provides ability to print Black & White pages on macOS.
>
> Cocoa API has
> [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode)
> function but it is marked
On Tue, 12 Mar 2024 16:36:15 GMT, Phil Race wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use the correct path to library
>
> test/jdk/java/awt/font/TextLayout/ArabicBox.java line 38:
>
>> 36: * @bug 4427483
>
> The test is converted to use `PassFailJFrame`.
>
> I confirmed the updated test reproduce the original problem described in
> [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text
> displayed as missing glyphs.
Alexey Ivanov has updated the pull request incrementally wi
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy
wrote:
> The fix provides ability to print Black & White pages on macOS.
>
> Cocoa API has
> [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode)
> function but it is marked
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy
wrote:
> The fix provides ability to print Black & White pages on macOS.
>
> Cocoa API has
> [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode)
> function but it is marked
On Tue, 12 Mar 2024 13:35:33 GMT, Alexey Ivanov wrote:
> The test is converted to use `PassFailJFrame`.
>
> I confirmed the updated test reproduce the original problem described in
> [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text
> displayed as missing glyphs.
te
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy
wrote:
> The fix provides ability to print Black & White pages on macOS.
>
> Cocoa API has
> [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode)
> function but it is marked
On Tue, 12 Mar 2024 12:34:57 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18231#pullrequestreview-1931511748
On Tue, 12 Mar 2024 15:24:21 GMT, Magnus Ihse Bursie wrote:
> Please re-test.
Hi Magnus, thanks for the adjustments. I reenabled your patch in our
build/test queue .
-
PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1992009593
On Mon, 11 Mar 2024 12:27:08 GMT, Joachim Kern wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert SEARCH_PATH changes
>
> make/autoconf/toolchain.m4 line 940:
>
>> 938: if test "x$OPENJDK_TARGET_OS" =
On Mon, 11 Mar 2024 12:44:55 GMT, Matthias Baesken wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert SEARCH_PATH changes
>
> With this change added, currently configure fails
>
>
> checking for ibm-l
1 - 100 of 198 matches
Mail list logo
