On Tue, 30 Apr 2024 20:38:06 GMT, Harshitha Onkar wrote:
>> For the following manual test, more instructions are added as to what to
>> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
>> clarity.
>
> Harshitha Onkar has updated the pull request incrementally with one
On Thu, 2 May 2024 05:14:59 GMT, Abhishek Kumar wrote:
> Also, since this test is for all platforms, did you test on mac?
On Mac, the original bug is reproducible. Content Opaque, Tabs Opaque and
Tabpane Opaque properties doesn't work similar to the Metal/Nimbus/GTK LAF.
-
PR
On Thu, 2 May 2024 05:04:00 GMT, Tejesh R wrote:
> > > here
> >
> >
> > There are no changes to the COPYING file in the newest version of giblib so
> > there weren't any changes here either
>
> The latest version has `= MIT LICENSE` instead of `The GIFLIB distribution is
> Copyright (c)
On Fri, 26 Apr 2024 21:37:56 GMT, Alisen Chung wrote:
> Updating giflib, clientlibs tests are green on all platforms
Marked as reviewed by tr (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/18985#pullrequestreview-2034836229
On Tue, 30 Apr 2024 10:25:42 GMT, Prasanta Sadhukhan
wrote:
> Also, since this test is for all platforms, did you test on mac?
Not tested on mac since it was meant only for Nimbus/GTK, will check and update.
-
PR Review Comment:
On Tue, 30 Apr 2024 18:45:41 GMT, Alisen Chung wrote:
> > here
>
> There are no changes to the COPYING file in the newest version of giblib so
> there weren't any changes here either
The latest version has `= MIT LICENSE` instead of `The GIFLIB distribution is
Copyright (c) 1997 Eric S.
On Tue, 30 Apr 2024 07:19:50 GMT, Prasanta Sadhukhan
wrote:
> As per my testing in windows, this is not satisfied for Nimbus and all tabs
> are gray, not only the selected one..
> Is this a bug not solved yet?
Don't think this as a bug. Since in Nimbus the tab colors and gradients are
On Tue, 30 Apr 2024 16:49:49 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/Focus/6981400/Test1.java line 186:
>>
>>> 184: Util.clickOnComp(compToClick, robot);
>>> 185:
>>> 186: if (Platform.isOnWayland()) {
>>
>> If the goal is just to move the window to the front
On Wed, 1 May 2024 16:43:13 GMT, Phil Race wrote:
> The issue was discovered by failing a closed test that you wrote some time
> ago.
=) ok
-
PR Comment: https://git.openjdk.org/jdk/pull/18950#issuecomment-2089251764
On Thu, 25 Apr 2024 17:22:48 GMT, Alexander Zvegintsev
wrote:
>> This fix adds missing doPrivileged calls in TokenStorage, which is used to
>> help take screenshots in Wayland.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last
On Wed, 1 May 2024 19:24:24 GMT, Alexander Scherbatiy
wrote:
>> The fix adds new public `OutputBin` print attribute class which allow to set
>> a printer output bin in a `PrinterJob` class. The corresponding internal
>> `CustomOutputBin` class is added as well.
>>
>> - Constants used in
On Sat, 13 Apr 2024 22:58:31 GMT, Phil Race wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add output bins support to the common print dialog
>
>
On Sat, 13 Apr 2024 21:26:35 GMT, Phil Race wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add output bins support to the common print dialog
>
>
> The fix adds new public `OutputBin` print attribute class which allow to set
> a printer output bin in a `PrinterJob` class. The corresponding internal
> `CustomOutputBin` class is added as well.
>
> - Constants used in `OutputBin` class are based on [Internet Printing
> Protocol (IPP):
On Wed, 1 May 2024 16:40:21 GMT, Phil Race wrote:
> So it sounds like the JDK mods are no longer needed, at least for current
> mainline compilers, and I assume you verified that all those formatting
> changes are from upstream, not your IDE ?
>
> If yes, approved, but it needs a 2nd reviewer
On Tue, 30 Apr 2024 21:33:41 GMT, Alexander Zvegintsev
wrote:
>> does this also apply for the other JDK modification for old compilers as
>> well?
>
> Regarding the `JDK modifications to support building using old compilers`
> from `gif_lib.h`:
>
> I found my old [review
>
On Fri, 26 Apr 2024 21:37:56 GMT, Alisen Chung wrote:
> Updating giflib, clientlibs tests are green on all platforms
Changes LGTM then.
-
Marked as reviewed by dnguyen (Committer).
PR Review: https://git.openjdk.org/jdk/pull/18985#pullrequestreview-2034229002
On Wed, 1 May 2024 16:50:15 GMT, Phil Race wrote:
>> @prrace Yes but I have to postpone this work.
>
> @scientificware please say when you will be getting back to this
@prrace Sorry for the delay about all my contributions but I won a racing bib
for the "Marathon Pour Tous" of Paris 2024
On Thu, 11 Apr 2024 17:23:19 GMT, Alexey Ivanov wrote:
>> I added the backticks so it now shows the source but all I did was
>> `"s///"`
>>
>> Yes, I think it might be wise to add such a test scenario.
>
> Added `HTMLUnderlineOnly.java` and `HTMLStrikeOnly.java` which test different
>
On Thu, 11 Apr 2024 17:20:12 GMT, Alexey Ivanov wrote:
>> The value of the
>> [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS
>> property is not inherited correctly in Swing. If the `` element is
>> mixed with `` or ``, only the value from the `style` attribute of
>>
On Fri, 19 Jan 2024 19:27:54 GMT, ScientificWare wrote:
>> @scientificware - are you still working on this ?
>
> @prrace Yes but I have to postpone this work.
@scientificware please say when you will be getting back to this
-
PR Comment:
On Sun, 28 Apr 2024 15:45:35 GMT, 柳鲲鹏 wrote:
>> 柳鲲鹏 has updated the pull request with a new target base due to a merge or a
>> rebase. The incremental webrev excludes the unrelated changes brought in by
>> the merge/rebase. The pull request contains ten additional commits since the
>> last
On Tue, 7 Nov 2023 19:18:28 GMT, Jan Trukenmüller wrote:
> The MIDI file parser misinterprets events without status byte when they
> appear directly after a Meta of SysEx event.
>
> For my bugfix I had to decide between two possible solutions:
> - Strict solution: Throw an
On Tue, 30 Apr 2024 07:54:52 GMT, Alexander Zvegintsev
wrote:
> > How hard is it to create a new test for this issue?
>
> The issue was discovered by failing a closed test that you wrote some time
> ago.
And while we need that existing test to pass I don't think it is worth writing
a 2nd
On Fri, 26 Apr 2024 21:37:56 GMT, Alisen Chung wrote:
> Updating giflib, clientlibs tests are green on all platforms
So it sounds like the JDK mods are no longer needed, at least for current
mainline compilers, and I assume you verified that all those formatting changes
are from upstream, not
On Wed, 1 May 2024 16:29:10 GMT, Alexey Ivanov wrote:
> As soon as I integrated
> `test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java`
> #18957, the test started failing in CI on Linux and macOS. There are six
> failures found so far.
>
> Before starting code review
On Wed, 1 May 2024 16:29:10 GMT, Alexey Ivanov wrote:
> As soon as I integrated
> `test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java`
> #18957, the test started failing in CI on Linux and macOS. There are six
> failures found so far.
>
> Before starting code review
On Wed, 1 May 2024 16:29:10 GMT, Alexey Ivanov wrote:
> As soon as I integrated
> `test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java`
> #18957, the test started failing in CI on Linux and macOS. There are six
> failures found so far.
>
> Before starting code review
As soon as I integrated
`test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java`
#18957, the test started failing in CI on Linux and macOS. There are six
failures found so far.
Before starting code review and later, I ran the test many times on CI and I
never saw so many
On Thu, 25 Apr 2024 16:37:39 GMT, Alexey Ivanov wrote:
> This PR provides a regression test for
> [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in
> BasicDirectoryModel.validateFileCache_ reviewed in #18111.
>
> The test is inspired and based on `ConcurrentModification`
30 matches
Mail list logo
