Re: RFR: 8331619: TabbedPane's contentOpaque, tabsOpaque and setOpaque doesn't work properly in Aqua LAF

2024-05-10 Thread Abhishek Kumar
On Fri, 10 May 2024 17:33:53 GMT, Sergey Bylokhov wrote: > Is it possible to change all these properties in the native apps? I am not sure whether we can change the tab or content area color in native apps. I will check and update. - PR Comment:

Re: RFR: 8331746: Create a test to verify that the cmm id is not ignored

2024-05-10 Thread Alexey Ivanov
On Mon, 6 May 2024 20:51:55 GMT, Sergey Bylokhov wrote: > The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and > verify that the cmm id of the icc profile is properly reported. Before > JDK-8321489 we always report 'lcms' as a cmm id. Marked as reviewed by aivanov

Re: RFR: 8331619: TabbedPane's contentOpaque, tabsOpaque and setOpaque doesn't work properly in Aqua LAF

2024-05-10 Thread Sergey Bylokhov
On Fri, 10 May 2024 07:05:11 GMT, Abhishek Kumar wrote: > JTabbedPane's contentOpaque and tabsOpaque properties are not honored in Aqua > L JTabbedPane's content area and tab background color are not as expected > when tabbedpane opacity is set to true or false. Fix is to handle the opacity >

Integrated: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected

2024-05-10 Thread Tejesh R
On Fri, 19 Apr 2024 07:12:36 GMT, Tejesh R wrote: > Instructions set has been updated as per OS specific. JTable keyboard > navigation is tested in each OS and according it's current implementation the > instructions has been updated (Few has been removed and few has been > updated). >

Re: RFR: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected [v5]

2024-05-10 Thread Abhishek Kumar
On Fri, 10 May 2024 09:29:32 GMT, Tejesh R wrote: >> Instructions set has been updated as per OS specific. JTable keyboard >> navigation is tested in each OS and according it's current implementation >> the instructions has been updated (Few has been removed and few has been >> updated). >>

Re: RFR: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected [v4]

2024-05-10 Thread Tejesh R
On Fri, 10 May 2024 07:30:18 GMT, Abhishek Kumar wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review updates > > test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 192: > >> 190: .columns(50)

Re: RFR: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected [v5]

2024-05-10 Thread Tejesh R
> Instructions set has been updated as per OS specific. JTable keyboard > navigation is tested in each OS and according it's current implementation the > instructions has been updated (Few has been removed and few has been > updated). > PassFailJFrame.builder is used. Tejesh R has updated the

Re: RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled [v3]

2024-05-10 Thread Dmitry Markov
On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Added pageloader cancel before new page creation along with code >> restructuring. Moved all page loading calls inside synchronize to make it >> thread safe. >> >> Regards, >> Renjith. > > Renjith

Re: RFR: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected [v4]

2024-05-10 Thread Abhishek Kumar
On Fri, 10 May 2024 05:31:31 GMT, Tejesh R wrote: >> Instructions set has been updated as per OS specific. JTable keyboard >> navigation is tested in each OS and according it's current implementation >> the instructions has been updated (Few has been removed and few has been >> updated). >>

RFR: 8331619: TabbedPane's contentOpaque, tabsOpaque and setOpaque doesn't work properly in Aqua LAF

2024-05-10 Thread Abhishek Kumar
JTabbedPane's contentOpaque and tabsOpaque properties are not honored in Aqua L JTabbedPane's content area and tab background color are not as expected when tabbedpane opacity is set to true or false. Fix is to handle the opacity behavior correctly and inline with other LAF as well. Existing