On Tue, 11 Jun 2024 06:05:02 GMT, Prasanta Sadhukhan
wrote:
> TestUngrab.java was added for
> [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix but the
> test can be run for all platforms as the behaviour is common for all
> CI run job link in JBS..
This pull request has
On Tue, 11 Jun 2024 06:05:02 GMT, Prasanta Sadhukhan
wrote:
> TestUngrab.java was added for
> [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix but the
> test can be run for all platforms as the behaviour is common for all
> CI run job link in JBS..
There are few unused
On Tue, 11 Jun 2024 06:05:02 GMT, Prasanta Sadhukhan
wrote:
> TestUngrab.java was added for
> [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix.
I think that this test was added for
[JDK-8325435](https://bugs.openjdk.org/browse/JDK-8325435) that you recently
integrated.
Looks like there was a typo for null character. It should be `'\0'` instead of
`'/0'`.
Build with clang toolchain with the help of [this
PR](https://github.com/openjdk/jdk/pull/17019) and after the changes there is
no warning.
-
Commit messages:
- typo for null character fixed
On Wed, 12 Jun 2024 04:17:02 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/JMenu/TestUngrab.java line 28:
>>
>>> 26: /*
>>> 27: * @test
>>> 28: * @bug 8267374
>>
>> Should the current bug id be updated here?
>
> No, we only put the product ids in the tag and this is test-only fix
On Tue, 11 Jun 2024 06:05:02 GMT, Prasanta Sadhukhan
wrote:
> TestUngrab.java was added for
> [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix but the
> test can be run for all platforms as the behaviour is common for all
> CI run job link in JBS..
Marked as reviewed by
On Wed, 12 Jun 2024 04:12:13 GMT, Tejesh R wrote:
>> TestUngrab.java was added for
>> [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix but the
>> test can be run for all platforms as the behaviour is common for all
>> CI run job link in JBS..
>
>
On Wed, 12 Jun 2024 04:05:32 GMT, Jayathirth D V wrote:
>> Resolved typos related to ArrayIndexOutOfBoundsException in BufferedImage
>> and JTableHeader.
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
Looks
On Tue, 11 Jun 2024 06:05:02 GMT, Prasanta Sadhukhan
wrote:
> TestUngrab.java was added for
> [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix but the
> test can be run for all platforms as the behaviour is common for all
> CI run job link in JBS..
On Wed, 12 Jun 2024 04:02:46 GMT, Jayathirth D V wrote:
> I see there are 3 other places where we have this typo and one among them is
> in client code. So i have updated that file.
That's right the other two places were not in client area so I specified only
the open test. Thank you for
On Tue, 11 Jun 2024 16:57:58 GMT, Abhishek Kumar wrote:
> There are few other places where this typo is present, one of them is in this
> open test. `open\test\jdk\javax\swing\JTabbedPane\4361477\bug4361477.java` I
> think this can be addressed in this PR.
I see there are 3 other places where
> Resolved typos related to ArrayIndexOutOfBoundsException in BufferedImage and
> JTableHeader.
Jayathirth D V has updated the pull request incrementally with one additional
commit since the last revision:
Update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19654/files
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert updated translation
>
> Did not look at each for translation accuracy (did some for Japanese), but
> looks good
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert updated translation
>
> Did not look at each for translation accuracy (did some for Japanese), but
> looks good
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The
On Mon, 10 Jun 2024 20:37:41 GMT, Damon Nguyen wrote:
>> src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties
>> line 32:
>>
>>> 30: border.jobattributes=作业属性
>>> 31: border.media=介质
>>> 32: border.output=出纸
>>
>> What triggered this ? Just someone noticing it and
On Sat, 8 Jun 2024 00:49:29 GMT, Alisen Chung wrote:
>> test/jdk/javax/swing/JPopupMenu/MouseDragPopupTest.java line 59:
>>
>>> 57: });
>>> 58: robot.waitForIdle();
>>> 59: robot.delay(1000);
>>
>> Suggestion:
>>
>> robot.setAutoDelay(100);
>>
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementally with one additional
On Tue, 11 Jun 2024 11:24:13 GMT, Tejesh R wrote:
> What happens when we introduce another component in-between, say for example
> in the test we add one more Frame in-between printDailogButton and mainFrame.
> Which frame does get activated on close of print dialog? The intermediate one
> or
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The translation tool adjusted some definitions, which causes some
On Tue, 11 Jun 2024 06:00:19 GMT, Christian Stein wrote:
>> "Ausgabefächer" is the best German translation here.
>
> The reason for going with "Bereich (area)" instead of "Fach (compartment)" is
> that an area is more general compared to a compartment. At least in German:
> every "Fach" is a
On Tue, 4 Jun 2024 16:24:23 GMT, Alexey Ivanov wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Swing was added in JDK 1.2
>
> src/java.desktop/share/classes/java/awt/geom/Path2D.java line 297:
>
>> 295:
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The
On Tue, 11 Jun 2024 17:15:49 GMT, Naoto Sato wrote:
>> Yeah, I believe you're right. Noted as something else to file against the
>> translation tool.
>
> Just out of curiosity, do we know why `\t` was attached in the first place? I
> don't think it is with the original English properties.
I
On Mon, 10 Jun 2024 19:45:14 GMT, Damon Nguyen wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties
>> line 278:
>>
>>> 276: UndeclaredElementInContentSpec = Contentmodell des Elements
>>> "{0}" verweist auf das nicht deklarierte
8334032: Missing @since tag in new class OutputBin
-
Commit messages:
- FIXUP: Trailing Whitespace
- 8334032: javax.print: Missing @since tag in new class OutputBin
Changes: https://git.openjdk.org/jdk/pull/19662/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=19662=00
On Tue, 11 Jun 2024 12:22:24 GMT, Jayathirth D V wrote:
> Resolved typos related to ArrayIndexOutOfBoundsException in BufferedImage and
> JTableHeader.
There are few other places where this typo is present, one of them is in this
open test.
On Mon, 10 Jun 2024 20:33:05 GMT, Alexey Ivanov wrote:
> These improvements to the test can be combined with fixing
> [JDK-8333026](https://bugs.openjdk.org/browse/JDK-8333026), or the test can
> be updated separately.
>
> I'll submit a new bug to track this activity. Thank you for bringing
Resolved typos related to ArrayIndexOutOfBoundsException in BufferedImage and
JTableHeader.
-
Commit messages:
- 8333801: Typos in @code references of BufferedImage and JTableHeader
Changes: https://git.openjdk.org/jdk/pull/19654/files
Webrev:
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
This pull request has now been integrated.
Changeset: 86b5
On Fri, 7 Jun 2024 20:34:23 GMT, Alisen Chung wrote:
>> Add a check for previous focused window on modal unblocking. If the owner of
>> a closing dialog was the last focused window, then the owner of the dialog
>> should regain focus.
>
> Alisen Chung has updated the pull request incrementally
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The
On Sun, 9 Jun 2024 19:35:04 GMT, Justin Lu wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove double quotes
>
> src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties
> line 285:
>
TestUngrab.java was added for
[JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix but the
test can be run for all platforms as the behaviour is common for all
CI run job link in JBS..
-
Commit messages:
- Test-fix
Changes:
On Mon, 10 Jun 2024 20:01:47 GMT, Alisen Chung wrote:
>> Issue is a mouse drag will trigger a popup in macos, but not in linux or
>> windows.
>> The solution is to add a check for a mouse pressed event to show popup and
>> prevent mouse entered events from triggering the popup
>
> Alisen Chung
On Mon, 10 Jun 2024 20:34:10 GMT, Damon Nguyen wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties
>> line 409:
>>
>>> 407: compiler.err.unconditional.pattern.and.default=Switch umfasst sowohl
>>> ein nicht bedingtes Muster als auch ein Standardlabel
On Tue, 11 Jun 2024 05:43:12 GMT, Christian Stein wrote:
>> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties
>> line 66:
>>
>>> 64: label.size=Göße:
>>> 65: label.source=:
>>> 66: label.outputbins=Aächer:
>>
>> How confident are we in this ?
>> google translate says
38 matches
Mail list logo
