On Wed, 19 Jun 2024 08:38:29 GMT, Tejesh R wrote:
> Have you ever noticed focus going out of dialog/frame when application starts
> in CI system? In this test, since you are directly using TAB to navigate till
> Cancel button, any changes that focus might not be on the Dialog on startup?
> I
> On cancelling PageDialog, same PageFormat object should be returned which
> stopped working after
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so that correct
> value is returned from PageDialog.show action..
> An
On Wed, 19 Jun 2024 10:39:35 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test fix
>
> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 694:
>
>> 692:
On Wed, 19 Jun 2024 10:32:28 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test fix
>
> test/jdk/java/awt/print/PrinterJob/PageDialogCancelTest.java line 57:
>
>> 55:
> On cancelling PageDialog, same PageFormat object should be returned which
> stopped working after
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so that correct
> value is returned from PageDialog.show action..
> An
On Mon, 17 Jun 2024 05:07:22 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java
>> line 369:
>>
>>> 367: @Override
>>> 368: public void setEnabled(boolean enabled) {
>>> 369: if (splitPane.isOneTouchExpandable()
On Wed, 19 Jun 2024 19:20:24 GMT, Alexey Ivanov wrote:
>>> You should rather call
>>> [setDelay(50)](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294)
>>> to add the delay between method calls.
>>
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote:
> Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a
> delay to stable the test and multiple run in CI is Ok. Link is added in JBS.
Marked as reviewed by aivanov (Reviewer).
-
PR Review:
On Wed, 19 Jun 2024 15:38:10 GMT, Alexander Zvegintsev
wrote:
>>> How does it help? You're delaying EDT.
>>
>> I was unable to reproduce the failure scenario in my local machine but
>> didn't observe any failure in mach5 also. Will ask Vitaly or @azvegint to
>> verify as they are able to
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote:
> Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a
> delay to stable the test and multiple run in CI is Ok. Link is added in JBS.
Marked as reviewed by azvegint (Reviewer).
-
PR Review:
On Wed, 19 Jun 2024 11:15:54 GMT, Abhishek Kumar wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 113:
>>
>>> 111: }
>>> 112: setDelay(50);
>>> 113: return panel;
>>
>> How does it help? You're delaying EDT.
>>
>> You should rather call
>>
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the
> This patch contains a set of changes to improve static builds. They will pave
> the way for implementing a full static-only java launcher. The changes here
> will:
>
> 1) Make sure non-exported symbols are made local in the static libraries.
> This means that the risk of symbol conflict is
> This patch contains a set of changes to improve static builds. They will pave
> the way for implementing a full static-only java launcher. The changes here
> will:
>
> 1) Make sure non-exported symbols are made local in the static libraries.
> This means that the risk of symbol conflict is
On Tue, 18 Jun 2024 20:31:58 GMT, Phil Race wrote:
> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
> This reduces the coupling between the java.desktop module and the internals
> of the java.base module.
>
> The code being changed here is not particularly performance sensitive,
On Tue, 18 Jun 2024 16:41:12 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition update
>
> test/jdk/com/sun/java/swing/plaf/gtk/TestMenuMnemonicOnAltPress.java line 44:
>
>> 42: import
On Tue, 18 Jun 2024 16:26:49 GMT, Alexey Ivanov wrote:
> Can we use or even re-use the logic in Windows L to display and hide menu
> mnemonics?
For windows behavior is different than linux.
https://github.com/openjdk/jdk/pull/18992#issuecomment-2100033545
I don't think that the logic in
On Wed, 19 Jun 2024 11:01:26 GMT, Alexey Ivanov wrote:
> How does it help? You're delaying EDT.
I was unable to reproduce the failure scenario in my local machine but didn't
observe any failure in mach5 also. Will ask Vitaly or @azvegint to verify as
they are able to replicate the failure.
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote:
> Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a
> delay to stable the test and multiple run in CI is Ok. Link is added in JBS.
You should ask Vitaly to test your changeset in his environment to confirm the
On Wed, 19 Jun 2024 08:30:42 GMT, Prasanta Sadhukhan
wrote:
>> On cancelling PageDialog, same PageFormat object should be returned which
>> stopped working after
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so
Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a delay
to stable the test and multiple run in CI is Ok. Link is added in JBS.
-
Commit messages:
- delay added for stable test
Changes: https://git.openjdk.org/jdk/pull/19788/files
Webrev:
On Wed, 19 Jun 2024 08:30:42 GMT, Prasanta Sadhukhan
wrote:
>> On cancelling PageDialog, same PageFormat object should be returned which
>> stopped working after
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so
> On cancelling PageDialog, same PageFormat object should be returned which
> stopped working after
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so that correct
> value is returned from PageDialog.show action..
> An
On Wed, 19 Jun 2024 06:49:03 GMT, Abhishek Kumar wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test fix
>
> test/jdk/java/awt/print/PrinterJob/PageDialogCancelTest.java line 51:
>
>> 49:
On Wed, 19 Jun 2024 05:34:55 GMT, Prasanta Sadhukhan
wrote:
> On cancelling PageDialog, same PageFormat object should be returned which
> stopped working after
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so that
On Fri, 7 Jun 2024 20:34:23 GMT, Alisen Chung wrote:
>> Add a check for previous focused window on modal unblocking. If the owner of
>> a closing dialog was the last focused window, then the owner of the dialog
>> should regain focus.
>
> Alisen Chung has updated the pull request incrementally
26 matches
Mail list logo
