On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote:
> This is somewhat a continuation for
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and
> [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
>
> The former removed the `doIt` flag in #18584, but it introduced a regr
On Tue, 25 Jun 2024 01:02:29 GMT, Damon Nguyen wrote:
>> Ravi Gupta has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8333403: review comments fixed
>
> Tested on MacOS. The test passes and looks functional. Minor comments.
>
> Have you t
On Mon, 24 Jun 2024 20:40:54 GMT, Alexey Ivanov wrote:
> Will this resolve Phil's concern? Both arrays will use the same size.
@prrace Does this address your concerns? If it does I will commit it
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19798#discussion_r1657972007
On Wed, 26 Jun 2024 20:51:18 GMT, Alisen Chung wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8334495
>
> src/java.desktop/share/classes/sun/font/GlyphList.java line 364:
>
>> 362: * a native call which doe
> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
> This reduces the coupling between the java.desktop module and the internals
> of the java.base module.
>
> The code being changed here is not particularly performance sensitive, and it
> is not executed in the most common cases.
>
On Thu, 27 Jun 2024 10:06:49 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Wed, 30 Aug 2023 14:20:41 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8314731 : Adds support for the alt attribute in the image type input
>> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731)
>>
>> This is tracked in JBS as
>> - [JDK
On Thu, 27 Jun 2024 13:15:19 GMT, Julian Waters wrote:
> It would be helpful if JNI had a jobject unique_ptr type for C++
But `std::unique_ptr` wasn't available when JNI had been conceived…
It could be added…
The declaration in your sample still looks cumbersome… or _unwieldy_ as you
said. Wr
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote:
> This is somewhat a continuation for
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and
> [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
>
> The former removed the `doIt` flag in #18584, but it introduced a regr
On Thu, 27 Jun 2024 12:54:55 GMT, Alexey Ivanov wrote:
> > …I believe I was referring to the use of C++'s std::unique_ptr, which has
> > the functionality for cleanup that we need.
>
> Yes, `std::unique_ptr` could be useful for handling automatic deallocation of
> objects created with the `new
On Thu, 27 Jun 2024 11:26:24 GMT, Julian Waters wrote:
> …I believe I was referring to the use of C++'s std::unique_ptr, which has the
> functionality for cleanup that we need.
Yes, `std::unique_ptr` could be useful for handling automatic deallocation of
objects created with the `new` operator
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote:
> This is somewhat a continuation for
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and
> [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
>
> The former removed the `doIt` flag in #18584, but it introduced a regr
On Wed, 26 Jun 2024 20:30:55 GMT, Alisen Chung wrote:
> > Yes, there is some disconnect. For all OS (MAC with above changes) print
> > range is working properly only with following values firstPage =0 and
> > lastPage =-1 at **RasterPrinterJob.java** and highly depend on
> > **pageRangesAttr**
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote:
> This is somewhat a continuation for
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and
> [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
>
> The former removed the `doIt` flag in #18584, but it introduced a regr
On Wed, 26 Jun 2024 23:42:16 GMT, Alisen Chung wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 640:
>>
>>> 638: HGLOBAL oldG = AwtPrintControl::getPrintHDMode(env, self);
>>> 639: if (setup.hDevMode != oldG) {
>>> 640:AwtPrintControl::se
On Tue, 25 Jun 2024 15:47:49 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove access modifier from method declaration
>
> Changes requested by aivanov (Reviewer).
@aivanov-jdk Updated th
> In GTK LAF, the menu mnemonics are always displayed which is different from
> the native behavior. In native application **(tested with gedit for normal
> buttons and tested with libreoffice for menu**), the menu mnemonics toggle on
> press of `ALT` key. Menu mnemonics are hidden initially and
On Tue, 25 Jun 2024 15:35:47 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove access modifier from method declaration
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLoo
On Thu, 27 Jun 2024 07:40:43 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
> This testcase checks for the following assertions for Component events:
>
> 1. When components are resized, moved, hidden and shown the respective events
> are triggered.
> 2. When the components are hidden/disabled also,the component events like
> resized/moved are triggered.
> 3. When a hidd
On Mon, 10 Jun 2024 20:07:34 GMT, Alisen Chung wrote:
>> Ravi Gupta has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8333403: Copyright Header added
>
> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 237:
>
>> 235:
> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
> can't be dragged via its divider, But if SplitPane have one touch expandable
> true than user can click those buttons and change the divider position.
> So, if splitpane is disabled, then both dragging in divider and
22 matches
Mail list logo
