Re: RFR: 8312198: [macos] metal pipeline - window rendering stops after display sleep [v2]

2025-05-25 Thread Jayathirth D V
On Fri, 23 May 2025 11:38:32 GMT, Jayathirth D V wrote: >> In stress based scenarios it is observed that nothing is drawn in UI content >> when display wakes up from sleep in Metal pipeline of macOS. Unfortunately i >> am not able to reproduce it, but based on details in the bug it looks like

Integrated: 8312198: [macos] metal pipeline - window rendering stops after display sleep

2025-05-25 Thread Jayathirth D V
On Wed, 21 May 2025 06:11:18 GMT, Jayathirth D V wrote: > In stress based scenarios it is observed that nothing is drawn in UI content > when display wakes up from sleep in Metal pipeline of macOS. Unfortunately i > am not able to reproduce it, but based on details in the bug it looks like we

Re: RFR: 8312198: [macos] metal pipeline - window rendering stops after display sleep [v2]

2025-05-25 Thread Sergey Bylokhov
On Fri, 23 May 2025 11:38:32 GMT, Jayathirth D V wrote: >> In stress based scenarios it is observed that nothing is drawn in UI content >> when display wakes up from sleep in Metal pipeline of macOS. Unfortunately i >> am not able to reproduce it, but based on details in the bug it looks like

Re: RFR: 8351913: ToolkitImage renders some gifs wrong [v6]

2025-05-25 Thread Jeremy Wood
> I do not have much background in LZW compression or in C, but I'm reasonably > confident this resolves the problem I'm observing. It looks like the > GifImageDecoder was not always correctly handling compression codes after the > table reached its limit of ~4096. If anyone has suggestions for

Re: RFR: 8357034: GifImageDecoder can produce wrong transparent pixels [v2]

2025-05-25 Thread Jeremy Wood
> If there are two consecutive frames that use DISPOSAL_SAVE, but the > transparent pixel index changed: we might accidentally send the wrong data to > the ImageConsumer. > > We already had logic that submits info "the hard way" (see comment in code); > this PR just makes sure we trigger that b

Re: RFR: 8357034: GifImageDecoder can produce wrong transparent pixels [v3]

2025-05-25 Thread Jeremy Wood
> If there are two consecutive frames that use DISPOSAL_SAVE, but the > transparent pixel index changed: we might accidentally send the wrong data to > the ImageConsumer. > > We already had logic that submits info "the hard way" (see comment in code); > this PR just makes sure we trigger that b

Re: RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes [v6]

2025-05-25 Thread Jeremy Wood
> This resolves a gif parsing bug where an unwanted opaque rectangle could > appear under these conditions: > > 1. The disposal method for frames is 1 (meaning "do not dispose", aka > "DISPOSAL_SAVE") > 2. The transparent pixel is non-zero > 3. There's more than one such consecutive frame > > P

Re: RFR: 8351913: ToolkitImage renders some gifs wrong [v5]

2025-05-25 Thread Jeremy Wood
> I do not have much background in LZW compression or in C, but I'm reasonably > confident this resolves the problem I'm observing. It looks like the > GifImageDecoder was not always correctly handling compression codes after the > table reached its limit of ~4096. If anyone has suggestions for

Re: RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes [v5]

2025-05-25 Thread Jeremy Wood
> This resolves a gif parsing bug where an unwanted opaque rectangle could > appear under these conditions: > > 1. The disposal method for frames is 1 (meaning "do not dispose", aka > "DISPOSAL_SAVE") > 2. The transparent pixel is non-zero > 3. There's more than one such consecutive frame > > P

Re: RFR: 8356594: JSplitPane loses divider location when reopened via JOptionPane.createDialog() [v4]

2025-05-25 Thread Prasanta Sadhukhan
On Sat, 24 May 2025 03:32:50 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Set orientation only if changed...add headful in test > > src/java.desktop/share/classes/javax/swing/JSplitPan

Re: RFR: 8357299: Graphics copyArea doesn't copy any pixels when there is overflow

2025-05-25 Thread Prasanta Sadhukhan
On Fri, 23 May 2025 20:59:41 GMT, Phil Race wrote: >> Graphics copyArea overflow check bails out of copying pixels if there is >> overflow. >> The spec says ""If a portion of the source rectangle lies outside the bounds >> of the component, or is obscured by another window or component, {@code

Re: RFR: 8356049: Need a simple way to play back a sound clip [v10]

2025-05-25 Thread Phil Race
> A simple API to replace java.applet.AudioClip > > CSR is now created : https://bugs.openjdk.org/browse/JDK-8356200 Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8356049 - Changes: - all: https://git.openjdk.org/jdk/p

Re: RFR: 8356049: Need a simple way to play back a sound clip [v9]

2025-05-25 Thread Phil Race
On Sun, 25 May 2025 04:56:14 GMT, Sergey Bylokhov wrote: > possibly we can extend this by two group of methods `asyncPlay/play` and > `asyncLoop/loop` to make it easy to use in a different situations? There are probably going to be zero to a handful of apps anywhere that use this API without a

Re: RFR: 8357598: Toolkit.removeAWTEventListener should handle null listener in AWTEventListenerProxy

2025-05-25 Thread Sergey Bylokhov
On Thu, 22 May 2025 21:21:30 GMT, Sergey Bylokhov wrote: > The issue was found here: > https://github.com/openjdk/jdk/pull/24692#discussion_r2089545502 > > AWTEventListener and AWTEventListenerProxy are public classes and there's no > assertion that EventListenerProxy.getListener() will always

RFR: 8357598: Toolkit.removeAWTEventListener should handle null listener in AWTEventListenerProxy

2025-05-25 Thread Sergey Bylokhov
The issue was found here: https://github.com/openjdk/jdk/pull/24692#discussion_r2089545502 AWTEventListener and AWTEventListenerProxy are public classes and there's no assertion that EventListenerProxy.getListener() will always return a non-null value. So removeAWTEventListener method should fe