On Tue, 16 Jul 2024 19:44:40 GMT, Damon Nguyen wrote:
> But why does this only apply to custom LAFs? What does Nimbus and GTK do
> differently? Because I'm assuming the fix was for all 3 before, but now
> you're just removing the fix from Synth and applying it to GTK & Nimbus.
The painter for
On Tue, 16 Jul 2024 19:49:39 GMT, Damon Nguyen wrote:
> Are there no repercussions to setting this boolean to `TRUE` across the board
> for one test to pass?
I guess my question is, why was it explicitly set to FALSE before and now we
set it to TRUE?
Why was it set to `FALSE` before is
On Mon, 15 Jul 2024 09:57:22 GMT, Prasanta Sadhukhan
wrote:
>> When a JTable is resized with` JTable.setAutoResizeMode` set to `
>> AUTO_RESIZE_LAST_COLUMN` then it behaves exactly as if I specified
>> `AUTO_RESIZE_ALL_COLUMNS`.
>> This is because when `JTable.doLayout` tries to resize the
On Mon, 15 Jul 2024 09:21:24 GMT, Prasanta Sadhukhan
wrote:
>> When a JTable is resized with` JTable.setAutoResizeMode` set to `
>> AUTO_RESIZE_LAST_COLUMN` then it behaves exactly as if I specified
>> `AUTO_RESIZE_ALL_COLUMNS`.
>> This is because when `JTable.doLayout` tries to resize the
On Mon, 15 Jul 2024 09:22:05 GMT, Prasanta Sadhukhan
wrote:
> Not sure about the spec you are referring to? I see
> https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/swing/JTable.html#AUTO_RESIZE_NEXT_COLUMN
> `When a column is adjusted in the UI, adjust the next column
On Wed, 10 Jul 2024 10:28:08 GMT, Prasanta Sadhukhan
wrote:
> When a JTable is resized with` JTable.setAutoResizeMode` set to `
> AUTO_RESIZE_LAST_COLUMN` then it behaves exactly as if I specified
> `AUTO_RESIZE_ALL_COLUMNS`.
> This is because when `JTable.doLayout` tries to resize the
This test was modified under
[JDK-8328403](https://bugs.openjdk.org/browse/JDK-8328403) bug to remove the
applet usage. Test modification includes the instruction change as well which
says that `Check that there is a panel with "Text Preview Panel" text and with
title "Preview" in the
On Wed, 10 Jul 2024 22:12:59 GMT, Alisen Chung wrote:
>> Issue is due to the condition added for the opaque property of
>> SynthTabbedPane in
>> [JDK-8226990](https://bugs.openjdk.org/browse/JDK-8226990). The previous fix
>> for GTK and Nimbus was handled commonly in `SynthTabbedPaneUI` class
Issue is due to the condition added for the opaque property of SynthTabbedPane
in [JDK-8226990](https://bugs.openjdk.org/browse/JDK-8226990). The previous fix
for GTK and Nimbus was handled commonly in `SynthTabbedPaneUI` class to render
the tabs based on opaque property. Since the Synth
On Mon, 29 Apr 2024 09:00:46 GMT, Abhishek Kumar wrote:
> In GTK LAF, the menu mnemonics are always displayed which is different from
> the native behavior. In native application **(tested with gedit for normal
> buttons and tested with libreoffice for menu**), the menu mnemoni
On Fri, 12 Jul 2024 09:33:22 GMT, Prasanta Sadhukhan
wrote:
> Looks good to me.. Hope you have tested on windows and mac too..
Testing on windows and mac seems ok to me.
-
PR Comment: https://git.openjdk.org/jdk/pull/20052#issuecomment-2225261560
On Fri, 12 Jul 2024 09:14:57 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Panel size updated to avoid clipping in Java L
>
> src/demo/share/jfc/Swi
of toolbar is less than frame
> width. Hence, there is no clipping.
>
> The proposed solution is to increase the width and height of SwingSet2 demo
> frame.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
heigh
On Thu, 11 Jul 2024 14:09:43 GMT, Prasanta Sadhukhan
wrote:
> I guess it will be better to use PREFERRED_WIDTH/HEIGHT+x instead of
> hardcoding the value..
Updated.
-
PR Comment: https://git.openjdk.org/jdk/pull/20052#issuecomment-2224960869
of toolbar is less than frame
> width. Hence, there is no clipping.
>
> The proposed solution is to increase the width and height of SwingSet2 demo
> frame.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Pane
On Thu, 11 Jul 2024 14:09:43 GMT, Prasanta Sadhukhan
wrote:
> I believe setPreferredSize in the constructor is still needed, right?
Yeah, it is required otherwise the window is very small in size.
> It seems there is a lag when L changed from Java to GTK and the frame takes
> some time
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
minor spacing
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18992/files
- new:
On Thu, 11 Jul 2024 07:14:30 GMT, Prasanta Sadhukhan
wrote:
> Yes, it is problemlisted for 8144124 and that is why I said it is handled
> separately...
The issue mentioned in
[JDK-8144124](https://bugs.openjdk.org/browse/JDK-8144124) seems not
reproducible to me. Got your point that test
On Mon, 8 Jul 2024 09:11:57 GMT, Prasanta Sadhukhan
wrote:
> This test tests the wrapping policy of JTabbedPane in one of the
> subinstructions which is not applicable for macos which does not support
> wrapping or scrolling in tabbed layout.
> It can be seen in "Dictionary" native app
On Thu, 11 Jul 2024 07:14:30 GMT, Prasanta Sadhukhan
wrote:
> Also, The tester mentioned in the descriptions "Focus painted incorrectly in
> tabbed pane"
Yeah, I saw that and ran the test, I can see that focus behaves correctly for
the specified instructions.
-
PR Comment:
On Thu, 11 Jul 2024 06:55:17 GMT, Prasanta Sadhukhan
wrote:
> > This test is in the list of
> > [Problemlist](https://github.com/kumarabhi006/jdk/blob/e227c7e37d4de0656f013f3a936b1acfa56cc2e0/test/jdk/ProblemList.txt#L775)
> > file, need to remove from the list.
>
> That seems to be some
On Mon, 8 Jul 2024 09:11:57 GMT, Prasanta Sadhukhan
wrote:
> This test tests the wrapping policy of JTabbedPane in one of the
> subinstructions which is not applicable for macos which does not support
> wrapping or scrolling in tabbed layout.
> It can be seen in "Dictionary" native app
On Wed, 10 Jul 2024 23:35:59 GMT, Phil Race wrote:
> This looks like it is much better than the first iteration and being able to
> unify some code is good. The change looks "big" but seems to be mostly
> because of refactoring. I suppose you tracked down all tests that need
> updating ?
On Wed, 10 Jul 2024 20:38:48 GMT, Alisen Chung wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Frame size change for GTK L only
>
> src/demo/share/jfc/SwingSet2/SwingSet2.java line
On Tue, 9 Jul 2024 11:51:51 GMT, Abhishek Kumar wrote:
> > Also, is it possible to change the width only when GTK is loaded and not
> > irrespectively?
>
> Tried changing the frame width in
> [updateThisSwingSet](https://github.com/openjdk/jdk/blob/0e0dfca21f64ecfcb3e5ed7
of toolbar is less than frame
> width. Hence, there is no clipping.
>
> The proposed solution is to increase the width and height of SwingSet2 demo
> frame.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last rev
On Tue, 9 Jul 2024 10:36:12 GMT, Prasanta Sadhukhan
wrote:
> If the issue is only about width, is it needed to change the height too?
Not exactly but the ratio of width to height was looking odd. so, I proposed to
change it too (keeping the aspect ratio same as before).
> Also, is it
On Mon, 8 Jul 2024 15:18:14 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> wild import expand. SynthGraphicsUtils revert back
>
> src/java.desktop/share/classes/
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Typo in copyright header
-
Changes:
- all: https://git.openjdk.org/jd
On Mon, 8 Jul 2024 13:12:33 GMT, Abhishek Kumar wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> wild import expand. SynthGraphicsUtils revert back
>
> Adding a brief details f
On Mon, 8 Jul 2024 09:39:11 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the men
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
wild import expand. SynthGraphicsUtils revert back
-
Changes:
- all: https://git
On Fri, 5 Jul 2024 11:12:50 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the men
On Fri, 5 Jul 2024 15:16:57 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Javadoc style comment, unused import removed
>
> src/java.desktop/share/classes/sun/s
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Move mnemonic hide check in GTKGraphicsUtils and minor update
-
Changes:
- all: https
On Fri, 5 Jul 2024 11:20:47 GMT, Abhishek Kumar wrote:
> The issue is due to the preferred width of the toggle button in GTK L for
> GTK3 only.
> Comparing the preferred width of toggle button with GTK2 or other LAF, it is
> much higher in GTK3. The difference is due to the
The issue is due to the preferred width of the toggle button in GTK L for
GTK3 only.
Comparing the preferred width of toggle button with GTK2 or other LAF, it is
much higher in GTK3. The difference is due to the insets value in GTK3.
In SwingSet2 demo there are as many as 16 demos are added in
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Javadoc style comment, unused import removed
-
Changes:
- all: https://git.openjdk
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
wild imports expand, imports sorting
-
Changes:
- all: https://git.openjdk.org/jd
On Thu, 4 Jul 2024 17:22:01 GMT, Alexey Ivanov wrote:
> This changeset enables hiding / showing mnemonics on `JMenuBar` only. Do you
> plan to update `ButtonUI` and `LabelUI` for GTK Look-and-Feel too?
Not as a part of this PR. It can be taken up as other bug.
@aivanov-jdk Imports are
On Fri, 28 Jun 2024 20:05:44 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove AquaMnemonicHandler class and unused APIs from WinDowsLookAndFeel,
>> cop
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Test update to refer MnemonicHandler class
-
Changes:
- all: https://git.openjdk
On Fri, 28 Jun 2024 19:11:21 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove AquaMnemonicHandler class and unused APIs from WinDowsLookAndFeel,
>>
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Wild imports and review comments fix
-
Changes:
- all: https://git.openjdk.org/jd
On Fri, 28 Jun 2024 20:03:32 GMT, Alexey Ivanov wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/TestMenuMnemonicOnAltPress.java line 63:
>>
>>> 61:
>>> UIManager.setLookAndFeel("com.sun.java.swing.plaf.gtk.GTKLookAndFeel");
>>> 62: } else if
On Fri, 28 Jun 2024 19:59:15 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove AquaMnemonicHandler class and unused APIs from WinDowsLookAndFeel,
>> copy
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Remove AquaMnemonicHandler class and unused APIs from WinDowsLookAndFeel,
copyright year update
On Thu, 27 Jun 2024 17:17:12 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Mnemonic handler class
>> - Mnemonic handler added and previous implementation
On Thu, 27 Jun 2024 17:17:12 GMT, Alexey Ivanov wrote:
> I think we're moving in the right direction.
>
> My idea was to extract the common functionality as the methods
> `setMnemonicHidden`, `isMnemonicHidden` and `repaintMnemonicsInWindow`,
> `repaintMnemonicsInContainer` into a helper
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Common AltProcessor class for GTk and Aqua, helper method in MnemonicHandler
class, review comments u
On Tue, 25 Jun 2024 15:47:49 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove access modifier from method declaration
>
> Changes requested by aivanov (Re
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with two additional
commits since the last revision:
- Mnemonic handler class
- Mnemonic handler added and previous implementation revert back
-
On Tue, 25 Jun 2024 15:35:47 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove access modifier from method declaration
>
> src/java.desktop/share/class
On Tue, 25 Jun 2024 15:11:31 GMT, Alexey Ivanov wrote:
>> I will check and update if it is possible.
>
> Thank you for looking into it. A `MnemonicHandler` class in `sun.swing` or
> `sun.swing.plaf` package could be a good candidate. The `sun.swing` package
> contains a lot of support classes
On Mon, 24 Jun 2024 07:17:19 GMT, Abhishek Kumar wrote:
>>> Wouldn't it be easier to install altProcessor always in
>>> SynthLookAndFeel.initialize and to uninstall it in
>>> SynthLookAndFeel.uninitialize like it's done in WindowsLookAndFeel:
>> https://githu
On Mon, 24 Jun 2024 06:21:51 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthRootPaneUI.java
>> line 45:
>>
>>> 43: private SynthStyle style;
>>> 44: static final AltProcessor altProcessor = new AltPro
On Fri, 21 Jun 2024 20:14:28 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove access modifier from method declaration
>
> src/java.desktop/share/
On Fri, 21 Jun 2024 20:08:58 GMT, Alexey Ivanov wrote:
> Wouldn't it be easier to install altProcessor always in
> SynthLookAndFeel.initialize and to uninstall it in
> SynthLookAndFeel.uninitialize like it's done in WindowsLookAndFeel:
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Remove access modifier from method declaration
-
Changes:
- all: https://git.openjdk
On Thu, 20 Jun 2024 20:55:11 GMT, Phil Race wrote:
>> Infact `isMnemonicHidden` can also be changed to a `protected` member of the
>> class. I will check and update.
>
> protected members of public classes are part of the API
> Go look at javadoc - or generate javadoc for this change and see
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote:
> Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a
> delay to stable the test and multiple run in CI is Ok. Link is added in JBS.
This pull request has now been integrated.
Changeset: 9ef86da5
Author:Ab
On Fri, 14 Jun 2024 20:21:16 GMT, Phil Race wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition update
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/Synth
On Tue, 18 Jun 2024 16:28:50 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition update
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/Sy
untu and
> Oracle linux.
>
> CI testing is green and link attached in JBS.
Abhishek Kumar has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains eight a
On Wed, 19 Jun 2024 19:35:54 GMT, Alexey Ivanov wrote:
> Would it be clearer if setDelay(50) was called in the constructor of
> bug6492108?
I am ok with the current placing of setDelay(50).
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1647193228
On Tue, 18 Jun 2024 16:41:12 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition update
>
> test/jdk/com/sun/java/swing/plaf/gtk/TestMenuMnemonicOnAltPress.
On Tue, 18 Jun 2024 16:26:49 GMT, Alexey Ivanov wrote:
> Can we use or even re-use the logic in Windows L to display and hide menu
> mnemonics?
For windows behavior is different than linux.
https://github.com/openjdk/jdk/pull/18992#issuecomment-2100033545
I don't think that the logic in
On Wed, 19 Jun 2024 11:01:26 GMT, Alexey Ivanov wrote:
> How does it help? You're delaying EDT.
I was unable to reproduce the failure scenario in my local machine but didn't
observe any failure in mach5 also. Will ask Vitaly or @azvegint to verify as
they are able to replicate the failure.
Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a delay
to stable the test and multiple run in CI is Ok. Link is added in JBS.
-
Commit messages:
- delay added for stable test
Changes: https://git.openjdk.org/jdk/pull/19788/files
Webrev:
On Wed, 19 Jun 2024 05:34:55 GMT, Prasanta Sadhukhan
wrote:
> On cancelling PageDialog, same PageFormat object should be returned which
> stopped working after
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so that
On Tue, 18 Jun 2024 12:50:42 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java
>> line 1056:
>>
>>> 1054: * @param hide true if mnemonics should be hidden
>>> 1055: * @since 23
>>> 1
On Tue, 18 Jun 2024 12:51:34 GMT, Abhishek Kumar wrote:
>> since this method should be recursing through all of a component's
>> subcomponents, shouldn't there not even be an if check here?
>
>> JComponent extends Container .. so this will traverse everything in the
>&g
On Fri, 14 Jun 2024 20:28:11 GMT, Phil Race wrote:
> Hmm. So .. new public API ? Is this absolutely necessary ?
I don't see why an app would need to call this directly.
`setMnemonicHidden` can be changed to a `protected` member as you pointed out
it may not be required by an app to call this
On Sat, 15 Jun 2024 00:23:07 GMT, Alisen Chung wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
>> line 785:
>>
>>> 783: }
>>> 784:
>>> 785: if (c instanceof Container) {
>>
>> JComponent extends Container .. so this will
On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics ar
On Fri, 14 Jun 2024 09:28:28 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Fri, 14 Jun 2024 09:06:24 GMT, Damon Nguyen wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/Synth
`ALT` press.
> Proposed fix is to handle the `ALT` key press for GTK LAF and mimic the
> native behavior. Fix is similar to the `ALT` key processing in Windows LAF.
> Automated test case is added to verify the fix and tested in Ubuntu and
> Oracle linux.
>
> CI testing is green and l
On Fri, 14 Jun 2024 03:52:56 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Thu, 13 Jun 2024 12:54:57 GMT, Prasanta Sadhukhan
wrote:
> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
> can't be dragged via its divider, But if SplitPane have one touch expandable
> true than user can click those buttons and change the divider position.
>
On Wed, 12 Jun 2024 04:58:47 GMT, Abhishek Kumar wrote:
> Looks like there was a typo for null character. It should be `'\0'` instead
> of `'/0'`.
> Build with clang toolchain with the help of [this
> PR](https://github.com/openjdk/jdk/pull/17019) and after the changes there is
On Tue, 11 Jun 2024 06:05:02 GMT, Prasanta Sadhukhan
wrote:
> TestUngrab.java was added for
> [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix but the
> test can be run for all platforms as the behaviour is common for all
> CI run job link in JBS..
There are few unused
On Tue, 11 Jun 2024 06:05:02 GMT, Prasanta Sadhukhan
wrote:
> TestUngrab.java was added for
> [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix.
I think that this test was added for
[JDK-8325435](https://bugs.openjdk.org/browse/JDK-8325435) that you recently
integrated.
Looks like there was a typo for null character. It should be `'\0'` instead of
`'/0'`.
Build with clang toolchain with the help of [this
PR](https://github.com/openjdk/jdk/pull/17019) and after the changes there is
no warning.
-
Commit messages:
- typo for null character fixed
On Wed, 12 Jun 2024 04:05:32 GMT, Jayathirth D V wrote:
>> Resolved typos related to ArrayIndexOutOfBoundsException in BufferedImage
>> and JTableHeader.
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
Looks
On Wed, 12 Jun 2024 04:02:46 GMT, Jayathirth D V wrote:
> I see there are 3 other places where we have this typo and one among them is
> in client code. So i have updated that file.
That's right the other two places were not in client area so I specified only
the open test. Thank you for
On Tue, 11 Jun 2024 12:22:24 GMT, Jayathirth D V wrote:
> Resolved typos related to ArrayIndexOutOfBoundsException in BufferedImage and
> JTableHeader.
There are few other places where this typo is present, one of them is in this
open test.
On Fri, 10 May 2024 07:05:11 GMT, Abhishek Kumar wrote:
> JTabbedPane's contentOpaque and tabsOpaque properties are not honored in Aqua
> L JTabbedPane's content area and tab background color are not as expected
> when tabbedpane opacity is set to true or false. Fix is to handle th
On Fri, 24 May 2024 11:38:30 GMT, Abhishek Kumar wrote:
> "java.awt.IllegalComponentStateException: component must be showing on the
> screen to determine its location" is thrown when getLocationOnScreen method
> is invoked for JTableHeader while testing JFileCho
e are trying to access the parent location but
> that is not visible and ICSE is thrown.
>
> Fix is to handle the exception and can be verified using the steps mentioned
> in [JDK-8332550](https://bugs.openjdk.org/browse/JDK-8332550).
> CI testing is green and link is mentioned in JBS.
e are trying to access the parent location but
> that is not visible and ICSE is thrown.
>
> Fix is to handle the exception and can be verified using the steps mentioned
> in [JDK-8332550](https://bugs.openjdk.org/browse/JDK-8332550).
> CI testing is green and link is mentioned in JBS.
On Thu, 6 Jun 2024 07:28:59 GMT, Alexander Zuev wrote:
>> As per the spec, getLocationOnScreen() API can throw ICSE and it should be
>> right to catch this exception. Moreover, I tried checking with the
>> JTableHeader's visibility, still got the ICSE while performing the testing.
>> So, I
On Wed, 5 Jun 2024 22:27:43 GMT, Alisen Chung wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> copyright year update
>
> src/java.desktop/share/classes/javax/swing/table/JTableHea
e are trying to access the parent location but
> that is not visible and ICSE is thrown.
>
> Fix is to handle the exception and can be verified using the steps mentioned
> in [JDK-8332550](https://bugs.openjdk.org/browse/JDK-8332550).
> CI testing is green and link is mentioned in JBS.
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
Ran the updated test and looks good to me.
-
Marked as
On Fri, 24 May 2024 06:44:06 GMT, Abhishek Kumar wrote:
> bug6492108.java test always fails in GTK L in single as well as dual screen
> linux machines. Since this test was not marked as "_headful_" in it's initial
> version, it never failed but after the fix of
&g
On Wed, 5 Jun 2024 12:20:00 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 172:
>>
>>> 170:
>>> 171: try {
>>> 172: g2d.drawString(emptyIterator, 20.0f, 180.0f);
>>
>> Does the line below also need to change ?
>>
On Fri, 10 May 2024 17:33:53 GMT, Sergey Bylokhov wrote:
>> JTabbedPane's contentOpaque and tabsOpaque properties are not honored in
>> Aqua L JTabbedPane's content area and tab background color are not as
>> expected when tabbedpane opacity is set to true or false. Fix is to handle
>> the
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 172:
>
On Tue, 4 Jun 2024 15:21:30 GMT, Alexey Ivanov wrote:
>> Updated.
>
> I can't see it in the PR. Didn't push?
Oh my bad, I missed to add that changes. Pushed now.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1626228348
1 - 100 of 1011 matches
Mail list logo
