On Thu, 25 Jul 2024 14:43:27 GMT, Alexey Ushakov wrote:
>> Trivial fix to move the screencast token storage file from
>> `~/.awt/robot/screencast-tokens.properties` to
>> `~/.java/robot/screencast-tokens.properties`, where it should be.
>> Old location is still valid and will only be used if
Trivial fix to move the screencast token storage file from
`~/.awt/robot/screencast-tokens.properties` to
`~/.java/robot/screencast-tokens.properties`, where it should be.
Old location is still valid and will only be used if there is a file in the old
location and the new location does not have
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote:
> Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a
> delay to stable the test and multiple run in CI is Ok. Link is added in JBS.
Marked as reviewed by azvegint (Reviewer).
-
PR Review:
On Wed, 19 Jun 2024 11:15:54 GMT, Abhishek Kumar wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 113:
>>
>>> 111: }
>>> 112: setDelay(50);
>>> 113: return panel;
>>
>> How does it help? You're delaying EDT.
>>
>> You should rather call
>>
On Tue, 28 May 2024 02:25:46 GMT, Alexander Zvegintsev
wrote:
> Some of the modal tests fail in X11 compatibility mode on Wayland, because a
> mouse click emulated with XTEST does not not cause the windows to be
> reordered.
>
> This is a known limitation because these
On Sat, 1 Jun 2024 09:20:28 GMT, lawrence.andrews wrote:
> According to
> https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/java/awt/Window.html#toFront()
> some platforms does not support toFront() , how are we handling this case ?
AFAIK, we do not test on such platforms/window
On Fri, 31 May 2024 12:24:42 GMT, Prasanta Sadhukhan
wrote:
>> Issue is in macosx, when a JMenu or JPopupmenu is opened and then window is
>> resized from the lower right corner, then the Menu / JPopupmenu stays open
>> unlike in native osx apps like Notes, Mail etc..
>>
>> This is because
On Fri, 31 May 2024 12:01:22 GMT, Prasanta Sadhukhan
wrote:
> WIll it be a problem if we use toFront for the frame anyways? We have seen
> and done tofront() for many tests where the frame gets obscured by some other
> window so mouseclicks was not on desired area
For this set of tests, yes,
On Tue, 28 May 2024 02:25:46 GMT, Alexander Zvegintsev
wrote:
> Some of the modal tests fail in X11 compatibility mode on Wayland, because a
> mouse click emulated with XTEST does not not cause the windows to be
> reordered.
>
> This is a known limitation because these
On Thu, 30 May 2024 12:05:25 GMT, Prasanta Sadhukhan
wrote:
> Issue is in macosx, when a JMenu or JPopupmenu is opened and then window is
> resized from the lower right corner, then the Menu / JPopupmenu stays open
> unlike in native osx apps like Notes, Mail etc..
>
> This is because when
On Wed, 22 May 2024 02:25:14 GMT, Alexander Zvegintsev
wrote:
> These changes are intended to stabilize testing on Wayland in X11
> compatibility mode.
>
>
>
> Many tests may fail if there is no `robot.delay()` call after
> `robot.waitForIdle()` (right afte
gular X11 server does.
>
>
>
> For some tests it is critical to call AWT code on EDT(it prevents NPE):
> java/awt/List/KeyEventsTest/KeyEventsTest.java
> java/awt/Paint/ListRepaint.java
>
>
>
> Some other explanations can be found inline in the comments for a
On Tue, 28 May 2024 02:25:46 GMT, Alexander Zvegintsev
wrote:
> Some of the modal tests fail in X11 compatibility mode on Wayland, because a
> mouse click emulated with XTEST does not not cause the windows to be
> reordered.
>
> This is a known limitation because these
Some of the modal tests fail in X11 compatibility mode on Wayland, because a
mouse click emulated with XTEST does not not cause the windows to be reordered.
This is a known limitation because these click events do not leave the XWayland
server and are not reported to the Wayland compositor.
On Wed, 22 May 2024 20:51:05 GMT, Phil Race wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> typo
>
> test/jdk/javax/swing/JButton/PressedButtonRightClickTest.java line 97:
>
On Wed, 22 May 2024 20:49:44 GMT, Phil Race wrote:
>> test/jdk/java/awt/TrayIcon/TrayIconPopup/TrayIconPopupTest.java line 48:
>>
>>> 46: boolean actionPerformed = false;
>>> 47: Object actionLock = new Object();
>>> 48: static final int ATTEMPTS = 10;
>>
>> Each attempt sleeps for
gular X11 server does.
>
>
>
> For some tests it is critical to call AWT code on EDT(it prevents NPE):
> java/awt/List/KeyEventsTest/KeyEventsTest.java
> java/awt/Paint/ListRepaint.java
>
>
>
> Some other explanations can be found inline in the comments for a
On Wed, 22 May 2024 02:25:14 GMT, Alexander Zvegintsev
wrote:
> These changes are intended to stabilize testing on Wayland in X11
> compatibility mode.
>
>
>
> Many tests may fail if there is no `robot.delay()` call after
> `robot.waitForIdle()` (right afte
These changes are intended to stabilize testing on Wayland in X11 compatibility
mode.
Many tests may fail if there is no `robot.delay()` call after
`robot.waitForIdle()` (right after displaying a window).
Some tests do not release previously pressed mouse button/key, this leads to
other
On Mon, 29 Apr 2024 10:44:37 GMT, Alexander Zvegintsev
wrote:
> Some tests try to get the focus of a window by clicking on its title bar.
>
> On XWayland, however, emulating mouse clicks with XTEST currently only
> affects the XWayland server, not the window decorations, so try
On Tue, 30 Apr 2024 20:38:06 GMT, Harshitha Onkar wrote:
>> For the following manual test, more instructions are added as to what to
>> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
>> clarity.
>
> Harshitha Onkar has updated the pull request incrementally with one
> So the solution is to click inside the window or call `toFront()` to get the
> window focused.
>
> Some tests have issues with AWT/Swing calls not being on EDT, it is not the
> goal of this change to fix them as they require way too many code changes,
> and make this PR hard
On Wed, 1 May 2024 22:44:41 GMT, Sergey Bylokhov wrote:
>> Do we really need an additional click on the title in this case?
>> Just `toFront` should be enough on all platforms.
>
> `toFront()` is known to be broken on some versions of metacity/gnome, not
> sure it was fixed or not, that was a
On Thu, 25 Apr 2024 11:52:35 GMT, Alexander Zvegintsev
wrote:
> This fix adds missing doPrivileged calls in TokenStorage, which is used to
> help take screenshots in Wayland.
This pull request has now been integrated.
Changeset: 9912abf5
Author:Alexander Zvegintsev
URL:
On Tue, 30 Apr 2024 18:46:51 GMT, Alisen Chung wrote:
>> The GIFLIB version 5.2.2 adds the `ifndef` wrap, and it is no longer the
>> "JDK modification", so it looks like our comment can be removed
>
> does this also apply for the other JDK modification for old compilers as well?
Regarding the
On Tue, 30 Apr 2024 05:47:05 GMT, Sergey Bylokhov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> test/jdk/java/awt/Focus/6981400/
On Tue, 30 Apr 2024 05:54:03 GMT, Sergey Bylokhov wrote:
> How hard is it to create a new test for this issue?
The issue was discovered by failing a closed test that you wrote some time ago.
-
PR Comment: https://git.openjdk.org/jdk/pull/18950#issuecomment-2084631823
On Tue, 30 Apr 2024 02:02:30 GMT, Alexander Zvegintsev
wrote:
>> Some tests try to get the focus of a window by clicking on its title bar.
>>
>> On XWayland, however, emulating mouse clicks with XTEST currently only
>> affects the XWayland server, not the windo
On Mon, 29 Apr 2024 21:08:28 GMT, Harshitha Onkar wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> test/jdk/java/awt/regtesthelpers/Util.java line
> So the solution is to click inside the window or call `toFront()` to get the
> window focused.
>
> Some tests have issues with AWT/Swing calls not being on EDT, it is not the
> goal of this change to fix them as they require way too many code changes,
> and make this PR hard
On Fri, 26 Apr 2024 22:02:38 GMT, Phil Race wrote:
>> Updating giflib, clientlibs tests are green on all platforms
>
> src/java.desktop/share/native/libsplashscreen/giflib/gif_hash.h line 40:
>
>> 38: #include
>> 39: #endif
>> 40: /** End JDK modifications to support building on Windows **/
>
On Mon, 29 Apr 2024 10:44:37 GMT, Alexander Zvegintsev
wrote:
> Some tests try to get the focus of a window by clicking on its title bar.
>
> On XWayland, however, emulating mouse clicks with XTEST currently only
> affects the XWayland server, not the window decorations, so try
Some tests try to get the focus of a window by clicking on its title bar.
On XWayland, however, emulating mouse clicks with XTEST currently only affects
the XWayland server, not the window decorations, so trying to click on the
window title will have no effect.
So the solution is to click
> This fix adds missing doPrivileged calls in TokenStorage, which is used to
> help take screenshots in Wayland.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
fix copyright years
-
Changes:
- all:
This fix adds missing doPrivileged calls in TokenStorage, which is used to help
take screenshots in Wayland.
-
Commit messages:
- initial
Changes: https://git.openjdk.org/jdk/pull/18950/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18950=00
Issue:
On Wed, 20 Mar 2024 03:09:32 GMT, Alexander Zvegintsev
wrote:
> Test converted to main.
> Instructions split to Windows and Linux, with some clarifications.
> The test runs successfully on Windows and Linux.
This pull request has now been integrated.
Changeset: fb8f2a0a
Author:
On Mon, 25 Mar 2024 16:55:35 GMT, Alisen Chung wrote:
>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> test instructions
On Thu, 21 Mar 2024 13:02:29 GMT, Alexander Zvegintsev
wrote:
> Two tests may fail intermittently on Wayland, the standard `waitForIdle` and
> `delay` fixes the issue.
>
> Manual and CI testing looks good.
This pull request has now been integrated.
Changeset: 638708ca
Author:
> Two tests may fail intermittently on Wayland, the standard `waitForIdle` and
> `delay` fixes the issue.
>
> Manual and CI testing looks good.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
Add @require
On Fri, 22 Mar 2024 05:15:38 GMT, Alexander Zuev wrote:
>> Convert test to a main based;
>> Move test to an appropriate folder;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Got rid of the test
On Thu, 21 Mar 2024 16:17:33 GMT, Prasanta Sadhukhan
wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding library and build clauses
>
> test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 59:
>
>>
On Thu, 21 Mar 2024 18:13:41 GMT, Alisen Chung wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor jtreg tag change
>
> test/jdk/java/awt/im/bug4490692.java line 115:
>
>> 113: return panel;
>> 114:
On Thu, 21 Mar 2024 17:33:22 GMT, Harshitha Onkar wrote:
>> test/jdk/java/awt/im/bug4490692.java line 95:
>>
>>> 93: @Override
>>> 94: public void keyPressed(KeyEvent e) {
>>> 95: if (e.getKeyCode() == 23 || e.getKeyCode() == 60) {
>>
>>> CASE 2: This step is automated and
On Thu, 21 Mar 2024 17:52:34 GMT, Harshitha Onkar wrote:
>> Following test is converted from applet to main using PassFailJFrame.
>>
>> The original test had ignore tag - **The fix for this problem was backed out
>> for 5057184. Remove this "ignore" tag when it is fixed again.**
>> I believe
On Thu, 21 Mar 2024 16:51:36 GMT, Damon Nguyen wrote:
>> Convert
>> java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
>> test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last
On Wed, 20 Mar 2024 15:48:41 GMT, Alexander Zuev wrote:
>> Convert test to main manual;
>> Move test to appropriate folder;
>> Delete old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Moving test metadata closer
On Tue, 19 Mar 2024 01:14:29 GMT, Alexander Zvegintsev
wrote:
>> we need to add next to Pass/Fail a "Pause Timer" button, that
> (a) stops the count down
> (b) changes the Pause Timer to "Resume Timer"
> ~~(c) disables Pass/Fail until the timer is resumed~
On Thu, 21 Mar 2024 14:25:36 GMT, Alexander Zuev wrote:
> Since you are editing these files you can also drop the @author tag from the
> test metadata. Otherwise looks good.
Sure,
author removed
../../../regtesthelpers -> /java/awt/regtesthelpers,
moved whole block closer to class
> Two tests may fail intermittently on Wayland, the standard `waitForIdle` and
> `delay` fixes the issue.
>
> Manual and CI testing looks good.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
au
On Mon, 18 Mar 2024 17:31:07 GMT, Damon Nguyen wrote:
> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java
> applet test to main using PassFailJFrame
test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 33:
> 31: * on HiDPI + non-HiDPI display
On Wed, 20 Mar 2024 18:02:37 GMT, Alisen Chung wrote:
>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> spacing
test/jdk/javax/swing/JColorChooser/Test6977726.java
On Wed, 20 Mar 2024 21:33:04 GMT, Phil Race wrote:
> Converts
> java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.html
> to a main program.
Marked as reviewed by azvegint (Reviewer).
On Wed, 20 Mar 2024 21:02:02 GMT, Alexander Zvegintsev
wrote:
> Test converted to main. Tested on Linux with Japanese ibus-anthy input method.
This pull request has now been integrated.
Changeset: 43080173
Author: Alexander Zvegintsev
URL:
https://git.openjdk.org/jdk/com
On Thu, 21 Mar 2024 11:56:46 GMT, Alexey Ivanov wrote:
>>> I wonder if it's the default focus owner?
>>
>> It is(e.g. with `setFocusPainted(true)`):
>> 
>>
>>> Should we request focus to Pass instead?
On Mon, 18 Mar 2024 23:46:34 GMT, Alexander Zvegintsev
wrote:
> The test converted to automated, CI and manual testing looks good on all
> platforms.
This pull request has now been integrated.
Changeset: 700d2b91
Author:Alexander Zvegintsev
URL:
https://git.openjdk.org/jdk/
Two tests may fail intermittently on Wayland, the standard `waitForIdle` and
`delay` fixes the issue.
Manual and CI testing looks good.
-
Commit messages:
- initial
Changes: https://git.openjdk.org/jdk/pull/18431/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18431=00
On Wed, 20 Mar 2024 16:59:47 GMT, Harshitha Onkar wrote:
>> Following test is converted from applet to main using PassFailJFrame.
>>
>> The original test had ignore tag - **The fix for this problem was backed out
>> for 5057184. Remove this "ignore" tag when it is fixed again.**
>> I believe
On Thu, 21 Mar 2024 10:35:19 GMT, Tejesh R wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor spacing
>
> test/jdk/java/awt/InputMethods/DiacriticsTest/DiacriticsTest.
On Wed, 20 Mar 2024 23:45:31 GMT, Phil Race wrote:
>> This seems to have been some previous not very complete conversion of a test
>> from applet to main.
>> It even still had Applet imported and miscellaneous comments. I've cleaned
>> it up.
>
> Phil Race has updated the pull request
On Thu, 21 Mar 2024 11:16:29 GMT, Alexey Ivanov wrote:
> I wonder if it's the default focus owner?
It is(e.g. with `setFocusPainted(true)`):
> Should we request focus to Pass instead?
Probably not,
t;
>
> Example screenshots:
>
> 
> 
Alexander Zvegintsev has updated the p
> Test converted to main.
> Instructions split to Windows and Linux, with some clarifications.
> The test runs successfully on Windows and Linux.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
mino
Test converted to main. Tested on Linux with Japanese ibus-anthy input method.
-
Commit messages:
- initial
Changes: https://git.openjdk.org/jdk/pull/18412/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18412=00
Issue: https://bugs.openjdk.org/browse/JDK-8328631
Stats:
On Wed, 20 Mar 2024 17:58:59 GMT, Alexey Ivanov wrote:
> I would place the Pause button into the timeout panel at the top. Yet the
> button is larger than the label. The font may be reduced, a symbol '⏸'
> (U+23F8) and '⏵' (U+23F5) could be used (see [Media control
>
t;
>
> Example screenshots:
>
> 
> 
Alexander Zvegintsev has updated the pull request increment
On Wed, 20 Mar 2024 17:27:44 GMT, Phil Race wrote:
>> This seems to have been some previous not very complete conversion of a test
>> from applet to main.
>> It even still had Applet imported and miscellaneous comments. I've cleaned
>> it up.
>
> Phil Race has updated the pull request
On Mon, 18 Mar 2024 21:12:19 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main and remains in the problem list, as the problem
> is still valid on Linux and macos.
> The test passes on Windows.
>
> * sleeps on EDT removed, replaced with the Swing timer
Test converted to main.
Instructions split to Windows and Linux, with some clarifications.
The test runs successfully on Windows and Linux.
-
Commit messages:
- split instructions for Windows and Linux
- initial
Changes: https://git.openjdk.org/jdk/pull/18388/files
Webrev:
On Tue, 19 Mar 2024 23:30:39 GMT, Phil Race wrote:
> This seems to have been some previous not very complete conversion of a test
> from applet to main.
> It even still had Applet imported and miscellaneous comments. I've cleaned it
> up.
On Tue, 19 Mar 2024 20:49:36 GMT, Alexander Zuev wrote:
>> Convert applet based test to a main based test;
>> Move test to an apporpriate location;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> -
On Mon, 18 Mar 2024 21:00:36 GMT, Alexander Zuev wrote:
> Convert applet based test to a main based test;
> Move test to an apporpriate location;
> Remove old files;
test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 32:
> 30: * @build PassFailJFrame
> 31: * @run main/manual
On Tue, 19 Mar 2024 12:16:08 GMT, Abhishek Kumar wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> reduce delay
>
> test/jdk/java/awt/Frame/InitialMaximizedTest/InitialMaximized
> The test converted to automated, CI and manual testing looks good on all
> platforms.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
reduce delay
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Tue, 19 Mar 2024 01:14:29 GMT, Alexander Zvegintsev
wrote:
>> we need to add next to Pass/Fail a "Pause Timer" button, that
> (a) stops the count down
> (b) changes the Pause Timer to "Resume Timer"
> ~~(c) disables Pass/Fail until the timer is resumed~
> we need to add next to Pass/Fail a "Pause Timer" button, that
(a) stops the count down
(b) changes the Pause Timer to "Resume Timer"
~~(c) disables Pass/Fail until the timer is resumed~~
the test will not have to pause or be aware - only the PassFailJFrame machinery.
~~So the tester can do
On Tue, 19 Mar 2024 00:20:17 GMT, Harshitha Onkar wrote:
> Since the .html file is removed, the test file could be moved one level up.
Yes, we can do that, but we already had a discussion that it makes it harder to
do the review, since the github doesn't handle that moving well.
It can be done
On Tue, 19 Mar 2024 00:10:17 GMT, Harshitha Onkar wrote:
>> The test is converted to main and remains in the problem list, as the
>> problem is still valid on Linux and macos.
>> The test passes on Windows.
>>
>> * sleeps on EDT removed, replaced with the Swing timer
>> * Unnecessary
The test converted to automated, CI and manual testing looks good on all
platforms.
-
Commit messages:
- 8328401: Convert
java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to
automated
Changes: https://git.openjdk.org/jdk/pull/18367/files
Webrev:
The test is converted to main and remains in the problem list, as the problem
is still valid on Linux and macos.
The test passes on Windows.
* sleeps on EDT removed, replaced with the Swing timer
* Unnecessary ltemListener and variables removed.
* Updated instructions with html for better
On Mon, 18 Mar 2024 18:35:23 GMT, Damon Nguyen wrote:
>> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to
>> main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review changes
On Mon, 18 Mar 2024 06:40:36 GMT, Damon Nguyen wrote:
>> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to
>> main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove
On Sat, 16 Mar 2024 22:34:10 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR
On Mon, 18 Mar 2024 12:25:24 GMT, Abhishek Kumar wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>>
On Wed, 13 Mar 2024 17:28:41 GMT, Harshitha Onkar wrote:
>> The following InputMethod test, bug8154816.java is converted to main using
>> PassFailJFrame.
>>
>> - test renamed to PinyinIMCapsTest
>> - moved one directory above - /java/awt/im/
>> - html file deleted.
>>
>> PS: I tried to
On Fri, 15 Mar 2024 15:02:27 GMT, Alexey Ivanov wrote:
>> I expected the label to be aligned to the left. For this to happen, the
>> label may need to wrapped into another panel or horizontal box with added
>> glue.
>>
>>
>>
>> Box logLabelBox = Box.createHorizontalBox();
>>
On Fri, 15 Mar 2024 13:16:39 GMT, Alexey Ivanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add logArea placeholder text
>> - review comments
>
> test/jdk/java/aw
.instructions(INSTRUCTIONS)
> .rows(20)
> .columns(70)
> .logArea()
> .build()
> .awaitAndCheck();
>
>
>
>
> //somewhere in event handlers:
> PassFailJFrame.log("Very important messa
On Fri, 15 Mar 2024 07:29:53 GMT, Abhishek Kumar wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Marked as reviewed by azvegint (Reviewer).
test/jdk/javax/swing/JSlider/bug6587742.java line 30:
> 28: * @build PassFailJFrame
> 29: * @run
On Fri, 15 Mar 2024 12:07:49 GMT, Jie Fu wrote:
> Please review this trivial change.
> Thanks.
Marked as reviewed by azvegint (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18326#pullrequestreview-1938858286
On Fri, 15 Mar 2024 12:38:23 GMT, Alexander Zvegintsev
wrote:
>> Please review this trivial change.
>> Thanks.
>
> Marked as reviewed by azvegint (Reviewer).
> Thanks @azvegint for the review.
Thank you for the fix
-
PR Comment: https://git.openj
On Thu, 14 Mar 2024 16:40:56 GMT, Damon Nguyen wrote:
> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
> using PassFailJFrame
test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 67:
> 65: .rows(15)
> 66: .columns(40)
> 67:
On Thu, 14 Mar 2024 19:36:53 GMT, Phil Race wrote:
> This test draws the same tray icon, has similar instructions to, and is
> subsumed by the related test DisposeInActionEventTest.java
> And because this test has incomplete instructions not covering macOS it is
> problem-listed.
> The other
Often manual tests have a text area in the instruction window to print feedback
from the test to be evaluated by a tester.
I stumbled across another test that needed this, so I decided to make these
changes a standard feature.
List of changes:
* The log text area can be added below the `Pass`
On Fri, 15 Mar 2024 04:40:14 GMT, Alexander Zvegintsev
wrote:
> Often manual tests have a text area in the instruction window to print
> feedback from the test to be evaluated by a tester.
> I stumbled across another test that needed this, so I decided to make these
> change
On Tue, 12 Mar 2024 19:28:45 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
This pull request has now been integrated.
Changeset: df909e2f
Author:Alexander Zvegintsev
URL:
https://git.openjdk.org/jdk/
On Thu, 14 Mar 2024 13:26:37 GMT, Alexey Ivanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> extract logFrameBounds, instructions update
>
> test/jdk/java/awt/Frame/Ge
> The test is converted to main.
> Tested on Linux, Macos and Windows.
Alexander Zvegintsev has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contai
On Wed, 13 Mar 2024 19:43:10 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
This pull request has now been integrated.
Changeset: 7cc1965a
Author:Alexander Zvegintsev
URL:
https://git.openjdk.org/jdk/
> The test is converted to main.
> Tested on Linux, Macos and Windows.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
add empty line
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18287/files
On Mon, 11 Mar 2024 17:29:50 GMT, Alexander Zvegintsev
wrote:
> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written
> to test the very specific functionality of `XFileDialogPeer`, so it shouldn't
> be run on platforms other than Linux.
>
> We a
1 - 100 of 470 matches
Mail list logo
