On Fri, 28 Feb 2025 15:42:51 GMT, Alexey Ivanov wrote:
> Thread dump shows no AWT threads, yet jtreg harness still waits for the test
> thread to finish, in particular it waits for
> [StreamCopier](https://github.com/openjdk/jtreg/blob/759946dedbafa423552851ecb98bc3bb8dcf30ec/src/share/classes/
On Fri, 28 Feb 2025 14:41:41 GMT, Alexander Zvegintsev
wrote:
> During the [JDK-8344891 Remove uses of sun.misc.ReflectUtil in
> java.desktop](https://bugs.openjdk.org/browse/JDK-8344891) it was discovered
> that `beans/finder/MethodFinder.findMethod' incorrectly retu
During the [JDK-8344891 Remove uses of sun.misc.ReflectUtil in
java.desktop](https://bugs.openjdk.org/browse/JDK-8344891) it was discovered
that `beans/finder/MethodFinder.findMethod' incorrectly returned null if a
signature was not in the cache and added it to the cache if it was already
there
On Thu, 27 Feb 2025 19:39:37 GMT, Alisen Chung wrote:
>> upgrading third party library to newest version
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> readd license header to files
src/java.desktop/share/native/liblcms/L
On Wed, 26 Feb 2025 22:26:48 GMT, Alexander Zuev wrote:
> - Check that the calculated audio data size does not exceed available heap
> memory before committing to the rendering
> - Add a test case
test/jdk/javax/sound/midi/BulkSoundBank/BulkSoundBank.java line 33:
> 31: * @bug 8350813
> 32:
On Thu, 27 Feb 2025 00:56:23 GMT, Harshitha Onkar wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> NoResizeEventOnDMChangeTest update
>
> test/jdk/java/awt/Fu
On Tue, 25 Feb 2025 15:57:38 GMT, Mikhail Yankelevich wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> NoResizeEventOnDMChangeTest update
>
> test/jdk/java/awt/FullScre
excluded for versions below that.
>
> ---
>
> Testing looks good (manual + automated).
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
NoResizeEventOnDMChangeTest update
-
Changes:
- all: https://git.
Wayland clients are by design not allowed to change the resolution in Wayland.
XRandR in Xwayland is just an emulation, it doesn't actually change the desktop
resolution. This emulation is per window/x11 client, so different clients can
have different emulated resolutions at the same time.
Any r
On Mon, 24 Feb 2025 21:44:12 GMT, Damon Nguyen wrote:
>> Redo for JComboBox infinite scrolling issue. The issue is that when a
>> scrollbar is clicked and held, if the user switches focus (ex: ALT+TAB)
>> while scrolling, when focused is returned to the scrolling application, the
>> JComboBox
On Thu, 6 Feb 2025 22:03:54 GMT, Alisen Chung wrote:
>> Some useful methods in ExtendedRobot should be migrated into Robot itself so
>> that ExtendedRobot can be removed in the future. The tests using
>> ExtendedRobot for these migrated methods are changed to use only Robot
>> (removing unnece
On Wed, 19 Feb 2025 23:04:39 GMT, Damon Nguyen wrote:
>> Redo for JComboBox infinite scrolling issue. The issue is that when a
>> scrollbar is clicked and held, if the user switches focus (ex: ALT+TAB)
>> while scrolling, when focused is returned to the scrolling application, the
>> JComboBox
On Fri, 21 Feb 2025 16:29:08 GMT, Rajat Mahajan wrote:
>> **Issue:**
>> The JNI method `Java_sun_awt_windows_WTaskbarPeer_setOverlayIcon `calls
>> `CreateIconFromRaster `that can throw a C++ exception.
>>
>> The C++ exception must be caught and must not be allowed to escape the JNI
>> method.
On Wed, 19 Feb 2025 23:29:44 GMT, Alisen Chung wrote:
>> Upgrading freetype 3rd party tool to newest update
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove ws tool
I assume testing looks good.
-
Marked
On Tue, 18 Feb 2025 07:45:06 GMT, Prasanta Sadhukhan
wrote:
> Test is failing in ubuntu 23.x and beyond with expected red pixel not being
> picked up
> Increase in fontsize increase the possibility of font red pixel being picked
> up.
> Test is now passing in ubuntu 24.04 and in CI..
Marked
On Tue, 18 Feb 2025 11:48:09 GMT, Alexey Ivanov wrote:
> **Problem:**
>
> When instructions are long, the formatting in `PassFailJFrame` looks off:
>
> 1. When the instructions are displayed on the screen for the first time, the
> HTML is scrolled to the bottom, which isn't convenient;
> 2. Nu
On Mon, 10 Feb 2025 19:07:49 GMT, Alexander Zvegintsev
wrote:
> Filed as a separate issue to keep the #23426 clean.
>
> Fix is the same as in the
> `src/java.desktop/unix/native/libpipewire/include/spa/param/audio/raw.h` part
> of the [JDK-8309703](https://bugs.openjdk.org/bro
> Filed as a separate issue to keep the #23426 clean.
>
> Fix is the same as in the
> `src/java.desktop/unix/native/libpipewire/include/spa/param/audio/raw.h` part
> of the [JDK-8309703](https://bugs.openjdk.org/browse/JDK-8309703)
Alexander Zvegintsev has updated the pull req
On Mon, 3 Feb 2025 18:50:41 GMT, Alexander Zvegintsev
wrote:
> This changeset updates the pipewire headers to the latest available version.
> It contains the minimum set of required header files needed to build the JDK.
>
> The updated headers are a direct copy from
On Tue, 11 Feb 2025 04:15:49 GMT, Prasanta Sadhukhan
wrote:
> Test seems to fail in ubuntu 22.04 system..It seems removing setAutoDelay is
> making the test more stable in such systems.
> Tested in all platforms where it is still ok without auto delay. CI job link
> in JBS..
Marked as reviewe
On Tue, 11 Feb 2025 16:17:13 GMT, Alexey Ivanov wrote:
> If a manual test throws an exception during construction of `PassFailJFrame`,
> the test execution hangs. When the builder pattern is used, no UI appears on
> the screens, but the Java process does not terminate automatically because
> t
On Tue, 11 Feb 2025 01:07:33 GMT, Harshitha Onkar wrote:
> One thing that I noticed and wanted discuss further: This is when I delete
> the screencast-tokens.properties file and the permission is granted for the
> first screen share (new token generated), it asks for permission every time
> fo
On Tue, 11 Feb 2025 08:33:09 GMT, Julian Waters wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> move fix to spa/utils/endian.h
>
> src/java.desktop/unix/native/libpipewire
> Filed as a separate issue to keep the #23426 clean.
>
> Fix is the same as in the
> `src/java.desktop/unix/native/libpipewire/include/spa/param/audio/raw.h` part
> of the [JDK-8309703](https://bugs.openjdk.org/browse/JDK-8309703)
Alexander Zvegintsev has updated t
> Filed as a separate issue to keep the #23426 clean.
>
> Fix is the same as in the
> `src/java.desktop/unix/native/libpipewire/include/spa/param/audio/raw.h` part
> of the [JDK-8309703](https://bugs.openjdk.org/browse/JDK-8309703)
Alexander Zvegintsev has updated t
On Tue, 4 Feb 2025 23:35:32 GMT, Damon Nguyen wrote:
> Redo for JComboBox infinite scrolling issue. The issue is that when a
> scrollbar is clicked and held, if the user switches focus (ex: ALT+TAB) while
> scrolling, when focused is returned to the scrolling application, the
> JComboBox will
On Tue, 4 Feb 2025 23:35:32 GMT, Damon Nguyen wrote:
> Redo for JComboBox infinite scrolling issue. The issue is that when a
> scrollbar is clicked and held, if the user switches focus (ex: ALT+TAB) while
> scrolling, when focused is returned to the scrolling application, the
> JComboBox will
Filed as a separate issue to keep the #23426 clean.
Fix is the same as in the
`src/java.desktop/unix/native/libpipewire/include/spa/param/audio/raw.h` part
of the [JDK-8309703](https://bugs.openjdk.org/browse/JDK-8309703)
-
Depends on: https://git.openjdk.org/jdk/pull/23426
Commit
On Fri, 7 Feb 2025 06:57:01 GMT, Prasanta Sadhukhan
wrote:
> When you say "Testing looks good" you mean the normal jtreg client testsuite
> or any other specific testing that was done?
normal jtreg client testsuite + manual testing
-
PR Comment: https://git.openjdk.org/jdk/pull/2
On Thu, 6 Feb 2025 14:10:52 GMT, Roman Marchenko wrote:
>> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make
>> `Introspector.addMethod()` working properly when filtering methods out.
>>
>> Also fixed the test, and added the approptiate test case.
>
> Roman Marchenko has updated t
On Tue, 4 Feb 2025 16:28:51 GMT, Roman Marchenko wrote:
>> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make
>> `Introspector.addMethod()` working properly when filtering methods out.
>>
>> Also fixed the test, and added the approptiate test case.
>
> Roman Marchenko has updated t
On Mon, 3 Feb 2025 18:50:41 GMT, Alexander Zvegintsev
wrote:
> This changeset updates the pipewire headers to the latest available version.
> It contains the minimum set of required header files needed to build the JDK.
>
> The updated headers are a direct copy from
This changeset updates the pipewire headers to the latest available version.
It contains the minimum set of required header files needed to build the JDK.
The updated headers are a direct copy from the
https://gitlab.freedesktop.org/pipewire/pipewire/-/releases/1.3.81 (except for
the `\t` -> `
On Mon, 3 Feb 2025 19:02:30 GMT, Damon Nguyen wrote:
>> The test instructions say that disabled PopupMenus should not have shortcuts
>> shown, but on MacOS, these shortcuts still appear. When checking native
>> MacOS15 behavior, disabled PopupMenus still have shortcuts shown. Since the
>> test
On Mon, 3 Feb 2025 17:49:15 GMT, Damon Nguyen wrote:
>> The test instructions say that disabled PopupMenus should not have shortcuts
>> shown, but on MacOS, these shortcuts still appear. When checking native
>> MacOS15 behavior, disabled PopupMenus still have shortcuts shown. Since the
>> test
On Tue, 28 Jan 2025 23:21:26 GMT, Alisen Chung wrote:
>> Currently on macOS when mouseMove is given an offscreen coordinate to move
>> the mouse to, mouseMove will physically clamp to the edge of the screen, but
>> if you try to grab the mouse location immediately after by using
>> MouseInfo.g
On Tue, 28 Jan 2025 11:28:27 GMT, Alexander Zvegintsev
wrote:
> Several TrayIcon tests are trying to click on the system tray icon with Robot
> using XTest API.
>
> Basically we have the same kind of failures as before, e.g.
> [JDK-8280990](https://bugs.openjdk.org/bro
On Fri, 13 Dec 2024 04:16:06 GMT, Alexander Zvegintsev
wrote:
> The previous [JDK-8319103](https://bugs.openjdk.org/browse/JDK-8319103) fix
> was not complete.
>
> The case where a menu item with a focusable component was not a direct child
> of a window was missing(failing
On Wed, 29 Jan 2025 15:46:31 GMT, Alexey Ivanov wrote:
>> Use a `CountDownLatch` in `javax/swing/AbstractButton/bug6298940.java`
>> instead of delay.
>> Use `Util.hitMnemonics` instead of custom code to handle macOS.
>>
>> I ran the updated test a few times with `JTREG=REPEAT_COUNT=20`, the t
o the ungrab event was posted prematurely.
>
> This can be fixed by adding `waylandWindowFocusListener` to all submenus in
> hierarchy.
>
> The manual test updated to use this case, and also added an automated test
> that checks that it didn't close prematurely.
Alexande
On Wed, 29 Jan 2025 15:50:25 GMT, Alexey Ivanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> test/jdk/javax/swing/JPopupMenu/NestedFocusablePo
f
>> moving/resizing/stacking the windows.
>
> I also tested the same tests by clicking manually instead of using the robot,
> and it works as expected.
> So for now, skip those tests on Wayland (and do some minor cleanup).
>
> Testing after modifications is also green
On Tue, 28 Jan 2025 17:44:19 GMT, Alexey Ivanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - minor
>> - review comments
>
> test/jdk/java/awt/TrayIcon/Acti
On Mon, 20 Jan 2025 13:07:19 GMT, Andrey Turbanov wrote:
> Two `Hashtable`'s in `javax.swing.text.html.CSS.LengthUnit` class are
> modified only within `` block:
> 1. lengthMapping
> 2. w3cLengthMapping
>
> We can replace them with immutable maps to avoid Hashtable synchronization
> overhead.
Several TrayIcon tests are trying to click on the system tray icon with Robot
using XTest API.
Basically we have the same kind of failures as before, e.g.
[JDK-8280990](https://bugs.openjdk.org/browse/JDK-8280990)
> the reason is this is using XTEST, an X11 protocol which will not work
> outsi
On Tue, 28 Jan 2025 11:28:27 GMT, Alexander Zvegintsev
wrote:
> Several TrayIcon tests are trying to click on the system tray icon with Robot
> using XTest API.
>
> Basically we have the same kind of failures as before, e.g.
> [JDK-8280990](https://bugs.openjdk.org/bro
On Fri, 24 Jan 2025 16:47:42 GMT, Alexey Ivanov wrote:
> Use a `CountDownLatch` in `javax/swing/AbstractButton/bug6298940.java`
> instead of delay.
> Use `Util.hitMnemonics` instead of custom code to handle macOS.
>
> I ran the updated test a few times with `JTREG=REPEAT_COUNT=20`, the test
On Mon, 27 Jan 2025 06:16:29 GMT, Naveen Narayanan wrote:
>> This contains test fixes for the following issue in
>> ScreenCaptureRobotTest.java
>>
>> •Failures in Mac OS because of mouse pointer visible on top of the image
>> that is screen captured by robot.
>>
>> Testing:
>> Tested usin
o the ungrab event was posted prematurely.
>
> This can be fixed by adding `waylandWindowFocusListener` to all submenus in
> hierarchy.
>
> The manual test updated to use this case, and also added an automated test
> that checks that it didn't close prematurely.
Alexande
On Fri, 24 Jan 2025 17:30:30 GMT, Alexey Ivanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> getLocationOnScreen on EDT
>
> test/jdk/javax/swing/JPopupMenu/NestedFo
On Thu, 23 Jan 2025 13:48:06 GMT, Joachim Kern wrote:
>> We (SAP) try to introduce the ‘IBM Open XL C/C++ for AIX 17.1.2’ (based on
>> clang 17) as a feasible compiler for jdk25, because in combination with the
>> 17.1.3 runtime this would enable the support for ubsan.
>> Unfortunately, the new
On Thu, 23 Jan 2025 11:37:23 GMT, Naveen Narayanan wrote:
> This contains test fixes for the following issue in
> ScreenCaptureRobotTest.java
>
> • Failures in Mac OS because of mouse pointer visible on top of the image
> that is screen captured by robot.
>
> Testing:
> Tested using Mach5
On Tue, 21 Jan 2025 14:28:26 GMT, Alexander Zvegintsev
wrote:
> The beancontext package description or the deprecation text in the classes
> doesn't say anything about why the API is deprecated.
> A few more words have been added in this regard.
This pull request has now b
On Tue, 24 Dec 2024 03:02:51 GMT, anass baya wrote:
> Remove PassFailJFrame constructor with screenshots since no test is using it
Marked as reviewed by azvegint (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22873#pullrequestreview-2569960923
On Thu, 23 Jan 2025 11:09:23 GMT, Alexey Ivanov wrote:
>> With this changeset, I update the
>> `java/awt/List/ItemEventTest/ItemEventTest.java` test to improve its
>> stability and analysis of failures of the test.
>>
>> 1. Use thread-safe `StringBuffer` for `actualSelectionOrder` to track
>>
On Wed, 22 Jan 2025 16:45:17 GMT, Alexey Ivanov wrote:
> With this changeset, I update the
> `java/awt/List/ItemEventTest/ItemEventTest.java` test to improve its
> stability and analysis of failures of the test.
>
> 1. Use thread-safe `StringBuffer` for `actualSelectionOrder` to track
> selec
On Wed, 22 Jan 2025 20:20:28 GMT, Alexey Ivanov wrote:
> The fields of `ListSelectionEvent` are set in the constructor and are never
> modified, mark the fields — `firstIndex`, `lastIndex`, `isAdjusting` — with
> the `final` modifier.
Marked as reviewed by azvegint (Reviewer).
-
On Wed, 22 Jan 2025 17:16:11 GMT, Alexey Ivanov wrote:
> A trivial change which removes repeated ‘a’ from the [javadoc for the
> `ListSelectionEvent`
> class](https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/javax/swing/event/ListSelectionEvent.html):
>
>> “The change is limited
On Wed, 22 Jan 2025 01:38:56 GMT, Harshitha Onkar wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> formatting
>
> test/jdk/javax/swing/JPopupMenu/NestedFocusablePopupTest.jav
o the ungrab event was posted prematurely.
>
> This can be fixed by adding `waylandWindowFocusListener` to all submenus in
> hierarchy.
>
> The manual test updated to use this case, and also added an automated test
> that checks that it didn't close prematurely.
Alexande
> The beancontext package description or the deprecation text in the classes
> doesn't say anything about why the API is deprecated.
> A few more words have been added in this regard.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit
On Tue, 21 Jan 2025 21:28:35 GMT, Alexey Ivanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> src/java.desktop/share/classes/java/beans/beancontex
The beancontext package description or the deprecation text in the classes
doesn't say anything about why the API is deprecated.
A few more words have been added in this regard.
-
Commit messages:
- 8347008: beancontext package spec does not clearly explain why the API is
deprecate
On Tue, 21 Jan 2025 04:09:17 GMT, Abhishek Kumar wrote:
>> There are no tabs available for GTK Look and Feel due to the different
>> ColorChooser UI design. Updated the test to skip testing for GTK L&F.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit s
On Thu, 16 Jan 2025 11:53:18 GMT, Andrey Turbanov wrote:
> There is a field `javax.swing.text.html.CSS#styleConstantToCssMap` which uses
> legacy `Hashtable` class.
> As this map is read-only and all its content is initialized in `` we
> can safely use immutable `Map` instead.
Marked as review
On Mon, 20 Jan 2025 19:35:18 GMT, Alexey Ivanov wrote:
> It's an inconvenience which can be overcome by compiling the test and
> `SkippedException` together:
*Grumbling*:
"Overcome" is a good word in this case, as it's not even close to the
convenience of just `java `, where you don't have to
On Mon, 20 Jan 2025 19:56:18 GMT, Alexey Ivanov wrote:
> What if the window that loses focus is not the parent of the popup hierarchy?
> Or is it guaranteed that all the children of the popup window receive the
> focus lost event?
I can't imagine such a case, but even if it is, it will all be
o the ungrab event was posted prematurely.
>
> This can be fixed by adding `waylandWindowFocusListener` to all submenus in
> hierarchy.
>
> The manual test updated to use this case, and also added an automated test
> that checks that it didn't close prematurely.
Alexande
On Mon, 20 Jan 2025 01:08:01 GMT, Alexander Zvegintsev
wrote:
>> The previous [JDK-8319103](https://bugs.openjdk.org/browse/JDK-8319103) fix
>> was not complete.
>>
>> The case where a menu item with a focusable component was not a direct child
>> of a wind
o the ungrab event was posted prematurely.
>
> This can be fixed by adding `waylandWindowFocusListener` to all submenus in
> hierarchy.
>
> The manual test updated to use this case, and also added an automated test
> that checks that it didn't close prematurely.
Alexande
On Fri, 13 Dec 2024 22:12:58 GMT, Alexander Zvegintsev
wrote:
>> src/java.desktop/unix/classes/sun/awt/UNIXToolkit.java line 550:
>>
>>> 548:
>>> addWaylandWindowFocusListenerToWindow(oppositeWindow);
>>> 549:
On Wed, 15 Jan 2025 09:45:33 GMT, Prasanta Sadhukhan
wrote:
> This manual test draws a "custom" Caret which is to be placed in the same
> position between characters but it is seen the movement of caret leaves
> artifacts. Custom caret is rendering 2 horizontal and 1 vertical line to
> render
On Wed, 15 Jan 2025 21:52:52 GMT, Rajat Mahajan wrote:
>> **Issue:**
>> AwtWindow::SetIconData leaks the old icon handles in hOldIcon and hOldIconSm
>> if CreateIconFromRaster raises an exception. Additionally, an exception is
>> checked only after the first call to CreateIconFromRaster.
>>
>
On Thu, 16 Jan 2025 11:52:14 GMT, Jayathirth D V wrote:
> In PNG we have non-essential compressed text chunks zTXt and iTXt, which can
> consume considerable amount of memory when they contain large amount of
> compressed data.
>
> We should restrict the amount of text data we want to decompre
On Fri, 1 Nov 2024 14:43:39 GMT, Andrey Turbanov wrote:
> Static and non-static `CSS.LengthUnit.getValue` methods essentially do the
> same thing.
> https://github.com/openjdk/jdk/blob/751a914b0a377d4e1dd30d2501f0ab4e327dea34/src/java.desktop/share/classes/javax/swing/text/html/CSS.java#L3085-L3
On Fri, 1 Nov 2024 20:13:31 GMT, Andrey Turbanov wrote:
> The Hashtable `javax.swing.text.html.HTML.scMapping` is modified only within
> `` block.
> We can replace it with immutable map to avoid Hashtable synchronization
> overhead.
Marked as reviewed by azvegint (Reviewer).
-
PR
On Mon, 13 Jan 2025 10:23:28 GMT, Alexander Zuev wrote:
> If pitch drifts too low assume minimum allowed pitch to continue sampling.
Marked as reviewed by azvegint (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23064#pullrequestreview-254607
On Fri, 1 Nov 2024 14:02:52 GMT, Andrey Turbanov wrote:
> The Hashtable `javax.swing.text.html.parser.Entity#entityTypes` is modified
> only within `` block.
> We can replace it with immutable map to avoid Hashtable synchronization
> overhead.
> Similar to what we did in #21825.
Marked as revi
On Thu, 2 Jan 2025 20:01:28 GMT, Archie Cobbs wrote:
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
>
> This issue is a follow up to
> [JDK-8343476](https://bugs.openjdk.org/browse/JDK-8343476) to remove some
> additional warnings that were missed in t
On Mon, 6 Jan 2025 05:43:19 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi All,
>>
>> I have updated the test and made it automation friendly. Please review and
>> let me know your suggestions
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit
On Fri, 13 Dec 2024 12:39:02 GMT, Alexey Ivanov wrote:
>> The previous [JDK-8319103](https://bugs.openjdk.org/browse/JDK-8319103) fix
>> was not complete.
>>
>> The case where a menu item with a focusable component was not a direct child
>> of a window was missing(failing the `if (window ==
>
On Thu, 12 Dec 2024 13:29:55 GMT, GennadiyKrivoshein wrote:
>> Fix for https://bugs.openjdk.org/browse/JDK-8343224,
>> print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4.
>>
>> **Reason of the bug:**
>> The reason for the regression bug is a missed check for the standard me
The previous [JDK-8319103](https://bugs.openjdk.org/browse/JDK-8319103) fix was
not complete.
The case where a menu item with a focusable component was not a direct child of
a window was missing(failing the `if (window == oppositeWindow.getParent() ) {`
check), so the ungrab event was posted pr
On Wed, 4 Dec 2024 20:38:52 GMT, GennadiyKrivoshein wrote:
>> Fix for https://bugs.openjdk.org/browse/JDK-8343224,
>> print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4.
>>
>> **Reason of the bug:**
>> The reason for the regression bug is a missed check for the standard med
On Fri, 1 Nov 2024 13:32:07 GMT, Andrey Turbanov wrote:
> The Hashtable `javax.swing.text.html.parser.Element#contentTypes` is
> initialized only within `` block.
> We can replace it with immutable map to avoid Hashtable `synchronized`
> overhead.
Marked as reviewed by azvegint (Reviewer).
--
On Wed, 11 Dec 2024 09:13:06 GMT, Saagar Jha wrote:
>> 8345876: Update nativeAddAtIndex comment to match the code
>
> Saagar Jha has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains one commit:
>
> Update nativeAddAtIndex comment to m
On Tue, 10 Dec 2024 11:43:44 GMT, Nizar Benalla wrote:
> Please review this trivial change fixing a broken link in
> `PresentationDirection.java`
>
> The contents of the links are identical, I used the [wayback
> machine](https://web.archive.org/web/20210511075617/https://ftp.pwg.org/pub/pwg/s
On Sat, 7 Dec 2024 04:41:01 GMT, Saagar Jha wrote:
> 8345876: Update nativeAddAtIndex comment to match the code
> Ok so I think that solved the "I don't have a way to make a bug for this"
> issue. I have signed an OCA a while back, is there anything else I need to do
> there?
It looks like y
On Mon, 9 Dec 2024 20:47:07 GMT, Harshitha Onkar wrote:
> ```
> public void delay(int ms) {
> if (isEventDispatchThread()) {
> throw new IllegalThreadStateException("delay() called on EDT");
> }
> ```
There is already a `checkNotDispatchThread` method, so we can reuse it.
--
On Wed, 20 Nov 2024 18:10:40 GMT, Damon Nguyen wrote:
>> Change test instructions and drawString to say "Text" instead of "Default"
>> for cursor type. Added instructions to test `setCursor` for the frame as
>> well. Also increased the column count to fit the instructions in linux, as
>> it wa
On Thu, 5 Dec 2024 20:27:16 GMT, Daniel Gredler wrote:
>> When `LineBreakMeasurer` is used to break text into lines, internally it
>> uses `TextMeasurer` and `TextLine` to do the job. In the common case,
>> `TextLine.getComponents(...)` allocates a `TextLineComponent[]` with room
>> for a sing
On Fri, 6 Dec 2024 06:37:28 GMT, Prasanta Sadhukhan
wrote:
> The no-arg constructor BasicSliderUI() was added accidentally. It should be
> removed.
>
> [JDK-8334580](https://bugs.openjdk.org/browse/JDK-8334580) deprecates the
> BasicSliderUI() constructor, and this follow-up is to remove the
On Wed, 4 Dec 2024 15:40:31 GMT, Alexey Ivanov wrote:
> This is a continuation to #20376, it moves the text in
> `Document-{insert,remove}.svg` down by 0.5 pixel.
>
> This change makes the text centred in the boxes.
>
> Here are quotes from
> https://github.com/openjdk/jdk/pull/20376#issuecom
On Wed, 27 Nov 2024 12:47:29 GMT, Dmitry Markov wrote:
> If AWT/Swing app displays several windows and an user changes the keyboard
> layout and then closes the focused window, the app does not keep the keyboard
> layout changes.
>
> It is necessary to sync currentLocale and Windows keyboard l
On Tue, 3 Dec 2024 17:17:22 GMT, Harshitha Onkar wrote:
>> The following two tests failed intermittently due to stability issues after
>> JEP486 (Removal of Security Manager). Tests have been updated for stability.
>> This test is applicable for linux platform only, hence `@requires (os.family
On Tue, 3 Dec 2024 01:13:09 GMT, Alexander Zvegintsev
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> frame title
>
> test/jdk/java/awt/datatransfer/Independence/Independence
On Tue, 3 Dec 2024 05:25:18 GMT, Harshitha Onkar wrote:
>> The following two tests failed intermittently due to stability issues after
>> JEP486 (Removal of Security Manager). Tests have been updated for stability.
>> This test is applicable for linux platform only, hence `@requires (os.family
On Mon, 2 Dec 2024 23:03:14 GMT, Phil Race wrote:
>> Remove SecurityManager related code from Swing filechooser implementation
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8345141
Marked as reviewed by azvegint (Reviewer).
On Tue, 3 Dec 2024 00:17:11 GMT, Harshitha Onkar wrote:
>> The following two tests failed intermittently due to stability issues after
>> JEP486 (Removal of Security Manager). Tests have been updated for stability.
>> This test is applicable for linux platform only, hence `@requires (os.family
On Mon, 2 Dec 2024 19:01:06 GMT, Phil Race wrote:
>> Remove SecurityManager related code in the desktop module that is not
>> covered by other PRs
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8345143
Marked as reviewed by
1 - 100 of 721 matches
Mail list logo
