On Wed, 18 Sep 2024 09:06:04 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which replaces the use of
> the outdated "-mx" option with the "-Xmx" option when launching the java
> processes in this test? This test was missed out from one of the earlier
> integrate
gint @aivanov-jdk please take a look.
Sergey Bylokhov has updated the pull request incrementally with one additional
commit since the last revision:
Update bug4490179.java
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20861/files
- new: https://git.openjdk.org/jdk/p
gint @aivanov-jdk please take a look.
Sergey Bylokhov has updated the pull request incrementally with one additional
commit since the last revision:
PR review part 1
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20861/files
- new: https://git.openjdk.org/jdk/pull/20861/
On Mon, 9 Sep 2024 20:34:30 GMT, Sergey Bylokhov wrote:
>> Not sure if it's a product bug…
>>
>> AWT components do not explicitly state whether they're thread-safe or not.
>> It's more or less assumed they should be. At the same time, I don't see cod
On Mon, 9 Sep 2024 19:32:04 GMT, Alexey Ivanov wrote:
>At the same time, I find it weird that repaint paints directly in its code and
>then posts paint event.
This is one of the implementation details of the AWT, the "native" component
should be painted before the paint event will proceed on E
On Wed, 4 Sep 2024 20:50:38 GMT, Sergey Bylokhov wrote:
> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been
> tweaked, see inline comments.
>
> Notes:
> * We have a few XXXRepaint.java tests and in this patch, I updated all of
> them to follow t
Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been
tweaked, see inline comments.
Notes:
* We have a few XXXRepaint.java tests and in this patch, I updated all of them
to follow the change added to the ListRepaint.java
@azvegint @aivanov-jdk please take a look.
-
On Thu, 5 Sep 2024 12:04:19 GMT, Nikita Gubarkov wrote:
>> I moved SurfaceDataProxy cache into a separate class.
>> Now caching level is determined by placement of the
>> SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns"
>> proxies and therefore strong refs via them d
On Wed, 29 May 2024 09:56:20 GMT, Alexander Zvegintsev
wrote:
>> These changes are intended to stabilize testing on Wayland in X11
>> compatibility mode.
>>
>>
>>
>> Many tests may fail if there is no `robot.delay()` call after
>> `robot.waitForIdle()` (right after displaying a window).
>>
On Wed, 4 Sep 2024 18:50:12 GMT, Sergey Bylokhov wrote:
>> I'm not sure that this should happen, (implemenation bug?) but it is outside
>> the scope of the test updates to fix.
>
> this looks like a product bug.
see https://bugs.openjdk.org/browse/JDK-8339561
-
On Wed, 22 May 2024 02:51:31 GMT, Alexander Zvegintsev
wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> spacing
>
> test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java line 53:
>
>> 51: import jdk.test
On Wed, 29 May 2024 09:56:20 GMT, Alexander Zvegintsev
wrote:
>> These changes are intended to stabilize testing on Wayland in X11
>> compatibility mode.
>>
>>
>>
>> Many tests may fail if there is no `robot.delay()` call after
>> `robot.waitForIdle()` (right after displaying a window).
>>
On Wed, 22 May 2024 20:44:54 GMT, Phil Race wrote:
>> test/jdk/java/awt/Paint/ListRepaint.java line 40:
>>
>>> 38: static Frame frame;
>>> 39:
>>> 40: public static void main(final String[] args) throws Exception {
>>
>> It is critical to call AWT code on EDT in this test, otherwise it
On Thu, 1 Aug 2024 21:51:04 GMT, Daniel Gredler wrote:
>> At some point the `JPEGImageWriter` was optimized to reduce duplication /
>> copying of rasters and data buffers (see `JDK-6266748`). However,
>> `PNGImageWriter` never received a similar optimization, and is making
>> unnecessary copie
On Thu, 29 Aug 2024 04:38:29 GMT, Tejesh R wrote:
> On analysis of captured image, it is observed that there are few pixels which
> vary slightly w.r.t to expected color. Hence tolerance is included in color
> comparison.
> Tested in mach5 multiple time and its green.
Have you checked what is
On Wed, 28 Aug 2024 16:43:49 GMT, Kevin Rushforth wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reattach thread if AWT is the owner of NSApplication
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/Appli
On Wed, 28 Aug 2024 02:19:08 GMT, Prasanta Sadhukhan
wrote:
>> The testcase calls Platform.exit before the dialog is made visible but
>> on macOS, JavaFX takes over the AppKit thread and uses that as the FX
>> application thread. As part of the FX platform shutdown process, it detaches
>> that
On Wed, 31 Jul 2024 07:12:35 GMT, Prasanta Sadhukhan
wrote:
> Since Math.round with integer argument returns the same value, and also
> since all arguments and calculations in the
> AquaProgressBarUI#getStringPlacement are integer arithmetic, Math.round is
> redundant and can be removed
src
On Mon, 26 Aug 2024 19:02:56 GMT, Alexander Zvegintsev
wrote:
> There are two mouse pointer locations on Wayland:
>
> `#1` Wayland compositor - can be controlled by a physical mouse device, or
> libei, this location is visible on a screen as a mouse cursor and is
> propagated to `#2`.
>
> `#
On Sat, 24 Aug 2024 00:04:33 GMT, Phil Race wrote:
>> I'm also not sure that this is the right fix. It seems like it will fix one
>> specific place where AWT could do an upcall on the AppKit thread after FX
>> has detached without addressing the problem as a whole.
>>
>> Another possible fix w
On Fri, 23 Aug 2024 23:30:53 GMT, Phil Race wrote:
> Can you make it clear it is a "Swing" property and update the CSR too.
Maybe we can improve the javadoc tool for that? It is currently possible to
mark/highlight the system properties in the doc, it should be possible to do
the same for Swin
On Mon, 29 Jul 2024 13:43:42 GMT, Alexey Ivanov wrote:
> This changeset updates the image in the documentation for the
> `Document.insert` method. The image in `Document.remove` was updated by
> [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #15701.
>
> Now the illustration o
On Thu, 22 Aug 2024 03:59:57 GMT, Sergey Bylokhov wrote:
> The unused `java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY` field is
> deleted.
>
> It was unused since [8037485](https://bugs.openjdk.org/browse/JDK-8037485):
> Refactor java.awt.datatransfer to eliminate de
The unused `java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY` field is
deleted.
It was unused since [8037485](https://bugs.openjdk.org/browse/JDK-8037485):
Refactor java.awt.datatransfer to eliminate dependency on AWT.
See:
https://github.com/openjdk/jdk/commit/0fecd7769453dfb3ef1609b057a9e
On Fri, 18 Nov 2022 08:42:12 GMT, Sergey Bylokhov wrote:
>> Redo of 8295369: Update LCMS to 2.14
>> Update LCMS to newest release.
>> Updated DISABLED_WARNINGS_gcc for LCMS to include type limits to prevent a
>> build error in linux.
>> Automatic tests and J2D
On Tue, 30 Jul 2024 03:16:27 GMT, Prasanta Sadhukhan
wrote:
>> I was pointing out a spelling mistake. Nothing more.
>
> ok..fixed..
Look like is not fixed yet?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/20289#discussion_r1720494106
On Wed, 17 Jul 2024 21:23:10 GMT, Phil Race wrote:
> NB those times (124ms and 178 ms ) include the execution time for layout as
> well,
> but the difference is what matters to answer this question and it is answered
> as expected.
This is a good news!
-
PR Comment: https://git.o
On Thu, 15 Aug 2024 07:26:28 GMT, Prasanta Sadhukhan
wrote:
>> Issue is
>> BasicScrollBarUI.ArrowButtonListener starts a timer in mousePressed(), and
>> stops it in mouseReleased(). If the frame containing the scrollbar is
>> disabled between the MOUSE_PRESSED and the MOUSE_RELEASED events, th
On Fri, 16 Aug 2024 07:36:01 GMT, Manukumar V S wrote:
>> java/awt/Frame/MaximizeUndecoratedTest.java fails in OEL due to a slight
>> color difference in the background color. This is currently reproduced only
>> for Oracle Linux.
>>
>> The Color object I'm getting for each of these Point obj
On Fri, 16 Aug 2024 19:45:19 GMT, Alexander Zvegintsev
wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk.properties
>> line 63:
>>
>>> 61: FileChooser.renameFileButton.textAndMnemonic=&Rename File
>>> 62: FileChooser.cancelButton.textAndMnemonic=&Cancel
>>> 63:
On Tue, 25 Jun 2024 22:03:38 GMT, Phil Race wrote:
> or if the layout code is executed first then I'd expect to see zero machinery
> init cost here.
It will be good to check thi.s So we'll use it freely, assuming it won't
introduce any additional overhead.
-
PR Comment: https://g
On Mon, 24 Jun 2024 22:25:22 GMT, Phil Race wrote:
>> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
>> This reduces the coupling between the java.desktop module and the internals
>> of the java.base module.
>>
>> The code being changed here is not particularly performance sensit
On Fri, 7 Jun 2024 20:34:23 GMT, Alisen Chung wrote:
>> Add a check for previous focused window on modal unblocking. If the owner of
>> a closing dialog was the last focused window, then the owner of the dialog
>> should regain focus.
>
> Alisen Chung has updated the pull request incrementally
On Mon, 10 Jun 2024 21:09:35 GMT, Alisen Chung wrote:
> Removing if check for unsupported jawt versions
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19639#pullrequestreview-2121875806
On Tue, 11 Jun 2024 02:37:44 GMT, Sergey Bylokhov wrote:
>> Removing if check for unsupported jawt versions
>
> Is it possible to cover this fix by the test?
> @mrserb can you look at this one.
The change looks fine. I remember we had a task to test jawt functionality, but
se
On Wed, 12 Jun 2024 11:52:47 GMT, Alexey Ivanov wrote:
> How do we remove this constructor? Can it be removed right away? Should it be
> deprecated for several releases before it's removed?
Just delete it in all versions of 17+?
-
PR Comment: https://git.openjdk.org/jdk/pull/19192
On Mon, 10 Jun 2024 21:09:35 GMT, Alisen Chung wrote:
> Removing if check for unsupported jawt versions
Is it possible to cover this fix by the test?
-
PR Comment: https://git.openjdk.org/jdk/pull/19639#issuecomment-2159660501
On Fri, 10 May 2024 17:33:53 GMT, Sergey Bylokhov wrote:
>> JTabbedPane's contentOpaque and tabsOpaque properties are not honored in
>> Aqua L&F. JTabbedPane's content area and tab background color are not as
>> expected when tabbedpane opacity is set to true or
On Thu, 6 Jun 2024 23:28:07 GMT, Alisen Chung wrote:
> Add a check for previous focused window on modal unblocking. If the owner of
> a closing dialog was the last focused window, then the owner of the dialog
> should regain focus.
src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWind
On Wed, 29 May 2024 11:51:34 GMT, Alexey Ivanov wrote:
>> When mapping methods and when they first appeared (by using the historical
>> record built into javac) I use an id in the form of
>> `method:
>> .()` so
>> for covariant overrides in general, when the return type changes I consider
>
On Mon, 6 May 2024 20:51:55 GMT, Sergey Bylokhov wrote:
> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and
> verify that the cmm id of the icc profile is properly reported. Before
> JDK-8321489 we always report 'lcms' as a cmm id.
This pull r
> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and
> verify that the cmm id of the icc profile is properly reported. Before
> JDK-8321489 we always report 'lcms' as a cmm id.
Sergey Bylokhov has updated the pull request with a new target base due to a
> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and
> verify that the cmm id of the icc profile is properly reported. Before
> JDK-8321489 we always report 'lcms' as a cmm id.
Sergey Bylokhov has updated the pull request incrementally with one addit
On Fri, 10 May 2024 07:05:11 GMT, Abhishek Kumar wrote:
> JTabbedPane's contentOpaque and tabsOpaque properties are not honored in Aqua
> L&F. JTabbedPane's content area and tab background color are not as expected
> when tabbedpane opacity is set to true or false. Fix is to handle the opacity
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote:
> Opening closed dnd test
> Test is green on all platforms
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19128#pullrequestreview-2044249314
The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and
verify that the cmm id of the icc profile is properly reported. Before
JDK-8321489 we always report 'lcms' as a cmm id.
-
Commit messages:
- 8331746: Create a test to verify that the cmm id is not ignored
Ch
On Thu, 2 May 2024 13:01:12 GMT, Alexander Zvegintsev
wrote:
>> Some tests try to get the focus of a window by clicking on its title bar.
>>
>> On XWayland, however, emulating mouse clicks with XTEST currently only
>> affects the XWayland server, not the window decorations, so trying to click
On Thu, 2 May 2024 18:45:54 GMT, Phil Race wrote:
> Change GPL+CP -> GPL as required for all tests.
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19068#pullrequestreview-2036784210
On Tue, 30 Apr 2024 16:49:49 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/Focus/6981400/Test1.java line 186:
>>
>>> 184: Util.clickOnComp(compToClick, robot);
>>> 185:
>>> 186: if (Platform.isOnWayland()) {
>>
>> If the goal is just to move the window to the front the
On Wed, 1 May 2024 16:43:13 GMT, Phil Race wrote:
> The issue was discovered by failing a closed test that you wrote some time
> ago.
=) ok
-
PR Comment: https://git.openjdk.org/jdk/pull/18950#issuecomment-2089251764
On Thu, 25 Apr 2024 17:22:48 GMT, Alexander Zvegintsev
wrote:
>> This fix adds missing doPrivileged calls in TokenStorage, which is used to
>> help take screenshots in Wayland.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revis
On Thu, 25 Apr 2024 17:22:48 GMT, Alexander Zvegintsev
wrote:
>> This fix adds missing doPrivileged calls in TokenStorage, which is used to
>> help take screenshots in Wayland.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revis
On Tue, 30 Apr 2024 02:02:30 GMT, Alexander Zvegintsev
wrote:
>> Some tests try to get the focus of a window by clicking on its title bar.
>>
>> On XWayland, however, emulating mouse clicks with XTEST currently only
>> affects the XWayland server, not the window decorations, so trying to click
On Thu, 25 Apr 2024 16:37:39 GMT, Alexey Ivanov wrote:
> This PR provides a regression test for
> [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in
> BasicDirectoryModel.validateFileCache_ reviewed in #18111.
>
> The test is inspired and based on `ConcurrentModification` tha
On Sat, 11 Nov 2023 12:32:15 GMT, Jan Trukenmüller wrote:
>> The MIDI file parser misinterprets events without status byte when they
>> appear directly after a Meta of SysEx event.
>>
>> For my bugfix I had to decide between two possible solutions:
>> - Strict solution: Throw an InvalidMidiData
On Tue, 9 Apr 2024 18:50:17 GMT, Phil Race wrote:
> The main problem here is that we do not curate what font point size we passed
> to freetype,
> and would pass in one larger than freetype's maximum of FT_USHORT_MAX which
> is USHRT_MAX.
> This isn't documented, SFAICS, and is checked a couple
On Wed, 17 Apr 2024 04:31:16 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is m
On Thu, 11 Apr 2024 09:33:09 GMT, Alexey Ivanov wrote:
> This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`.
>
> `IS_WINVISTA` was not used at all.
>
> `IS_WINXP` guarded support for icons with alpha channel. It is now safe to
> assume Java runs on a Windows version
On Tue, 16 Apr 2024 04:16:26 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is m
On Tue, 16 Apr 2024 04:09:47 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JComboBox/DisabledComboBoxFontTestAuto.java line 58:
>>
>>> 56:
>>> 57: private static void createCombo() {
>>> 58: combo = new JComboBox();
>>
>> If we can use unicode blank character instead of "Simpl
On Thu, 11 Apr 2024 09:33:09 GMT, Alexey Ivanov wrote:
> This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`.
>
> `IS_WINVISTA` was not used at all.
>
> `IS_WINXP` guarded support for icons with alpha channel. It is now safe to
> assume Java runs on a Windows version
On Wed, 10 Apr 2024 21:25:06 GMT, Larry Cable wrote:
>> the beancontext package was added (by me) in JDK 1.2 to provide
>> JavaBeans(tm) with a containment and services hierarchy.
>>
>> based upon concepts from OpenDoc, which was a popular component model at the
>> time, the API pre-dated the
On Tue, 5 Mar 2024 17:40:01 GMT, Alexey Ivanov wrote:
>> The implementation of `Win32ShellFolder2.compareTo` is inconsistent: there
>> are cases where
>> `a < b & b < c but a == c`
>> which *violates its general contract*.
>>
>> In particular, it happens for the personal folder (*Documents*
On Fri, 5 Apr 2024 15:46:06 GMT, Alexey Ivanov wrote:
> Remove unused class `KeyBuilder` and unused field `unusedSets`.
> Update a comment which used javadoc syntax.
> Mark `KeyEnumeration` and `FontKey` classes as *`final`*.
>
> All the client tests are green.
Marked as reviewed by serb (R
On Fri, 5 Apr 2024 15:46:06 GMT, Alexey Ivanov wrote:
> Remove unused class `KeyBuilder` and unused field `unusedSets`.
> Update a comment which used javadoc syntax.
> Mark `KeyEnumeration` and `FontKey` classes as *`final`*.
>
> All the client tests are green.
Could you please check the hi
On Mon, 1 Apr 2024 22:53:12 GMT, Larry Cable wrote:
> the beancontext package was added (by me) in JDK 1.2 to provide JavaBeans(tm)
> with a containment and services hierarchy.
>
> based upon concepts from OpenDoc, which was a popular component model at the
> time, the API pre-dated the additi
On Fri, 29 Mar 2024 20:02:53 GMT, Alexey Ivanov wrote:
>>> However, there are cases where instantiating and testing is safe on main
>>> thread.
>>
>> That is my point, make it less safe - when the component is created on one
>> thread:EDT and then for some reason accessed on a different thread
On Fri, 15 Mar 2024 14:45:36 GMT, Alexey Ivanov wrote:
>> I'm adding a regression test for
>> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
>> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a
>> regression test for
>> [JDK-8240690](https://bugs.openjdk.
On Wed, 27 Mar 2024 20:19:41 GMT, Alexey Ivanov wrote:
> However, there are cases where instantiating and testing is safe on main
> thread.
That is my point, make it less safe - when the component is created on one
thread:EDT and then for some reason accessed on a different thread, the
rescan
On Tue, 19 Mar 2024 17:03:25 GMT, Alexey Ivanov wrote:
>Instantiating JFileChooser on EDT adds complexity for no benefit. The
>JFileChooser is still accessed concurrently from several threads, including
>Swing internal thread.
But still, this is a common requirement to create UI components on
On Thu, 14 Mar 2024 20:13:58 GMT, Sergey Bylokhov wrote:
> This is a request to forward port the test added by the
> [JDK-8241307](https://bugs.openjdk.org/browse/JDK-8241307) with inverted
> condition - jdk jdk11 the marlin should be used by default.
This pull request has now been i
On Fri, 15 Mar 2024 12:02:43 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java
>> line 99:
>>
>>> 97: createFiles(temp);
>>> 98:
>>> 99: final JFileChooser fc = new JFileChooser(temp.toFile());
>>
>> it should
On Fri, 15 Mar 2024 14:50:12 GMT, Alexey Ivanov wrote:
>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
>> synchronized.
>>
>> Without synchronization, a thread checks if `filesLoader` is not null and
>> creates a new `FilesLoader` thread. If the thread is pre-empted bet
On Sat, 16 Mar 2024 21:32:02 GMT, Phil Race wrote:
> We don't have any others in JDK 23, so I am not sure what this test does for
> us.
Right now it is not useful, but that is the same story we had in OpenJDK 8 -
only the one engine for years, and then the engine "accidentally" changed to
mar
This is a request to forward port the test added by the
[JDK-8241307](https://bugs.openjdk.org/browse/JDK-8241307) with inverted
condition - jdk jdk11 the marlin should be used by default.
-
Commit messages:
- Create DefaultRenderingEngine.java
Changes: https://git.openjdk.org/jdk
On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov wrote:
>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
>> synchronized.
>>
>> Without synchronization, a thread checks if `filesLoader` is not null and
>> creates a new `FilesLoader` thread. If the thread is pre-empted betw
On Tue, 5 Mar 2024 11:04:30 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java
>> line 101:
>>
>>> 99: */
>>> 100: public synchronized void invalidateFileCache() {
>>> 101: if (filesLoader != null) {
>>
>> This is a publ
On Mon, 4 Mar 2024 15:52:45 GMT, Alexey Ivanov wrote:
> I'm adding a regression test for
> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a
> regression test for
> [JDK-8240690](https://bugs.openjdk.org/br
On Thu, 7 Mar 2024 12:36:05 GMT, Dmitry Markov wrote:
>> Updated several tests to avoid potential failure with recent LCMS update and
>> non-LCMS generated profile.
>
> Dmitry Markov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Toleranc
On Thu, 7 Mar 2024 12:32:09 GMT, Dmitry Markov wrote:
>> Actually the purpose of these particular tests is validation of the quality
>> of the built-in color profiles.
>
> I agree, I reverted almost all changes except the ones in tolerance for
> non-LCMS profiles. That values need to be updated
On Tue, 5 Mar 2024 00:58:42 GMT, Sergey Bylokhov wrote:
>> Updated several tests to avoid potential failure with recent LCMS update and
>> non-LCMS generated profile.
>
> test/jdk/sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java line 63:
>
>> 61:
On Sun, 3 Mar 2024 09:01:49 GMT, Dmitry Markov wrote:
> Updated several tests to avoid potential failure with recent LCMS update and
> non-LCMS generated profile.
test/jdk/sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java line 63:
> 61: 10.5, // GRAY
> 62: 215.0, //
On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov wrote:
> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
> synchronized.
>
> Without synchronization, a thread checks if `filesLoader` is not null and
> creates a new `FilesLoader` thread. If the thread is pre-empted between t
On Wed, 21 Feb 2024 04:27:13 GMT, Tejesh R wrote:
>> That code was added by me to implement the shaped windows on macOS, that is
>> the only platform we support the translucent backbuffer in RepaintManager.
>> For the translucent backbuffer and even opaque component it is necessary to
>> clear
On Wed, 21 Feb 2024 01:23:34 GMT, Phil Race wrote:
> Embedded frames are for applets (dead) and JAWT and SWT. I don't see how any
> of those could use this.
yeah, I meant jawt, not eawt. SWT used some of the code directly from the
native code, so they bypassed private access and modules. Might
On Tue, 20 Feb 2024 22:46:58 GMT, Phil Race wrote:
>Anyone have ANY idea where or how this might be used ? I'd like to be sure
>before I propose that.
When the eawt was enhanced to support embedded frames all related
non-public/internal code was not deleted - it was found that people used that
On Tue, 20 Feb 2024 05:36:55 GMT, Tejesh R wrote:
>> Since this is an intermediate buffer its content should not affect the
>> rendering, so it should contain only the image rendered by the component
>> itself.
>
> This how it is done in
> [RepaintManager](https://github.com/openjdk/jdk/blob/
On Tue, 20 Feb 2024 05:17:04 GMT, Sergey Bylokhov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Frame dispose moved into EDT
>
> src/java.desktop/share/classes/javax/swing/BufferStrateg
On Mon, 12 Feb 2024 05:38:17 GMT, Tejesh R wrote:
>> This is happening in linux where `BuffereStrategyPaintManager` is used to
>> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
>> to offscreen where the background is not refreshed, which does only clipping
>> and
On Mon, 12 Feb 2024 05:38:17 GMT, Tejesh R wrote:
>> This is happening in linux where `BuffereStrategyPaintManager` is used to
>> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
>> to offscreen where the background is not refreshed, which does only clipping
>> and
On Wed, 14 Feb 2024 18:09:15 GMT, Per Minborg wrote:
>> This PR proposes to remove the use of `Unsafe` in the class
>> `XEmbeddingContainer ` and replace it with the supported FFM API.
>>
>> I tried to make this PR as small as possible while opening up for migration
>> of other classes later o
On Tue, 6 Feb 2024 08:09:20 GMT, Tejesh R wrote:
>> Since the fix was done for linux alone, I have restricted the test to it.
>> Anyhow it works on windows and mac.
>
> Somehow the automated test is not working flawless in windows and mac. In
> windows the image is getting stuck at center of wh
On Sat, 3 Feb 2024 12:31:16 GMT, Jiří Vaněk wrote:
> added workarounds so freshly built jdk can set its necessary source/taret
> without touching ant/makefile. In addition it can set itself as
> compiler/runner without putting itself on path.
Marked as reviewed by serb (Reviewer).
---
On Sat, 13 Jan 2024 20:17:06 GMT, Jiří Vaněk wrote:
>Also, I'm not saying to bump source/target to something drastic like 20 or so,
>I originally prosed 8 - which is the oldest live openjdk anyway. However
>(unless something unexpected comes form
>https://bugs.openjdk.org/browse/JDK-8323169) w
On Thu, 15 Feb 2024 01:11:51 GMT, Alexander Zvegintsev
wrote:
> There is an issue displaying the xembed icons in the appIndicators area which
> are not displayed correctly with certain Gnome Shell versions.
> It was already fixed
> [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/comm
On Tue, 6 Feb 2024 03:10:36 GMT, Sergey Bylokhov wrote:
> The ClipShapeTest test is split into 4 different tests which could be
> executed in parallel.
>
> The execution time is changed from:
>
>
> ==
> Test summary
> =
On Mon, 22 Jan 2024 18:10:27 GMT, Alexey Ivanov wrote:
>Is this bug similar to
>[JDK-8032219](https://bugs.openjdk.org/browse/JDK-8032219)?
That bug was caused by mixing the vector-based API(lines) and
rasters(fillRect). At that time we rendered the line outside of the component's
bounds, and
On Thu, 8 Feb 2024 20:28:06 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>> al
On Tue, 6 Feb 2024 05:43:26 GMT, Abhishek Kumar wrote:
> JTabbedPane's content area, tab area and tab background color are not as
> expected when opaque is set to true or false.
> The proposed fix is to handle the TabbedPane's background color in installed
> LAFs. Manual test is added to suppo
On Tue, 6 Feb 2024 20:13:01 GMT, Alexander Zuev wrote:
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
> overflow.
src/java.desktop/share/classes/javax/swing/JTabbedPane.java line 2340:
> 2338:
> 2339: public Point getLocationOnScreen() {
> 2340:
1 - 100 of 962 matches
Mail list logo
