On Thu, 30 Nov 2023 17:44:46 GMT, Alexey Ivanov wrote:
>> You don't call `parent.getWidth()` here, you always call `this.getWidth()`.
>>
>> I don't know why `JTableHeader` has special handling for it… Yet in the case
>> of `JTableHeader` it may be reasonable: the header follows the table width
On Thu, 30 Nov 2023 17:44:11 GMT, Alexey Ivanov wrote:
>> I actually reused it from `JTableHeader` class and yeah it will be
>> `parent.getWidth ` always as of now, but I thought it might be for future
>> purpose, but not sure... Should we retain or just use `parent.getWidth`
>> directly?
>
>
On Thu, 30 Nov 2023 17:03:00 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/JTable.java line 9809:
>>
>>> 9807: }
>>> 9808: return super.getWidth();
>>> 9809: }
>>
>> Can you elaborate on why it's needed? Presumably both versions return the
>> same width
On Thu, 30 Nov 2023 12:37:37 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 9809:
>
>> 9807: }
>> 9808: re
On Thu, 30 Nov 2023 10:52:18 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 3013:
>
>> 3011: }
>> 3012:
On Thu, 30 Nov 2023 10:03:47 GMT, Tejesh R wrote:
>> Table contents does not follow right-left Orientation when Max width of
>> columns are set. This is due to not considering the offset in `x position`
>> while painting table grid and table cell. The fix handles the offset and
>> adjust the x
> Table contents does not follow right-left Orientation when Max width of
> columns are set. This is due to not considering the offset in `x position`
> while painting table grid and table cell. The fix handles the offset and
> adjust the x position for each paint, similar to how header is paint
