Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v7]

2023-02-14 Thread Sergey Bylokhov
On Mon, 13 Feb 2023 09:19:05 GMT, Prasanta Sadhukhan wrote: >> Issue is observed that after changing the Look & Feel from Metal to Nimbus >> and back to Metal, the Nimbus font continues to be used by a JFileChooser. >> This is because Synth `installDefaults `methods set the font, but its >> i

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v6]

2023-02-14 Thread Alexey Ivanov
On Mon, 13 Feb 2023 09:19:23 GMT, Prasanta Sadhukhan wrote: > ok..modified but I guess mine was not "incorrect" either.. No, it was not wrong. I believe this way is clearer though: if `curFont == origFont`, `equals` is bound to return `true`, so you can just avoid calling `equals` twice and m

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v7]

2023-02-14 Thread Alexey Ivanov
On Mon, 13 Feb 2023 09:19:05 GMT, Prasanta Sadhukhan wrote: >> Issue is observed that after changing the Look & Feel from Metal to Nimbus >> and back to Metal, the Nimbus font continues to be used by a JFileChooser. >> This is because Synth `installDefaults `methods set the font, but its >> i

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v6]

2023-02-13 Thread Prasanta Sadhukhan
On Fri, 10 Feb 2023 17:08:34 GMT, Alexey Ivanov wrote: >> I dont think it's redundant..There's a || check in between >> >> If `curFont `is not null and `origFont `is null, then 1st condition `curFont >> != null && !curFont.equals(origFont)` is satisfied and it will throw >> exception >> >> If

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v7]

2023-02-13 Thread Prasanta Sadhukhan
> Issue is observed that after changing the Look & Feel from Metal to Nimbus > and back to Metal, the Nimbus font continues to be used by a JFileChooser. > This is because Synth `installDefaults `methods set the font, but its > inverse methods `uninstallDefaults `do not remove them. > Fix is mad

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v6]

2023-02-10 Thread Alexey Ivanov
On Fri, 10 Feb 2023 16:58:02 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 70: >> >>> 68: System.out.println("current font " + curFont); >>> 69: if ((curFont != null && !curFont.equals(origFont)) >>>

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v6]

2023-02-10 Thread Prasanta Sadhukhan
On Fri, 10 Feb 2023 16:08:56 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add both null check > > test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 70: > >> 68:

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v6]

2023-02-10 Thread Alexey Ivanov
On Fri, 10 Feb 2023 16:00:56 GMT, Prasanta Sadhukhan wrote: >> Issue is observed that after changing the Look & Feel from Metal to Nimbus >> and back to Metal, the Nimbus font continues to be used by a JFileChooser. >> This is because Synth `installDefaults `methods set the font, but its >> i

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v6]

2023-02-10 Thread Prasanta Sadhukhan
> Issue is observed that after changing the Look & Feel from Metal to Nimbus > and back to Metal, the Nimbus font continues to be used by a JFileChooser. > This is because Synth `installDefaults `methods set the font, but its > inverse methods `uninstallDefaults `do not remove them. > Fix is mad

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v5]

2023-02-10 Thread Alexey Ivanov
On Fri, 10 Feb 2023 11:44:35 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 69: >> >>> 67: Font curFont = fc.getFont(); >>> 68: System.out.println("current font " + curFont); >>> 69:

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v5]

2023-02-10 Thread Prasanta Sadhukhan
On Thu, 9 Feb 2023 20:45:58 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update test > > test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 69: > >> 67:

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v5]

2023-02-09 Thread Alexey Ivanov
On Thu, 9 Feb 2023 02:59:11 GMT, Prasanta Sadhukhan wrote: >> Issue is observed that after changing the Look & Feel from Metal to Nimbus >> and back to Metal, the Nimbus font continues to be used by a JFileChooser. >> This is because Synth `installDefaults `methods set the font, but its >> in

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v4]

2023-02-08 Thread Prasanta Sadhukhan
On Wed, 8 Feb 2023 11:44:28 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> jcheck fix > > test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 53: > >> 51: SwingU

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v5]

2023-02-08 Thread Prasanta Sadhukhan
> Issue is observed that after changing the Look & Feel from Metal to Nimbus > and back to Metal, the Nimbus font continues to be used by a JFileChooser. > This is because Synth `installDefaults `methods set the font, but its > inverse methods `uninstallDefaults `do not remove them. > Fix is mad

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v4]

2023-02-08 Thread Alexey Ivanov
On Wed, 8 Feb 2023 05:36:55 GMT, Prasanta Sadhukhan wrote: >> Issue is observed that after changing the Look & Feel from Metal to Nimbus >> and back to Metal, the Nimbus font continues to be used by a JFileChooser. >> This is because Synth `installDefaults `methods set the font, but its >> in

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v4]

2023-02-08 Thread Alexey Ivanov
On Wed, 8 Feb 2023 05:36:55 GMT, Prasanta Sadhukhan wrote: >> Issue is observed that after changing the Look & Feel from Metal to Nimbus >> and back to Metal, the Nimbus font continues to be used by a JFileChooser. >> This is because Synth `installDefaults `methods set the font, but its >> in

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v4]

2023-02-08 Thread Alexey Ivanov
On Wed, 8 Feb 2023 05:36:55 GMT, Prasanta Sadhukhan wrote: >> Issue is observed that after changing the Look & Feel from Metal to Nimbus >> and back to Metal, the Nimbus font continues to be used by a JFileChooser. >> This is because Synth `installDefaults `methods set the font, but its >> in

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v4]

2023-02-07 Thread Prasanta Sadhukhan
> Issue is observed that after changing the Look & Feel from Metal to Nimbus > and back to Metal, the Nimbus font continues to be used by a JFileChooser. > This is because Synth `installDefaults `methods set the font, but its > inverse methods `uninstallDefaults `do not remove them. > Fix is mad

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v3]

2023-02-07 Thread Sergey Bylokhov
On Mon, 6 Feb 2023 08:46:24 GMT, Prasanta Sadhukhan wrote: >> Issue is observed that after changing the Look & Feel from Metal to Nimbus >> and back to Metal, the Nimbus font continues to be used by a JFileChooser. >> This is because Synth `installDefaults `methods set the font, but its >> in

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v2]

2023-02-06 Thread Prasanta Sadhukhan
On Sun, 5 Feb 2023 03:59:57 GMT, Sergey Bylokhov wrote: >> It tests for Nimbus as the fix is for that only. >> It tests transition from >> Metal/Motif/Windows/WIndowsClassis->Nimbus->Metal/Motif/Windows/WindowsClassis >> for windows platform, say. >> We can enhance the test to test other L&F u

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v3]

2023-02-06 Thread Prasanta Sadhukhan
> Issue is observed that after changing the Look & Feel from Metal to Nimbus > and back to Metal, the Nimbus font continues to be used by a JFileChooser. > This is because Synth `installDefaults `methods set the font, but its > inverse methods `uninstallDefaults `do not remove them. > Fix is mad

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v2]

2023-02-04 Thread Sergey Bylokhov
On Fri, 3 Feb 2023 04:26:39 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 58: >> >>> 56: SwingUtilities.updateComponentTreeUI(fc); >>> 57: System.out.println("Nimbus font " + fc.getFont()); >>> 58: SwingUt

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v2]

2023-02-02 Thread Prasanta Sadhukhan
On Thu, 2 Feb 2023 20:40:24 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Iterate all installed L&F > > test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 58: > >> 56:

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v2]

2023-02-02 Thread Sergey Bylokhov
On Fri, 27 Jan 2023 04:25:48 GMT, Prasanta Sadhukhan wrote: >> Issue is observed that after changing the Look & Feel from Metal to Nimbus >> and back to Metal, the Nimbus font continues to be used by a JFileChooser. >> This is because Synth `installDefaults `methods set the font, but its >> i

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v2]

2023-01-27 Thread Abhishek Kumar
On Fri, 27 Jan 2023 04:25:48 GMT, Prasanta Sadhukhan wrote: >> Issue is observed that after changing the Look & Feel from Metal to Nimbus >> and back to Metal, the Nimbus font continues to be used by a JFileChooser. >> This is because Synth `installDefaults `methods set the font, but its >> i

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v2]

2023-01-26 Thread Prasanta Sadhukhan
> Issue is observed that after changing the Look & Feel from Metal to Nimbus > and back to Metal, the Nimbus font continues to be used by a JFileChooser. > This is because Synth `installDefaults `methods set the font, but its > inverse methods `uninstallDefaults `do not remove them. > Fix is mad

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change

2023-01-25 Thread Sergey Bylokhov
On Wed, 25 Jan 2023 06:45:53 GMT, Prasanta Sadhukhan wrote: > Issue is observed that after changing the Look & Feel from Metal to Nimbus > and back to Metal, the Nimbus font continues to be used by a JFileChooser. > This is because Synth `installDefaults `methods set the font, but its > inver

RFR: 6753661: JFileChooser font not reset after Look & Feel change

2023-01-24 Thread Prasanta Sadhukhan
Issue is observed that after changing the Look & Feel from Metal to Nimbus and back to Metal, the Nimbus font continues to be used by a JFileChooser. This is because Synth `installDefaults `methods set the font, but its inverse methods `uninstallDefaults `do not remove them. Fix is made to reset