On Thu, 20 Jun 2024 20:55:11 GMT, Phil Race wrote:
>> Infact `isMnemonicHidden` can also be changed to a `protected` member of the
>> class. I will check and update.
>
> protected members of public classes are part of the API
> Go look at javadoc - or generate javadoc for this change and see
On Tue, 18 Jun 2024 13:15:00 GMT, Abhishek Kumar wrote:
>>> Hmm. So .. new public API ? Is this absolutely necessary ?
>> I don't see why an app would need to call this directly.
>>
>> `setMnemonicHidden` can be changed to a `protected` member as you pointed
>> out it may not be required by an
On Fri, 14 Jun 2024 20:21:16 GMT, Phil Race wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition update
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
> line 780:
>
>>
On Tue, 18 Jun 2024 16:28:50 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition update
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthRootPaneUI.java
> line 115:
>
>>
On Tue, 18 Jun 2024 16:41:12 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition update
>
> test/jdk/com/sun/java/swing/plaf/gtk/TestMenuMnemonicOnAltPress.java line 44:
>
>> 42: import
On Tue, 18 Jun 2024 16:26:49 GMT, Alexey Ivanov wrote:
> Can we use or even re-use the logic in Windows L to display and hide menu
> mnemonics?
For windows behavior is different than linux.
https://github.com/openjdk/jdk/pull/18992#issuecomment-2100033545
I don't think that the logic in
On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Tue, 18 Jun 2024 12:50:42 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java
>> line 1056:
>>
>>> 1054: * @param hide true if mnemonics should be hidden
>>> 1055: * @since 23
>>> 1056: */
>>
>> Hmm. So .. new public API
On Tue, 18 Jun 2024 12:51:34 GMT, Abhishek Kumar wrote:
>> since this method should be recursing through all of a component's
>> subcomponents, shouldn't there not even be an if check here?
>
>> JComponent extends Container .. so this will traverse everything in the
>> Swing UI.
> Is there any
On Fri, 14 Jun 2024 20:28:11 GMT, Phil Race wrote:
> Hmm. So .. new public API ? Is this absolutely necessary ?
I don't see why an app would need to call this directly.
`setMnemonicHidden` can be changed to a `protected` member as you pointed out
it may not be required by an app to call this
On Sat, 15 Jun 2024 00:23:07 GMT, Alisen Chung wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
>> line 785:
>>
>>> 783: }
>>> 784:
>>> 785: if (c instanceof Container) {
>>
>> JComponent extends Container .. so this will
On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Fri, 14 Jun 2024 20:22:42 GMT, Phil Race wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition update
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
> line 785:
>
>>
On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
> In GTK LAF, the menu mnemonics are always displayed which is different from
> the native behavior. In native application **(tested with gedit**), the menu
> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
> and then toggles between show/hide on `ALT` press.
>
17 matches
Mail list logo
