On Mon, 24 Jul 2023 00:38:52 GMT, Sergey Bylokhov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added test cases, fixed spacing
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line
> 98
On Fri, 23 Jun 2023 20:24:21 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
On Fri, 23 Jun 2023 20:24:21 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
On Wed, 14 Jun 2023 20:35:14 GMT, Alisen Chung wrote:
>> I don't like the idea of a delay in either of the ways discussed here.
>> And although I do think that its much better to wait for delivery of an
>> event, I'm not sure I understand the windowState listener proposal.
>> How do you know in
On Fri, 23 Jun 2023 20:24:21 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
On Fri, 23 Jun 2023 20:24:21 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
added test cases, fixed spacing
-
On Fri, 23 Jun 2023 17:57:16 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
added suggested changes
-
Changes
On Wed, 21 Jun 2023 16:12:46 GMT, Harshitha Onkar wrote:
>> test/jdk/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java line
>> 48:
>>
>>> 46: public class MaximizedToIconified
>>> 47: {
>>> 48: static volatile int lastFrameState;
>>
>> What is the purpose of test change? Can yo
On Wed, 21 Jun 2023 08:26:12 GMT, Dmitry Markov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated test lastFrameState variable
>
> test/jdk/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java line
On Tue, 20 Jun 2023 20:08:20 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
updated test lastFrameState variable
-
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
wait for window state change
-
Ch
On Wed, 14 Jun 2023 20:09:45 GMT, Phil Race wrote:
> I don't like the idea of a delay in either of the ways discussed here. And
> although I do think that its much better to wait for delivery of an event,
> I'm not sure I understand the windowState listener proposal. How do you know
> in this
On Wed, 14 Jun 2023 20:09:45 GMT, Phil Race wrote:
> I don't like the idea of a delay in either of the ways discussed here. And
> although I do think that its much better to wait for delivery of an event,
> I'm not sure I understand the windowState listener proposal. How do you know
> in this
On Mon, 12 Jun 2023 22:29:25 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
On Mon, 12 Jun 2023 22:29:25 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
On Mon, 12 Jun 2023 22:29:25 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
use realsync to flush native queue
---
On Wed, 7 Jun 2023 20:13:55 GMT, Alisen Chung wrote:
>> If I got it right the switching to `ICONIFIED`/`MAXIMIZED_BOTH` state takes
>> more time on macOS 13 than on previous macOS version. So the test failure is
>> triggered by the lack of synchronisation.
>> When you added displayChanged() cal
On Tue, 30 May 2023 18:41:38 GMT, Alisen Chung wrote:
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
Also noticed this comment in setWindowState() of [CPlatformWindow.java#L1011
](https://github.com/open
On Wed, 7 Jun 2023 20:13:55 GMT, Alisen Chung wrote:
>> If I got it right the switching to `ICONIFIED`/`MAXIMIZED_BOTH` state takes
>> more time on macOS 13 than on previous macOS version. So the test failure is
>> triggered by the lack of synchronisation.
>> When you added displayChanged() cal
On Tue, 30 May 2023 18:41:38 GMT, Alisen Chung wrote:
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
Possibly some synchronization is needed in the jdk, it needs to be checked why
the message is not post
On Fri, 2 Jun 2023 12:50:31 GMT, Dmitry Markov wrote:
> If I got it right the switching to `ICONIFIED`/`MAXIMIZED_BOTH` state takes
> more time on macOS 13 than on previous macOS version. So the test failure is
> triggered by the lack of synchronisation. When you added displayChanged()
> call
On Tue, 30 May 2023 21:21:20 GMT, Sergey Bylokhov wrote:
> Why this method is not called automatically by our native code? what events
> are changed since macOS 13.0?
@mrserb There might be a new window state in macOS 13 due to a the new [Stage
Manager](https://support.apple.com/en-us/HT213315
On Tue, 30 May 2023 18:41:38 GMT, Alisen Chung wrote:
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
If I got it right the switching to `ICONIFIED`/`MAXIMIZED_BOTH` state takes
more time on macOS 13 than
On Tue, 30 May 2023 21:25:36 GMT, Sergey Bylokhov wrote:
> BTW it is unclear what the call to "displayChanged" will fix. Will it set the
> correct "graphicsDevice", if yes then what gD was used before the call, if
> not then what property is updated by the "displayChanged"?
I think the problem
On Thu, 1 Jun 2023 20:24:21 GMT, Alisen Chung wrote:
>> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line
>> 997:
>>
>>> 995: // let's return into the normal states first
>>> 996: execute(CWrapper.NSWindow::deminiaturize);
>>> 997
On Tue, 30 May 2023 20:31:55 GMT, Dmitry Markov wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line
> 997:
>
>> 995:
On Tue, 30 May 2023 18:41:38 GMT, Alisen Chung wrote:
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
BTW it is unclear what the call to "displayChanged" will fix. Will it set the
correct "graphicsDevice"
On Tue, 30 May 2023 18:41:38 GMT, Alisen Chung wrote:
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
Why this method is not called automatically by our native code? what events are
changed since macOS 13
On Tue, 30 May 2023 18:41:38 GMT, Alisen Chung wrote:
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
Changes requested by dmarkov (Reviewer).
src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWin
added displayChanged call to CPlatformWindow when frame first needs to
deiconify or unmaximize
All client tests passed after change
-
Commit messages:
- removed from problemlist
- init commit
Changes: https://git.openjdk.org/jdk/pull/14226/files
Webrev: https://webrevs.openjdk.or
34 matches
Mail list logo
