Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-27 Thread Alexey Ivanov
On Mon, 25 Sep 2023 15:45:59 GMT, Alexey Ivanov wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > test/jdk/java/awt/Frame/DefaultSizeTest.java line 42: > >> 40: and should be

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-27 Thread Alexey Ivanov
On Tue, 26 Sep 2023 14:43:13 GMT, Alexey Ivanov wrote: >> I think it's fine the way it is now. Just in case the user sees some unusual >> failure. > > Well, yes… I haven't thought about it. Anyway I submitted [JDK-8317111](https://bugs.openjdk.org/browse/JDK-8317111): Provide access to Pass/Fa

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-27 Thread Alexey Ivanov
On Tue, 26 Sep 2023 14:46:39 GMT, Alexey Ivanov wrote: >> I have already tried this using keyboard shortcuts. >> >> Alt+F4 works fine on Window and Linux (many popular DEs close windows by >> Alt+F4 by default, e.g. Gnome shell, Plasma). >> >> For macos we don't have a system handler for Cmd +

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-26 Thread Alexey Ivanov
On Mon, 25 Sep 2023 20:19:17 GMT, Alexander Zvegintsev wrote: > But this will probably be a task for one of the next test sprints. Absolutely, it's too many changes. Yet it may make the test easier. In fact, I thought about iterating the values automatically … and ask the tester to click the

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-26 Thread Alexey Ivanov
On Mon, 25 Sep 2023 20:23:27 GMT, Alexander Zvegintsev wrote: >> test/jdk/javax/swing/JFrame/DefaultCloseOperation.java line 78: >> >>> 76: - Select "Dispose" from the "JDialog Default Close Operation" >>> ComboBox >>> 77: - On the TestDialog, select "Close" from the system

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-25 Thread Alexander Zvegintsev
On Mon, 25 Sep 2023 16:43:57 GMT, Alexey Ivanov wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > test/jdk/javax/swing/JFrame/DefaultCloseOperation.java line 1: > >> 1: /* > > I wonder i

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-25 Thread Alexey Ivanov
On Fri, 22 Sep 2023 15:43:18 GMT, Alexander Zvegintsev wrote: >> Open sourcing several manual applet tests >> >> >> test/jdk/java/awt/Frame/DefaultSizeTest.java >> test/jdk/java/awt/LightweightComponent/LightweightCliprect.java >> test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java >> test/j

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-22 Thread Alexander Zvegintsev
> Open sourcing several manual applet tests > > > test/jdk/java/awt/Frame/DefaultSizeTest.java > test/jdk/java/awt/LightweightComponent/LightweightCliprect.java > test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java > test/jdk/javax/swing/JFrame/DefaultCloseOperation.java Alexander Zvegintsev h