On Thu, 14 Mar 2024 09:59:43 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JEditorPane/bug4325606.java line 100:
>>
>>> 98: Utilities.getRowStart(pane, pane.getCaretPosition());
>>> 99: } catch (BadLocationException blex) {
>>> 100: throw new Runti
On Thu, 14 Mar 2024 09:25:29 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update test/jdk/javax/swing/JDesktopPane/bug4773378.java
>>
>> Co-authored-by: Alexey Ivanov
>
> test/jdk/java
On Wed, 13 Mar 2024 20:51:18 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JEditorPane/bug4694598.java line 74:
>>
>>> 72: String html = " " +
>>> 73: "" +
>>> 74: "" +
>>
>> Suggestion:
>>
>> "" +
>>
>> Isn't it enough? Alternative
On Wed, 13 Mar 2024 20:49:19 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JEditorPane/bug4694598.java line 64:
>>
>>> 62: } catch (IOException ioe){
>>> 63: throw new RuntimeException("Could not create html file to
>>> embed", ioe);
>>> 64: }
>>
>> Move creati
On Wed, 13 Mar 2024 19:57:08 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JEditorPane/bug4325606.java line 84:
>>
>>> 82: robo.setAutoDelay(100);
>>> 83: robo.delay(1000);
>>> 84: Point p = frame.getLocationOnScreen();
>>
>> Technically, `getLocationOnS
On Thu, 14 Mar 2024 01:15:45 GMT, Alexander Zuev wrote:
>> Cleaned up five more tests.
>>
>> Continuation of https://github.com/openjdk/jdk/pull/18184
>>
>> Unfortunately one of the commits rendered the whole PR invalid so i closed
>> it and restarting it here.
>> All comments from the previou
On Wed, 13 Mar 2024 16:26:38 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update test/jdk/javax/swing/JDesktopPane/bug4773378.java
>>
>> Co-authored-by: Alexey Ivanov
>
> test/jdk/java
On Wed, 13 Mar 2024 19:40:16 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JDesktopPane/bug4773378.java line 99:
>>
>>> 97: bug4773378.this.wait();
>>> 98: }
>>> 99: }
>>
>> Suggestion:
>>
>> frameActivated.await();
>>
>>
>> Using `CountDownLa
> Cleaned up five more tests.
>
> Continuation of https://github.com/openjdk/jdk/pull/18184
>
> Unfortunately one of the commits rendered the whole PR invalid so i closed it
> and restarting it here.
> All comments from the previous review are addressed.
Alexander Zuev has updated the pull requ
On Wed, 13 Mar 2024 00:49:15 GMT, Alexander Zuev wrote:
>> I'm also a bit surprised I don't see all the rest of the original html &
>> java files anywhere now, not as deleted, not as changed.
>
> There's something wrong with the latest commit. Looking at it now.
Ok, either github or skara got m
On Tue, 12 Mar 2024 23:04:17 GMT, Phil Race wrote:
>> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html line 1:
>>
>>> 1:
>>
>> Looks like you forgot to remove this file ?
>
> I'm also a bit surprised I don't see all the rest of the original html & java
> files anywhere now, not as d
On Tue, 12 Mar 2024 22:57:45 GMT, Phil Race wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor changes based on the review.
>> Tests moved to the components folders.
>
> test/jdk/javax/swing/JEditorPane/4694
On Tue, 12 Mar 2024 22:33:51 GMT, Alexander Zuev wrote:
>> Clean up five more tests.
>>
>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
>> test/jdk/javax/swing/JE
> Clean up five more tests.
>
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
> test/jdk/javax/swing/JEditor
On Tue, 12 Mar 2024 20:04:52 GMT, Phil Race wrote:
>> No harm but a dependency on a library which isn't used.
>
> I am very much against including libraries that aren't needed.
> If this test isn't using any JRobot functionality, please remove it.
Ok, removed.
-
PR Review Comment:
15 matches
Mail list logo
