Re: RFR: 8317696: Fix compilation with clang-16 [v3]

2023-10-11 Thread Jan Kratochvil
On Tue, 10 Oct 2023 20:37:07 GMT, Phil Race wrote: >> src/java.desktop/unix/native/common/awt/awt_GraphicsEnv.h line 53: >> >>> 51: #define MITSHM_PERM_OWNER (0600) >>> 52: >>> 53: extern int XShmQueryExtension(Display* dpy); >> >> I wonder if it's even needed here: the declaration should

Re: RFR: 8317696: Fix compilation with clang-16 [v3]

2023-10-10 Thread Phil Race
On Mon, 9 Oct 2023 18:29:26 GMT, Alexey Ivanov wrote: >> Jan Kratochvil has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove declaration changes which are not required >>- suggested by djelinski > >

Re: RFR: 8317696: Fix compilation with clang-16 [v3]

2023-10-09 Thread Daniel Jeliński
On Mon, 9 Oct 2023 15:01:41 GMT, Jan Kratochvil wrote: >> `--with-toolchain-type=clang` fails the compilation for me with >> `clang-16.0.6-3.fc38.x86_64` >> >> While the warnings can be disabled I find better to just fix them. The GTK >> prototypes in JDK reported by clang are either missing

Re: RFR: 8317696: Fix compilation with clang-16 [v3]

2023-10-09 Thread Alexey Ivanov
On Mon, 9 Oct 2023 15:01:41 GMT, Jan Kratochvil wrote: >> `--with-toolchain-type=clang` fails the compilation for me with >> `clang-16.0.6-3.fc38.x86_64` >> >> While the warnings can be disabled I find better to just fix them. The GTK >> prototypes in JDK reported by clang are either missing

Re: RFR: 8317696: Fix compilation with clang-16 [v3]

2023-10-09 Thread Jan Kratochvil
On Mon, 9 Oct 2023 14:38:27 GMT, Daniel Jeliński wrote: >> Jan Kratochvil has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove declaration changes which are not required >>- suggested by djelinski > >

Re: RFR: 8317696: Fix compilation with clang-16 [v3]

2023-10-09 Thread Jan Kratochvil
> `--with-toolchain-type=clang` fails the compilation for me with > `clang-16.0.6-3.fc38.x86_64` > > While the warnings can be disabled I find better to just fix them. The GTK > prototypes in JDK reported by clang are either missing or wrong. > > >