On Tue, 23 Apr 2024 05:02:53 GMT, Tejesh R wrote:
> > Do you mind if I shorten the subject of the bug? _Printing JTable throws
> > InternalError: HTHEME is null_?
>
> Sure, it's better to shorten it. And since its only for windows L, it can
> be mentioned in subject I guess.
I've updated the
On Tue, 23 Apr 2024 10:23:33 GMT, Tejesh R wrote:
>> I didn't get the need for helper method?
>
> Ok, I got it. And I have updated. But if we want to change `theme` to `long`,
> then I guess we have to do it every calling function I guess. So is it better
> to leave it as `Long` ?
I still
On Tue, 23 Apr 2024 10:31:02 GMT, Alexey Ivanov wrote:
>> Ok, I got it. And I have updated. But if we want to change `theme` to
>> `long`, then I guess we have to do it every calling function I guess. So is
>> it better to leave it as `Long` ?
>
> I still think we should change `Long` to
On Tue, 23 Apr 2024 07:11:30 GMT, Tejesh R wrote:
>> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 117:
>>
>>> 115:if (theme == null || theme == 0) {
>>> 116:theme = openTheme(widget, defaultDPI);
>>> 117:}
>>
>> `theme` can't be `null`
On Mon, 22 Apr 2024 15:09:37 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved failure handling inside openThemeImpl method
>
> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java
On Mon, 22 Apr 2024 15:14:41 GMT, Alexey Ivanov wrote:
> Do you mind if I shorten the subject of the bug? _Printing JTable throws
> InternalError: HTHEME is null_?
Sure, it's better to shorten it.
-
PR Comment: https://git.openjdk.org/jdk/pull/18706#issuecomment-2071413388
On Mon, 22 Apr 2024 07:03:54 GMT, Tejesh R wrote:
>> Yes, `openTheme()` actually returns 0. Hence I used `null` && `0` checker.
>
> Moved the failure handling to `openThemeImpl()`.
> Yes, `openTheme()` actually returns 0. …
This is why it can't be `null`.
-
PR Review Comment:
On Mon, 22 Apr 2024 07:08:00 GMT, Tejesh R wrote:
>> Getting a theme for particular dpi failed in windows L during print test.
>> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
>> was independent of DPI. After the fix
>>
On Mon, 22 Apr 2024 07:08:00 GMT, Tejesh R wrote:
>> Getting a theme for particular dpi failed in windows L during print test.
>> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
>> was independent of DPI. After the fix
>>
On Mon, 22 Apr 2024 07:00:52 GMT, Tejesh R wrote:
>> I agree. The current approach calls `openThemeImpl` three times: once or
>> twice with the passed `dpi` and then once with `defaultDPI` as the fallback.
>> Moreover, it *leaks theme handles* if `openThemeImpl` returns non-zero value
>> and
On Fri, 19 Apr 2024 19:46:01 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 120:
>>
>>> 118: // this should be called only with writeLock held
>>> 119: private static Long getThemeImpl(String widget, int dpi) {
>>> 120: if
> Getting a theme for particular dpi failed in windows L during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjdk/jdk/commit/a63afa4aa62863d1a199a0fb7d2f56ff8fcd04fd)
> getting a
12 matches
Mail list logo
