On Thu, 15 Feb 2024 20:12:08 GMT, Alexander Zvegintsev
wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [5a988a50](https://github.com/openjdk/jdk/commit/5a988a5087d0afbb577c6715fd5e1e44564888cb)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The c
Hi all,
This pull request contains a backport of commit
[5a988a50](https://github.com/openjdk/jdk/commit/5a988a5087d0afbb577c6715fd5e1e44564888cb)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Alexander Zvegintsev on 15 Feb 2024
and
On Thu, 15 Feb 2024 12:51:15 GMT, Alexander Zvegintsev
wrote:
>> There is an issue displaying the xembed icons in the appIndicators area
>> which are not displayed correctly with certain Gnome Shell versions.
>> It was already fixed
>> [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/
On Thu, 15 Feb 2024 16:05:17 GMT, Alexander Zvegintsev
wrote:
>>> If we have Gnome Shell < 45:
>>> -> SystemTray is not supported(`isSupported` returns `false`)
>>
>> If isSupported returns false for version < 45, then why we need this code
>> because as I understand, if systemTray is unsuppor
On Thu, 15 Feb 2024 12:51:15 GMT, Alexander Zvegintsev
wrote:
>> There is an issue displaying the xembed icons in the appIndicators area
>> which are not displayed correctly with certain Gnome Shell versions.
>> It was already fixed
>> [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/
On Thu, 15 Feb 2024 15:51:18 GMT, Prasanta Sadhukhan
wrote:
>>> But here the question is about getTrayIconSize for "disabling system tray"
>>> [i.e. should we do
>> if (shouldDisableSystemTray) {
>> return;
>> }
>>> and as I understand we are disabling it even though it can
On Thu, 15 Feb 2024 14:45:21 GMT, Alexander Zvegintsev
wrote:
> If we have Gnome Shell < 45:
> -> SystemTray is not supported(`isSupported` returns `false`)
If isSupported returns false for version < 45, then why we need this code
because as I understand, if systemTray is unsupported, then sys
On Thu, 15 Feb 2024 13:00:31 GMT, Prasanta Sadhukhan
wrote:
> But here the question is about getTrayIconSize for "disabling system tray"
> [i.e. should we do
if (shouldDisableSystemTray) {
return;
}
> and as I understand we are disabling it even though it can be supported (i
On Thu, 15 Feb 2024 12:43:04 GMT, Alexander Zvegintsev
wrote:
>> src/java.desktop/unix/classes/sun/awt/X11/XSystemTrayPeer.java line 94:
>>
>>> 92: return;
>>> 93: }
>>> 94:
>>
>> What about `getTrayIconSize`? Should we allow to return
>> TRAY_ICON_HEIGHT/TRAY_ICON_WIDTH
> There is an issue displaying the xembed icons in the appIndicators area which
> are not displayed correctly with certain Gnome Shell versions.
> It was already fixed
> [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/commit/20a81d786697f40880e81d867453b1bad9524ec1).
>
> However this i
On Thu, 15 Feb 2024 09:04:58 GMT, Prasanta Sadhukhan
wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> IllegalThreadStateException
>
> src/java.desktop/unix/classes/sun/awt/UNIXToolkit.java line 307:
>
>> 3
On Thu, 15 Feb 2024 01:11:51 GMT, Alexander Zvegintsev
wrote:
> There is an issue displaying the xembed icons in the appIndicators area which
> are not displayed correctly with certain Gnome Shell versions.
> It was already fixed
> [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/comm
On Thu, 15 Feb 2024 01:11:51 GMT, Alexander Zvegintsev
wrote:
> There is an issue displaying the xembed icons in the appIndicators area which
> are not displayed correctly with certain Gnome Shell versions.
> It was already fixed
> [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/comm
On Thu, 15 Feb 2024 01:11:51 GMT, Alexander Zvegintsev
wrote:
> There is an issue displaying the xembed icons in the appIndicators area which
> are not displayed correctly with certain Gnome Shell versions.
> It was already fixed
> [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/comm
On Thu, 15 Feb 2024 03:29:39 GMT, Phil Race wrote:
>>> Latest comment from Phil related to not disabling SystemTray for Gnome>=45
>>> needs to be taken care.
>>
>> With the current version string format, this should not happen unless the
>> executable is somewhere else, environment variables a
On Thu, 15 Feb 2024 01:11:51 GMT, Alexander Zvegintsev
wrote:
> There is an issue displaying the xembed icons in the appIndicators area which
> are not displayed correctly with certain Gnome Shell versions.
> It was already fixed
> [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/comm
On Thu, 15 Feb 2024 03:26:54 GMT, Alexander Zvegintsev
wrote:
>> A fair question. My understanding of how Gnome vs Gnome Shell vs GTK version
>> naming interact here is definitely not as clear as I'd like but I understand
>> anything that is Gnome 3.X or 40+ (and < 44.1) is affected, leaving o
On Thu, 15 Feb 2024 03:13:05 GMT, Phil Race wrote:
>> Latest comment from Phil related to not disabling SystemTray for Gnome>=45
>> needs to be taken care.
>> Also do we need to worry about this issue being regression from some Gnome
>> version like 3.38.0 and we need to disable SystemTray only
On Thu, 15 Feb 2024 02:58:45 GMT, Jayathirth D V wrote:
>> And in fact we need to be VERY careful that we don't turn the existing code
>> reporting "available == false" into "true" due to us simply detecting Gnome
>> >= 45 .. that would be unfortunate.
>
> Latest comment from Phil related to no
On Thu, 15 Feb 2024 02:20:51 GMT, Phil Race wrote:
>> If we do that we could be up to 99.5% of cases aren't affected.
>
> And in fact we need to be VERY careful that we don't turn the existing code
> reporting "available == false" into "true" due to us simply detecting Gnome
> >= 45 .. that wou
On Thu, 15 Feb 2024 02:10:59 GMT, Phil Race wrote:
>>> (arm-waving alert) 99% of apps don't do it at all,
>>
>> That may not be so arm-wavy actually considering this has been a problem for
>> a while and we haven't exactly been inundated with complaints, especially
>> since on RH & (I think) F
On Thu, 15 Feb 2024 01:59:48 GMT, Phil Race wrote:
>> src/java.desktop/unix/classes/sun/awt/UNIXToolkit.java line 286:
>>
>>> 284: try {
>>> 285: Process process =
>>> 286: new ProcessBuilder("/usr/bin/gnome-shell", "--version")
>>
>> How it will affect perfo
On Thu, 15 Feb 2024 02:10:23 GMT, Phil Race wrote:
>> According to my tests, the call to `getGnomeShellMajorVersion()` took about
>> 25-35 ms on average, but it is a one-time task.
>
>> (arm-waving alert) 99% of apps don't do it at all,
>
> That may not be so arm-wavy actually considering this
On Thu, 15 Feb 2024 02:10:22 GMT, Alexander Zvegintsev
wrote:
>> Well, clearly the exec will take some non-zero time, but this part of
>> initialising the SystemTray only happens once and (arm-waving alert) 99% of
>> apps don't do it at all, so I don't see it as a major problem and it needs
>
On Thu, 15 Feb 2024 01:41:49 GMT, Sergey Bylokhov wrote:
>> There is an issue displaying the xembed icons in the appIndicators area
>> which are not displayed correctly with certain Gnome Shell versions.
>> It was already fixed
>> [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/commit
On Thu, 15 Feb 2024 01:11:51 GMT, Alexander Zvegintsev
wrote:
> There is an issue displaying the xembed icons in the appIndicators area which
> are not displayed correctly with certain Gnome Shell versions.
> It was already fixed
> [externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/comm
There is an issue displaying the xembed icons in the appIndicators area which
are not displayed correctly with certain Gnome Shell versions.
It was already fixed
[externally](https://gitlab.gnome.org/3v1n0/gnome-shell/-/commit/20a81d786697f40880e81d867453b1bad9524ec1).
However this is still a bl
27 matches
Mail list logo
