On Thu, 20 Jun 2024 20:03:20 GMT, Phil Race wrote:
>> All I wanted is to bring up the inconsistency so that a few people would
>> take a look at it while reviewing this change.
>
> It does look odd. Focus would need transferring in both cases I'd expect.
> It goes back to the very beginning of
On Fri, 21 Jun 2024 03:17:38 GMT, Prasanta Sadhukhan
wrote:
>> The way it was "before" is that we always returned the value of "doIt". Why
>> not restore that for consistency ?
>
> I believe that's what this PR is doing, it returns value of "doIt" at end,
> isn't it?
> The way it was
On Thu, 20 Jun 2024 20:04:47 GMT, Phil Race wrote:
>> The only problem with the flag is that the data flow is not as clear.
>>
>> I'm not insisting, it worked before and it will work in the future.
>
> The way it was "before" is that we always returned the value of "doIt". Why
> not restore
On Thu, 20 Jun 2024 10:39:48 GMT, Alexey Ivanov wrote:
>> Yes, it could have been done that way and my intiial fix in JBS is that only
>> but I wanted to reinstate the flag as it is before
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) which was working
>> till now..
>
> The
On Thu, 20 Jun 2024 03:39:47 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 694:
>>
>>> 692: ::GlobalUnlock(setup.hDevMode);
>>> 693: }
>>> 694: doIt = JNI_TRUE;
>>
>> Another option would be to return
On Wed, 19 Jun 2024 08:38:29 GMT, Tejesh R wrote:
> Have you ever noticed focus going out of dialog/frame when application starts
> in CI system? In this test, since you are directly using TAB to navigate till
> Cancel button, any changes that focus might not be on the Dialog on startup?
> I
On Wed, 19 Jun 2024 10:39:35 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test fix
>
> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 694:
>
>> 692:
On Wed, 19 Jun 2024 10:32:28 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test fix
>
> test/jdk/java/awt/print/PrinterJob/PageDialogCancelTest.java line 57:
>
>> 55:
On Wed, 19 Jun 2024 08:30:42 GMT, Prasanta Sadhukhan
wrote:
>> On cancelling PageDialog, same PageFormat object should be returned which
>> stopped working after
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so
On Wed, 19 Jun 2024 08:30:42 GMT, Prasanta Sadhukhan
wrote:
>> On cancelling PageDialog, same PageFormat object should be returned which
>> stopped working after
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so
> On cancelling PageDialog, same PageFormat object should be returned which
> stopped working after
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so that correct
> value is returned from PageDialog.show action..
> An
On Wed, 19 Jun 2024 06:49:03 GMT, Abhishek Kumar wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test fix
>
> test/jdk/java/awt/print/PrinterJob/PageDialogCancelTest.java line 51:
>
>> 49:
12 matches
Mail list logo
