Re: RFR: JDK-8299052 : ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2023-06-07 Thread Harshitha Onkar
On Wed, 7 Jun 2023 11:19:38 GMT, Alexey Ivanov wrote: >> Updated > > It doesn't feel right this way either. A cleaner approach would be to pass > the undecorated file name and add the extension and specify the format inside > `captureScreen`. (Passing the same value as a parameter usually produ

Re: RFR: JDK-8299052 : ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2023-06-07 Thread Alexey Ivanov
On Tue, 6 Jun 2023 22:55:06 GMT, Harshitha Onkar wrote: >> test/jdk/java/awt/Mixing/AWT_Mixing/ViewportOverlapping.java line 164: >> >>> 162: OverlappingTestBase.doMain(args); >>> 163: captureScreen("Img_5.png"); >>> 164: } >> >> It is just a test, so no need to over-enginee

Re: RFR: JDK-8299052 : ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2023-06-06 Thread Harshitha Onkar
On Tue, 6 Jun 2023 22:34:15 GMT, Phil Race wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review fix > > test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java line 2: > >> 1: /* >> 2: * Copyright (c) 2

Re: RFR: JDK-8299052 : ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2023-06-06 Thread Phil Race
On Fri, 2 Jun 2023 19:35:23 GMT, Harshitha Onkar wrote: >> ViewportOverlapping test was failing intermittently during CI runs on Win10 >> and Win11. >> >> Although this intermittent issue wasn't replicable when the individual test >> as well as the test group was run multiple times. Hence scr

Re: RFR: JDK-8299052 : ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2023-06-06 Thread Phil Race
On Fri, 2 Jun 2023 19:35:23 GMT, Harshitha Onkar wrote: >> ViewportOverlapping test was failing intermittently during CI runs on Win10 >> and Win11. >> >> Although this intermittent issue wasn't replicable when the individual test >> as well as the test group was run multiple times. Hence scr

Re: RFR: JDK-8299052 : ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2023-06-04 Thread Andrey Turbanov
On Fri, 2 Jun 2023 19:35:23 GMT, Harshitha Onkar wrote: >> ViewportOverlapping test was failing intermittently during CI runs on Win10 >> and Win11. >> >> Although this intermittent issue wasn't replicable when the individual test >> as well as the test group was run multiple times. Hence scr

Re: RFR: JDK-8299052 : ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2023-06-02 Thread Harshitha Onkar
On Fri, 2 Jun 2023 18:17:54 GMT, Alexey Ivanov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review fix > > test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java line 496: > >> 494: >> 495: //

Re: RFR: JDK-8299052 : ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2023-06-02 Thread Harshitha Onkar
> ViewportOverlapping test was failing intermittently during CI runs on Win10 > and Win11. > > Although this intermittent issue wasn't replicable when the individual test > as well as the test group was run multiple times, a defensive fix has been > applied. The fix is made to the base class -

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2023-01-19 Thread Alexey Ivanov
On Thu, 19 Jan 2023 08:33:25 GMT, Jayathirth D V wrote: > Are these tests verified in our CI with multiple runs after exclusiveAccess > is removed? These tests have always run in exclusive access in the CI. - PR: https://git.openjdk.org/jdk/pull/11747

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2023-01-19 Thread Jayathirth D V
On Thu, 22 Dec 2022 18:15:07 GMT, Harshitha Onkar wrote: >> ViewportOverlapping was failing intermittently on Windows (Win10 & 11). >> Added robot.setAutoWaitForIdle() to ViewportOverlapping and its base class >> (OverlappingTestBase) to stabilize the test. >> >> Additionally added awt & swing

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2022-12-22 Thread Alexey Ivanov
On Wed, 21 Dec 2022 21:48:24 GMT, Harshitha Onkar wrote: >> *Headful* tests are not supposed concurrently: they display UI and often use >> Robot to send input events to the UI. Running such tests concurrently leads >> to obscure failures. In our CI system, `JTREG_JOBS=1` is passed to `make` >

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2022-12-22 Thread Sergey Bylokhov
On Thu, 22 Dec 2022 18:15:07 GMT, Harshitha Onkar wrote: >> ViewportOverlapping was failing intermittently on Windows (Win10 & 11). >> Added robot.setAutoWaitForIdle() to ViewportOverlapping and its base class >> (OverlappingTestBase) to stabilize the test. >> >> Additionally added awt & swing

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2022-12-22 Thread Harshitha Onkar
> ViewportOverlapping was failing intermittently on Windows (Win10 & 11). Added > robot.setAutoWaitForIdle() to ViewportOverlapping and its base class > (OverlappingTestBase) to stabilize the test. > > Additionally added awt & swings tests to exclusiveAccess.dir in TEST.ROOT. Harshitha Onkar ha